Repository navigation
test(gui-user): a new crewmate speaks first, no user greeting bubble - #20009
Conversation
dc44e51 to
c7aa864
Compare
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 30fb11d Description read[DESCRIPTION-READ] 3bfdf64b1772533ad82ae9f64757eb6a2921b698bf73ae135555cbe42bb020da That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
c7aa864 to
30fb11d
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Backend Tests (3.12, 8) red on head 30fb11d is |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that updates one GUI scenario expectation and adds a test that pins it.
Problem / Motivation
Goal: The nightly GUI user test's
crewmate-create-firstscenario checks the greeting a new crewmate really shows, so it stops failing on a bubble the app no longer draws.The scenario expects "a chat bubble containing "welcome to the team" (the greeting the page sends on your behalf)". Nightly run 38377905101 found only the crewmate's reply, "pong from the fake ACP backend", and filed #19792 as a blocker.
Why it matters
Every nightly fails this scenario and re-files the same false blocker. A red scenario that is always red hides a real regression in the create flow.
Not a goal
website/capture/crewmates-page-create.tsx.What changed (motivation → approach → change)
The page stopped sending a greeting as the user when #18805 landed (2026-10-12). Now the server starts the crewmate's first turn from a hidden note and writes no user row (
src/kiro_crew/dashboard/mate_welcome.py, pinned bytest/test_mate_welcome.py). So the only bubble is the crewmate's own reply. The scenario was last edited on 2026-10-09 (#18475) and still asks for the old user bubble.The
crewmate-create-firstscenario now expects a reply bubble from the crewmate with no typing, and says no bubble from the user is expected.filterCrewmateChatis not the cause: there is no user row to hide.Backwards compatibility
Compatible: only a test scenario's wording and one test change; no product code.
Removes nothing: the old expectation named a bubble the product stopped drawing on 2026-10-12.
Tests
test/gui_user/test_scenarios_and_report.py::TestShippedScenarios::test_created_crewmate_speaks_first_with_no_user_greeting_bubblepins the expectation to the shipped behaviour: no "welcome to the team" or "on your behalf", the fake backend'sREPLY_TEXTquoted, and no user bubble expected. It fails on main's scenario and passes with this change.Determinism: the file is a pure read of YAML. 67 passed in 3 repeats in file order and once under
-n 2(xdist order).Manual verification
N/A: the scenario runs only in the nightly GUI user-test lane with a model tester. The product contract it now names is pinned by
test/test_mate_welcome.py::test_a_goal_kickoff_runs_without_a_transcript_row.Related Issues
Closes #19792
Pattern harvest
Not generalizable: one scenario quoted a page-sent string that #18805 deleted; the new test pins this scenario to the fake backend's reply constant.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)