Skip to content

test(gui-user): a new crewmate speaks first, no user greeting bubble - #20009

Merged
bolichen97 merged 1 commit into
mainfrom
fix/crewmate-greeting-19792
Oct 14, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/crewmate-greeting-19792

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The nightly GUI user test's crewmate-create-first scenario checks the greeting a new crewmate really shows, so it stops failing on a bubble the app no longer draws.

The scenario expects "a chat bubble containing "welcome to the team" (the greeting the page sends on your behalf)". Nightly run 38377905101 found only the crewmate's reply, "pong from the fake ACP backend", and filed #19792 as a blocker.

Why it matters

Every nightly fails this scenario and re-files the same false blocker. A red scenario that is always red hides a real regression in the create flow.

Not a goal

What changed (motivation → approach → change)

The page stopped sending a greeting as the user when #18805 landed (2026-10-12). Now the server starts the crewmate's first turn from a hidden note and writes no user row (src/kiro_crew/dashboard/mate_welcome.py, pinned by test/test_mate_welcome.py). So the only bubble is the crewmate's own reply. The scenario was last edited on 2026-10-09 (#18475) and still asks for the old user bubble.

The crewmate-create-first scenario now expects a reply bubble from the crewmate with no typing, and says no bubble from the user is expected. filterCrewmateChat is not the cause: there is no user row to hide.

Backwards compatibility

Compatible: only a test scenario's wording and one test change; no product code.

Removes nothing: the old expectation named a bubble the product stopped drawing on 2026-10-12.

Tests

test/gui_user/test_scenarios_and_report.py::TestShippedScenarios::test_created_crewmate_speaks_first_with_no_user_greeting_bubble pins the expectation to the shipped behaviour: no "welcome to the team" or "on your behalf", the fake backend's REPLY_TEXT quoted, and no user bubble expected. It fails on main's scenario and passes with this change.

Determinism: the file is a pure read of YAML. 67 passed in 3 repeats in file order and once under -n 2 (xdist order).

Manual verification

N/A: the scenario runs only in the nightly GUI user-test lane with a model tester. The product contract it now names is pinned by test/test_mate_welcome.py::test_a_goal_kickoff_runs_without_a_transcript_row.

Related Issues

Closes #19792

Pattern harvest

Not generalizable: one scenario quoted a page-sent string that #18805 deleted; the new test pins this scenario to the fake backend's reply constant.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 13, 2026 23:36
@bolichen97
bolichen97 requested a review from mbriones98 October 13, 2026 23:36
@bolichen97
bolichen97 enabled auto-merge (squash) October 13, 2026 23:36
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 13, 2026
@bolichen97
bolichen97 force-pushed the fix/crewmate-greeting-19792 branch from dc44e51 to c7aa864 Compare October 13, 2026 23:47
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 30fb11d594df98e9f6c850b0d070c53bacd6ceae touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 30fb11d594df98e9f6c850b0d070c53bacd6ceae ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 30fb11d594df98e9f6c850b0d070c53bacd6ceae — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 30fb11d

Description read

[DESCRIPTION-READ] 3bfdf64b1772533ad82ae9f64757eb6a2921b698bf73ae135555cbe42bb020da

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@bolichen97
bolichen97 force-pushed the fix/crewmate-greeting-19792 branch from c7aa864 to 30fb11d Compare October 14, 2026 00:09
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 30fb11d594df98e9f6c850b0d070c53bacd6ceae and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 30fb11d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 30fb11d594df98e9f6c850b0d070c53bacd6ceae: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 30fb11d594df98e9f6c850b0d070c53bacd6ceae — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 30fb11d

Verdict parsed from the review's SHA-scoped output markers for commit 30fb11d594df98e9f6c850b0d070c53bacd6ceae.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 30fb11d594df98e9f6c850b0d070c53bacd6ceae: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 8) red on head 30fb11d is test/test_pid_lifecycle.py::TestSpawnedMarkerInjection::test_spawn_site_source_registry hitting the real-default-home guard (KIROCREW_HOME pin missing on that xdist worker). This PR only changes test/gui_user/ and cannot reach that test; it passes 3/3 locally at this head. Re-ran the failed job of run 38488516086 once.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 14, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that updates one GUI scenario expectation and adds a test that pins it.

@bolichen97
bolichen97 merged commit 377a68f into main Oct 14, 2026
147 of 149 checks passed
@bolichen97
bolichen97 deleted the fix/crewmate-greeting-19792 branch October 14, 2026 02:05
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ux(members): The greeting the app sent on my behalf never shows in the chat; I only see the reply "pon…

2 participants