Skip to content

feat(dashboard): add project-city, the project report as a 3D city - #20030

Closed
chenmingwei23 wants to merge 1 commit into
mainfrom
feat/dashboard-project-city
Closed

chenmingwei23 wants to merge 1 commit into
mainfrom
feat/dashboard-project-city

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship a built-in Dynamic Dashboard page that draws the project report as an animated 3D city, with the same numbers and rules as project-report. Its own words are English by default and follow the reader's UI language, like every built-in page.

Every built-in page today is cards and tables. None shows a crewmate's whole body of work in one picture, and the feature's owner asked for a younger, animated 3D version of the project report.

Why it matters

A person running several workstreams reads all of them at a glance: a district per workstream, tower height for spend, colour for state, a beam over anything waiting on them. Every number is still the record's, so the picture never says something the report would not.

Not a goal

What changed (motivation → approach → change)

Part What it does
dashboard_templates/builtin/project-city/manifest.json Binds items, omitted, series, last_entry_at from the workstreams fold and for_you, verdict, ci as crewmate-written, in project-report's exact shapes, verdict.words included
dashboard_templates/builtin/project-city/template.html The city (three.js), over the same record as text: verdict, counts, red lanes, Needs-you cards, who is working, work tree, credits per hour, task drawer. Its own words in English and zh-CN
scripts/build-project-city-three.mjs Rebuilds the inlined three.js block from the pinned three@0.134.0 tarball and checks the committed copy byte for byte; --write replaces it
.github/workflows/ci.yml, docs/ci/ci-and-reviews.md A project_city_three path filter and an advisory project-city-three job that runs the rebuild check only when the page, the script or the notice changes
THIRD-PARTY-NOTICES The three.js r134 MIT notice and the two edits to its text
dashboard_templates/builtin/README.md, docs/feature-map/README.md The new page, its two deliberate differences, fourteen pages instead of thirteen

Motivation. The owner signed off on a local demo of this city and asked for it as a real page: no style name anywhere, the report's content, motion kept.

Approach. The page reuses project-report's field contract, so a crewmate can switch pages without rewriting a value, and ports its four rules: an unreported cost is a dash (a hollow dashed tower), a cut list says how much it dropped, a worker serving two tasks is billed once, and a verdict older than the fold's last entry reads "No word yet". A parity test mounts both pages on one record and holds the city's figures to the report's.

Its own words follow the reader's locale like every built-in: English by default, zh-CN from an I18N table, record values as written, and a crewmate's verdict.words over the desk words. The locale suite holds every built-in to zh-CN, and the review contract forbids loosening that rule for a new page.

The frame blocks the network, so three.js is inlined, bundled from the package's src/ down to the classes the city uses, because the published build's loaders hold fetch( and DOMParser (465 KB of a 646 KB page; the ceiling is 1,000,000 bytes). scripts/build-project-city-three.mjs is the recipe, a test pins the block's sha256, and a path-filtered CI job reruns the recipe and fails unless the committed block is that rebuild. The script edits three.js's text twice, both recorded in the notice: generateUUID's fallback draws from crypto.getRandomValues instead of Math.random(), which code scanning flags behind every object's uuid; and three comment links name the default branch as HEAD for the inclusive-language scan.

Change. The page renders on load and on each host push, and rebuilds the scene only when what it draws changed (the reader's language included), so the camera stays where the reader left it. Every value reaches the page as text. Its one message out is kirocrew-dashboard:act. It draws one still frame under prefers-reduced-motion, stops while hidden, and without WebGL says so while the text half stands. It is always dark, in solid fills and fixed state colours shared by scene and HTML, because emissive light only reads on a dark ground; that is the one place it skips the theme variables. ci names no upkeep helper, because a helper ships beside one template.

A picked workstream shows only its own record: every card counts its board and the boards under its tasks, as its header does, and the crewmate's verdict and another pull request's lane board wait on the All view. Pills count open tasks, so they add up to All. The desk splits its total into workers and crewmate, the legend says it counts tasks, and Accepted says what its total counts. Chips name states, not actions. Rejected and abandoned share one closed look, and the two looks that need a person carry a ring in the legend as in the city. A narrow canvas stands the camera back so every district stays in frame, with the camera buttons under it.

Backwards compatibility

Compatible: a new built-in id beside the thirteen; no field, fold, route or default changes. One reach to know about: a crewmate whose slug is project-city and that adopted no page gets this page by the existing slug rule (instance.default_template_id).

Removes nothing: the diff adds a page, its tests, its build script and its notes. The locale suite gains one probe, and every case it runs for the thirteen pages runs for all fourteen.

Tests

  • test/test_dashboard_template_project-city.py (new): the seven fields and their fold sources equal project-report's, and all three written fields take its exact shapes; every written field carries upkeep and no helper; neither file names the style, in English or in the zh-CN table; both files are ASCII, with the zh-CN words as \u escapes; no network spelling; the page fits MAX_PAGE_BYTES and passes validate_page; the only host message is act and the library posts none; the library is three.js r134 under its MIT banner; the block's sha256 is the one the build script pins; ci.yml's filter names the page, the script, the notice and the lockfile, and its job runs the check without --write; no object's uuid comes from Math.random(); no CSS gradient; the notice is recorded; the reduced-motion block and every keyframe.
  • test/test_dashboard_templates_builtin.py: project-city joins EXPECTED_IDS, so the shared loader, fold-path, packaging and preview/apply cases cover it.
  • website/src/test/projectCityPage.test.ts (new): the real script in jsdom over a deep-frozen read: no-WebGL fallback keeps the numbers, a dash for an unmeasured task and board, "1 reported no cost", cut tasks and cut boards counted, one worker billed once, a verdict stands or reads as no word by written_at, a Needs-you option posts exactly one act, zh-CN words with record values as written, English under every other locale, a crewmate's desk words win, a push in a new locale redraws, a push keeps the chosen workstream and the drawer's focus, under one workstream the nested board's blocked task, the spend, the pill counts and no other workstream's verdict or lane board, the Accepted and desk counts saying what they count, state words on chips, one name per task state everywhere, tasks as the unit of In flight and Accepted, who fixes a failing lane in words, and the fills-only line under every card's buttons.
  • website/src/test/projectCityParity.test.ts (new): both pages on the sample record give the same sentence, counts and the figures under them, spend line and every tree row, the same dashes, the same cut counts, the same verdict state standing and superseded, and the same sentence and tree under one workstream.
  • website/src/test/dashboardTemplatesI18n.test.ts: fourteen built-ins, with project-city in the probes; no case is skipped for any page.

Determinism, on this head:

for i in $(seq 20); do python -m pytest -n0 -p no:cacheprovider -q -o addopts='' test/test_dashboard_template_project-city.py || break; done
-> 20/20 green
10x python -m pytest -n 4 --dist loadgroup --max-worker-restart=2 -p no:cacheprovider -q -o addopts='' \
    test/test_dashboard_template_project-city.py test/test_dashboard_templates_builtin.py test/test_dashboard_template_project-report.py
-> 10/10 green, 158 passed each
shuffled node ids of the two backend files, seed=4172 -> 95 passed
10x npx vitest run src/test/projectCityPage.test.ts src/test/projectCityParity.test.ts src/test/dashboardTemplatesI18n.test.ts --sequence.shuffle --sequence.seed=<11..101>
-> 10/10 green, 139 passed each
node scripts/build-project-city-three.mjs, twice, in a clean export of this commit after npm ci --ignore-scripts in website/
-> rebuilt from three@0.134.0 with esbuild 0.25.12; matches template.html, sha256 c34a80a19ccbf578633ecf96911623e8ee10018f76699172d1e82757b51c1a5d

Manual verification

Headless Chromium (Playwright 1.58, software WebGL) over two documents: the render harness from scripts/render_dashboard_builtin.py, and the gateway's own dashboard_frame.compose() output with its CSP, bootstrap, frozen read and beacon. Both: 0 page errors, 0 console errors, no request but the file itself. Two frames 1.2 s apart differ with motion on and are identical under reduced motion, whose button then reads "Play motion". Hovering a tower shows its tooltip, a pill flies to one workstream, a tree row opens the drawer, and an option posts exactly one act. At the side panel's 430 px there is no horizontal scroll, every district and its sign stay in frame with the camera buttons right under the city, and a touch screen's hint reads "drag to turn" with no ctrl. The composed page posted kirocrew-dashboard:ready with refill: true; a posted refill moved Accepted from 7 to 8, flashed the changed row once and kept one canvas. With the locale set to zh-CN, the counts, the sentence, the legend, the canvas label, the district signs and the view buttons are Chinese, and the workstream and task names stay as the record wrote them. Over an empty record the page reads "No workstream yet" with its hint and draws an empty plaza. In a browser started with WebGL turned off, the canvas says so in one line and every count, card and tree row stays.

Screenshots / video

The sample is a made-up English project. Wide, all workstreams:

The city with three workstream districts, the spend rings in the middle and the verdict, counts and red lanes around it

Hovering a tower:

A tower's tooltip with its state, its whole workstream name, spend and last report

One workstream picked from the pills; only its own record shows:

The camera on one district with its sign; the counts and legend scoped to it

A zh-CN reader:

The same city with the page's own words in Chinese and the record's names as written

The side panel's 430 px width:

At 430 px the whole city stays in frame, the camera buttons sit under it, and the counts and verdict drop below

A walk through the city turning, two views, one workstream, the tree and the drawer:

walkthrough.webm

A crewmate with no work yet:

The empty page: the plaza with no spend, then No workstream yet and the hint to give the crewmate a goal

A browser with WebGL turned off:

The canvas says WebGL is off and the city cannot be drawn; the counts, verdict, lanes, cards and work tree all stay

Reduced motion, the drawer, and the whole page

Under reduced motion the city is still and the button reads Play motion

A task's drawer: what the worker said, the ruling, the verdict, result, lanes and events

The whole page: city, lanes, Needs-you cards, who is working, the work tree with credits per row, and credits per hour

Related Issues

Closes #19998

Related: #18642, #18755

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@chenmingwei23
chenmingwei23 requested review from a team and KiroCrewCaptain as code owners October 14, 2026 00:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@chenmingwei23
chenmingwei23 force-pushed the feat/dashboard-project-city branch from 2760984 to c1d38c8 Compare October 14, 2026 01:17
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that projectCityParity.test.ts fails when one of project-report's four rules changes. The rules are copied into the city, not shared, so that test is the only thing that catches drift.

[DESIGN-REVIEWED] 9f9e7b7

Description read

[DESCRIPTION-READ] 2c1965aed2ec71424716154e96e8878733a6f2bdf2ea4466d360b4b831fbeb33

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The city ships inside the wheel as a 654 KB built-in with a vendored three.js and its own CI job. The existing operator's-own-page route was never weighed.

Not justified as shipped

  • Item 1 — oversized: a page of project-city/template.html 654,458 bytes, 3.8× the largest of the 13 shipped pages (project-report, 173,736), so it rides every install. The description never weighs the existing <data home>/panel-templates/<id>/ route (builtin/README.md:130, "An operator's own page"; 0 mentions in the intent). Its only stated provenance is "the feature's owner asked for".
    Subtraction: ship the page through the operator's-own-page folder. That drops scripts/build-project-city-three.mjs, the project-city-three job and the project_city_three filter, and the vendored block's upkeep goes with them.
    Clears when: the description names why a reader needs this page in the wheel rather than in panel-templates/, or a maintainer confirms the built-in placement.

What this change ships

Inventory (7 items) — 6 justified

Intent: give a person running several workstreams the project report as one animated 3D picture. This is an ADDITION.

  1. A new 14th built-in Dashboard page, a 3D city of the project report — oversized: the operator-page route was never weighed
  2. The page uses project-report's seven fields and four rules, with a parity test — justified
  3. Its own words come in English and zh-CN — justified
  4. three.js r134 is inlined, with two text edits recorded in the notice — justified
  5. A rebuild script and an advisory, path-filtered CI job check the inlined block — justified
  6. The page is always dark and skips the theme variables — justified
  7. A crewmate whose slug is project-city now gets this page by default, through the existing slug rule — justified

[FIRST-PRINCIPLES-REVIEWED] 9f9e7b7

Description read

[DESCRIPTION-READ] 1722c7e9cc0ae4f2ac1f831dc3364b60fecbbdffd6287b79e2977d0cdbf94d7a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

People who aren't engineers can't follow the city's numbers or its words: counts don't reconcile, statuses are hard to tell apart, and lanes, rounds and the centre ring go unexplained.

Watch

  • The headline counts don't add up for a reader. The page shows "10 in flight", "7 of 19 tasks accepted" and "9 workers with work open". It also says "Needs you 6 in all" above five cards, an "Earlier · 1" line and "New since you looked · 5". The blind reader's words: "I can't work out how 10, 19 and 9 fit together." This is on the main path every visit, so the summary loses trust. Fix: state each card's unit next to the number, for example "19 tasks in total, 7 accepted" and "6 = 5 new + 1 earlier".
  • Words in the desk and the drawer only mean something to engineers. Examples: "red lanes", "head 8f3c2a1", "semgrep / py-audit", "What the conductor decided", "Not adjudicated", "it_ca540655", "round". The reader had "no idea" what any of these are, and couldn't tell how "crewmate", "worker" and "conductor" relate. Every drawer and every lane panel has this problem, so the detail a user drills into for is unreadable. Fix: use task names, for example "checks" for lanes and "plan step" for conductor, and drop the raw ids.
  • "needs a rerun" reads like a button. It is a status span (pc-lane-o) that sits next to "yours to fix", but the reader said "I'd be afraid 'needs a rerun' starts something". Fix: write it as a state, "did not run, rerun needed", and style it apart from the controls.
  • Some state pairs in the legend look the same. The reader "can't tell 'Closed' from 'Accepted', or 'Gone quiet' from 'No report yet'". "quiet 2m" also shows as a timer on Working tasks, so "quiet" means two things. Fix: rename the timer, for example "last report 2m ago", and give Closed a sub-label such as "rejected or dropped".
  • The centre ring is explained only in the empty state (shot 6) and in a note near the bottom of the page. The populated city never says what it is. Fix: show the "credits spent in all" label on the ring in every state.

Suggestions

  • Hover tooltip (shot 2): place it so it doesn't cover the district name labels.
  • entry_ago: 'entry {t}': change to "last report {t}".

[UX-REVIEWED] 9f9e7b7

Description read

[DESCRIPTION-READ] 8e08f155f2bc50dc4389fe799745ccc132df775f3e10d691474f9941c1fea648

That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3 — this comment is updated in place on each push.

Review details

No findings that block the merge.

FINDING — .github/workflows/ci.yml:202 — the project_city_three filter also triggers on 'website/package-lock.json', but three descriptions leave it out: the job's own comment ("runs only when the page, the script or the notice changes"), the docs/ci/ci-and-reviews.md row ("Path-filtered on the page, that script and THIRD-PARTY-NOTICES") and the builtin README. A PR that only bumps the lockfile's esbuild pin runs this job, and none of those three texts says it will → Fix: add website/package-lock.json (the pinned esbuild) to the ci.yml comment, the ci-and-reviews.md row and the builtin README.

[OPUS-REVIEWED] 9f9e7b7

Verdict parsed from the review's SHA-scoped output markers for commit 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9f9e7b7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 9f9e7b7ee018d312b92624ffd4d42a14a9c957a3: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@chenmingwei23
chenmingwei23 force-pushed the feat/dashboard-project-city branch from c1d38c8 to ae49d4c Compare October 14, 2026 03:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: English-only allowlist weakens the universal locale ratchet span=ce4e99003c6c

Fixed in ae49d4c; the ratchet is not loosened. ENGLISH_ONLY and englishProbe() are gone: website/src/test/dashboardTemplatesI18n.test.ts is main's file plus one PROBES entry for project-city, with the built-in count moved from 13 to 14.
Every case runs for every built-in again, project-city included: its static words carry data-i18n, every keyed word renders in zh-CN under zh-CN, and its zh-CN empty-state probe replaces the English one.
The page gained an I18N table (en, zh-CN) like the other built-ins; English stays the default, and values from fields are never translated.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: one-workstream cards counted the workstream's own board only span=ce02b6b7774f

Fixed in ae49d4c. renderStream hands the desk, the worker list, the pipeline and the Spend card boardsUnder(list, s): the workstream's board and every board nested under its tasks, the set renderHead and renderKpis count. The Spend card states the tree's roll-up, each worker billed once, so it equals the header.
projectCityPage.test.ts pins it: a blocked task on a nested board reaches the scoped desk, sentence and Needs-you count, and the header and the Spend card both read 7.00.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: a host push dropped keyboard focus out of the open task drawer span=ce02b6b7774f

Fixed in ae49d4c. renderDrawer checks whether focus sat inside #pc-drawer-host before it clears it, and if so focuses the rebuilt drawer's close button, so a keyboard user stays in the dialog across a push.
projectCityPage.test.ts "keeps keyboard focus in an open task drawer across a host push" pins it.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: the vendored library can't be checked or upgraded span=066c959244d8

Fixed in ae49d4c. scripts/build-project-city-three.mjs rebuilds the inlined block from the three@0.134.0 tarball (registry sha512 pinned) with the esbuild website/package.json pins, and compares it with template.html byte for byte; --write replaces it on an upgrade, and its header lists the upgrade steps.
It pins the block's sha256, and test_the_library_is_the_block_its_build_script_pins holds the committed page to that pin, so a hand edit fails the suite and a recipe change moves the pin in the same diff. On this head the check reports a match, sha256 c34a80a19ccbf578633ecf96911623e8ee10018f76699172d1e82757b51c1a5d.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: the report's rules now live in two pages span=2be816bd4f36

Fixed in ae49d4c by the first option in Clears-when. website/src/test/projectCityParity.test.ts mounts both shipped pages on test/fixtures/dashboard_templates/sample_workstreams.json and asserts the same header sentence, the three counts, the spend line and every tree row (level, name, done/total, credits, cut count).
Its cases name the four rules: the same dashes and the same "N reported no cost" for unreported costs, one worker billed once on the same row, the same cut counts with omitted: 2, and the same verdict state standing and superseded; plus the same sentence and tree under one picked workstream.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: one idea, four names span=a5987fce7312

Fixed in ae49d4c. The unit is "workstream" wherever a reader sees it: the tree tags read WORKSTREAM / ROUND / TASK / SUBTASK, the tree and spend captions say workstreams and rounds, the scoped count says "this workstream", and the footer says "3 workstreams and 1 under a task" instead of a board count.
The header sentence says "accepted", the word the Accepted count and the pipeline use, so one count has one name.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: some panels ignore the selected tab span=f1de78f0e7b6

Fixed in ae49d4c by naming their scope rather than filtering them. The verdict is the crewmate's one line about all of its work, and the lane board is one pull request's checks, so neither has a per-workstream version to show.
Under a picked workstream the verdict box carries an "all workstreams" chip, and so does the lane board unless one of that workstream's tasks names its pull request. Everything else under a pick (desk, workers, pipeline, spend, tree, counts) is scoped to the workstream. projectCityPage.test.ts pins both chips and the unmarked case.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: the counts can't be reconciled span=2d201d66af67

Fixed in ae49d4c. Every pill counts open tasks, nested boards included, and says so in its tooltip ("10 open tasks"), so the workstream pills add up to All (2 + 7 + 1 = 10) and All equals In flight.
The Needs-you desk puts a count after each shelf's name ("New since you looked" and the folded "Earlier"), so the cards shown and folded add up to the Needs you total. projectCityPage.test.ts pins the pill sums.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: zoom hint is wrong on phones span=861acb71fe1b

Fixed in ae49d4c with a narrower change than suggested. On a coarse pointer the hint reads only "drag to turn". "Pinch to zoom" would name a gesture the city does not have: zoom is off unless ctrl, meta or alt is held with the wheel, so the canvas never captures a page scroll or a pinch.
At 430 px the legend wraps under the city; a touch-screen run at 430 px read "drag to turn" with no ctrl.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author
  • fixed: tooltips cut workstream names at 18 characters span=1cdb8f8b7ce9

Fixed in ae49d4c. A tower's tooltip names its whole workstream. Only the sign over a district keeps the short form, because it is drawn into the scene at a fixed size.

@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Oct 14, 2026
@chenmingwei23
chenmingwei23 force-pushed the feat/dashboard-project-city branch from 74050cb to cd80252 Compare October 14, 2026 13:13
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased: onto e4270cfcec (15 new main commits since 85457980aa), no conflicts. New head cd80252b02. Main touched docs/ci/ci-and-reviews.md, .github/workflows/security-scope-review.yml and test/test_ci_surface_tests.py; the tests that read them, plus this page's own, pass on the rebased tree (1431 pytest, 135 vitest), and black, isort, flake8 and docs lint are clean.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Oct 14, 2026
A new built-in Dynamic Dashboard page that draws a crewmate's work as
an animated 3D city: each workstream is a district, each round a
street, each task a tower whose height is its worker's credits, and
each subtask an annex behind its task. The same record is drawn as
text under the city, so a reader without WebGL loses the picture and
nothing else.

It binds project-report's seven fields from the same places and keeps
that page's rules: an unreported cost is a dash, a cut list says how
much it dropped, a worker that served two tasks is billed once, and a
verdict older than the record reads as no word. A parity test mounts
both pages on one sample record and holds the city's figures to the
report's. Its Needs-you buttons post kirocrew-dashboard:act only. Its
own words follow the reader's locale like the other pages, English by
default and zh-CN from an I18N table; it is always dark, and still
under prefers-reduced-motion.

The city is drawn with three.js r134 (MIT), bundled from the npm
package's own sources down to the classes the page uses, so it carries
no loader and makes no request. scripts/build-project-city-three.mjs
rebuilds that block from the pinned tarball and checks the committed
copy; a test pins its sha256, and a path-filtered CI job runs the check
whenever the page, the script or THIRD-PARTY-NOTICES changes. It makes two edits to three.js's
text, both recorded in THIRD-PARTY-NOTICES: generateUUID's fallback
draws from crypto.getRandomValues instead of Math.random(), and three
links in its shader comments name the default branch as HEAD.
@chenmingwei23
chenmingwei23 force-pushed the feat/dashboard-project-city branch from cd80252 to 9f9e7b7 Compare October 14, 2026 13:46
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=507ef2e27fc5

Fixed in 9f9e7b7ee0. In flight and Accepted now count tasks ("10 tasks", then "7 tasks" over "7 of 19 tasks accepted"). Only Needs you says items, because it adds the items the crewmate raised to the tasks that wait on the reader. A new case pins all three units.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=bafae6b54a43

The clipped label came from evidence older than the camera fit: shot-01 predates the default camera standing back until every district and its sign sit inside the free part of the canvas. The new wide shot shows "Weekly digest email" whole. Signs also hold 30 characters before an ellipsis, up from 18. At 430 px, a label smaller than 11 px on screen is hidden, as the new phone shot shows.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=080d11f6095e

Fixed in 9f9e7b7ee0. The line "A button only fills your chat box. Nothing is sent until you press send." now sits under the buttons of every Needs-you card, "Go ahead" included, not only under the blocked ones. A failing lane names who fixes it in plain text with no box: "yours to fix", "a maintainer's to fix", or "needs a rerun". New cases pin both.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=47ba63c96614

Fixed in 9f9e7b7ee0. The page background, the canvas box and the cards now use solid palette fills, and the scanline overlay is gone. A new test asserts the style block holds no gradient(. The sky inside the WebGL scene is a texture the scene draws, not a page fill.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=f3ab0228c9b4

Fixed in 9f9e7b7ee0. Each task state now has one name everywhere on the page: "Asks you" and "Blocked", with one matching pair in the zh-CN table, in the legend, the desk tags, and the tree and desk chips. A new case reads the whole page and finds neither "Needs an answer" nor "Needs unblocking".

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

span=5b7574701a1f

The alert is a required gate here. CodeQL is one of the workflows PR Readiness waits on (.github/workflows/pr-readiness.yml lists CodeQL), and a failing conclusion reds readiness. On c1d38c8f1a the CodeQL check concluded failure: "10 new alerts including 10 high severity security vulnerabilities", all at the Math.random() fallback of generateUUID. The maintainers chose to fix that fallback rather than dismiss the alerts. The patch is one branch, pinned in scripts/build-project-city-three.mjs, re-applied on every rebuild, and recorded in THIRD-PARTY-NOTICES.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 9f9e7b7.

The lanes reran on this head after the last round of dispositions, which target cd80252. These current-head items have no reply yet:

  1. UX Review CONCERNS (comment): the headline counts do not reconcile, desk and drawer copy uses engineer-only words, 'needs a rerun' reads like a button, some state pairs look the same and 'quiet' means two things, and the centre ring is unexplained outside the empty state. Fix each one or rebut it with evidence.
  2. First Principles CONCERNS, Item 1 (comment): the 654 KB page ships in the wheel, and the description never weighs the operator's-own-page route. This needs a written reason for built-in placement or a maintainer's confirmation.
  3. Opus finding: the project_city_three filter includes website/package-lock.json (ci.yml:202), but the job comment (ci.yml:405), the ci-and-reviews.md row and the builtin README leave it out.
  4. Design PASS punchline: show that projectCityParity.test.ts goes red when one of project-report's four copied rules changes.

What would clear this: one disposition per item on this head, plus the maintainer ruling on placement. The new CI job uses no secrets, sets persist-credentials false and installs with --ignore-scripts. Checks on this head are green. I ran nothing locally.

— crew-pr-reviewer (r100)

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ship these templates out? I think they are more for personal usage. Our default templates are not what we shall chase, but encourage users to build their own ones.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 14, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Thanks @iamwhatever, agreed. This page fits better as one a person builds for their own dashboard than as a built-in, so I'm closing this PR. Putting a crewmate-written page live without a built-in is tracked in #20354. The branch stays in case we want it later.

auto-merge was automatically disabled October 14, 2026 22:52

Pull request was closed

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 14, 2026
@bolichen97
bolichen97 deleted the feat/dashboard-project-city branch November 6, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Dashboard: an animated 3D variant of the project report page

3 participants