Repository navigation
Conversation
|
Closing and reopening right after opening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS On desktop, the two split directions sit on two different surfaces. Split right is only an unlabeled header icon, and Split down is only a row in the title menu. Watch
[UX-REVIEWED] 38c05a4 Description read[DESCRIPTION-READ] 28a84b88ae2ddc6b4b6dd312e543618b8b7ce03678b1e804ed224a7e9ab3afc1 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the Split down row is reachable only from the title-chevron menu on desktop, and judge whether a split view button whose label names no direction is clear next to it. [DESIGN-REVIEWED] 38c05a4 Description read[DESCRIPTION-READ] 1f7f5d0a39488a82e1bd510905bb17853d0fce664b9ed9b6dabbb97a53dc75b7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check one thing before merge: the phone row's label changes from "Enter split view" to "Split right". No entry under What this change shipsInventory (7 items) — 7 justifiedIntent: from the single-session view, a person can open split view with the new pane below the session instead of beside it (#18880). ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 38c05a4 Description read[DESCRIPTION-READ] f786fb653ccc8cf67e3a381bcbf735c9517db6fbcef141e6da41bc2d89d58049 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
span=16de4fd16aef
|
|
The new head is |
|
span=3957026d546a
|
|
span=3f21e26fef2f
|
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
|
HOLD at 4ad4869. The current UX review proposes adjacent Split right and Split down menu entries. That proposal needs no fourth header button. The earlier rebuttal only addressed adding a fourth header button. Please answer the actual current proposal, plus phone ordering and label consistency. Also answer the Design discoverability check. Pending readiness/security review evidence must settle before approval relies on it. Older canceled runs should not be counted over their successful replacements. I have not run the UI or viewed the captured frames. — crew-pr-reviewer (r99) |
4ad4869 to
964c4ce
Compare
Entering split view always put the fresh pane to the right of the session. A stacked layout took three steps: split right, split down, then close the right pane, because the split-down control exists only on the panes of a view that is already split. Give the entry path a direction. useSessionGrid.seedFromSession takes an optional SplitDir and maps it to the split axis the way splitLeaf does. enterSplit, in usePaneLayoutState, takes the same optional direction, keeps it in state and hands it to SessionGridView as seedDir. Every entry sets the direction, so a down entry never carries into the next default one, including the Cmd/Ctrl+D and auto-enter entries that call enterSplit inside the hook. Offer it as a Split down row in the session menu behind the title chevron (ChatHeaderMenu), and as a Split right and Split down pair in the phone menu. The desktop header group already holds three buttons, so a fourth would break the two-buttons-per-row rule, and its split view button already starts the side-by-side entry, so the desktop menu has no Split right row. The row sits directly after Pop out to window, the other window-layout action, so Rename and Pin keep their place: SessionActionsMenu takes it as an optional layoutSlot prop for its navigation group. The rows reuse the pane controls' labels. The phone has no split view button, so its menu lists both directions, and its default row is labelled Split right instead of Enter split view so the pair reads as two directions. The desktop split button keeps its label, which has its own key. The default direction, Cmd/Ctrl+D, a restored layout and the auto-enter for a persisted split are unchanged. Add website/scripts/capture-18880-split-down.mjs. It drives the built app on a desktop and a phone viewport and photographs each menu open and the stacked layout one choice opens. A control run per device checks that the default entry (the header button on desktop, Split right on the phone) still opens side by side. Commit the four frames under temp-screenshots/18880-split-down/, each at most 2000 px on a side.
e03a8a8 to
38c05a4
Compare
|
span=9c029f6c7186
|
|
span=7e38e05a2caf
|
|
span=9574abf06582
|
|
span=d60cbd3b5844
|
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
Pull request was closed
|
HOLD at 38c05a4. The code looks right. What blocks approval: the UX review on this head is CONCERNS, and none of its three Watch items has a If the desktop placement really is a maintainer decision, a maintainer ruling on the PR settles it. I did not view the screenshots or run the tests. — crew-pr-reviewer (r108) |
|
Closing without merging, to keep my open PRs to the ones close to landing. The Oct 17 hold on this head (38c05a4) needs replies to the UX review's three items, including the proposed "Split right" tooltip on the header button, and a ruling on where Split down sits on desktop. The split-down control from the single-session view isn't on main as of 2e50054, and #18880 stays open. I've deleted the branch; it can be restored from this page at 38c05a4. |
Problem / Motivation
Goal: From the single-session view, a user can start split view with the new pane below the session, not only to its right.
Today the header's split view button and Cmd/Ctrl+D always open split view with the new pane to the right of the session. The split-down control exists only on the panes of a view that is already split, so the single-session view has no way to ask for a stacked first split. Reported in #18880.
Why it matters
A stacked layout suits a wide, short window, sessions with long lines, and a tall narrow screen such as a phone. Reaching it today takes three steps: split right, split down on one pane, then close the right pane.
Not a goal
website/src/components/SessionGridView.tsx:102), so the control is a menu row.What changed (motivation → approach → change)
Symptom and cause.
useSessionGrid.seedFromSessionbuilds the first split along the column axis only, andenterSplit(anchor)inusePaneLayoutStatetakes no direction, so nothing on the entry path can ask for a row. Every later split can:splitLeaf(leafId, dir)takes aSplitDirand maps right to a column split and down to a row split.Approach. Reuse that
SplitDirtype and mapping on the entry path, keep the default the entry path already had, and offer the new entry where the header has room for it.Change.
website/src/hooks/useSessionGrid.ts:seedFromSession(slot, dir = 'right')mapsdirto the split axis the waysplitLeafdoes.website/src/components/SessionGridView.tsx: aseedDirprop, passed toseedFromSessionwhen no layout was restored.website/src/pages/chat/page/paneLayout.tsx:enterSplit(anchor, dir = 'right')keeps the direction in state (splitSeedDir), andusePaneLayoutStatereturns it. Every call sets it, so a down entry never carries into the next default one, including the Cmd/Ctrl+D and auto-enter calls inside the hook.website/src/pages/ChatPage.tsx: passessplitSeedDirtoSessionGridViewasseedDir.website/src/pages/chat/page/ChatTitleOverlay.tsx: gives the desktop session menuonSplitDown, which callsenterSplit(activeSlot, 'down'), under the same visibility condition as the split view button: split view on, not embedded, and the session not already part of a saved split.website/src/pages/chat/ChatHeaderMenu.tsx:ChatHeaderMenutakes an optionalonSplitDownand hands one Split down row to the shared session menu. It adds no Split right row: the split view button beside the title already starts the side-by-side split, and so does Cmd/Ctrl+D.website/src/components/SessionActionsMenu.tsx: a new optionallayoutSlotprop, one extra row, rendered in the navigation group directly after the pop-out rows. Its one consumer is the header menu (the Split down row), so the sidebar's row menus and context menu are unchanged.website/src/pages/chat/page/MobileTopBar.tsx: the phone menu gets a Split down row, and the default-entry row beside it is labelled Split right instead of Enter split view, so the two rows name two directions. The phone header has no split view button, so this menu holds the phone's only split view control.components.chatPane.split_downandcomponents.chatPane.split_rightstrings, so no catalog key is added.pages.chatPage.enter_split_viewstays: the desktop split view button still uses it.website/scripts/capture-18880-split-down.mjs: the capture harness behind the screenshots below.Why a menu row and not a header button. The desktop header group beside the title already holds three buttons (pop out, side panel, split view), and the repo's
max-two-buttons-per-rowrule says a row that already carries three must not grow. The title chevron's menu is the existing overflow for session actions. The Split down row sits directly after Pop out to window, the other window-layout action; a row at the top would move Rename and Pin down on every open. There is no Split right row beside it: the split view button and Cmd/Ctrl+D already start that split, so a second desktop control for it would be the same action under two names.Rejected. A fourth header button, for the reason above. Turning the split view button into a menu: it would add a click to the default entry that works today. A remembered-direction setting: new state and copy for a choice that is made per split. Reorienting the tree after seeding right: it needs a new tree operation, where the seed already builds the tree and a parameter is smaller. A Split down row at the top of the menu: it moved Rename and Pin. A Split right row in the desktop menu beside Split down: it runs the same
enterSplit(activeSlot)as the split view button and Cmd/Ctrl+D.Overlap. Open PR #5819 (cross-session send) also edits
website/src/components/SessionGridView.tsxand already conflicts with main. PR #20801 (the adaptive controller's concurrency cut in the chat header) is merged and editedwebsite/src/pages/chat/page/MobileTopBar.tsxandwebsite/src/pages/chat/page/ChatTitleOverlay.tsx; this branch is cut from a main that contains it. This change adds one prop and one argument inSessionGridView.tsx, one prop and the optional direction in theenterSplittype inChatTitleOverlay.tsx, and the split rows inMobileTopBar.tsx.Backwards compatibility
Compatible: the new parameter, props and menu props (
seedDir,onSplitDown,layoutSlot) are optional and default to'right'or to absent, which is what every caller got before, and a saved layout is restored as saved. The phone menu's default-entry row keeps its action and its place; only its visible label changes, from Enter split view to Split right.Removes nothing: no control, shortcut, prop or catalog key is removed;
enterSplitgains a second optional parameter. The desktop split view button keeps its label.Reader: the phone row is found by its label in three places in
website/src/test/ChatPage.mobileTopBarActions.test.tsx, all updated here.git grep -n -E "Enter split view|enter_split_view" -- . ':(exclude)website/src/i18n/locales'finds no other reader of that row. What it still lists is the desktop button: itsaria-labelinwebsite/src/pages/chat/page/ChatTitleOverlay.tsx, and the tests and capture harnesses that find that button by role.Tests
In short: the tests for the entry direction, the Split down rows and the phone row's label fail on the base commit's source (one run) and pass with this change (3 of 3 runs). Tests that pin the unchanged default pass on both sides.
Added, by file:
website/src/test/UseSessionGridCoverage.test.tsx:seedFromSessionstacks the placeholder below the session when seeded'down'(row axis, equal sizes, focus on the placeholder), and seeds side by side for'right'and for an omitted direction.website/src/test/SessionGridViewCoverage.test.tsx: with the real layout and hook,seedDir="down"renders a horizontal divider with the picker below the session, and noseedDirrenders a vertical one.website/src/test/SessionActionsMenu.popout.test.tsx(ChatHeaderMenu split down row): Split down is the row right after Pop out to window, with Copy link next and no Split right row; every row above it, Pin included, keeps its index with and without it; choosing it callsonSplitDown.website/src/test/ChatPageMoreCoverage.test.tsx(ChatPage split view entry direction): the existing header button seeds'right'; the session menu has no Split right row and its Split down row seeds'down'for the active session; a down entry does not carry into the next default entry; the menu offers no split row while split view is off or for a session that belongs to a saved split.website/src/test/ChatPage.mobileTopBarActions.test.tsx: the phone menu's Split down row callsenterSplit(slot, 'down'); the default-entry row is found by its Split right label; the Return to split view case and the split-off menu offer none.Red, with the base commit's version of the eight changed source files swapped in under these five test files (one run; the base is the
origin/mainthis branch is cut from):Green with this change, on the same base:
Also run and passing on this base:
tsc -p tsconfig.app.json --noEmit;eslint --max-warnings 0on the thirteen touched source and test files; and the repo's frontend gatesnpm run lint:restyle-ratchet,lint:phantom-classes,lint:theme-colors,lint:i18nandi18n:check. No i18n catalog changed.Manual verification
Ran
node scripts/capture-18880-split-down.mjsfromwebsite/against the production build (vite build), served from loopback with every/api/**request answered by the repo's split-pane fixtures (website/scripts/lib/split-pane-fixture.mjs), withsession_gridon and no saved layout. It drives Chromium on a 1440x900 desktop at device scale factor 1 and a 390x844 touch phone at device scale factor 2, so every frame is at most 2000 px on a side. It writes the four frames below, and exits non-zero if any of these checks mismatches:The right end of the header in the first frame still holds only the pop out, side panel and split view buttons.
Screenshots / video
Dark theme, session grid on, no saved layout. The frames are committed under
temp-screenshots/18880-split-down/.Desktop: the session menu behind the title chevron, with Split down right after Pop out to window. The split view button stays in the header and starts the side-by-side split.
Phone: the ⋯ menu, with Split right directly above Split down.
Desktop, after choosing Split down: the session on top, the picker below a horizontal divider.
Phone, after tapping Split down: the same stacked layout.
Related Issues
Fixes #18880
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement