Skip to content

test(slack): replace the fixed waits in status_reactions with await_until - #20125

Merged
javenciu merged 1 commit into
mainfrom
test/wait-discipline-status-reactions
Oct 14, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/wait-discipline-status-reactions

Conversation

@javenciu

@javenciu javenciu commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Short fixed waits in 1 test file are replaced by waits on the signal they were polling for, so a slow CI runner can no longer turn them red.

The wait-discipline ratchet counts, per file, the sites the repo still tolerates. This PR retires: 2 test_status_reactions.py.

Why it matters

A fixed wait_for(..., timeout=N) is a bet on the runner's speed: on a loaded shard the event arrives after N and the test fails for a reason unrelated to the code under test. The repo tracks these sites per file in test/wait_discipline_baseline.txt and the ratchet lets each count only go down; retiring them is how the suite gets quieter.

Not a goal

  • Files whose counted sites are polling sleeps (those need a different helper and a judgement call).
  • Any refactor or reformatting of untouched lines.
  • Raising or adding a baseline entry (the ratchet only tightens).

What changed (motivation → approach → change)

Each site below replaced asyncio.wait_for(<signal>, timeout=N) with await_until from kiro_crew.testing.wait, which waits on the same signal with the suite's lost-run ceiling instead of a per-site bet.

  • test/test_status_reactions.py: await asyncio.wait_for(sink.started.wait(), 5.0)
  • test/test_status_reactions.py: await asyncio.wait_for(sink.first_remove.wait(), 5.0)
  • test/wait_discipline_baseline.txt: removed 2 test_status_reactions.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Deleting the baseline line with the test file untouched: test/test_wait_discipline_ratchet.py fails (1 failed, 38 passed), proving the gate still counts the old sites.
  • With the edit: the ratchet and the touched file pass together, run with -W error::RuntimeWarning so every replaced wait is proven awaited; the file's own pass count is unchanged.
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the wait-discipline ratchet baseline (precedents #19928, #20014, #19527).

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners October 14, 2026 04:50
@javenciu
javenciu requested a review from mbriones98 October 14, 2026 04:50
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision b25b09e47a32d1a640c23fb8f2972cc8c45c6689 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b25b09e47a32d1a640c23fb8f2972cc8c45c6689 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] b25b09e

Description read

[DESCRIPTION-READ] 8869f70b77bd29daf2142963dfcf226cee081ae53c178214cf1f68bfd860bd11

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision b25b09e47a32d1a640c23fb8f2972cc8c45c6689 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b25b09e47a32d1a640c23fb8f2972cc8c45c6689 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b25b09e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b25b09e47a32d1a640c23fb8f2972cc8c45c6689: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b25b09e47a32d1a640c23fb8f2972cc8c45c6689 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b25b09e

Verdict parsed from the review's SHA-scoped output markers for commit b25b09e47a32d1a640c23fb8f2972cc8c45c6689.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b25b09e47a32d1a640c23fb8f2972cc8c45c6689: <one-sentence reason>

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 14, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@javenciu
javenciu force-pushed the test/wait-discipline-status-reactions branch from 4a74564 to b25b09e Compare October 14, 2026 11:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@javenciu
javenciu enabled auto-merge (squash) October 14, 2026 13:47

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: replaces a fixed asyncio.wait_for timeout with await_until in one test and drops that file from the wait-discipline baseline; test files only.

@javenciu
javenciu merged commit 3398d54 into main Oct 14, 2026
113 of 175 checks passed
@javenciu
javenciu deleted the test/wait-discipline-status-reactions branch October 14, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants