Skip to content

test(flock): pin utf-8 on the test_flock_compat subprocess call - #20134

Merged
javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-flock-compat
Oct 14, 2026
Merged

javenciu merged 1 commit into
mainfrom
test/subprocess-encoding-flock-compat

Conversation

@javenciu

@javenciu javenciu commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 test/test_flock_compat.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now pins UTF-8 (encoding="utf-8", or the shared **UTF8_TEXT mapping from kiro_crew.subprocess_utf8 where the file's neighbours use it), and the file's baseline line is removed.

  • test/test_flock_compat.py: [_sys.executable, "-c", code], capture_output=True, text=True, timeout=120
  • .github/subprocess-encoding-baseline.txt: removed 1 test/test_flock_compat.py.

Backwards compatibility

Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Deleting the baseline line with the file untouched: RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits non-zero ("new offender(s)"), proving the gate still counts the old call.
  • With the edit: python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0, and the touched file' own tests pass with an unchanged count.
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.

Screenshots / video

Why no screenshot: nothing renders; this change touches test code and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #19928, #20014, #19527).

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners October 14, 2026 05:22
@javenciu
javenciu requested a review from mbriones98 October 14, 2026 05:22
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 964938c0b162f7b95c9718531f7cff639a375ed4 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 964938c0b162f7b95c9718531f7cff639a375ed4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 964938c

Description read

[DESCRIPTION-READ] f7262286cc147b5ff143d5f3f59d9f32bea283025d4a3bfb3b82cccce4169356

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 964938c0b162f7b95c9718531f7cff639a375ed4 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 964938c0b162f7b95c9718531f7cff639a375ed4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 964938c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 964938c0b162f7b95c9718531f7cff639a375ed4: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 964938c0b162f7b95c9718531f7cff639a375ed4 — this comment is updated in place on each push.

Review details

No issues found.

[OPUS-REVIEWED] 964938c

Verdict parsed from the review's SHA-scoped output markers for commit 964938c0b162f7b95c9718531f7cff639a375ed4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 964938c0b162f7b95c9718531f7cff639a375ed4: <one-sentence reason>

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 14, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@javenciu
javenciu enabled auto-merge (squash) October 14, 2026 08:48

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins utf-8 on one test subprocess call and drops its line from the encoding baseline.

@javenciu
javenciu merged commit 1f75b72 into main Oct 14, 2026
120 of 184 checks passed
@javenciu
javenciu deleted the test/subprocess-encoding-flock-compat branch October 14, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants