Repository navigation
test(guard): pin utf-8 on the test_host_service_guard subprocess call - #20139
Conversation
test_an_ordinary_spawn_still_works runs a text-mode subprocess.run without an encoding, so it decodes the child's output with the locale code page, which is not UTF-8 on Windows (#5249). Pass encoding="utf-8" and drop the file's line from .github/subprocess-encoding-baseline.txt so the ratchet shrinks.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 00e5eb9 Description read[DESCRIPTION-READ] b908c03bc9c6c00545d866201a4ef069c0cba2833fbf6afe265940bdcca86ca7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change; pins encoding=utf-8 on the test_host_service_guard subprocess call and drops its subprocess-encoding baseline entry.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 test/test_host_service_guard.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now pins UTF-8 (
encoding="utf-8", or the shared**UTF8_TEXTmapping fromkiro_crew.subprocess_utf8where the file's neighbours use it), and the file's baseline line is removed.test/test_host_service_guard.py:res = subprocess.run([sys.executable, "-c", "print('ok')"], capture_output=True, text=True).github/subprocess-encoding-baseline.txt: removed1 test/test_host_service_guard.py.Backwards compatibility
Compatible: test-only change
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits non-zero ("new offender(s)"), proving the gate still counts the old call.python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0, and the touched file' own tests pass with an unchanged count.Manual verification
N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.
Screenshots / video
Why no screenshot: nothing renders; this change touches test code and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #19928, #20014, #19527).