Repository navigation
fix(apps): address GH #14471 follow-ups: .app_secret link, dismiss label, desktop string - #20163
Conversation
Capture harness frames (after)Frames 01–08 re-shot with the updated translations and the new REFUSAL constant. Frame 03 — Trusted page banner (item 4: new dismiss label) Frame 04 — Narrow page banner (item 4) Frame 05 — Update page banner (item 4) Frame 06 — Trust-saved failure (item 7: new REFUSAL string) All 8 frames captured and asserted green by the harness locally (see run output in task). |
Capture harness frames 04/05/06 re-shotFrame 04 (narrow):  |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the pre-transaction refusal follows the existing Notes
[DESIGN-REVIEWED] 1596bc4 Description read[DESCRIPTION-READ] bd56c787385eda9e42c043700231eb692e9c4e04c5bf9ce5754db6d5c59ac8cb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Both fixes have a reproducible defect and work at the mechanism level. One copy of the stale string is left in the frontend test file. Notes
What this change shipsInventory (5 items) — 4 justifiedIntent: an app update should never silently lose the app's secret, and the frontend fixtures should match the backend's refusal text. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 1596bc4 Description read[DESCRIPTION-READ] 434863d0c981368aeeac82d08268635a4e5603f161e7e98e743adb92d0d43847 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No dashboard control changed. The frontend edits are test and capture-harness fixtures, and frame 06 shows the updated refusal string. Notes
[UX-REVIEWED] 1596bc4 Description read[DESCRIPTION-READ] e0b0b4033716f98d6e7cae6a5a7b820f9c5d2071b1f8506405db7623680d50e8 That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
6a6f1c4 to
24e97d2
Compare
24e97d2 to
48cff0e
Compare
39ec58a to
f9f7abf
Compare
f9f7abf to
05e3833
Compare
05e3833 to
dc99cb5
Compare
mbriones98
left a comment
There was a problem hiding this comment.
Checks green and readiness passed at 4f6716c; no behavior change.
|
HOLD at 4f6716c. The
|
4f6716c to
5e974e5
Compare
|
Rebased onto latest main (head bef203d). Notes for the maintainer:
|
bef203d to
61b44c6
Compare
Item 3 — update refuses an installed .app_secret symlink shutil.move relocates the link outside its tree; a relative target does not resolve, so tmp_secret.is_file() fails and the secret is lost. Refuse before the transaction opens (data-link refusal shape). SEL-logged. Test + link_screen_sites.py baseline added. Item 7 — test and harness aligned with the landed Python string TrustAppModal.test.tsx and capture harness REFUSAL constant updated from 'desktop app' to 'Kiro Crew\'s desktop build'.
…ed .app_secret The refusal said to remove the link and retry. Doing just that drops the secret: the retry has nothing to preserve and the old tree is deleted. Name the safe step instead. Also black-format the new test.
|
First Principles BLOCK on 61b44c6 (the "Close notice" relabel drops the cue that dismissing re-enables Install/Update): resolved in 1596bc4 by dropping item 4. The dismiss label stays main's "Dismiss notice and re-enable Install/Update" in every catalog; the |
|
Why the frozen Goal and Not a goal changed: the owner decided to drop item 4 (the dismiss relabel) rather than override the First Principles finding. The Goal no longer names the label change, and Not a goal now says the label stays as on main. No other frozen text changed. |
61b44c6 to
1596bc4
Compare
|
HOLD at 1596bc4. The r101 items are cleared: item 4 (the dismiss relabel) is dropped, every AI lane passes on this head, and CI is green. The KiroCrew/src/kiro_crew/apps/manager_install.py Lines 628 to 648 in 1596bc4 What holds it: the change adds a refusal and audit row on the update path for the app's credential file, which the maintainers' rule reserves for a human reviewer. AI findings judged non-blocking:
Items 5 and 6 stay tracked in #14471. — crew-pr-reviewer (r138) |
bolichen97
left a comment
There was a problem hiding this comment.
[operator: bolichen97] Reviewed at the current head. The .app_secret link refusal runs before the update transaction opens, matching the existing data-link pre-check, and the new test pins that the link, its target, the record and the tree stay untouched. The desktop string change is mirrored in the capture script and both frontend tests. No breaking issues found.
Non-blocking: this covers part of #14471's follow-ups, so that issue stays open for the rest, which matches the PR not using a closing keyword.
AI-assisted, approved by bolichen97







Refs #14471
Problem / Motivation
Goal: Fix two deferred follow-ups from #13568: refuse an update whose installed
.app_secretis a symlink, and align the test/harness REFUSAL constant with the backend string.Items 3 and 7. Items 4, 5 and 6 excluded: item 4 keeps main's dismiss label (owner decision), item 5 awaits a maintainer ruling, item 6 belongs in the release PR per AGENTS.md.
Intended? / Repro
@requires_symlinkstest; without the fixupdate_appreturnsok=Trueand the secret is gone.Why it matters
findReportbehavior against the old string; a live deployment with the new string would silently break the handoff.Not a goal
What changed (motivation → approach → change)
Item 3 —
shutil.moverelocates the link outside its tree; a relative target no longer resolves, sotmp_secret.is_file()fails and the secret is not put back. Fix: checkis_link_or_junction(secret_file)before the transaction opens and returnAppResult(ok=False).Changed:
src/kiro_crew/apps/manager_install.py,test/test_app_manager_copy_tree.py,test/link_screen_sites.py.Item 7 — REFUSAL constants in
TrustAppModal.test.tsxand the capture harness updated from "desktop app" to "Kiro Crew's desktop build".Changed:
website/src/test/TrustAppModal.test.tsx,website/scripts/capture-trust-modal-install-reason.mjs.Backwards compatibility
Compatible: item 3 adds a refusal for a shape the install path never creates. Item 7 is a fixture change only.
Removes nothing: no existing reader of
.app_secretor the refusal string is removed.Tests
test_app_manager_copy_tree.py::TestCopyAppTree::test_an_installed_app_secret_link_refuses_the_update_before_the_transaction— new,@requires_symlinksTrustAppModal.test.tsx— REFUSAL constants updatedManual verification
Capture harness run locally, all 8 frames written and asserted. Frame 06 shows the updated refusal string.
Screenshots / video
Frame 06 — trust-saved failure (item 7: updated refusal string):

Related Issues
Pattern harvest
Rule candidate: When a pre-transaction move can relocate a symlink outside its tree, add a pre-transaction
is_link_or_junctionrefusal matching the data-link shape — each gateway-owned root entry that can carry a link needs its own check.Checklist
Reader: src/kiro_crew/apps/manager_install.py