Repository navigation
fix: hide Decisions judge selects from search when feature is withdrawn - #20231
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the two image attachments show the in-page Settings search with "which judge" both withheld and shown. [DESIGN-REVIEWED] a8107a2 Description read[DESCRIPTION-READ] 4fb71924ca6449b0e5b7924df0ee7639e8397ce29543b6af6f532808962e3986 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that the clipped left edge of the search results in both screenshots comes from the capture harness's 320px container, not from [UX-REVIEWED] a8107a2 Description read[DESCRIPTION-READ] 466dc0d88231b978ed91aed2038839746a0a0f730fb490685a689444857c2689 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Confirm the per-issue capture harness and Playwright script should be committed rather than kept as local verification tooling. Not justified as shipped
What this change shipsInventory (4 items) — 3 justifiedIntent: Settings search should stop offering two Decisions judge controls on installations where Decisions is not offered. FIX.
[FIRST-PRINCIPLES-REVIEWED] a8107a2 Description read[DESCRIPTION-READ] 3e6cb76fe5bbb057dbe727c9b94c3693ce8b46ab2abe5a54f56a868cb1a8c953 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Frontend Tests (2) shard is failing on |
DecisionsPointPanel.tsx's two SettingsSelect controls (judge provider and model) were extracted into the settings registry but absent from DECISIONS_SETTING_IDS, so Settings search returned them even when decisions_enabled is false. Add both ids to the governed set. Extend the coverage test to also scan DecisionsPointPanel.tsx so a future control added to that file fails the test rather than leaking. Add palette-provider test cases that assert the two entries are withheld under a governance pin. Refs #13850
10c34d4 to
a8107a2
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (5 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds the two judge selects from the Decisions point panel to DECISIONS_SETTING_IDS so settings search hides them when the feature is withdrawn; tests assert both states and that every control in that panel is listed.
Problem / Motivation
Goal: Hide the Decisions (Jev) judge-provider and judge-model settings from search when
decisions_enabledis false.DecisionsPointPanel.tsx's twoSettingsSelectcontrols — "Which judge answers" (developer.which-judge-answers) and "Model for the small-model judge" (developer.model-for-the-small-model-judge) — are extracted into the settings registry by the shared extractor but were not listed inDECISIONS_SETTING_IDS. Whendecisions_enabledis false,settingEntryOfferedreturnedtruefor them, so both search surfaces (the command palette and the in-page Settings search) returned these results even on a fleet where the feature is not offered. A hit navigates to a section where neither the card nor the point panel is rendered, which reads as a broken page.Why it matters
A user on an installation where Decisions is not offered sees Settings search return "Which judge answers" and "Model for the small-model judge" when searching. Following either result navigates to a Settings page with no card, no panel and no controls — the page appears broken. The card's existing governance path already covers every other row; these two fell through because they live in
DecisionsPointPanel.tsx, which the coverage test did not scan.Not a goal
theme_install, Feature Preview cards with no backend flag, etc.) — listed as "Not in this PR" below.social_share_enabledis checked — no Settings entries exist in the registry for it, so there is nothing to filter.Intended? / Repro
Intended? No. The governance filter for the Decisions card was intentionally introduced to prevent dead search results. The two judge selects are part of that same governed card and the same ceiling applies. The omission is confirmed by the comment in
DECISIONS_SETTING_IDSitself ("A control added to the card without a line here is a red test rather than a live leak") and by the extractor's PANEL_TAB_MAP, which listsDecisionsPointPanel.tsxas a scanned file.Repro (file:line):
website/src/components/commandPalette/settingsSearchGovernance.test.ts— the "DECISIONS_SETTING_IDS covers the whole card" describe block reads onlyDecisionsCard.tsx;DecisionsPointPanel.tsxis inPANEL_TAB_MAPbut not in the test.website/src/components/commandPalette/settingsSearchCore.ts:95—DECISIONS_SETTING_IDShas 6 entries;developer.which-judge-answersanddeveloper.model-for-the-small-model-judgeare absent.website/src/pages/settings/DecisionsPointPanel.tsx:191,203— twoSettingsSelectelements with statici18nT(...)labels that the extractor reads and adds to the registry.What changed (motivation → approach → change)
The registry lists every setting the build ships regardless of whether the gateway offers it.
settingEntryOfferedis the filter: it returnsfalsefor any id inDECISIONS_SETTING_IDSwhendecisionsEnabledis false. The two judge selects are extracted fromDecisionsPointPanel.tsxinto the registry but were absent from the governed set, so the filter passed them through.Fix: add both ids to
DECISIONS_SETTING_IDSwith a comment tying them to the point panel. Extend the coverage test to also scanDecisionsPointPanel.tsxwith the same extractor, so a control added to that file fails the test rather than silently entering the search corpus. Add palette-provider test cases that assert the two entries are withheld when decisions is off and offered when it is on.Backwards compatibility
Compatible:
DECISIONS_SETTING_IDSis an additive change that only widens the filter, never removes entries from it. No API or config key changes.Removes nothing: only Settings search results are hidden — the underlying config paths remain valid and settable.
Tests
settingsSearchGovernance.test.ts→ newitin "the palette provider honours it": asserts "Which judge answers" and "Model for the small-model judge" are withheld from both full-corpus search and tab listing whendecisionsEnabledis false, and offered when true.settingsSearchGovernance.test.ts→ newitin "DECISIONS_SETTING_IDS covers the whole card": runs the extractor overDecisionsPointPanel.tsxand asserts every label found has its registry id inDECISIONS_SETTING_IDS.[...DECISIONS_SETTING_IDS]expansion.Manual verification
Verified via capture harness (
website/capture/settings-search-governance-13850.tsx) with the dashboard config stub. Screenshots below show the search box with query "which judge" in both states.Screenshots / video
Search query "which judge" —
decisions_enabled: false(judge entry absent):Search query "which judge" —
decisions_enabled: true(judge entry shown):Related Issues
Refs #13850
Not in this PR
These Settings surfaces have no existing backend availability signal and are not covered by this PR (need a maintainer-designed signal per the conductor's decision):
capabilities.*flag (e.g. artifact deploy, crewmates, chat-on-a-crew, composable layout, webhooks)capabilities.theme_installwired to/api/dashboard/config)Pattern harvest
Rule candidate: review-prompt
Pattern: A file listed in the settings extractor's
PANEL_TAB_MAPthat belongs to a governed card should be covered by the governance coverage test alongside the primary card file. The test scope should match the extractor's scope.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.