Skip to content

test: split test_ai_review_workflows.py, part 2 of 3 - #20347

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t02-test-ai-review-workflows-p2
Oct 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t02-test-ai-review-workflows-p2

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring test/test_ai_review_workflows.py under the 2,000-line cap on hand-written files without changing a single test, in a three-PR series; this PR is part 2.

test/test_ai_review_workflows.py is still 13,971 lines after part 1 (#20282). It is past the 2,000-line cap on hand-written files, and nearly every review-workflow change collides in it.

Why it matters

Every change to a review lane edits this one file, so unrelated PRs conflict in it and a reader has to search thousands of lines for the pin that guards a workflow. Splitting by the behaviour under test gives each lane's pins a findable home.

Not a goal

  • Changing, renaming, rewriting or de-flaking any test. Bodies move verbatim.
  • Changing any workflow, script or product behaviour. The workflow edits are comments.
  • Finishing the split here: part 3 moves the rest.

What changed (motivation → approach → change)

Like part 1, this part moves ONE contiguous run of the original, so git's default diff equals git diff --minimal byte for byte (701,226 bytes). The run is TestBlockAdjudicationContract through TestReviewSandboxFailsClosed, plus the file's tail from TestTheGuardedUpsertRecordsWhatReachedTheSlot on, which part 1 left adjacent to it: 28 classes, 596 tests.

File Lines What it holds
test/test_ai_review_workflows_block_adjudication.py (new) 1,354 the adjudication of GPT's blocking findings
test/test_ai_review_workflows_verdict_publication.py (new) 1,323 each lane's real guarded comment upsert
test/test_ai_review_workflows_whole_design_verdicts.py (new) 821 how the design, UX and first-principles lanes reach and present a verdict
test/test_ai_review_workflows_gpt.py (new) 496 the GPT lanes
test/test_ai_review_workflows_first_principles.py (new) 270 the First Principles lanes (problems-first contract for now)
test/test_ai_review_workflows_human_override.py (new) 300 human overrides (the handler's fork re-run for now)
test/test_ai_review_workflows_code_review_greps.py (new) 208 Code Review's grep steps on a real repository
test/test_ai_review_workflows_comment_writes.py 1,010 -> 1,531 + the byte-identity pins (TestReviewLaneVerdictVisibilityAcrossLanes)
test/test_ai_review_workflows_credential_isolation.py 261 -> 841 + what each lane's model can reach
test/test_ai_review_workflows_fork_verdict.py 758 -> 1,231 + the unstamped fork body and the fork scope override
test/ai_review_workflows_helpers.py 231 -> 673 + _GUARDED_LANES and the helpers the new parts share with the original

TestReviewLaneVerdictVisibility is 1,549 lines, and two classes instantiate it as their harness, so the three must share a file: 1,729 lines, over the 1,600-line target. Its seven workflow-source pins (byte-identical guard and write primitive, retried lookups, honest write reports) move to a new topic class, TestReviewLaneVerdictVisibilityAcrossLanes, in comment_writes; the harness and its behavioural tests keep the class name the two harness users bind, in verdict_publication. Those seven tests are the only ones whose class changes.

The comments that cite those byte-identity pins (12 review workflows, the CI doc and two tests) now name test_ai_review_workflows_comment_writes.py.

Backwards compatibility

Compatible: only test modules move; no product import path, entry point or API changes, and every test keeps its name and parameters.

Removes nothing: the 596 moved tests still run, from sibling files in the same directory, and nothing imports from test/test_ai_review_workflows.py.

Move audit

test/test_ai_review_workflows.py: 13971 -> 7367 lines; moved 100.0% (python-ast)
475 of 475 units moved or kept, 0 changed

Tests

No test is added or changed. The proof that nothing was lost:

base this PR
collected tests 1,489 1,489
(test, params) multiset — identical
(class, test, params) multiset — identical once the seven pins below map back to TestReviewLaneVerdictVisibility

Class mapping (29 collected tests):

Old New Collected
TestReviewLaneVerdictVisibility::test_guard_function_is_byte_identical_across_all_lanes TestReviewLaneVerdictVisibilityAcrossLanes::test_guard_function_is_byte_identical_across_all_lanes 1
TestReviewLaneVerdictVisibility::test_only_the_fail_closed_lanes_exit_on_a_verdict_that_missed_the_slot TestReviewLaneVerdictVisibilityAcrossLanes::test_only_the_fail_closed_lanes_exit_on_a_verdict_that_missed_the_slot 1
TestReviewLaneVerdictVisibility::test_the_lookup_that_gates_a_verdict_write_is_retried TestReviewLaneVerdictVisibilityAcrossLanes::test_the_lookup_that_gates_a_verdict_write_is_retried 12
TestReviewLaneVerdictVisibility::test_write_primitive_is_byte_identical_across_every_publishing_lane TestReviewLaneVerdictVisibilityAcrossLanes::test_write_primitive_is_byte_identical_across_every_publishing_lane 1
TestReviewLaneVerdictVisibility::test_no_verdict_write_announces_a_success_it_did_not_get TestReviewLaneVerdictVisibilityAcrossLanes::test_no_verdict_write_announces_a_success_it_did_not_get 12
TestReviewLaneVerdictVisibility::test_only_the_idempotent_write_may_repeat_without_confirming TestReviewLaneVerdictVisibilityAcrossLanes::test_only_the_idempotent_write_may_repeat_without_confirming 1
TestReviewLaneVerdictVisibility::test_every_lane_calls_the_guard_and_fork_fp_covers_both_sites TestReviewLaneVerdictVisibilityAcrossLanes::test_every_lane_calls_the_guard_and_fork_fp_covers_both_sites 1
  • Floor on this head (every test_ai_review_workflows* file, the tests that read an edited workflow, the 21 that scan every workflow, and the doc/ratchet readers): 3,668 passed.
  • L36: for every changed file, git diff --numstat and git diff --minimal --numstat against the base agree (the original: +8 / -6,612).
  • test/test_flake_pattern_ratchet.py, test/test_wait_discipline_ratchet.py, comment-history and brand gates, black, isort, flake8, docs_lint.py, semgrep 1.78 with CI's configs (0 findings): all pass.

Determinism: the moved tests are unchanged, so their determinism is what it was on main.

CI path references

Comment lines only, no logic; each names the file that now holds TestReviewLaneVerdictVisibilityAcrossLanes:

  • "test_ai_review_workflows.py pins it byte-identical across all" (the write primitive) -> test_ai_review_workflows_comment_writes.py, in claude-review.yml, design-review.yml, first-principles-review.yml, fork-design-review.yml, fork-first-principles-review.yml, fork-gpt-review.yml, fork-opus-review.yml, fork-security-scope-review.yml, fork-ux-review.yml, security-scope-review.yml, ux-review.yml.
  • "byte-identically in every review lane; test_ai_review_workflows.py" (guarded_comment_upsert) -> test_ai_review_workflows_comment_writes.py, in the same files except claude-review.yml (10 files).
  • codex-review.yml: "test_ai_review_workflows.py pins both byte-identical across all lanes" (its guarded upsert and write primitive) -> test_ai_review_workflows_comment_writes.py.

No workflow path filter or file list names the target.

Citations updated

  • docs/ci/ci-and-reviews.md: the guarded-upsert byte identity -> test_ai_review_workflows_comment_writes.py; names the file now holding TestOverrideHandlerReRunsTheBoundForkLaneRun.
  • test/test_review_slot_read_error.py (docstring and one comment) and test/test_withheld_verdict_retention.py (one comment): -> test_ai_review_workflows_comment_writes.py. Comment text only.

Moved literals the content scan reads

  • AKIAIOSFODNN7EXAMPLE (AWS's documented example id, 2 lines) moves with TestBlockAdjudicationArithmetic to block_adjudication.py:941,949; the bare FAKE_SECRET = "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY" (the documented example secret) moves with TestForkLaneRedactsCredentialValues to credential_isolation.py:292; "ghp_" + ... is built at runtime.

Line-cap baseline

Lowers this target's row in .github/file-line-cap-baseline.txt from 14,106 to 7,367 (it stays over 2,000 until part 3). python3 scripts/check_file_line_cap.py: 0 failures.

Upstream change carried

#20332 (codex-review.yml converges onto the shared guarded upsert) landed after this PR opened and edited the classes it moves. The recipe was re-run on main ec99d9056b, so its edits move verbatim: TestGptVerdictVisibility and TestGptRefusalTerminalState in gpt, TestReviewLaneVerdictVisibility and its two harness users in verdict_publication, the seven pins in comment_writes, and the new codex row of _GUARDED_LANES in the helper module.

Notes for reviewers

  • The harness class keeps its docstring and every member verbatim (only the blank lines where the seven pins were cut out close up); "the identity test" its docstring mentions is now TestReviewLaneVerdictVisibilityAcrossLanes in comment_writes.
  • Docstrings of the parts this PR fills only partly (gpt, whole_design_verdicts, first_principles, human_override) describe what they hold now; part 3 widens them.

Manual verification

N/A — test-only move; the collected multiset, the move audit and the passing runs above are the verification.

Related Issues

Part of #20192

Follow-up: #20383 (pre-existing shapes moved verbatim; de-flake there)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 14, 2026 15:22
@bolichen97
bolichen97 requested a review from mbriones98 October 14, 2026 15:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1961e612dc2be095798ae50c8e2583f060c32523 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1961e612dc2be095798ae50c8e2583f060c32523 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 1961e61

Description read

[DESCRIPTION-READ] 53cb6c35718b7c2a8d9372593ee12774a52cf5eab7abea4ed69a02d5ba72ec72

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1961e612dc2be095798ae50c8e2583f060c32523 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check one thing before merge: CI's collected count still matches base (1,489 tests). The seven pins moved into TestReviewLaneVerdictVisibilityAcrossLanes are the only renamed node IDs.

What this change ships

Inventory (6 items) — 6 justified

Intent: Bring the review-workflow test file under the documented 2,000-line cap by moving tests verbatim. This is a refactor: neither a fix nor an addition.

  1. 28 test classes move out of test_ai_review_workflows.py into seven new topic files and three existing sibling files — justified
  2. Seven workflow-source pins move from TestReviewLaneVerdictVisibility into a new class, TestReviewLaneVerdictVisibilityAcrossLanes, which changes their test IDs — justified
  3. The shared helpers and _GUARDED_LANES move into test/ai_review_workflows_helpers.py — justified
  4. The file-line-cap baseline row shrinks from 14106 to 7367 — justified
  5. Comments in 12 review workflows and two tests now point to the new home of the byte-identity pins — justified
  6. ci-and-reviews.md now names the files that hold the moved pins — justified

[FIRST-PRINCIPLES-REVIEWED] 1961e61

Description read

[DESCRIPTION-READ] f50a831751c6d67b026c90839983481b2361f85282e073f37e11a195eab901d1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1961e612dc2be095798ae50c8e2583f060c32523 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1961e61

Verdict parsed from the review's SHA-scoped output markers for commit 1961e612dc2be095798ae50c8e2583f060c32523.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1961e612dc2be095798ae50c8e2583f060c32523: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1961e612dc2be095798ae50c8e2583f060c32523 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1961e61

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1961e612dc2be095798ae50c8e2583f060c32523: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Where the 2,000-line cap is written down

Outcome: rebutted (outside this PR's goal; nothing to change in this head).
The cap is recorded in #20192, the issue this PR is part of: "cap every hand-written source and test file at 2,000 lines", with a repository guard and a baseline as its first step.
That guard (a check script, its baseline and the AGENTS.md / code-style rule) is a separate PR of the same campaign; this PR only moves tests and must not also define the rule it serves.
The 1,600-line figure is the campaign's per-file target below the cap (headroom for the next feature PR); each new part here is at most 1,514 lines.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Security Scope Review -- ✅ PASS

Which legitimate operations does 1961e612dc2be095798ae50c8e2583f060c32523 newly refuse? Updated in place on each push. A script-confirmed regression blocks; the model proposes candidates and never decides a refusal.

Verdict basis: adjudicated, zero confirmed regressions.

Security scope review -- adjudicated candidates

  • macos-latest (platform posix): 5 classified, 0 newly refused, 5 still allowed.
  • ubuntu-latest (platform posix): 5 classified, 0 newly refused, 5 still allowed.
  • windows-latest (platform windows): 5 classified, 0 newly refused, 5 still allowed.

No candidate flipped from allowed to refused.

Scope-Verdict: PASS

TIGHTENING: none -- the patch makes nothing stricter, so there is no threat to quote. It touches no file under src/ or scripts/, so neither SHELL_DENY_TIERS nor any matcher, validator, path resolver or approval tier changes. Every hunk in .github/workflows/*.yml and docs/ci/ci-and-reviews.md is a comment or prose change that swaps the pinned test file name, e.g. - # lane; test_ai_review_workflows.py pins it byte-identical across all / + # lane; test_ai_review_workflows_comment_writes.py pins it byte-identical across all. The rest of the patch splits test/test_ai_review_workflows.py into topic files, adds helpers to test/ai_review_workflows_helpers.py, and lowers that file's entry in .github/file-line-cap-baseline.txt from 14106 to 7367.

ADJUDICATED: 8 candidates, 0 confirmed newly-refused

PLATFORM COVERAGE: the patch assumes no path, separator, interpreter, executable name or environment variable in any guard. The candidates still probe the maintainers' daily operations in the touched area, in both spellings:

  • posix: the env-stripped .venv/bin/python -m pytest test/... runs of the new split files (comment_writes, credential_isolation, human_override with -k).
  • windows: the same three runs as .venv\Scripts\python.exe with \ separators.
  • any: the line-cap gate the baseline change relies on, and a read-only git diff --stat of the touched trees.

No platform spelling the diff assumes is left unprobed.

[SCOPE-REVIEWED] 1961e61

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@bolichen97
bolichen97 force-pushed the refactor/linecap-t02-test-ai-review-workflows-p2 branch from 6d7d7d9 to 54792d7 Compare October 14, 2026 17:32
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main changed the classes this part moves (#20332 converged codex-review.yml onto the shared guarded upsert), so the split was re-cut on main 79edb16 with the recipe and #20332's edits move verbatim; CI re-running on 54792d7.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 14, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The seven pins in TestReviewLaneVerdictVisibilityAcrossLanes still collect 29 tests

Outcome: rebutted (checked on this head; holds).
pytest --collect-only on test/test_ai_review_workflows_comment_writes.py lists 29 node ids under TestReviewLaneVerdictVisibilityAcrossLanes: 1 + 1 + 12 + 1 + 12 + 1 + 1, the two 12s being the parametrizations over _VERDICT_PUBLISHING_LANES.
Over all 15 parts the collected multiset is 1,489 = 1,489 against main ec99d90 once those 29 map back to TestReviewLaneVerdictVisibility; the mapping table in the body lists each.
The seven tests read no self attribute and no class-level name, so the new class needs no harness; the move audit reports every unit AST-identical (475/475).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 14, 2026
mbriones98
mbriones98 previously approved these changes Oct 14, 2026

@mbriones98 mbriones98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks green and readiness passed at 54792d7; no behavior change.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 14, 2026
@bolichen97
bolichen97 force-pushed the refactor/linecap-t02-test-ai-review-workflows-p2 branch from 54792d7 to ed5d415 Compare October 14, 2026 22:00
@bolichen97

Copy link
Copy Markdown
Contributor Author

Scheduled main refresh: rebased onto main 37449b3 (no upstream change to the moved code; range-diff identical) and lowered this target's line-cap baseline row to 7,367; CI re-running on ed5d415.

@bolichen97
bolichen97 enabled auto-merge (squash) October 14, 2026 23:05
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Comments that still name test_ai_review_workflows.py point at pins the file still holds

Outcome: rebutted (checked at this head; each is accurate).
pr-readiness.yml:58 and :218 cite TestPrReadiness, which stays in test_ai_review_workflows.py for the whole series (test_review_lane_prompt_parity.py reads it by path).
The five "reports the intended name instead" lanes cite TestProtectedCheckNameHasOnePublisherPerPrType, and test_pr_quality_gates.py:288/337/1188 cite the UX evidence-script tests; both are still in test_ai_review_workflows.py at this head.
Part 3 moves those two and retargets the same 5 workflow lines (-> test_ai_review_workflows_fork_stage2.py) and 3 test comments (-> the ux parts) in its own commit; it keeps TestPrReadiness, TestDesignReviewPresentation and TestFirstPrinciplesReview.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Nothing selects these tests by their old node ids

Outcome: rebutted (checked; no selector keys on them).
Every moved test's node id changes, because the file path is part of it; the seven pins also change class.
git grep finds no node id, -k expression or path from test_ai_review_workflows.py in test/windows-, macos- or codebuild-expected-failures.txt, requires-real-symlinks.txt, the collect-ignore lists, wait_discipline_baseline.txt, conftest module sets, setup.cfg, .github/workflows or scripts/; the only references are prose citations, retargeted in this PR.
CI shards by file hash (scripts/ci_file_shards.py), so the moved tests still run in some shard; the collected multiset is 1,489 = 1,489 against main.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at ed5d415.

The split looks sound. I compared removed and added lines in the diff: every moved line reappears verbatim, the 192 test definitions match one for one, and the only non-move edits are the line-cap baseline row and comment lines that now name test_ai_review_workflows_comment_writes.py. All current-head AI lanes are PASS or no findings, and both PASS punchlines have dispositions. CI on this head is green.

What holds it: the move rehomes the credential-isolation pins into test_ai_review_workflows_credential_isolation.py and edits comments in the fork and security-scope review workflows. Changes to credential and security files are reserved for human review, so a maintainer needs to sign off. The workflow edits are comment-only and add no permissions, secrets or token exposure.

This clears when a maintainer reviews and approves the move. I read the diff and CI results; I did not run the tests.

— crew-pr-reviewer (r102)

The second part of the split moves the run from the block-adjudication
tests through the fork review sandbox, and the file's tail from the
guarded-upsert outcome tests on (28 classes, 596 tests), into seven new
sibling parts and the parts part 1 started.

TestReviewLaneVerdictVisibility is 1,549 lines, and two classes drive
it as their harness, so the three cannot share a 1,600-line part. Its
seven workflow-source pins move to a new topic class,
TestReviewLaneVerdictVisibilityAcrossLanes, in
test_ai_review_workflows_comment_writes.py; the harness and its
behavioural tests keep the class name the harness users bind.

Test bodies move verbatim; only those seven tests change class. The
workflow and doc comments that cite the byte-identity pins name their
new file.

Part of #20192
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Oct 15, 2026
@bolichen97
bolichen97 force-pushed the refactor/linecap-t02-test-ai-review-workflows-p2 branch from ed5d415 to 1961e61 Compare October 15, 2026 02:22
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 15, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Scheduled main refresh: rebased onto main 4cf5798 (no upstream change to the moved code; only other rows of the line-cap baseline moved, so the diff is identical); CI re-running on 1961e61.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The collected count still matches base at this head

Outcome: rebutted (checked on this head; holds).
pytest --collect-only over the 15 test_ai_review_workflows*.py files at 1961e61 collects 1,489 tests, a list byte-identical to the one proven against main ec99d90; no test_ai_review_workflows* file or the helper module changed on main between ec99d90 and 4cf5798, so base is still 1,489.
Every moved test's node id changes, because the file path is part of it; the seven pins are the only tests whose class also changes (mapping table in the body), and no selector keys on any of these node ids.
Every backend shard on this head (Linux 3.12, Windows, IPv6, namespace sandbox, crew container) completed green.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after a maintainer read the review lanes on this head: all clean; held only on the file count of a 1:1 test split.

@bolichen97
bolichen97 merged commit 4910703 into main Oct 15, 2026
103 of 104 checks passed
@bolichen97
bolichen97 deleted the refactor/linecap-t02-test-ai-review-workflows-p2 branch October 15, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants