Repository navigation
Conversation
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the "No recently closed sessions." notice. The two attached notice screenshots show the card saying "invalid agent name" instead, which is a different message. Evidence gaps
Notes
[UX-REVIEWED] 263a99e Description read[DESCRIPTION-READ] 277523447cd802e0b7fcc002ad0482ebc4ce24bf865a0c625655fdb2571ca7d5 That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The design reuses the existing resume path and the backend's own Notes
[DESIGN-REVIEWED] 25a04fb Description read[DESCRIPTION-READ] 2428f55e83f4160a2118d1fddd561614a1097d52a81de35b5411d993ac509231 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS No item blocks. The shortcuts-modal layout rework restacks every row on narrow windows, which is more than the new chord needs; it is a note, not a blocker. Notes
What this change shipsInventory (8 items) — 7 justifiedIntent: reopen an accidentally closed session with one keystroke, as in a browser. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 263a99e Description read[DESCRIPTION-READ] e62db63185e266af968bf5be3bb8723760a2c94d36a7460f3ce15eba783c1d44 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
c83422a to
85f62f0
Compare
|
self-added: no
|
|
|
|
85f62f0 to
9760b3f
Compare
|
Pushed |
9760b3f to
393177a
Compare
6c3f3d6 to
debe47c
Compare
|
|
self-added: no
|
|
The Opus 5.5 fork lane on |
|
|
|
|
|
Security Scope Review (fork) — 🔴 BLOCK (blocking)Which legitimate operations does the review scope was never resolved: the generate job did not finish (it timed out, failed or was cancelled), so no leg ran; its log names the step that stopped No |
|
|
|
|
|
Could a maintainer please click Approve and run workflows for The previous head, |
bolichen97
left a comment
There was a problem hiding this comment.
Thanks @hungtnvu. CI now runs on 195c8d4, and two blocking items need fixing before merge:
- Holding the reopen chord reopens several sessions. In
website/src/hooks/useKeyboardShortcuts.ts, the'reopen-chat'action has noe.repeatcheck. Every key auto-repeat pops another entry and starts its ownresumeFromHistory. The last request wins, so the user lands on an older session, and the entries in between are used up. Fix: return early one.repeatat the top of'reopen-chat', the way'new-chat'does. Add a test: one repeated keydown reopens exactly one session. - File line cap.
src/kiro_crew/dashboard/chat_api/resume.pyis now 2,001 lines, over the 2,000-line cap (python3 scripts/check_file_line_cap.py). That failsBackend Ratchets & BoundariesandFrontend Ratchets & i18n. Fix: move a whole definition into a sibling module, or save the line inside your hunk. Do not add a baseline row.
Backend Tests (3.12, 3) is also red on this head. Please check whether it is yours after the fixes; if it is a flake, say so and it gets one rerun.
AI-assisted review (code-review-sage), sent by CommunityCrew
Add a rebindable reopen-chat command under Actions. Each user close (Cmd+W, the sidebar X, session menus) that lands is recorded on a per-tab in-memory stack; the chord pops it newest first and resumes the session through the same path History and the command palette use, so the transcript comes back intact. Sessions on a surface the chat page cannot show are never recorded. The desktop menu's Refresh Token moves from CmdOrCtrl+Shift+T to CmdOrCtrl+Alt+T so the chord reaches the renderer. Fixes kirodotdev#18969
|
|
|
@hungtnvu we picked this up to drive it green. AI-assisted, sent by CommunityCrew |
ChatPageMoreCoverage.test.tsx reached 2,018 lines once merged with main, over the 2,000-line cap. Move the two resumeFromHistory leaveSplit tests this PR added into ChatPage.reopenLeavesSplit.test.tsx with only the setup they need. The old file is back to its main blob. Co-authored-by: Hung Vu <hungvu@amazon.com>
|
@hungtnvu AI-assisted, sent by CommunityCrew |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Approve. Nothing blocking at 25a04fb.
What this does for users: after an accidental close (⌘W, the sidebar ✕ or a session menu), ⌘⇧T on macOS or Ctrl+Shift+T elsewhere brings the session back with its transcript, newest first, up to 20 per tab. In a browser tab the working chord is Option/Alt+Shift+T, because the browser keeps Ctrl+Shift+T for its own tabs. The desktop app's Connection menu item that refreshes the window's credential moves to Cmd+Alt+T (macOS) and Ctrl+Alt+Shift+T (Windows/Linux), so the chord reaches the page.
What I checked:
- Reopen goes through the existing History resume (
resumeFromHistoryand POST /api/chat/slots/{slot}/resume). The backend change only adds a read-onlyhistory_keyto the slot list and the two resume responses (slot_projection.py:616, resume.py:283 and :741). There is no new write path. - Only user closes are recorded. A refused DELETE drops its entry. Surfaces the chat page cannot show are skipped (recentlyClosedSessions.ts:61). Incognito and Temporary sessions are recorded, which matches the 2026-09-25 decision that their transcript stays in History. The record lives only in the tab's memory.
- On terminals: the primary chord is left to the shell (useKeyboardShortcuts.ts:864). The File Explorer's Cmd/Ctrl+T now ignores Shift (FileExplorerPage.tsx:431). The shortcut registry test passes, 24/24.
- Both earlier change requests are fixed at this head. Holding the chord now reopens one session (useKeyboardShortcuts.ts:1094): removing that line reddens "claims a held chord's auto-repeats without reopening another session" (1 failed, 31 passed). resume.py is at 2,000 lines, and the line cap check passes.
- The last commit only moves the two leaveSplit tests into ChatPage.reopenLeavesSplit.test.tsx. ChatPageMoreCoverage.test.tsx is back to main's exact blob, and no source file changed.
- Local runs: reopenClosedSession 32/32, useSessionActions.cov80 27/27, FileExplorerPageCoverage 69/69, and the shortcut registry and Shortcuts modal suites 78/78. ChatPage.reopenLeavesSplit did not run locally because of a missing local dependency; CI's frontend shards are green on this head.
- The branch merges cleanly with main.
CI:
- 87 success, 10 skipped, 4 failure on 25a04fb.
- Backend Tests (3.12, 5) and Backend Tests (Windows) (5) both fail one test, test_decisions_model_route_derived.py::TestTheUsageRowOfARoutedStart::test_the_row_names_no_routed_id_the_child_may_have_withheld. The test reads the usage row before the background write finishes. Main fixed that race in #29982 after this branch's base, and this diff touches nothing on that path. The test passes 72/72 locally on this head and on main. Coverage Gate is red only because of it.
- Updating the branch onto main should clear all three. A plain re-run may reuse the old merge commit.
- The Opus 5.5 lane did not finish on this head. Its last finished verdict, "No findings" on eb9dde5, covered the same source.
Checked from source only: a real Electron window, Windows and macOS hosts, iframes and app frames (a keydown there does not reach the shell, the same as every other chord), and remote or member-thread sessions.
Follow-ups, not blocking:
- A session that was closed and then permanently deleted from History reopens as an empty session under its old title. The resume route treats a missing transcript as a new conversation and returns 200 with no messages. I reproduced this against this head. Nothing is persisted until the user types, so it does not block. Forgetting the entry when its History row is deleted, or skipping an empty resume, would fix it.
- A reopen the server refuses for good, for example a member thread opened on the wrong slot, goes back on top of the stack. Every later press retries it, so older entries cannot be reached until reload.
- The description's Tests list still names ChatPageMoreCoverage.test.tsx for the leaveSplit tests. They now live in ChatPage.reopenLeavesSplit.test.tsx.
- The remember, track and forget close sequence is written twice, in useKeyboardShortcuts.ts and useSessionActions.ts. One helper in recentlyClosedSessions.ts would keep the next close site consistent.
- Inside a terminal, the Option/Alt+Shift+T alias is still claimed by the page, as the existing Alt+Shift+N and Alt+Shift+W aliases are.
|
@hungtnvu I made a mistake here: I used AI-assisted, sent by CommunityCrew |






Problem / Motivation
Goal: Let a user reopen a session they just closed with Cmd/Ctrl+Shift+T, the way a browser reopens a closed tab.
Closing a session is one keystroke (Cmd/Ctrl+W), but undoing an accidental close means opening History, finding the conversation and clicking it. No shortcut or command reopens a closed session, so there is nothing to bind one to either.
Why it matters
Accidental closes are common when working across several sessions from the keyboard, and the recovery path breaks that flow every time. Cmd/Ctrl+Shift+T is the reopen convention in every browser, terminal and editor, so it is the chord users already try.
Not a goal
What changed (motivation → approach → change)
reopen-chat, in the Actions group of the shortcut registry, so it appears in the Cmd+/ reference and is rebindable in Settings → Shortcutswebsite/src/lib/recentlyClosedSessions.ts)setAgentSwitchNotice, the same status card and 6-second expiry that focus mode and a deferred model switch already use for neutral messages. No new state, reducer or component;App.tsxandchatSlice.ts's reducers are unchanged from mainhistory_key, the transcript session key the backend's ownslot_history_keyrule picks (src/kiro_crew/dashboard/slot_projection.py), unfolded, so a channel session (including a Slack thread whose transcript predates theslack:<ts>key migration) reopens its real transcriptleaveSplittoresumeFromHistory, which records it on main's existinglastResumeActivation, and the chat page leaves Split View on it the way it already does for a new chat's activation (website/src/pages/chat/page/activeSlotState.ts). Other resumes (History, the command palette) are unchangedwebsite/src/apps/file-explorer/FileExplorerPage.tsx), so the chord does not also open a tab thereA close is recorded only when the user closed the session (Cmd+W, the sidebar ✕, a session menu). It is recorded at the press, so Cmd+Shift+T right after Cmd+W finds it and rapid closes keep their press order, and if the server refuses the close, only that close's own entry is dropped, so a refused close is never offered and a later successful close of the same session keeps its entry. Reopen first waits for that close to finish (and, when it was refused, for each older entry it falls back to), so a close still waiting on the next session's transcript cannot clear the reopened one when it lands. Only then does it ask the leave guard, once, against the page on screen at that moment; a declined leave puts the entry back for the next press. If a close is slow, the leave prompt therefore appears after it finishes rather than at the press. Swaps that retire a tab for another one, bulk cleanup and apps closing their own sessions are not user closes and are not recorded. Sessions on a surface the chat page cannot show are skipped. Incognito and temporary sessions are recorded, because their transcript stays in History for the user to reopen (
docs/decisions/2026-09-25-incognito-and-temporary-chats-keep-their-transcript.md).Reopening uses the same
resumeFromHistorypath as History and the command palette, keyed by the recorded transcript key rather than the dashboard slot key. A session bound to Slack or another channel keeps its transcript under that channel's key, so guessingdashboard:<key>would open an empty session. The key is sent unfolded becauseConversationLog._pathfinds a pre-migration Slack thread's bare<ts>.jsonlonly from theslack:<ts>spelling. The backend sends the key it uses (typed inwebsite/src/types/index.chat.ts; the resume response stays untyped like the rest of main's resume thunk, andresumeFromHistoryinwebsite/src/store/chat/lifecycle.tscopies itshistory_keyonto the slot row), and the client never guesses one: a slot withouthistory_keyis not recorded. The jump to/chatgoes through the draft guard (useGuardedLeave), like the notification panel's resume. The session leaves the list only once leaving is allowed, a failed resume puts the same entry back, and a session that is already open again is skipped, matched by slot key or byhistory_key, so a linked session reopened from History under its folded transcript key counts as open.In the shortcuts reference (
website/src/components/ShortcutsModal.tsx) a combo's keys never split across lines: a row breaks only between combos. From thesmbreakpoint up the label stays on one line, with a gap of at least 12px (sm:gap-3) before its keys; below it each row puts a full-width label above its combos, so a narrow window never squeezes the label into a one-word column. The two new strings are in every locale catalog underwebsite/src/i18nand the pseudolocale.website/electron/README.mdnames the new Refresh Token chords.Backwards compatibility
Breaking: the desktop app's Connection → Refresh Token menu accelerator moves from CmdOrCtrl+Shift+T to Cmd+Alt+T (macOS) and Ctrl+Alt+Shift+T (Windows/Linux). Writer sweep on origin/main @ 6f92c0e:
website/electron/app-menu.js(the only accelerator, moved),website/electron/README.md(updated),website/electron/window-lifecycle.jstray item (no accelerator, unchanged). The Mochi app's owntoggleWindowdefault is a separate global shortcut in its own store and is untouched.The slot payload's and the resume response's
history_keyis a new optional field; older clients ignore it, and the client still works against a gateway that omits it. Removes nothing: no command, route, record or setting is removed; one menu accelerator moves.Tests
website/src/test/reopenClosedSession.test.tsx: the stack order, dedupe, cap and filters; the transcript key is the backend'shistory_key, and a slot without one is not recorded; the chord on both platforms and the alias; Cmd+W then reopen throughapi.resumeChatSlot; the close is recorded at the press while the DELETE is still pending, and rapid closes keep press order; a refused close is not offered, and a late refusal leaves a newer close of the same session in place; reopen during a close that is still loading the next session's transcript waits for it and the reopened session stays active with its transcript; a leave guard dirtied on another route during that wait is asked once after it, and declining keeps the entry; the same holds when the newest pending close is refused and reopen falls back to an older, already-closed entry; a declined leave keeps the page and the entry; an allowed leave lands on/chat; nothing to reopen sets the shell notice and asks nothing; a failed channel reopen keeps its key for the retry; a reopened session closed again before any slots update is still offered, because resume carrieshistory_keyonto its optimistic row; a session already reopened from History under a different slot key is walked past; the reference row keeps each combo's keys together; a held chord's auto-repeats reopen nothing more; reopen asks the page to leave Split View.website/src/test/ChatPageMoreCoverage.test.tsx: a resume withleaveSplitleaves Split View and shows the resumed chat; one without it keeps Split View.website/src/apps/file-explorer/FileExplorerPageCoverage.test.tsx: Cmd/Ctrl+Shift+T on the File Explorer does not open a folder tab, and plain Cmd/Ctrl+T still does.test/test_slot_history_key_projection.py:history_keyfor a dashboard slot, a linked Slack slot and an unbound channel-origin slot is the unfoldedslot_history_key; a pre-migration Slack thread's key resolves to its legacy<ts>.jsonl, and reopening by it through the resume route restores that transcript (fails with the old folded key); the resume response, fresh and already-live, returns the samehistory_keyas the slot list.website/src/hooks/useSessionActions.cov80.test.tsx: a sidebar/menu close is offered once it lands; itsdeleteSlotmock is thunk-shaped, matching whatclosedispatches.website/electron/test/app-menu.test.js: Refresh Token is on Cmd+Alt+T / Ctrl+Alt+Shift+T and no menu item claims Shift+T.Manual verification
Rendered from a production build of this head with
website/scripts/capture-shortcuts-registry.mjs,website/scripts/capture-settings-accelerator-caption.mjs(Connection menu built from the realbuildMenuTemplate, which also asserts the macOS caption) and a scratch variant of them. Closed and reopened a session with the browser aliases (Alt+Shift+W, then Alt+Shift+T) against the built SPA with a stubbed API: the close sentDELETE chat-2, the reopen sentresume dashboard_chat-2, and the transcript came back. Checked Settings → Shortcuts in browser and macOS desktop hosts, the Cmd+/ reference at 1280px and 360px, the Windows Connection menu, and the chord with nothing to reopen. Typecheck, the website build and the related frontend and backend tests pass locally.Screenshots / video
Closing "Fix the flaky upload retry test" with Alt+Shift+W, then reopening it with Alt+Shift+T, browser tab at 1440px:
Settings → Shortcuts, browser tab: the new row under Close session, Alt+Shift+T leading and Ctrl+Shift+T marked desktop-app-only.
Windows Connection menu: Refresh Token on Ctrl+Alt+Shift+T. On macOS the native menu shows ⌘⌥T.
Pressing the chord with nothing to reopen shows "No recently closed sessions." in the shell's existing notice. It is the same card a failed agent switch uses, unchanged from main, shown here with the agent-switch message:
macOS desktop row and the Cmd+/ reference
Related Issues
Fixes #18969
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)