Skip to content

fix(sidebar): say where to retry when hide-all stops partway - #20592

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/hide-all-stopped-notice-wording
Oct 15, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/hide-all-stopped-notice-wording

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When "Hide all PR and Issue chips" stops partway, the notice tells the user where to retry instead of saying "Could not hide".

When a hide-all walk stops partway, the session menu shows one error notice that reads "Stopped after hiding 2 of 6 chips. The chips still listed were not hidden. Could not hide. Try again." The last two sentences are the generic single-chip failure string. After a count of chips that were hidden, "Could not hide" reads as a contradiction, and "Try again" does not say what to retry. The approving review on #18556 raised this as a non-blocking follow-up.

Why it matters

A user who hits a partial stop reads two messages that disagree about whether anything was hidden, and gets no pointer to the action that finishes the job.

Not a goal

What changed (motivation → approach → change)

The stopped message in website/src/components/SourceLinksSubmenu.tsx built its text from hide_all_source_links_stopped followed by unlink_source_link_failed, the single-chip string. It now ends with a new key, pages.chatSidebar.hide_all_source_links_retry: "To try again, hide the rest from this menu." The key is added to all 13 catalogs under website/src/i18n/locales/.

The line names the menu rather than the Hide all entry. The entry only appears with two or more chips, so after a stop that leaves one chip, "select Hide all again" would point at something that is no longer there.

Backwards compatibility

Compatible: one new catalog key and a different string in an existing notice. No key, prop or API is removed.

Removes nothing: the stopped notice no longer appends unlink_source_link_failed, but that key stays in every catalog and the single-chip error still uses it.

Tests

website/src/test/ChatSidebar.sourceLinkUnlink.test.tsx: the hide-all stop test now expects "To try again, hide the rest from this menu." in the notice and asserts that "Could not hide. Try again." is absent. The single-chip failure test asserts the retry line is absent there.

Manual verification

Captured the stopped state in dark and light themes, shown below. The notice shows the count followed by the new retry line. The 973 frontend tests in src/i18n and the sidebar source-link tests pass, along with tsc, eslint, i18n:check, gen-ui-index --check and the frontend build.

Screenshots / video

Stopped notice, dark theme:

Stopped notice, dark

Stopped notice, light theme:

Stopped notice, light

Related Issues

Fixes #20591

Follow-up to the approving review on #18556.

Pattern harvest

Not generalizable: the defect was one string reused in a context its wording did not fit, specific to this notice.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners October 15, 2026 02:16
@Pearcekieser
Pearcekieser requested a review from buluoray October 15, 2026 02:16
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

This is a bug fix for #20591, a follow-up to the review on #18556. The fork account cannot add labels. Could a maintainer add the bug label to this PR and to #20591?

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 3a996ab1c4fc6143e64847150380d15cc166ecbb via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (3 items) — 3 justified

Intent: when "hide all" stops partway, the user should learn where to retry instead of reading "Could not hide" after a count of chips that were hidden. FIX (#20591).

  1. The stopped notice now ends "To try again, hide the rest from this menu." instead of "Could not hide. Try again." — justified
  2. The new retry string is in all 13 locale catalogs — justified
  3. Dark and light screenshots of the stopped notice are committed under temp-screenshots/ — justified

[FIRST-PRINCIPLES-REVIEWED] 3a996ab

Description read

[DESCRIPTION-READ] 9a03a43a971452b958033b432113d05ac44ffe4a4eaaa763b2871d9fd35c6f83

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 3a996ab1c4fc6143e64847150380d15cc166ecbb via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 3a996ab

Description read

[DESCRIPTION-READ] 2cf270939f0630cd24bfb65f506952b8be3aadae79505b81d4357249a3588bb8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of 3a996ab1c4fc6143e64847150380d15cc166ecbb via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has seen the new retry line. Both committed screenshots show it, so in this lane the verdict stops at CONCERNS.

Watch

  • The notice doesn't say which way to retry. The new line reads "To try again, hide the rest from this menu." Right above it, in attachment-01 and attachment-02, sits the "Hide all PR and Issue chips" entry, and below that each chip has its own row. The wording doesn't say whether to use Hide all again or hide the chips one at a time. The user still finds the way and nothing is lost, so this is low severity. It only comes up after a partial stop, which is rare.

Suggestions

  • Change the hide_all_source_links_retry text to "To finish, select the chips still listed above." That names the rows that are actually there. It also still makes sense when only one chip is left and the Hide all entry has disappeared, which was the author's reason for this wording.

[UX-REVIEWED] 3a996ab

Description read

[DESCRIPTION-READ] 5059df8264c803a7192368845ff39f9a0695837b3ab712429fa45cffccd28ee6

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 3a996ab1c4fc6143e64847150380d15cc166ecbb via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3a996ab

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 3a996ab1c4fc6143e64847150380d15cc166ecbb via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3a996ab

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026
A stopped hide-all walk showed "Stopped after hiding 2 of 6 chips. The
chips still listed were not hidden." followed by the generic single-chip
"Could not hide. Try again.", which read as contradicting the count.
The stopped notice now ends with "To try again, hide the rest from this
menu." in all 13 catalogs. It names the menu rather than Hide all
because a single remaining chip removes that entry.

Follow-up to the review on kirodotdev#18556.
@Pearcekieser
Pearcekieser force-pushed the fix/hide-all-stopped-notice-wording branch from 9ab9b72 to 3a996ab Compare October 15, 2026 05:16
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased on main (83e97cd), no behaviour change. The green run on 9ab9b72 no longer covered main, which had gained commits touching the 13 locale catalogs this PR edits. The rebase was clean, npm run gen:ui produced no diff, and tsc, i18n:check and 944 tests (src/i18n plus SourceLinksSubmenu) pass locally on 3a996ab.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

CI is green on 3a996ab and the PR carries readiness: passed. It is mergeable, and main has moved 4 commits since, none in files this PR touches. The fork account cannot arm auto-merge. Could a maintainer merge this PR or enable auto-merge on it?

note (non-blocking): UX CONCERNS says no first-time reader has seen the new retry line. The two committed screenshots under temp-screenshots/hide-all-retry-wording show it in the stopped notice. A reader test is the step a maintainer or the UX lane can add, and I have no way to run one from the fork.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 3a996ab.

The fix is small and correct. The stopped notice no longer ends with the single-chip "Could not hide. Try again." It appends a new key, hide_all_source_links_retry (SourceLinksSubmenu.tsx L230), which is present in all 13 catalogs, and the test pins the new text. CI is green, and it fixes #20591.

Blocker: the UX Review CONCERNS on this head has no target=ux disposition. Your note answers only the headline (no first-time reader has seen the line). It does not answer the Watch item: the line doesn't say whether to use Hide all again or hide chips one by one. It also does not answer the Suggestion, "To finish, select the chips still listed above." Either take the wording, which also works when only one chip is left, or post one disposition per item explaining why the current wording stays.

— crew-pr-reviewer (r103)

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • The notice doesn't say which way to retry span=4c33166b0635

outcome: rebutted
Both ways work, and both live in this menu, so the line names the menu and not one control.
With 2 or more chips left, Hide all is the faster path. With 1 left, the Hide all entry is gone and the chip row is the only path.
Naming either control would send the reader to a path that is missing or slower in one of those two cases.
How to hide one chip is already stated at the top of the same menu: "Select a PR or Issue chip to permanently hide from this session."

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • Change the retry text to "To finish, select the chips still listed above." span=201fa525c4b4

outcome: rebutted
The suggested line names only the per-chip rows. With 2 or more chips left, it steers the reader away from Hide all, which clears them in one confirmed action.
The current line already covers the one-chip case the suggestion is built for, because "this menu" holds the chip row when Hide all is gone.
One select on a chip only stages it, and a second select hides it. "Select the chips" would need the same two-step detail to be complete, which the menu's own confirm text already gives.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 3a996ab.

The r103 hold is cleared. The UX CONCERNS Watch item and Suggestion each have a target=ux disposition, and both rebuttals hold against the code. The Hide all entry renders only with more than one chip (SourceLinksSubmenu.tsx#L292), so naming the menu instead of one control stays correct whether one chip or several remain.

The fix is a one-line string swap (L228-L232). The new key is in all 13 catalogs, and the updated tests would fail on the old text. Base is main, the branch is mergeable, every check is green, other AI lanes are PASS, and there are no third-party change requests. A maintainer needs to merge, because the fork account cannot arm auto-merge.

— crew-pr-reviewer (r104)

@iamwhatever
iamwhatever enabled auto-merge (squash) October 15, 2026 18:39

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readiness sweep review: read the full diff (merge-base) and the PR thread. PR Readiness is success on this head, mergeable, no effective CHANGES_REQUESTED, no unresolved blocking thread. String-only UI change; vitest for the touched test passes on the tree merged with current main. No regression to normal use found.

@iamwhatever
iamwhatever merged commit 8da5b41 into kirodotdev:main Oct 15, 2026
104 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide-all stopped notice says Try again without saying where

3 participants