Repository navigation
fix(context): leave a hard-linked steering file out instead of refusing - #20628
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the Windows reparse-point path in [DESIGN-REVIEWED] 90d5dc2 Description read[DESCRIPTION-READ] 60a30db357a2cd3e38d0d59801f2c28e948337e0e11ed2a2e3402409b5bf0f0c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that kiro-cli itself loads the hard-linked steering on Windows. If it doesn't, the member starts without that vendor steering, and only a note and a warning say so. What this change shipsInventory (6 items) — 6 justifiedIntent: let a crew member whose installer hard-links its steering files start its sessions instead of being refused every time. FIX.
[FIRST-PRINCIPLES-REVIEWED] 90d5dc2 Description read[DESCRIPTION-READ] 071ea71ba0627f06714b499caef9a9f09044af3f84e27cf0d10b5d698f9f3eea That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
b02dba5 to
37689af
Compare
37689af to
b0dbfa7
Compare
|
|
|
|
b0dbfa7 to
6c381ba
Compare
|
Backend Tests (Windows) shard 6 fails on test_workflow_matrix_max_parallel[codeql.yml-analyze-], which also fails on a clean origin/main (5be771f): #20577 added codeql.yml after #20482's max-parallel rule. Tracked in #20698, fixed by #20699. This PR waits for that fix, then rebases. The AI review lanes on this head failed on the shared installation token's rate limit and will be re-run after the hourly reset. |
|
HOLD at 6c381ba. The fix itself is small and keeps the no-follow refusal: a hard-linked steering file is left out and named instead of stopping the member. The new tests cover the reported shape. To clear the hold:
— crew-pr-reviewer (r103) |
1c13362 to
0dca4a9
Compare
|
|
0dca4a9 to
97eadb7
Compare
|
|
97eadb7 to
f036c57
Compare
|
|
|
|
A steering document that passes the path screen and containment but that the no-follow descriptor read refuses (a hard link an installer placed, a non-link reparse point) is left out unread and named in one essential-context#unreadable-skipped note, so the member starts. The read is unchanged and any other declared source it refuses still refuses. Closes #20624
f036c57 to
90d5dc2
Compare
|
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved by a maintainer after reading the review lanes: every lane is clean on this head, and the automated triage held it only on a size, path, category or doc rule.
Problem / Motivation
Goal: A crew member starts even when one of its steering files is a hard link, instead of failing every session start.
A member whose package-installed template declares
file://.kiro/steering/**/*.mdfails at every session and subagent start withEssential source ...\.kiro\steering\<file>.md: missing, unreadable, or outside the admitted document root. The package manager places its steering by hard link and re-syncs it, so a manual fix comes undone within an hour. Reproduced on Windows with an isolatedKIROCREW_HOME: one steering file withst_nlink == 2refuses the whole start; a regular file beside it reads fine.Why it matters
A member with this template cannot be used at all: every chat, subagent and cron turn it serves is refused before the model is called, and the user has no setting that fixes it.
Not a goal
st_nlink > 1refusal insafe_read_file_bytes_nolinkstays as it is.What changed (motivation → approach → change)
The message comes from
member_essential_context._read()after the path screen and containment both pass: the no-follow descriptor read returned nothing because the inode has a second name. Symbolic links in the same steering trees are already left out and named (#17632, #19393); a hard link had no such path, so one file stopped the member.In
src/kiro_crew/member_essential_context.py,_read()raises a dedicated_UnreadableEssentialSourceErrorfor exactly that case. A steering document (the implicit global or project steering scan, or a declared match with asteeringpath component, the same test main already uses for itsinclusionfrontmatter) refused this way is left out: the essentials snapshot names it in oneessential-context#unreadable-skipped:<template>note (one label per template, so an owner and an execution template merge cleanly), and the KAS document reader andkiro_launch_documentsskip it with a warning. The file is never opened through its second name. The spec indocs/system-specs/modules/memory-skills-hooks.mdstates the rule.Backwards compatibility
Compatible: a start that succeeds today is unchanged; a start that was refused for a hard-linked steering file now succeeds without that file.
Removes nothing: no refusal of a read is lifted, no key or path is removed; only the consequence of one refusal for steering documents changes.
Tests
Six tests in
test/test_member_essential_context.py:kiro_launch_documents;Five fail on the parent commit (four with the reported message, the note test because the helper is new); the non-steering refusal test passes on both, as it must. All six pass on this head. Determinism: the six ran 10 times in a row (10/10 green) and once in a shuffled order, green. They use
os.linkonly, no timing or ordering.Manual verification
On Windows with an isolated
KIROCREW_HOME, a named workspace and the reported template shape,documents_for_memberrefused on the parent commit and returns the snapshot with the note on this head. Not run against a live gateway member chat.Related Issues
Closes #20624
Refs #18722
Pattern harvest
Not generalizable: the essentials reader already turns each per-file refusal class it can name (link, missing, managed prefix) into a named skip for steering; this adds the last class the descriptor read can return, rather than a new pattern.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)