Skip to content

feat(sidebar): broadcast one message to many sessions - #20741

Merged
buluoray merged 1 commit into
mainfrom
feat/broadcast-sessions
Oct 16, 2026
Merged

buluoray merged 1 commit into
mainfrom
feat/broadcast-sessions

Conversation

@buluoray

@buluoray buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a user send one message to many open sessions at once, picking them by state, with crewmate chats left out by default.

With many sessions open there is no way to tell them all something. When CI goes down for half an hour, every babysit loop should pause, and today that means opening each session and typing the same line again.

Why it matters

People running many loops and long tasks need one place to steer them together. Without it, a shared instruction costs one visit per session, and a session that gets missed keeps working on stale assumptions.

Not a goal

  • Queueing the message behind a running turn. Every send is a steer.
  • Scheduling a broadcast for later, or repeating it.
  • Reaching sessions on a connected peer crew.
  • Changing the agent-side session_broadcast tool.

What changed (motivation → approach → change)

The Sessions list menu (⋮) gets Broadcast message…, beside Switch all to model…, and opens a panel in the same slot those panels use.

The panel picks recipients with quick picks that show live counts: in a loop, in progress, approval or reply, all. The panel opens on the first of them that reaches anyone, so it never opens on an empty list. A three-way control sets crewmate chats to only, include or exclude, defaulting to exclude. A folded Custom criteria section lists the states as toggle chips, matched as any-of, and narrows by folder with its sub-folders, tag, pinned, or activity in the last 24 hours. A session that cannot take a message is never matched or counted: a peer crew's row, and a relay archive, which the server refuses with relay_archive_read_only. Any matched session can be unticked, and a tick keeps meaning "in this broadcast" after a send; under a Session / How it lands header (Session / Result once the list has been sent to), each row names its folder (or, without one, its last activity) on a second line under its title and says how the message will land: joining the running turn, joining after the user answers the approval or question that turn waits on, waiting behind live sub-agents or queued messages, or starting a new turn; a line above the list says no running work is interrupted.

Every message goes through the existing /api/chat send. A session's own running turn gets it as a steer, taken in after the current tool call. Any other session gets a plain send, so the server's hold behind live sub-agents and parked queue messages still applies. Only an explicit refusal can be retried; a late, unreadable or dropped-connection receipt may already have delivered, so that session is never resent. A refused session moves to the top of the list with the server's reason inline under it; an unconfirmed one follows it, and its label opens that session. After a send the button reads "Retry N failed". The right column takes at most 45% of a row and wraps, so a narrow pane keeps titles readable. The panel itself scrolls inside the sidebar, so Send stays reachable on a phone. Cancel and the text box are locked while a batch is sending. After a send, the count line becomes the outcome tally (sent, failed, unconfirmed) of the rows still listed. When nothing is left failed or unknown, the panel stays open on a confirmation ("Sent to N sessions") and Cancel becomes Close.

Matching lives in a pure helper, lib/broadcastTargets.ts, which uses the existing collectFolderSubtreeIds for folder narrowing. Its turn states are the board lanes from inferLane (needs approval, waiting, working, idle), fed by laneExtrasFor, lifted out of the board's column matcher so both read the same live signals; the state labels reuse the lane labels. Crewmate chats are recognised with the existing isCrewmateChat; Slot and AgentInfo gain the agent_kind and selection_kind fields already on the wire. Strings are added to all twelve catalogs under website/src/i18n/locales/ (en-XA.json regenerated).

Backwards compatibility

Compatible: a new menu item and panel; no existing route, setting or behaviour changes.

Removes nothing: the diff only adds a menu item, a panel, a helper and catalog keys.

Tests

  • website/src/lib/broadcastTargets.test.ts (24): every row's state equals its inferLane lane, an approval-blocked turn is needs-approval not working, loop as a mode on top of the lane, sub-agent approvals and workflows classed as the board classes them, relay archives never matched, each delivery label (steer, after the answer, after current work, new), steer sent only into a session's own running turn, each quick pick, the three crewmate modes, custom criteria (no state matches nothing, sub-folders included, tag/pin/24h), peer rows never targeted, a kind-less crewmate recognised through the caller's test, and steer-vs-new labelling.
  • website/src/pages/chat-sidebar/BroadcastPanel.test.tsx (27): the panel shrinking and scrolling inside the sidebar, the retry label after a refusal, the capped right column, the no-interruption line shown only before a send, opening on the first non-empty pick, the tally counting only rows still listed after the pick changes, the right column header switching to Result, an unconfirmed row moving up and opening its session, defaults (loop pick, crewmates excluded, a kind-less crewmate excluded), row labels, the include toggle, Send disabled on blank text, the trimmed text steered only to ticked rows, a refusal keeping the panel open with its reason on hover while a dropped-connection row is not resent and only the refused row is retried, Cancel and the text locked while sending, edited text reaching every matched row again, a refused row moving to the top, the confirmation counting every row reached across a retry, a custom state switching the pick to Custom, every quick pick re-seeding the state chips, a workflow session labelled as joining its turn, unconfirmed rows still named after a retry, the tally replacing the match count after a send, an idle session sent without the steer flag, an approval-parked turn labelled as joining after the answer, folder or last activity on same-named rows, and delivered rows staying ticked and locked.
  • Mutation checks: restoring the old receipt mapping, re-enabling Cancel while sending, removing the reset on edit, dropping the preset re-seed, hiding the inline reason, dropping the failed-first order, counting only the last press, bypassing laneExtrasFor, judging only the last press for the summary, matching relay archives, always steering, dropping the after-answer label, the tally, the last-activity text, unticking delivered rows, a fixed default pick, a tally over every result, a fixed column header, dropping the open link and dropping the unconfirmed-row order each turn one named test red.
  • website/src/store/switchSlotCallsiteClassification.test.ts: the new switchSlot site in ChatSidebar.tsx (opening an unconfirmed row) is classified as announced, like a row's own click.
  • website/src/test/ChatSidebar.chevronGrammar.test.ts: the disclosure count goes from 7 to 8 for the custom-criteria toggle, which uses DisclosureChevron.
  • Determinism: both new files passed 10 runs with --sequence.shuffle and seeds 1 to 10. No timers, sleeps or clock reads in either.

Ran locally: every step of CI's Frontend Lint & Type Check job (tsc -p tsconfig.app.json, eslint src/ --max-warnings 0, jscpd, the ui-index freshness check, the phantom-class and restyle ratchets), npm run i18n:check and the related vitest set with I18N_BASE_REF=origin/main (so the per-language style checks run as in CI), npm run lint:i18n, the 1486 sidebar/board/lane/i18n-related vitest files (32462 tests), npm run build, scripts/check_feature_map.py and scripts/docs-lint.sh. Not run locally: semgrep (not installed on this host).

Manual verification

In a pod built from this branch: opened the menu, filled the message, expanded Custom criteria and picked All, on desktop (1300px) and mobile (390px), dark theme, zh-CN. Shot the matched list, custom criteria, sending, a send with one refusal and one dropped connection, and the retry. The send outcomes came from Playwright request routing, so no session in the pod actually received the message. An earlier pass showed the crewmate control overflowing the panel and the selects in a larger font; both are fixed.

Screenshots / video

In a pod, dark theme, zh-CN, current build. The pod has no agent backend, so no session there can be running, parked on an approval or holding sub-agents: every row shows the idle label. The other three labels are covered by unit tests. Send outcomes came from Playwright request routing.

All picked: the no-interruption line above the list, crewmate hint

After a send with one refusal and one dropped connection: Result header, Retry 1 failed

Narrow (360px) viewport: titles stay readable next to the right column

As it opens: no loops, so it lands on the first pick with matches

All picked: each row's delivery, last activity on a second line

After a send: Result header, refused row first with its reason, the unconfirmed row next with its open link

A new message sent to every row: the full-success confirmation

Earlier shots: custom criteria, sending, menu entry

Custom criteria expanded

Sending: every row Sending, Close and Send locked

Desktop: Sessions menu

Related Issues

Closes #20706

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 15, 2026 08:09
@buluoray
buluoray requested a review from cruisercohen October 15, 2026 08:09
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cacf3cf9182dc3536ebf867a91b6116595d13cc3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that leaving the page during a send doesn't silently drop the rest: the browser sends four at a time, and leaving stops the sends still waiting.

[DESIGN-REVIEWED] cacf3cf

Description read

[DESCRIPTION-READ] 8bc782c81727cd19a0aadb98f28088dfda2ff8e688912c47120e1d0af65d300e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of cacf3cf9182dc3536ebf867a91b6116595d13cc3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The Custom criteria section adds four narrowing filters (folder, tag, pinned, 24h) that the Goal ("picking them by state") never asks for.

Not justified as shipped

  • Item 4 — oversized: the Goal is "send one message to many open sessions at once, picking them by state", but the diff adds folderId, tagId, pinnedOnly and activeWithinMs to BroadcastCriteria, plus their controls in BroadcastPanel.tsx. The per-row untick (item 5) already lets a user cut any subset by hand. Each filter has exactly one consumer: this panel.
    Subtraction: delete the four BroadcastCriteria fields, their branches in matchesBroadcast, and the folder/tag/pinned/24h controls with their catalog keys. Keep the state chips.
    Clears when: the mechanism is removed, or a human amends the Goal.
  • Item 3 — oversized: the Goal asks only that crewmate chats be "left out by default". An include/exclude toggle does that. The third mode, 'only', is not in the Goal and nothing in the description says who needs it.
    Subtraction: drop 'only' from CrewmateMode and CREW_MODES, and delete its catalog key.
    Clears when: the mode is removed, or a human amends the Goal.

What this change ships

Inventory (10 items) — 8 justified

Intent: let a user steer many sessions with one message instead of visiting each one. This is an ADDITION.

  1. Sessions ⋮ menu gains "Broadcast message…" — justified
  2. Quick picks (loop, working, waiting, all) with live counts; the panel opens on the first pick that reaches anyone — justified
  3. Crewmate control with only/include/exclude, defaulting to exclude — oversized
  4. Custom criteria: state chips plus folder, tag, pinned and 24h filters — oversized
  5. Matched rows can be unticked; each row says how the message will land — justified
  6. A running turn gets the message as a steer; any other session gets a plain send — justified
  7. Refused rows can be retried; unconfirmed rows are never resent and link to their session; refused and unconfirmed rows move to the top — justified
  8. Peer rows and relay archives are never matched or counted — justified
  9. laneExtrasFor moved out of the board's column matcher and shared by the board and the panel — justified
  10. Slot.agent_kind and AgentInfo.selection_kind typed (already on the wire, read by isCrewmateChat) — justified

[FIRST-PRINCIPLES-REVIEWED] cacf3cf

Description read

[DESCRIPTION-READ] f8840cfa9b4d8eaa6a5c972de72c7c5b947b94d35b0abe531267b739345916a5

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of cacf3cf9182dc3536ebf867a91b6116595d13cc3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The failed-send path sends people in two directions: the notice says to press send again, the button says "Retry N failed", and it retries sessions that are already closed.

Watch

  • Retry is offered for refusals that can't succeed. In shot-02 the failed row says "会话已关闭" (session closed). The primary button still reads "重试 1 个失败的" (retry the 1 failed), so retrying can't help. The blind reader said: "the failed chat is 'closed', so retrying looks pointless." This happens on every partial failure. Fix: only count refusals that can be retried in the button, and say plainly that closed sessions won't take the message.
  • The failure notice names the wrong control. broadcast_failed_some says "Send again to retry", but the button says "Retry {{n}} failed". The reader noticed: "The red box says 'press send', but this button says 'retry'." Fix: change the notice to "…Press Retry to resend."
  • "Include" doesn't say what it includes. In the crewmate switch "Only / Include / Exclude", the reader said "'包含' (include) alone doesn't say what is included… it confuses me." This control sets who receives the message, so a misread can reach agents the user meant to leave out. Fix: rename to "Include crewmates" / "Exclude crewmates" / "Only crewmates".
  • Rows jump on their own. After a send, failed and unconfirmed rows move to the top with no animation. A user who was tracking a row loses it while reading the results. Fix: animate the reorder with layout, or keep rows in place and pin a short failed summary above the list.

Suggestions

  • broadcast_sent_all (zh "已发送到") and the tally's "已送达" read as two different outcomes to the reader. Use one word for both.
  • Shots 4–9 come from earlier revisions: the reader saw "需要我处理" and "等我回复" in the pill that now reads "待审批或回应", and saw the button as "发送到 1个" instead of "Retry". Re-take the custom-criteria, sending and success shots on HEAD.

[UX-REVIEWED] cacf3cf

Description read

[DESCRIPTION-READ] 94c3587829d1b689f1294c5fedadfcfab68262cf492cbbadc724dc60de563d8c

That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cacf3cf9182dc3536ebf867a91b6116595d13cc3 — this comment is updated in place on each push.

Review details

Not blocking: one advisory finding on the Send button's label.

FINDING — website/src/pages/chat-sidebar/BroadcastPanel.tsx:418 — once any shown row has a result, the button reads broadcast_retry ("Retry {{n}} failed") with n: chosen.length, and chosen also counts rows that were never sent. Two ways to hit it: send to "Looping task" and then pick "All", or re-tick a row that was unticked before the send. Either way the button says "Retry N failed" when nothing failed, and pressing it does a first-time send → Fix: use the retry label only when every key in chosen has results[key] === 'failed'; otherwise use broadcast_send.

[OPUS-REVIEWED] cacf3cf

Verdict parsed from the review's SHA-scoped output markers for commit cacf3cf9182dc3536ebf867a91b6116595d13cc3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cacf3cf9182dc3536ebf867a91b6116595d13cc3: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cacf3cf9182dc3536ebf867a91b6116595d13cc3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cacf3cf

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cacf3cf9182dc3536ebf867a91b6116595d13cc3: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray force-pushed the feat/broadcast-sessions branch from e8b267d to 1180ce2 Compare October 15, 2026 10:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026
@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=e7f8f9049426 — Item 3 — duplicate of inferLane

fixed in 1180ce2: slotBroadcastStates now returns the lane from inferLane, fed by laneExtrasFor, which is lifted out of the board's column matcher (pages/chat-sidebar/board.ts) so the board and the panel read the same sub-agent, workflow and goal-loop signals.
An approval-blocked turn is now Needs approval, not Running. Pinned by broadcastTargets.test.ts "uses the board lane for every row" and "reads the live signals outside the slot payload".

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=77cd98e943cd — Item 4 — folder/tag/pinned/24h narrowing beyond the Goal

needs-a-decision: the owner asked for these narrowers explicitly when the design was picked (quick picks plus the custom criteria from mock B), so removing them would drop a requested feature.
The Goal line is frozen and only a human may amend it; @buluoray, please either amend the Goal to "picking them by state, folder, tag, pin or recent activity", or record an override for first-principles on the current head.

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=2565581c21ec — No sign that a broadcast went out

fixed in 1180ce2: a full success no longer closes the panel. It stays open on a status line ("Sent to N sessions."), every row reads Sent, and Cancel becomes Close.
Pinned by BroadcastPanel.test.tsx "steers the trimmed text into every ticked target and confirms on success"; shot in the PR body.

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=51c98340b5a8 — The default selection looks contradictory

fixed in 1180ce2: the custom state chips are seeded from the default quick pick (only In a loop) and re-seeded by every pick, so they always show what the highlighted pick means.
Pinned by "switches to Custom when a custom state is picked" and "re-seeds the custom state chips from every quick pick".

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=65a6f202d74a — Rows can't be told apart

fixed in 1180ce2: each row shows its folder name after the title, muted and truncated before the title is.

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=c9c17ef25fd4 — The "New message" row label reads as noise

fixed in 1180ce2: the pair is now "Joins running turn" / "Starts new turn" (zh-CN "插入当前轮" / "开始新一轮"), across all twelve catalogs.

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=068d262bb2e1 — "Crewmates" and the overlapping chips are unclear

fixed in 1180ce2: a helper line under the label reads "Chats run by your crewmates". The state chips now reuse the board's lane labels (Needs approval, Waiting on you, Working, Idle), and Running means the board's Working lane.

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=635381aeffee — Refusal explanations are available only on hover

fixed in 1180ce2: each refused row renders its server reason in an inline ErrorNotice under the row, with a recorded no-hand-off decision because the broadcast text is unsaved; the refused row also moves to the top of the list.
Pinned by "stays open on a refusal ..." (reason inline) and "moves a refused row to the top of the list".

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=635381aeffee — Custom states exceed the two-button row limit

rebutted: the state chips are one wrapping multi-select filter group, and the repository owner has ruled against applying max-two-buttons-per-row to it; the chips stay.
Per the owner's instruction, a gpt-lane override is recorded on the new head once the lane has reviewed it, scoped to this rule only.

@buluoray

Copy link
Copy Markdown
Contributor Author
  • steer to a "waiting on me" session, and to a harness without steer

answered: /api/chat with steer: true on a running turn calls steer_into_running_turn; when steer is unavailable (no live client, a backend without steer, an RPC error) the send falls through to the slot queue, so nothing is dropped and the receipt still reads accepted.
On a turn parked on an approval or a question card the steer is accepted and taken in when that tool call ends, i.e. after the user answers it; unlike the composer, the panel does not retire the card, so a broadcast never answers a question on the user's behalf. An idle session gets a new turn. Each is an accepted receipt, so the row reads Sent.

@buluoray

Copy link
Copy Markdown
Contributor Author

UX Review on e8b267d4fa could not evaluate the send states. They are shot on 1180ce2176 in the PR body: a session with a real running turn labelled "Joins running turn", the sending state, a partial failure (one request refused through Playwright routing) with its reason inline and the row moved to the top, and the retry ending on the confirmation.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray force-pushed the feat/broadcast-sessions branch from 1180ce2 to a792e22 Compare October 15, 2026 11:20
@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=c50ae525cb5c — Item 6 — duplicate of collectFolderSubtreeIds

fixed in a792e22: folderSubtree is deleted; folder narrowing calls collectFolderSubtreeIds(ctx.folders, criteria.folderId) from utils/folderTree.ts, and the context carries ChatFolder[].

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=c16b2724d86e — Second subtree walker

fixed in a792e22: same change as Item 6 — the second walker is gone and the match uses collectFolderSubtreeIds. Pinned by broadcastTargets.test.ts "includes sub-folders of the picked folder".

@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=a8b1d8a5f015 Starts new turn reads like a control

fixed in df0dc78: the label is plain muted text, now capped and wrapping; the line above the list explains each label, and only an unconfirmed row ever shows a button there. Shot c1 shows it.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

buluoray commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=f23876d4e9d1 Vocabulary collision for the waiting pick

fixed in df0dc78: the quick pick now names both lanes it covers, "Approval or reply" (待审批或回应), so it reads as the two chips 待审批 and 等你回应 together. "Custom" (自定义) stays: it is the common word for a user-defined pick across the app (e.g. 自定义回答 in question cards), and here it sits beside the quick picks it replaces.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=46b60d86d669 Retry button Send to 1 is ambiguous

fixed in df0dc78: after a send the button reads "Retry N failed" (重试 N 个失败的). Test "names the retry after a refusal" pins it.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=382c1f29e5fa say what a crewmate is

fixed in df0dc78: the hint reads "Chats run by your crewmates, the AI agents in your crew" (由 AI 队友(crew 里的 agent)运行的会话).
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=f00d7437ee5d the crewmate only mode

rebutted: the owner chose the three-way control (only / include / exclude) when approving the mock; "only" is the way to address just the crewmates, which an include toggle cannot do.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=99b1b56f381f SEND_CONCURRENCY = 4 vs the server's sequential sends

rebutted: the client case differs. Each sendTurn waits up to SEND_ABORT_MS (10s) for a receipt, so one slow or dropped session would stall every row behind it in a sequential loop; the server loop has no such per-call deadline. Four in flight bounds that stall without opening N POSTs at once.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@buluoray

Copy link
Copy Markdown
Contributor Author
  • Design punchline: closing the panel or tab mid-batch

answered: Close is disabled while sending, so the panel cannot be closed mid-batch; closing the tab leaves whatever was already sent, and each recipient session shows the message in its own transcript.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray force-pushed the feat/broadcast-sessions branch from df0dc78 to d0511ac Compare October 15, 2026 20:40
@buluoray

Copy link
Copy Markdown
Contributor Author

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: Rebased onto main c6d6106, which carries #20930 (the lazy-import count fix behind the inherited Backend Tests (3.12, 6) / Windows (6) / Coverage Gate reds). df0dc78 -> d0511ac; range-diff shows no change to this PR's own lines. tsc, eslint, i18n:check, feature-map check and 57 related test files pass. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray force-pushed the feat/broadcast-sessions branch from d0511ac to cacf3cf Compare October 15, 2026 22:42
@buluoray

Copy link
Copy Markdown
Contributor Author
  • span=635381aeffee Expanded broadcast panel clips its actions on phones

fixed in cacf3cf: the panel root carries min-h-0 overflow-y-auto, so it shrinks inside the sidebar's flex column and scrolls, keeping Send and Cancel reachable. Test "lets the panel shrink and scroll inside the sidebar" goes red without them.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray enabled auto-merge (squash) October 15, 2026 23:35
@buluoray
buluoray merged commit df7d7ce into main Oct 16, 2026
103 checks passed
@buluoray
buluoray deleted the feat/broadcast-sessions branch October 16, 2026 01:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broadcast one message to many sessions from the Sessions menu

2 participants