Repository navigation
docs(cron): document startup quarantine recovery - #20751
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The change only touches documentation and a comment, it changes no behaviour, removes nothing and adds no user-visible surface. [DESIGN-REVIEWED] 5c2085e Description read[DESCRIPTION-READ] 0085570a429d7d8f7b3f3f90cdc2968296fb7d8d46036c5fb1bb4210316164b3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this changes docs and comments only, it closes #17008, and every item describes recovery behaviour that already exists. What this change shipsInventory (4 items) — 4 justifiedIntent: let an operator see when gateway startup sets aside an unreadable cron store, where the copy goes, and how to restore it safely. FIX (documentation gap, #17008).
[FIRST-PRINCIPLES-REVIEWED] 5c2085e Description read[DESCRIPTION-READ] 09e26408c1272c6ba7317691028a97fa83cb84dd6ac95d962b8012a047b7a8a1 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
4826593 to
fc4ce9f
Compare
fc4ce9f to
a71e52d
Compare
|
Status note: the diff is docs/comment only and every completed check is green. GPT 6.1 Review computed a verdict for a71e52d but could not publish it ("API rate limit exceeded for installation", run 38722064694; the verdict is kept in that run's withheld-verdict artifact). The same lane reported no findings on 4826593, which has the identical diff (range-diff equal). Opus, Design and First Principles: no findings / PASS. Handing over: rerun that job in a quiet API window (rebasing first if main moved), then maintainer review. No auto-merge armed. |
|
Rebased onto main 88914fd to clear the merge conflict (main rewrote the CronService paragraph; kept main's text and re-added only the third-reader clause). Re-checked every doc claim against the moved code (cron_service/service/, gateway_runtime/cron_fire.py). Local Opus review found two wording gaps in this diff, both fixed: the spec now credits only doctor with the "replaces tasks added since" warning, and the cron.py comment no longer says "exact copies". CI re-running. |
a71e52d to
9e3d891
Compare
|
9e3d891 to
5c2085e
Compare
|
Review-ready on head 5c2085e (one commit on main 5f803ab, which includes red-main fix #22178).
Needs one maintainer approval. No auto-merge armed. |
bolichen97
left a comment
There was a problem hiding this comment.
Approving on 5c2085e. Spec text and one code comment only: when startup quarantines crons.json, where the copy goes, and the restore order. No behaviour change.
Problem / Motivation
Goal: Make cron quarantine recovery clear before an operator needs it.
The cron specification and the code comment do not fully say when startup moves an unreadable
crons.json, where it goes, or how to restore it safely.Why it matters
An operator needs the exact saved path and restore order to recover scheduled tasks without losing the quarantined bytes or overwriting tasks added later.
Not a goal
What changed (motivation → approach → change)
An operator can read in the cron specification exactly when startup sets
crons.jsonaside, where the copy goes, and how to put it back.Quarantine runs only at gateway startup, when the JSON cannot be decoded or is not an object holding a
jobslist; an object with nojobskey loads as an empty store. It renames the unchanged file intocron-history/quarantine, behind the file-tool fence and the sandbox mask. The dashboard notice and doctor name the copy and the restore order: repair it, runkirocrew stop, move it back, start again. Doctor warns that restoring replaces tasks added since.The comment above
cron_store_quarantine_copiesincron.pysays the same, and both places name the two doctor store readers the facade test pins.Backwards compatibility
Compatible: this changes documentation and comments only; runtime behavior and stored data are unchanged.
Removes nothing: no code path, data, key, or public function is removed.
Tests
No test is added or changed. Focused checks on the rebased head:
test/test_cron_store_quarantine.py,test/test_cron_load_malformed_entry.py,test/test_cli_doctor_refactor_facade.py,test/test_cron_refactor_contract.py,test/test_cron_service_bindings.py: 714 passed.scripts/docs_lint.py --test,scripts/docs-lint.sh,check_comment_history.py,check_brand_name.py,check_feature_map.py: passed.flake8,isort,black,mypyonsrc/kiro_crew/cron.py, andgit diff --check: passed.Manual verification
N/A — the focused tests and documentation checks cover this comment-only and specification-only change.
Screenshots / video
N/A — no user interface changes.
Related Issues
Closes #17008
Pattern harvest
Not generalizable: this fills one deferred documentation gap for an existing recovery path and does not change product behavior.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of
CONTRIBUTING.md.