Repository navigation
fix(members): say which crewmate to recreate on a short-name collision - #20766
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Run the delete-the-non-owner remedy end to end once: delete “{{self}}”, recreate it, and confirm both crewmates open their own chats. So far that path has only been traced through the code, not run. [DESIGN-REVIEWED] 7465092 Description read[DESCRIPTION-READ] c71950d266e6cdf28d2028abb552dbd8d53520eba1c2e116b7332ed24915bbe6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The chat notice tells users to delete a crewmate without saying what they lose, and the blind reader said they would not follow it. Watch
Suggestions
[UX-REVIEWED] 7465092 Description read[DESCRIPTION-READ] 23f73e531c9902ffa74d990515a02bd08e13771cd8a3a61aa2d5120053102008 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The delete-the-non-owner remedy that every notice now prescribes was traced through the code but "not run end to end". Confirm it before merge. What this change shipsInventory (9 items) — 9 justifiedIntent: when two crewmates share a short name, tell the user the remedy that actually clears the collision. This is a FIX (#12521).
[FIRST-PRINCIPLES-REVIEWED] 7465092 Description read[DESCRIPTION-READ] a9355920bbbe789cf54400f39178a259a084d16b7d5e86d6e8b7512ab3ad1527 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
8223a03 to
4403ff4
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
4c9ba89 to
9684874
Compare
|
Update on the UX naming question: #20342 merged, so the overlap is gone and no override is needed for it. 9684874 passes the open crewmate's header label as {{self}} from website/src/pages/members/MembersPageThread.tsx, and slug_collision now reads (en): "…Renaming keeps the short name, so delete “{{self}}” and create it again under a name with a different short name. Keep “{{name}}”." in all 12 locales. Rebased onto current main; CI re-running. |
9684874 to
fbb2ead
Compare
fbb2ead to
7465092
Compare
|
Rebased: the shard-6 red on fbb2ead (test_dashboard_server_composition_contract.py::test_the_lazy_imports_stay_inside_the_functions_that_need_them, 84 == 83) is main's: #19700 added a lazy import and #20930 moved the pin to 84. This head (7465092) includes #20930; the test passes locally. CI re-running. |
chenmingwei23
left a comment
There was a problem hiding this comment.
Approving: readiness: passed, all lanes green, no outstanding change requests.
Problem / Motivation
Goal: When two crewmates share a short name, the Members page tells the user the fix that actually works, and a test keeps shipped routing guidance on
spawn_run(crew=...).The Members page shows two notices when two crewmates fold to the same short name:
slug_collisionon the chat andnotes_collisionon the Notes tab. Both say "Rename one of the two crewmates". A rename changes only the name a crewmate shows. Its short name stays, so the collision stays.Issue #12521 also named
src/kiro_crew/config/prompt-orchestrator.md, which told the orchestrator to route withspawn_run(agent=...). That file left main with #15362. No shipped copy on main saysspawn_run(agent=next toselect_crew/route_crewtoday, and nothing guards against one coming back.Why it matters
A user who follows the notice renames a crewmate, sees the same notice again, and has no next step. A routing copy that says
agent=sends a crewmate's work into the caller's memory store, and nothing fails when one drifts in.Not a goal
src/kiro_crew/agent_panel.py,src/kiro_crew/dashboard/handlers/agent_panel.py). They are a separate surface.select_crew/route_crew(refactor: retire crew triggers, session_color, route_crew, select_crew #19274 owns that).What changed (motivation → approach → change)
The two notices offered a rename, but a rename keeps the short name, so the collision never clears. Deleting either crewmate is not safe either: the chat stays bound to the crewmate that opened it first, which is the one
slug_collisionnames. Delete that one and the other is refused withmember_pin_mismatch.Both notices now say a rename keeps the short name and which crewmate to delete.
slug_collisionnames both: "delete “{{self}}” and create it again under a name with a different short name. Keep “{{name}}”."{{self}}is the crewmate whose chat shows the notice, passed fromMembersPageThread.tsxwith the samecrewDisplayNamelabel the header pill shows;{{name}}is the crewmate that owns the thread.notes_collisioncannot know the owner (its 409 does not carry one), so it says to delete the one whose chat shows a short-name notice. All 12 translated catalogs carry the same meaning, each quoting names with its own style guide's marks, anden-XAis regenerated withnpm run i18n:pseudo. The matching row insrc/kiro_crew/docs/crew-members.md, a comment inCrewNotesTab.tsx, and two warning logs insrc/kiro_crew/dashboard/handlers/members.pysay the same thing.test/test_crewmate_guidance_copies.pyfails if either notice offers "Rename one" or "delete one", ifslug_collisionstops naming who to delete and who to keep, or if the Crew Members page stops giving the remedy the notices are pinned to. TheMembersPage.test.tsxcollision test checks the rendered notice names both crewmates. The existingtest_no_guidance_still_tells_the_model_to_use_agent_for_a_crewintest/test_crew_routing_and_delegation.pyreads packaged markdown too, and fails if a file that namesselect_creworroute_crewsaysspawn_run(agent=.Backwards compatibility
Compatible: copy, one doc row, one comment, one extra interpolation value and tests. No key is renamed;
{{name}}is kept in every locale and{{self}}is added toslug_collisionin every locale.Removes nothing: no key, route, field or behaviour is removed.
Tests
test/test_crewmate_guidance_copies.py::test_collision_notices_offer_the_remedy_the_page_states: both en notices say a rename keeps the short name and name the crewmate to delete. Red on the parenten.json(offers a rename) and on each earlier wording of this PR ("delete one", "delete this crewmate", the unquoted "not {{name}}"); green on this head.website/src/pages/members/MembersPage.test.tsx"surfaces a slug collision…": asserts the notice says delete “oncall” and keep “Oncall”. Red without theMembersPageThread.tsxchange, green with it.test/test_crew_routing_and_delegation.py::test_no_guidance_still_tells_the_model_to_use_agent_for_a_crew: extended to packaged markdown; red whenspawn_run(agent="<name>")is appended togoal-conductor/SKILL.md, green on this head.-n 4.src/i18n/**test including the per-localestyle/*Style.test.tsplussrc/pages/members/**(83 files, 1792 passed).i18n:check,i18n:render,check-i18n-keys,lint:i18n,tsc, eslint, flake8, isort, black, docs-lint, the comment-history gate, the flake-pattern ratchet and semgrep all pass.members.pykeeps its line count.Manual verification
Rendered the real
MembersPagethroughwebsite/capture/members-empty-placeholder.html, with the thread POST answered by a different member (the collision branch), and the realCrewNotesTabwith a 409 briefing read, both in en and de. The "Could not load teams" line above the notice comes from the gateway-free harness and is not part of this change. The delete-the-non-owner path was traced throughmembers.py(binding owner selection, binding refusal) andcrew_removal.py; it was not run end to end.Screenshots / video
After (en):
After (de, the longest rendering):
Notes tab in the collision state (the real
CrewNotesTabwith the briefing read answering 409briefing_slug_ambiguous), en:de:
Related Issues
Closes #12521
Pattern harvest
Rule candidate: review-prompt
Pattern: a user-facing remedy names an action the product cannot perform, or one that only works for one of the two subjects; check every "rename/delete/retry" instruction against the code path it relies on.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)