Skip to content

fix(members): say which crewmate to recreate on a short-name collision - #20766

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/12521-routing-rename-strings
Oct 16, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/12521-routing-rename-strings

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When two crewmates share a short name, the Members page tells the user the fix that actually works, and a test keeps shipped routing guidance on spawn_run(crew=...).

The Members page shows two notices when two crewmates fold to the same short name: slug_collision on the chat and notes_collision on the Notes tab. Both say "Rename one of the two crewmates". A rename changes only the name a crewmate shows. Its short name stays, so the collision stays.

Issue #12521 also named src/kiro_crew/config/prompt-orchestrator.md, which told the orchestrator to route with spawn_run(agent=...). That file left main with #15362. No shipped copy on main says spawn_run(agent= next to select_crew / route_crew today, and nothing guards against one coming back.

Why it matters

A user who follows the notice renames a crewmate, sees the same notice again, and has no next step. A routing copy that says agent= sends a crewmate's work into the caller's memory store, and nothing fails when one drifts in.

Not a goal

What changed (motivation → approach → change)

The two notices offered a rename, but a rename keeps the short name, so the collision never clears. Deleting either crewmate is not safe either: the chat stays bound to the crewmate that opened it first, which is the one slug_collision names. Delete that one and the other is refused with member_pin_mismatch.

Both notices now say a rename keeps the short name and which crewmate to delete. slug_collision names both: "delete “{{self}}” and create it again under a name with a different short name. Keep “{{name}}”." {{self}} is the crewmate whose chat shows the notice, passed from MembersPageThread.tsx with the same crewDisplayName label the header pill shows; {{name}} is the crewmate that owns the thread. notes_collision cannot know the owner (its 409 does not carry one), so it says to delete the one whose chat shows a short-name notice. All 12 translated catalogs carry the same meaning, each quoting names with its own style guide's marks, and en-XA is regenerated with npm run i18n:pseudo. The matching row in src/kiro_crew/docs/crew-members.md, a comment in CrewNotesTab.tsx, and two warning logs in src/kiro_crew/dashboard/handlers/members.py say the same thing.

test/test_crewmate_guidance_copies.py fails if either notice offers "Rename one" or "delete one", if slug_collision stops naming who to delete and who to keep, or if the Crew Members page stops giving the remedy the notices are pinned to. The MembersPage.test.tsx collision test checks the rendered notice names both crewmates. The existing test_no_guidance_still_tells_the_model_to_use_agent_for_a_crew in test/test_crew_routing_and_delegation.py reads packaged markdown too, and fails if a file that names select_crew or route_crew says spawn_run(agent=.

Backwards compatibility

Compatible: copy, one doc row, one comment, one extra interpolation value and tests. No key is renamed; {{name}} is kept in every locale and {{self}} is added to slug_collision in every locale.

Removes nothing: no key, route, field or behaviour is removed.

Tests

  • test/test_crewmate_guidance_copies.py::test_collision_notices_offer_the_remedy_the_page_states: both en notices say a rename keeps the short name and name the crewmate to delete. Red on the parent en.json (offers a rename) and on each earlier wording of this PR ("delete one", "delete this crewmate", the unquoted "not {{name}}"); green on this head.
  • website/src/pages/members/MembersPage.test.tsx "surfaces a slug collision…": asserts the notice says delete “oncall” and keep “Oncall”. Red without the MembersPageThread.tsx change, green with it.
  • test/test_crew_routing_and_delegation.py::test_no_guidance_still_tells_the_model_to_use_agent_for_a_crew: extended to packaged markdown; red when spawn_run(agent="<name>") is appended to goal-conductor/SKILL.md, green on this head.
  • Determinism: both tests only read files in sorted order. They have no clock, network or shared state. 5/5 green in reversed node order, plus green under -n 4.
  • Related sets run locally: backend routing/doc/line-cap/members tests (176 + 409 passed), 40 frontend files that reference the catalogs (2111 passed), every src/i18n/** test including the per-locale style/*Style.test.ts plus src/pages/members/** (83 files, 1792 passed). i18n:check, i18n:render, check-i18n-keys, lint:i18n, tsc, eslint, flake8, isort, black, docs-lint, the comment-history gate, the flake-pattern ratchet and semgrep all pass. members.py keeps its line count.

Manual verification

Rendered the real MembersPage through website/capture/members-empty-placeholder.html, with the thread POST answered by a different member (the collision branch), and the real CrewNotesTab with a 409 briefing read, both in en and de. The "Could not load teams" line above the notice comes from the gateway-free harness and is not part of this change. The delete-the-non-owner path was traced through members.py (binding owner selection, binding refusal) and crew_removal.py; it was not run end to end.

Screenshots / video

After (en):

slug collision notice, en

After (de, the longest rendering):

slug collision notice, de

Notes tab in the collision state (the real CrewNotesTab with the briefing read answering 409 briefing_slug_ambiguous), en:

notes collision notice, en

de:

notes collision notice, de

Related Issues

Closes #12521

Pattern harvest

Rule candidate: review-prompt
Pattern: a user-facing remedy names an action the product cannot perform, or one that only works for one of the two subjects; check every "rename/delete/retry" instruction against the code path it relies on.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 15, 2026 09:40
@iamwhatever
iamwhatever requested a review from buluoray October 15, 2026 09:40
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 7465092db7c22938d89c1bb252427d6bb15b83ce — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Run the delete-the-non-owner remedy end to end once: delete “{{self}}”, recreate it, and confirm both crewmates open their own chats. So far that path has only been traced through the code, not run.

[DESIGN-REVIEWED] 7465092

Description read

[DESCRIPTION-READ] c71950d266e6cdf28d2028abb552dbd8d53520eba1c2e116b7332ed24915bbe6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 7465092db7c22938d89c1bb252427d6bb15b83ce — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The chat notice tells users to delete a crewmate without saying what they lose, and the blind reader said they would not follow it.

Watch

  • The delete instruction gives no consequence or path. slug_collision now says "delete “{{self}}” and create it again" but never says whether the chat history or notes go with it, and it links to no delete action. The blind reader understood the advice correctly but said: "no, I wouldn't dare follow it. Deleting sounds permanent, and I'm not sure I'd lose nothing." This is rare but it repeats until fixed, and the only remedy offered is a destructive one. Smallest fix: one clause on what deleting removes, or a link to the crewmate's delete control.
  • The Notes notice doesn't say whether this crewmate is the one to delete. notes_collision says "delete the one whose chat shows a short-name notice", but the tab's own heading already names the crewmate ("Oncall"). The reader said: "I'd have to go and check each chat… I can't tell from the Notes panel whether that means this one." Same frequency, and it adds a step every time. Smallest fix: interpolate the tab's own crewmate, e.g. "If “{{name}}”'s chat shows a short-name notice, delete it and create it again…".
  • "short name" is never explained. The reader saw "Oncall" and "On-call" as different names and said: "I can't tell what a 'short name' is." Without that, "a name with a different short name" can't be acted on. Smallest fix: name the rule inline, e.g. "(the name with spaces, dashes and case removed)".

Suggestions

  • In slug_collision, put the action first: "Delete “{{self}}” and recreate it under a different name; keep “{{name}}”. Renaming won't fix this, because both share one short name."

[UX-REVIEWED] 7465092

Description read

[DESCRIPTION-READ] 23f73e531c9902ffa74d990515a02bd08e13771cd8a3a61aa2d5120053102008

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 7465092db7c22938d89c1bb252427d6bb15b83ce — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The delete-the-non-owner remedy that every notice now prescribes was traced through the code but "not run end to end". Confirm it before merge.

What this change ships

Inventory (9 items) — 9 justified

Intent: when two crewmates share a short name, tell the user the remedy that actually clears the collision. This is a FIX (#12521).

  1. The chat collision notice says a rename keeps the short name, names the crewmate to delete and recreate, and names the one to keep. — justified
  2. The Notes-tab collision notice says to delete the crewmate whose chat shows the short-name notice, then recreate it. — justified
  3. All 12 translated catalogs and the regenerated en-XA carry the same wording, and slug_collision gains {{self}} in each. — justified
  4. The Crew Members doc row now says which crewmate to delete, not "delete one". — justified
  5. Two backend warning logs say "recreate the one not owning its thread" instead of "rename one". — justified
  6. The chat notice gets a new interpolation value self, filled with the header pill's display name. — justified
  7. A new test pins both notices to the remedy the doc states and rejects "Rename one" and "delete one". — justified
  8. The routing-guidance test is extended to every packaged .md, so a file that routes with select_crew/route_crew cannot use spawn_run(agent=. — justified
  9. The CrewNotesTab comment now says recreate, not rename. — justified

[FIRST-PRINCIPLES-REVIEWED] 7465092

Description read

[DESCRIPTION-READ] a9355920bbbe789cf54400f39178a259a084d16b7d5e86d6e8b7512ab3ad1527

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 7465092db7c22938d89c1bb252427d6bb15b83ce — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 7465092

Verdict parsed from the review's SHA-scoped output markers for commit 7465092db7c22938d89c1bb252427d6bb15b83ce.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7465092db7c22938d89c1bb252427d6bb15b83ce: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 7465092db7c22938d89c1bb252427d6bb15b83ce and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 7465092

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 7465092db7c22938d89c1bb252427d6bb15b83ce: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@iamwhatever
iamwhatever force-pushed the fix/12521-routing-rename-strings branch from 8223a03 to 4403ff4 Compare October 15, 2026 10:46
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • slug_collision names only the crewmate to keep span=b440c3a9da38

Outcome: fixed in 4403ff4.
slug_collision now reads "delete the crewmate whose chat shows this notice, not {{name}}, then create it again under a name with a different short name", in all 12 locales.
The notice renders only inside the selected crewmate's open chat (MembersPage.tsx: collision recorded only when r.member !== m.name, rendered in that thread column), so "whose chat shows this notice" names the one to delete.
A {{self}} placeholder is rebutted as disproportional: it needs a MembersPage.tsx change while open #20342 rewrites that file, and the phrase above identifies the same crewmate without it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Reader has to work out that the header pill is this crewmate span=b9710cf23ce2

Outcome: fixed in 4403ff4.
slug_collision now reads "delete the crewmate whose chat shows this notice, not {{name}}, then create it again under a name with a different short name", in all 12 locales.
The notice renders only inside the selected crewmate's open chat (MembersPage.tsx: collision recorded only when r.member !== m.name, rendered in that thread column), so "whose chat shows this notice" names the one to delete.
A {{self}} placeholder is rebutted as disproportional: it needs a MembersPage.tsx change while open #20342 rewrites that file, and the phrase above identifies the same crewmate without it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Blind reader would not act on the notice span=ed63218b093c

Outcome: fixed in 4403ff4.
slug_collision now reads "delete the crewmate whose chat shows this notice, not {{name}}, then create it again under a name with a different short name", in all 12 locales.
The notice renders only inside the selected crewmate's open chat (MembersPage.tsx: collision recorded only when r.member !== m.name, rendered in that thread column), so "whose chat shows this notice" names the one to delete.
A {{self}} placeholder is rebutted as disproportional: it needs a MembersPage.tsx change while open #20342 rewrites that file, and the phrase above identifies the same crewmate without it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Deleting the wrong crewmate cannot be undone span=253bba1bd103

Outcome: fixed in 4403ff4.
slug_collision now reads "delete the crewmate whose chat shows this notice, not {{name}}, then create it again under a name with a different short name", in all 12 locales.
The notice renders only inside the selected crewmate's open chat (MembersPage.tsx: collision recorded only when r.member !== m.name, rendered in that thread column), so "whose chat shows this notice" names the one to delete.
A {{self}} placeholder is rebutted as disproportional: it needs a MembersPage.tsx change while open #20342 rewrites that file, and the phrase above identifies the same crewmate without it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Add a placeholder for the current crewmate span=33241ec304df

Outcome: fixed in 4403ff4.
slug_collision now reads "delete the crewmate whose chat shows this notice, not {{name}}, then create it again under a name with a different short name", in all 12 locales.
The notice renders only inside the selected crewmate's open chat (MembersPage.tsx: collision recorded only when r.member !== m.name, rendered in that thread column), so "whose chat shows this notice" names the one to delete.
A {{self}} placeholder is rebutted as disproportional: it needs a MembersPage.tsx change while open #20342 rewrites that file, and the phrase above identifies the same crewmate without it.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • notes_collision is muted and sends the user elsewhere span=7a5248dcb621

Outcome: rebutted.
The Notes view cannot name the crewmate to delete: its 409 briefing_slug_ambiguous refusal does not carry the thread owner, so pointing at the chat that shows the short-name notice is the most exact true instruction it can give.
Restyling the notice is a visual change outside the frozen goal, which is fixing the remedy the copy states.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • "Renaming keeps the short name" warns about an unseen control span=10ff3647c966

Outcome: rebutted.
Renaming exists: Edit on the Profile card and kirocrew agent update --display-name change the shown name (crew-members.md, Creating and editing).
The old notice told users to rename, so the clause tells them why that step does not help; dropping it would leave them to try it again.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Routing scan duplicates an existing test span=44f3155b1bcd

Outcome: fixed in 4403ff4.
The markdown scan now lives in test_crew_routing_and_delegation.py::test_no_guidance_still_tells_the_model_to_use_agent_for_a_crew, which reads control.py and every packaged .md that names select_crew or route_crew. The duplicate in test_crewmate_guidance_copies.py is removed; one rule, one test.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Two members.py warnings still say rename one member span=bc611cfe8ddb

Outcome: fixed in 4403ff4.
Both warnings in src/kiro_crew/dashboard/handlers/members.py now say to recreate the member that does not own the slug's thread under a new slug. The file keeps its 2,492-line count.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Run delete-the-non-owner end to end

Outcome: rebutted.
The path is pinned by code, not by a new end-to-end run: members.py selects the corroborated binding owner for the thread, crew_removal.py deletes only the registry entry and leaves the owner's dm.json binding valid, and a recreated name derives a new slug and persists its own binding.
The copy change adds no new behaviour, and owner retention on a colliding slug is pinned by test_members_dm_thread.py::test_colliding_slug_stays_with_first_bound_member, so a new end-to-end harness would be scope beyond the goal.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • The delete instruction points at this instead of naming the crewmate span=1b4734053741

Outcome: needs-a-decision.
@maintainers: naming the crewmate in slug_collision needs a {{self}} value passed from website/src/pages/members/MembersPage.tsx. Open #20342 rewrites that file (-4917 lines), so this PR left it untouched and states the target by place: "the crewmate whose chat shows this notice", which renders only in the non-owner's open chat.
Question: override the ux lane for 4403ff4 on that basis, or allow the one-line MembersPage.tsx change here (and #20342 carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Mechanism: the notice describes the crewmate by place, not name span=a3aaebd72c93

Outcome: needs-a-decision.
@maintainers: naming the crewmate in slug_collision needs a {{self}} value passed from website/src/pages/members/MembersPage.tsx. Open #20342 rewrites that file (-4917 lines), so this PR left it untouched and states the target by place: "the crewmate whose chat shows this notice", which renders only in the non-owner's open chat.
Question: override the ux lane for 4403ff4 on that basis, or allow the one-line MembersPage.tsx change here (and #20342 carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Blind reader would not delete anything span=216f482dd49c

Outcome: needs-a-decision.
@maintainers: naming the crewmate in slug_collision needs a {{self}} value passed from website/src/pages/members/MembersPage.tsx. Open #20342 rewrites that file (-4917 lines), so this PR left it untouched and states the target by place: "the crewmate whose chat shows this notice", which renders only in the non-owner's open chat.
Question: override the ux lane for 4403ff4 on that basis, or allow the one-line MembersPage.tsx change here (and #20342 carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Severity: every collision, destructive delete span=3376c3539f6f

Outcome: needs-a-decision.
@maintainers: naming the crewmate in slug_collision needs a {{self}} value passed from website/src/pages/members/MembersPage.tsx. Open #20342 rewrites that file (-4917 lines), so this PR left it untouched and states the target by place: "the crewmate whose chat shows this notice", which renders only in the non-owner's open chat.
Question: override the ux lane for 4403ff4 on that basis, or allow the one-line MembersPage.tsx change here (and #20342 carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Fix: pass the selected crewmate name in span=9e32e354a6a7

Outcome: needs-a-decision.
@maintainers: naming the crewmate in slug_collision needs a {{self}} value passed from website/src/pages/members/MembersPage.tsx. Open #20342 rewrites that file (-4917 lines), so this PR left it untouched and states the target by place: "the crewmate whose chat shows this notice", which renders only in the non-owner's open chat.
Question: override the ux lane for 4403ff4 on that basis, or allow the one-line MembersPage.tsx change here (and #20342 carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Short name is undefined span=0085824c3b30

Outcome: rebutted.
"Short name" is the product term the Crew Members page defines (src/kiro_crew/docs/crew-members.md: two crewmates fold to the same short name), and the notice already used it before this PR.
Showing the slug inline needs a new value from MembersPage.tsx, which this PR does not touch while #20342 rewrites it; that is new UI scope beyond the frozen goal of correcting the stated remedy.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • No path to the fix from the notice span=eedd39a92c6e

Outcome: rebutted.
Both actions already exist on the Members page: "New crewmate" in the roster and "Delete crewmate" in the crewmate editor; the notice names the action, not a new control.
Adding a delete or recreate button inside the notice is a new user-visible control, outside the frozen goal of correcting the remedy the copy states.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 15, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Severity: blocks the only fix on every collision span=036876338638

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • notes_collision should name the crewmate span=078c9aed7ef6

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Fix: name both crewmates directly span=0e5d5d0cd981

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Mechanism: the notice points at this crewmate without naming it span=0fad750febfb

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Blind reader would not delete anything span=1c6194412d61

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Cause: only the crewmate to keep is named span=300010c45442

Outcome: needs-a-decision.
@maintainers: naming the crewmate to delete needs a second value passed from website/src/pages/members/MembersPage.tsx (the placeholder the lane proposes). Open #20342 rewrites that file (-4917 lines), so this PR leaves it untouched. The copy names the one to keep (“{{name}}”) and places the one to delete: the notice renders only in the non-owner's open chat.
Question: override the ux lane for 4c9ba89 on that basis, allow the one-line MembersPage.tsx change here (#20342 then carries a one-line conflict), or park this PR until #20342 lands?

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Ask the agent is unclear span=67013496b5c5

Outcome: rebutted.
"Ask the agent" is the shared ErrorNotice askAgent action every inline error on the page carries; this PR does not add, rename or change it.
Relabelling a shared control is new scope outside the frozen goal of correcting the remedy the collision copy states.

@iamwhatever
iamwhatever force-pushed the fix/12521-routing-rename-strings branch from 4c9ba89 to 9684874 Compare October 15, 2026 16:38
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Update on the UX naming question: #20342 merged, so the overlap is gone and no override is needed for it. 9684874 passes the open crewmate's header label as {{self}} from website/src/pages/members/MembersPageThread.tsx, and slug_collision now reads (en): "…Renaming keeps the short name, so delete “{{self}}” and create it again under a name with a different short name. Keep “{{name}}”." in all 12 locales. Rebased onto current main; CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@iamwhatever
iamwhatever force-pushed the fix/12521-routing-rename-strings branch from 9684874 to fbb2ead Compare October 15, 2026 18:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@iamwhatever
iamwhatever force-pushed the fix/12521-routing-rename-strings branch from fbb2ead to 7465092 Compare October 15, 2026 22:41
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: the shard-6 red on fbb2ead (test_dashboard_server_composition_contract.py::test_the_lazy_imports_stay_inside_the_functions_that_need_them, 84 == 83) is main's: #19700 added a lazy import and #20930 moved the pin to 84. This head (7465092) includes #20930; the test passes locally. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: readiness: passed, all lanes green, no outstanding change requests.

@chenmingwei23
chenmingwei23 merged commit 8f63e25 into main Oct 16, 2026
103 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/12521-routing-rename-strings branch October 16, 2026 01:39
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two shipped strings contradict the crewmate routing and rename rules

2 participants