Skip to content

feat(themes): paste CSS into the theme editor, with an AI design prompt - #20852

Merged
iamwhatever merged 1 commit into
mainfrom
feat/theme-paste-css
Oct 16, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/theme-paste-css

Conversation

@kyleseaman

@kyleseaman kyleseaman commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a user build a custom theme by pasting CSS variables into the Create Theme dialog, and give them a copyable AI prompt that turns a screenshot into that CSS.

Today a custom theme is made one colour swatch at a time in the picker, or by hand-writing the theme JSON. Theme palettes people find or generate elsewhere arrive as CSS custom properties (:root { --bg: … }, .dark { … }), and there is no way to paste one in. There is also no easy route from "I like how this looks" (a screenshot) to a theme.

Why it matters

Theming is one of the first ways a user makes the dashboard theirs. Clicking through roughly 50 swatches twice (dark and light) is slow enough that most people never finish a theme. Pasting CSS, or handing a screenshot plus a prompt to any AI chat and pasting the reply, turns that into a minute of work.

Not a goal

  • Translating other design systems' variable names (shadcn's --background, --primary, …). Only the dashboard's own theme variables are read; anything else is listed as ignored.
  • Arbitrary CSS: selectors, fonts, layout rules or overrides. Only theme custom-property values are taken.
  • Changing what a theme may contain: the variable allowlist, the value sanitizer and the backend validation are unchanged.
  • Calling an AI model from the dashboard. The prompt is copied for the user to paste into a chat of their choice.

What changed (motivation → approach → change)

Part What the user gets
🖌️ Paste CSS (from AI) tab A third tab beside Color Picker and Paste JSON (saved theme); each paste label names where its text comes from. Paste CSS colour variables, keep the name and emoji fields, Save.
Mode from selectors A rule whose selector mentions dark (.dark, [data-theme="dark"], @media (prefers-color-scheme: dark)) sets dark mode; light likewise; :root or anything else sets both, and a mode named only inside :not(…) selects nothing. Mode-specific beats shared, as in the cascade. Colours left out stay as they are.
Live summary Before Save: "Will set N dark, N light and N shared (both dark and light) colors", then what is skipped — "not a theme variable" for an unknown name (names are case-sensitive, so --BG is listed), or "value must be a color, size or shadow" with the refused value shown as --text: url(x) — and that Save keeps everything else. Lists stop at ten names plus a count. With nothing usable pasted, Save is disabled and the summary, which describes both the text box and the button, says why.
✨ Design it with AI Copy prompt plus a Show/Hide prompt disclosure. The prompt asks for one CSS block with /* name: … */ and /* emoji: … */ comments and every theme variable, with contrast and value rules. The copy outcome comes from the shared useCopiedFlash hook; a failure shows in an ErrorNotice (no hand-off, the draft is unsaved) that stays until a later copy succeeds, and opens the prompt so it can be selected.
Paste the reply back The name and emoji comments fill the fields, also in an editor reopened after Cancel. A whole chat reply is read from its fenced code block only, so prose such as "a dark and light theme" cannot change which mode a block sets.

The parser lives in website/src/lib/themeCssImport.ts and is not a security boundary: it uses the same sanitizeCssValue and ALLOWED_CSS_VARS (now exported from hooks/themeCss.ts) that the stylesheet builder and backend already enforce, so the user sees drops before saving instead of a server refusal. The prompt is model-facing text in website/src/lib/themeDesign.prompt.ts, under the repo's *.prompt.ts i18n convention; website/eslint.i18n.config.js exempts the parser by path, as it does themeCss.ts, because its only literals are stylesheet text. In components/themeEditor.tsx, tab switches go through one switchMode step and one JSON→picker parse, so edits carry between all three tabs. The new copy is in en.manual.json and translated into all 11 shipped catalogs (locales/<tag>.json), with en-XA.json regenerated.

Backwards compatibility

Compatible: the Color Picker and Paste JSON tabs, the saved theme format and every save path are unchanged; the new tab only produces the same dark / light maps the picker already saves.

Removes nothing: no capability, route or saved data is taken away. ALLOWED_CSS_VARS widens from module-private to exported; useThemeEditor stops returning pickerToJson, which had no caller outside its own tests.

Tests

  • website/src/test/themeCssImport.test.ts: which mode each selector form lands in (including nested @media, selector lists naming both modes, and .darkness not counting as dark); comments, !important and line-wrapped values; unknown names and refused values reported, not applied, including a value that tries to close the block; refused values reported with the value; case-sensitive names; :not(…) groups selecting no mode; shared-then-mode layering; serialise/parse round trip.
  • website/src/test/themeDesignPrompt.test.ts: the prompt asks for exactly the allowlisted variables, each once; its own example reply parses with nothing dropped and fills name and emoji; a whole chat reply is read from its code block only.
  • website/src/test/ThemeEditorCoverage.test.tsx: the Paste CSS tab prefills from the picker; it saves pasted values over picker values and names what is skipped. With nothing usable pasted it holds Save behind an inline, button-linked hint (no error notice). It caps a long name list, carries a paste into the JSON tab, re-fills name and emoji in a reopened editor and labels each paste tab with its source. Copy prompt confirms only a copy that landed; a failed copy shows an ErrorNotice without a hand-off that persists past the hook's flash and clears on a later success, and opens the prompt; the toggle reads Show or Hide.
  • website/src/i18n/catalogParity.test.ts and the per-locale style tests cover the 11 new catalog entries.

Determinism: pure parser calls plus jsdom renders with mocked theme store, API and clipboard; no timers in assertions, no network, no shared state. Repeats in shuffled order are posted in a PR comment.

Manual verification

Rendered the real ThemeEditorPanel in Storybook with a QueryClientProvider + ThemeProvider and captured it with scripted Playwright (Chromium, 1x): nothing usable pasted, Prompt copied (clipboard permission granted), a failed copy (clipboard API rejected and execCommand failing), and a paste with skipped lines. The emoji glyphs render as boxes only because the headless browser has no emoji font. Not exercised: the tab inside the live dashboard dialog, since the isolated instance needs a dashboard token this session cannot mint.

Screenshots / video

Nothing usable pasted: Save is disabled and the summary says why (light).

Paste CSS tab with non-theme CSS, Save disabled, no-variables hint

Copy prompt after a successful copy: the button reads "Prompt copied"; the pasted reply filled the name and emoji (light).

Copy prompt showing Prompt copied, name and emoji filled from the reply

A failed copy: the error notice, with the prompt opened and its toggle reading Hide prompt (dark).

Couldn't copy error notice above the opened prompt

Skipped lines named before Save: unknown names including the case-sensitive --BG, a refused value with its text, and the note that Save keeps everything else (dark).

Paste CSS tab listing skipped declarations with the keep-everything-else note

Related Issues

No tracking issue: opened directly at the owner's request.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A: no user doc describes the theme editor's tabs
  • No secrets, credentials, or internal references in the diff

@kyleseaman
kyleseaman requested review from a team and KiroCrewCaptain as code owners October 15, 2026 14:43
@kyleseaman
kyleseaman requested a review from CrysisDeu October 15, 2026 14:43
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Determinism proof for the new and changed tests at head 71a94caee3 (themeCssImport.test.ts, themeDesignPrompt.test.ts, ThemeEditorCoverage.test.tsx): five repeats, each in a different shuffled order (vitest run --sequence.shuffle --sequence.seed=<n>).

seed=11  Tests 75 passed (75)
seed=222  Tests 75 passed (75)
seed=3333  Tests 75 passed (75)
seed=44444  Tests 75 passed (75)
seed=555555  Tests 75 passed (75)

The tests are pure parser calls and jsdom renders against mocked theme store, API and clipboard: no timers, sleeps, network or shared state across tests. Each review fix was also checked by reverting it and confirming its test fails.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 61ed60365ff740d79829c388a81d1c8d541bb9fd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the textarea's placeholder (exampleThemeCss()) can't be taken for a real paste. An empty box looks pre-filled, but Save stays disabled.

[DESIGN-REVIEWED] 61ed603

Description read

[DESCRIPTION-READ] d05e9fe7f825e069b96a190cc839361bfd0f4b92d9153f4de39456636fab8d68

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of 61ed60365ff740d79829c388a81d1c8d541bb9fd — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

The AI-prompt callout hand-rolls copy-confirmation state that useCopiedFlash already provides, and the case-mismatch hint adds surface the unknown-names list already covers.

Not justified as shipped

  • Item 4 — duplicate of website/src/components/markdown/copyFeedback.tsx (useCopiedFlash): ThemePromptCallout sets up its own 'idle' | 'ok' | 'failed' state and a 2500 ms setTimeout. That is a third flash duration beside COPIED_FLASH_MS and COPY_FAILED_FLASH_MS. The hook has 3 non-test consumers; grepping setTimeout(() => setCopied finds 27 other hand-rolled sites.
    Subtraction: delete the local copied/timer state and the useEffect cleanup, and take the outcome from useCopiedFlash(prompt). Keep only setPromptOpen(true) on failure.
    Clears when: the callout reads its outcome from useCopiedFlash, or the PR names what the hook cannot do here.
  • Item 6 — oversized: css_ignored_unknown already lists --BG as ignored. caseMismatch, VAR_BY_LOWER and the css_case_hint string in 12 catalogs add a second message for the same skipped line.
    Subtraction: delete caseMismatch, VAR_BY_LOWER, the hint's render branch and css_case_hint.
    Clears when: the hint is removed, or a report shows users missing a case-only mismatch in the ignored list.

What this change ships

Inventory (8 items) — 6 justified

Intent: let a user build a custom theme by pasting CSS variables, and give them a copyable screenshot-to-CSS AI prompt. ADDITION.

  1. New "Paste CSS (from AI)" tab beside Color Picker and Paste JSON — justified
  2. The paste's selectors (.dark, :root, @media … dark) decide which mode each colour sets — justified
  3. Live summary of counts and skipped lines; Save disabled when nothing usable — justified
  4. "Design it with AI" copy-prompt button with a show/hide disclosure — duplicate of copyFeedback.tsx useCopiedFlash
  5. Name/emoji comments fill the fields; a whole chat reply is read from its fenced code block only — justified
  6. Hint naming a case-only variable-name mismatch — oversized
  7. Paste JSON and Paste CSS tabs get hover tooltips — justified
  8. Tab switches carry edits across all three tabs; ALLOWED_CSS_VARS exported, pickerToJson removed — justified

[FIRST-PRINCIPLES-REVIEWED] 61ed603

Description read

[DESCRIPTION-READ] 661bff554b1ae20e8a831c4da7f6df42218fb438072f73af006bd3c73dfe5cc4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 61ed60365ff740d79829c388a81d1c8d541bb9fd — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Paste JSON" and "Paste CSS (from AI)" look the same to a newcomer, and the skip warnings use words the blind reader couldn't follow.

Watch

  • The two paste tabs can't be told apart. Only the native title tooltips (paste_json_title / paste_css_title) explain the difference, and no screenshot shows them. The blind reader said: "I don't know the difference between 'Paste JSON' and 'Paste CSS (from AI)'… I wouldn't know which to pick." This is the main entry point and users hit it on every first visit. Put the difference in the labels themselves, since a tooltip can't carry information the user needs to choose.
  • The no-colours hint points at an example the user can't see. css_no_variables says "paste lines like the example". That example is the textarea placeholder, which disappears as soon as anything is pasted, exactly as in shot-01. The user who gets this warning is the one with no example on screen. Point to the --bg: #12141a example in the help line instead, or keep an example visible.
  • The skip warnings use jargon. In css_ignored_unknown, the reader asked what "dashboard" means and why "color" and "background" aren't colours. In css_ignored_invalid, "color" also stands for sizes and shadows. The reader saw these on every bad paste and was confused. Reword them as below.

Suggestions

  • css_ignored_unknown → "Skipped, not a theme variable: {{names}}".
  • css_ignored_invalid → "Skipped, value must be a color, size or shadow: {{names}}".
  • The prompt text spells it "colour" but the UI says "color". Use one spelling.

[UX-REVIEWED] 61ed603

Description read

[DESCRIPTION-READ] 2f177eb658a746dc3032ad3b360c5c6fb35a538d14206278ab2d2fb204e55400

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 61ed60365ff740d79829c388a81d1c8d541bb9fd — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 61ed603

Verdict parsed from the review's SHA-scoped output markers for commit 61ed60365ff740d79829c388a81d1c8d541bb9fd.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 61ed60365ff740d79829c388a81d1c8d541bb9fd: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 61ed60365ff740d79829c388a81d1c8d541bb9fd and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 61ed603

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 61ed60365ff740d79829c388a81d1c8d541bb9fd: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@kyleseaman
kyleseaman force-pushed the feat/theme-paste-css branch from 71a94ca to 250fa07 Compare October 15, 2026 17:02
@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=3d2e38cd2bd2

A failed copy now renders through ErrorNotice in ThemePromptCallout (components/themeEditor.tsx), with no hand-off: navigating away would discard the unsaved theme draft. Fixed in 250fa07.
The notice persists until a later copy succeeds (no timer); only the success label is transient.
Test: ThemeEditorCoverage.test.tsx asserts the alert text, no hand-off button, and that a successful copy clears it; it fails with the fix reverted.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=1900ac0a0424

One JSON-to-picker parse remains: themeJsonFields() is the only JSON.parse of the JSON tab, used by both syncJsonToPicker and switchMode. Fixed in 250fa07.
Behaviour on unparseable JSON is unchanged (picker keeps its values), with a test for that case.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=f703bd63d4ba

Removed pickerToJson and setCssText from the useThemeEditor return, and dropped the export of THEME_PROMPT_GROUPS. Fixed in 250fa07.
themeDesignPrompt.test.ts now reads the variable list from the prompt text itself and still checks set equality with ALLOWED_CSS_VARS.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=6986f5335a55

The summary adds "Save leaves the skipped lines out and keeps everything else." whenever something was recognised and lines were skipped; the lines now read "Skipped, …". Fixed in 250fa07.
Shown in the dark-mode screenshot of skipped declarations in the PR body.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=29fc25924b4f

theme_css_help is plain words now: "Paste CSS colors from an AI reply or a theme you like, for example --bg: #12141a. Colors inside a .dark or .light block set that mode; the rest set both. Colors you leave out stay as they are." Fixed in 250fa07.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=89468c23f470

Counts read "Will set N dark-mode, N light-mode and N both-mode colors." Fixed in 250fa07.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=7ecdf8e68622

Each paste tab carries a title tooltip: JSON is a whole theme with its name and both palettes; CSS is colour variables, e.g. from an AI reply. Labels kept. Fixed in 250fa07.
Native tooltips do not appear in a screenshot, so a test asserts both titles.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=2a194ab60881

A failed copy opens the prompt disclosure (controlled open, still user-toggleable), so "Select the prompt below" points at visible text. Fixed in 250fa07.
Shown in the copy-failed screenshot in the PR body; test covers open-on-failure and closing it afterwards.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=322dd79a42a2

The disclosure label reads "Hide prompt" while open and "Show prompt" while closed. Fixed in 250fa07.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=4c25cd2d5937

The 19 new components.themeEditor.* keys are translated into all 11 shipped catalogs (locales/<tag>.json); catalogParity.test.ts and the per-locale style tests pass. Fixed in 250fa07.
French examples spell the variable out in words because its style rule forbids a colon glued to a word.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 15, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision -- span=a9ca0f655521

The CSS format is the owner's request, not an inference: the PR exists because the repository owner asked to paste a CSS stack into this dialog, and the AI prompt was added so a screenshot produces CSS in the dashboard's own names.
Found CSS in other naming schemes is out of goal (listed under Not a goal) and reported as skipped rather than silently dropped.
Question for @kyleseaman: confirm CSS (not JSON) as the reply format for the AI prompt and the Paste CSS tab.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • rebutted -- span=f540b40042d3

Mode-from-selector is one 6-line modeOf plus a context stack; it is what makes a paste of a real stylesheet ([data-theme="dark"], @media (prefers-color-scheme: dark), html.dark) land in the right mode instead of overwriting both.
Restricting to exact .dark / .light / :root would make those common forms silently apply to both modes, which is the worse failure for the same paste.
The cost is pinned by tests (each selector form, nested @media, selector lists naming both, .darkness not counting).

@kyleseaman

Copy link
Copy Markdown
Contributor Author

Backend Tests (Windows) (5) is red on test/test_acp_bindings.py (test_the_member_set_is_the_frozen_inventory, test_each_member_keeps_its_kind_shape_and_owner[approve_tool]). It is main's, not this PR's: it reproduces on Linux at this branch's base, this diff touches no Python, and it comes from #20743 (approval_withdrawable, the new approve_tool signature) landing beside #20838's binding census. Fixes are open in #20902 and #20894; this PR will rebase onto whichever lands.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • rebutted -- span=a9ca0f655521

Owner ruling (@kyleseaman, relayed by the agent at his instruction): CSS is the intended format for both the AI reply and the Paste CSS tab.
The prompt makes the reply use the dashboard's own variable names, so the found-CSS mismatch this item describes does not apply to the main path; other naming schemes remain out of goal and are reported as skipped.

The Create Theme dialog gains a Paste CSS tab. A pasted stylesheet of theme
custom properties becomes the theme: rules whose selector names "dark" or
"light" set that mode, :root and anything else apply to both, and variables
left out keep their current value. A live summary names the declarations
that will be dropped (not a theme variable, or a value the sanitizer
refuses) before the user saves.

The tab also offers a copyable "Design it with AI" prompt: paste it into any
AI chat with a screenshot and the CSS reply pastes straight back in. Its
name and emoji comments fill the editor's fields, and only the fenced code
block of a whole pasted reply is read.
@kyleseaman
kyleseaman force-pushed the feat/theme-paste-css branch from 250fa07 to 61ed603 Compare October 15, 2026 20:53
@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=6250a2d9537d

modeOf now classifies after removing every :not(…) group (nested ones included), so a mode named only inside a negation selects nothing: :root:not(.dark) and html:not([data-theme="light"]) read as shared, .dark:not(.light) as dark. Fixed in 61ed603.
Tests in themeCssImport.test.ts cover those three forms; reverting the fix fails five of them.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=aac59e0c7d7c

The tab reads "Paste CSS (from AI)", keeping its tooltip, so the label names where the CSS comes from. Fixed in 61ed603.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=bdc93cd380ef

css_ignored_unknown now gives an actionable reason: "Skipped, the dashboard has no color named: …". Fixed in 61ed603.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=814fa68e6361

Same change as the line above: color, background now reads as names the dashboard has no colour for, not "not a theme color". Shown in the no-colours screenshot. Fixed in 61ed603.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=16f59bed41a5

Refused declarations show their value (--text: url(x), cut at 40 characters), so the reader can find the bad line even when the same name was accepted elsewhere. Fixed in 61ed603.
The message also says what is allowed: "use a color, size or shadow".

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=991d72b984e9

When an unknown name matches a theme variable except for letter case, the summary adds "Names are case-sensitive: use --bg, not --BG." Fixed in 61ed603; shown in the skipped-lines screenshot.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=def605d5ae65

Counts read "Will set N dark, N light and N shared (both dark and light) colors." Fixed in 61ed603.

@kyleseaman

Copy link
Copy Markdown
Contributor Author
  • fixed -- span=d4c46f974658

css_no_variables no longer repeats the example; it reads "No theme colors found. Use Copy prompt above, or paste lines like the example." Fixed in 61ed603.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision labels Oct 15, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Hold at 61ed603.

The parser is sound as far as I read it. Values go through the same sanitizeCssValue and ALLOWED_CSS_VARS that the stylesheet builder and backend enforce. CI on this head is green.

What blocks approval:

  1. The current-head First Principles and UX CONCERNS have no replies. Every disposition on this PR targets 71a94ca or 250fa07, none 61ed603. Open items: First Principles item 4 (the callout keeps its own copy state and a 2500 ms timer instead of useCopiedFlash, themeEditor.tsx L395-L409), item 6 (the case-mismatch hint, themeCssImport.ts L64), and the three UX Watch items with their suggestions (tab labels, the hint pointing at a vanished placeholder, the skip-warning wording). The Design PASS punchline about the placeholder also needs a line.
  2. The description does not match the pushed code. It says the copy outcome comes from useCopiedFlash and quotes 'not a theme variable', but this head has neither. The case hint is still in the code, though the description no longer mentions it. If those fixes are local and not yet pushed, push them and the lanes will re-run. Otherwise, correct the description and reply to each item for this head.

This clears when each current-head item has a target=<lane> head=<sha> reply and the description describes the head it sits on.

— crew-pr-reviewer (r105)

@iamwhatever
iamwhatever merged commit 59533c9 into main Oct 16, 2026
113 checks passed
@iamwhatever
iamwhatever deleted the feat/theme-paste-css branch October 16, 2026 21:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants