Skip to content

fix(crew): name a paused goal's next step in the welcome recap - #20858

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/17826-resume-card-digits-wording
Oct 15, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/17826-resume-card-digits-wording

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In a crewmate's welcome recap, the line for a paused goal says in plain words that the text in brackets is that goal's next step, in every shipped language.

When you open a crewmate after a long break, its welcome recap lists each paused goal like this: Paused: Rotate the pager keys (next: confirm with Sam). A bare "next:" does not say what comes next.

Why it matters

The recap is the first thing a returning user reads in that chat. A line they have to puzzle over slows down picking the work back up.

Not a goal

What changed (motivation → approach → change)

The paused line now reads Paused: Rotate the pager keys (its next step: confirm with Sam).

Every shipped catalog in website/src/i18n/locales/ now says "next step" in its own words. Each one reuses a term that catalog already has for "next step":

Language Before After
en (next: …) (its next step: …)
zh-CN (下一步:…) unchanged, already "next step"
hi (अगला: …) (अगला कदम: …)
es (siguiente: …) (siguiente paso: …)
fr (ensuite : …) (prochaine étape : …)
bn (পরবর্তী: …) (পরবর্তী ধাপ: …)
pt (a seguir: …) (próximo passo: …)
ru (дальше: …) (следующий шаг: …)
de (als Nächstes: …) (nächster Schritt: …)
ja (次: …) (次の手順: …)
ko (다음: …) (다음 단계: …)
it (prossimo: …) (prossimo passo: …)

No translation adds a word for "its": the bracket already sits on that goal's line, and the zh-CN style guide asks to drop an owner word the reader can infer. The Japanese line also takes full-width brackets, as ja.md asks. The en-XA pseudolocale is regenerated.

Backwards compatibility

Compatible: only the value of pages.membersPage.welcome_paused_next changes; its key and its {{goal}} and {{next}} placeholders stay the same.

Removes nothing: the line still shows the goal and its next step; only the label in front of the step changes.

Tests

  • website/src/pages/members/MembersPage.test.tsx, the cold-welcome test, pins the new English line. It fails on main's catalog (received Paused: Rotate the pager keys (next: confirm with Sam)) and passes with this change.
  • npm run i18n:check against the merge base: all 19 checks pass, including [changed-values], [changed-passthrough] and [pseudolocale].
  • npx vitest run src/i18n with I18N_BASE_REF set: 49 files and 981 tests pass, including every language's style test on changed values.
  • Determinism: the changed test ran 20 times on its own, all green. The whole MembersPage.test.tsx file then ran 5 times with --sequence.shuffle (seeds 22720, 19320, 20332, 27431, 28145), 275 of 275 green each time.

Manual verification

The real MembersPage was rendered through the isolated capture entry (website/capture/members-page.html) with a gateway-free API stub: a long-idle crewmate, no goal in flight, and one paused goal with a next step. Before is main's catalog; after is this branch.

Screenshots / video

Before, on main:

Welcome recap on main: Paused: Rotate the pager keys (next: confirm with Sam)

After, this branch:

Welcome recap on this branch: Paused: Rotate the pager keys (its next step: confirm with Sam)

Related Issues

Refs #17826

#20422 edits the same catalogs and test file in nearby lines that do not touch these. git merge-tree of this commit with #20422's head (6f4fc09f24) merges with no conflict and keeps both changes.

Pattern harvest

Not generalizable: one unclear label in one catalog value; there is no repeated code shape to catch.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

The crewmate cold welcome lists each paused goal as
"Paused: <goal> (next: <step>)". A bare "next:" does not say what comes
next, so the line now reads "Paused: <goal> (its next step: <step>)".

Every shipped catalog now says "next step" in its own words; zh-CN
already did and keeps its value. The en-XA pseudolocale is regenerated
and the cold-welcome test pins the new English line.

Refs #17826
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 15, 2026 14:56
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 4afcca3

Description read

[DESCRIPTION-READ] 0c9232b34c606f8f0538b925860f36a870d65bfc047fa62ae1a69a44be5c9b0d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that #17826 actually reports the bare "next:" label as unclear. That issue is this relabel's only provenance, and no doc in the repo records it.

What this change ships

Inventory (4 items) — 4 justified

Intent: a returning user can tell that the bracketed text on a paused goal's recap line is that goal's next step. This is a FIX (relabel).

  1. The English recap line for a paused goal reads "(its next step: …)" instead of "(next: …)" — justified
  2. The ten other translated catalogs each say "next step" in their own wording; zh-CN is unchanged — justified
  3. The Japanese line switches to full-width brackets, as website/src/i18n/style/ja.md:32 requires — justified
  4. The en-XA pseudolocale is regenerated and the cold-welcome test pins the new English line — justified

[FIRST-PRINCIPLES-REVIEWED] 4afcca3

Description read

[DESCRIPTION-READ] a562f381e0c5508b2d8c420d5134fb5e294cbf3fde28d3c7064736f94cbfecd1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] 4afcca3

Description read

[DESCRIPTION-READ] f20a4025adf24a16dc3836c6f63431cedf9af59eea9a9f3de095c299bd651340

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4afcca3

Verdict parsed from the review's SHA-scoped output markers for commit 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4afcca3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4afcca31df3f8a5d307a81fc4c8c486ff949e3f8: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Provenance of the "next:" relabel

rebutted: the provenance is recorded. #17826 lists this exact ask as item 5: welcome_paused_next: "(its next step: {{next}})" in every catalog (UX span ece1e9a6f7af), #17826 (comment)
That item is the UX Review finding on PR #17797, accepted there and deferred to #17826 with the same wording: #17797 (comment)
So the bare "next:" label was reported as unclear by review, and this PR applies the recorded remedy, nothing wider.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 15, 2026

@chenmingwei23 chenmingwei23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batch approval: readiness: passed, no merge conflict, checks green.

@chenmingwei23
chenmingwei23 merged commit ebaa981 into main Oct 15, 2026
102 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/17826-resume-card-digits-wording branch October 15, 2026 15:41
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants