Repository navigation
fix(crew): name a paused goal's next step in the welcome recap - #20858
Conversation
The crewmate cold welcome lists each paused goal as "Paused: <goal> (next: <step>)". A bare "next:" does not say what comes next, so the line now reads "Paused: <goal> (its next step: <step>)". Every shipped catalog now says "next step" in its own words; zh-CN already did and keeps its value. The en-XA pseudolocale is regenerated and the cold-welcome test pins the new English line. Refs #17826
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 4afcca3 Description read[DESCRIPTION-READ] 0c9232b34c606f8f0538b925860f36a870d65bfc047fa62ae1a69a44be5c9b0d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that #17826 actually reports the bare "next:" label as unclear. That issue is this relabel's only provenance, and no doc in the repo records it. What this change shipsInventory (4 items) — 4 justifiedIntent: a returning user can tell that the bracketed text on a paused goal's recap line is that goal's next step. This is a FIX (relabel).
[FIRST-PRINCIPLES-REVIEWED] 4afcca3 Description read[DESCRIPTION-READ] a562f381e0c5508b2d8c420d5134fb5e294cbf3fde28d3c7064736f94cbfecd1 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] 4afcca3 Description read[DESCRIPTION-READ] f20a4025adf24a16dc3836c6f63431cedf9af59eea9a9f3de095c299bd651340 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
chenmingwei23
left a comment
There was a problem hiding this comment.
Batch approval: readiness: passed, no merge conflict, checks green.
Problem / Motivation
Goal: In a crewmate's welcome recap, the line for a paused goal says in plain words that the text in brackets is that goal's next step, in every shipped language.
When you open a crewmate after a long break, its welcome recap lists each paused goal like this:
Paused: Rotate the pager keys (next: confirm with Sam). A bare "next:" does not say what comes next.Why it matters
The recap is the first thing a returning user reads in that chat. A line they have to puzzle over slows down picking the work back up.
Not a goal
MateResumeCard) and itsresume_*copy, which are items 1, 2 and 4 of Crewmate resume card: localize count digits and align the continue step wording #17826. Open PR feat: add return-triggered warm task briefs #20422 removes them, per RFC docs(rfc): trigger warm task brief on return #20157.What changed (motivation → approach → change)
The paused line now reads
Paused: Rotate the pager keys (its next step: confirm with Sam).Every shipped catalog in
website/src/i18n/locales/now says "next step" in its own words. Each one reuses a term that catalog already has for "next step":(next: …)(its next step: …)(下一步:…)(अगला: …)(अगला कदम: …)(siguiente: …)(siguiente paso: …)(ensuite : …)(prochaine étape : …)(পরবর্তী: …)(পরবর্তী ধাপ: …)(a seguir: …)(próximo passo: …)(дальше: …)(следующий шаг: …)(als Nächstes: …)(nächster Schritt: …)(次: …)(次の手順: …)(다음: …)(다음 단계: …)(prossimo: …)(prossimo passo: …)No translation adds a word for "its": the bracket already sits on that goal's line, and the zh-CN style guide asks to drop an owner word the reader can infer. The Japanese line also takes full-width brackets, as
ja.mdasks. Theen-XApseudolocale is regenerated.Backwards compatibility
Compatible: only the value of
pages.membersPage.welcome_paused_nextchanges; its key and its{{goal}}and{{next}}placeholders stay the same.Removes nothing: the line still shows the goal and its next step; only the label in front of the step changes.
Tests
website/src/pages/members/MembersPage.test.tsx, the cold-welcome test, pins the new English line. It fails on main's catalog (receivedPaused: Rotate the pager keys (next: confirm with Sam)) and passes with this change.npm run i18n:checkagainst the merge base: all 19 checks pass, including[changed-values],[changed-passthrough]and[pseudolocale].npx vitest run src/i18nwithI18N_BASE_REFset: 49 files and 981 tests pass, including every language's style test on changed values.MembersPage.test.tsxfile then ran 5 times with--sequence.shuffle(seeds 22720, 19320, 20332, 27431, 28145), 275 of 275 green each time.Manual verification
The real
MembersPagewas rendered through the isolated capture entry (website/capture/members-page.html) with a gateway-free API stub: a long-idle crewmate, no goal in flight, and one paused goal with a next step. Before is main's catalog; after is this branch.Screenshots / video
Before, on main:
After, this branch:
Related Issues
Refs #17826
#20422 edits the same catalogs and test file in nearby lines that do not touch these.
git merge-treeof this commit with #20422's head (6f4fc09f24) merges with no conflict and keeps both changes.Pattern harvest
Not generalizable: one unclear label in one catalog value; there is no repeated code shape to catch.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.