Repository navigation
fix(apps): give the trust dialog's trusted-failure retry its own label - #20859
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the gateway-connection store goes back to connected once the gateway is reachable. If it stays false, the not-saved retry stays disabled. [DESIGN-REVIEWED] 8e4604d Description read[DESCRIPTION-READ] ac1e991df01f2c46c6da07b763e11939f7fdbaae70566f1f4cb7ef67400739c8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Quoting "Cancel" also rewrites three consent-state lines, which sit outside the Goal's "failure states". Not justified as shipped
What this change shipsInventory (7 items) — 6 justifiedIntent: make the trust dialog's retry say what it does in each failure state, and keep it off while it cannot work. This is a FIX (Closes #20798).
[FIRST-PRINCIPLES-REVIEWED] 8e4604d Description read[DESCRIPTION-READ] b71bd20d63b02802ef852cb0f24e9d684fab9127e4081f6aeaa22ff01a5ab898 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that the offline line in shot-04, "Kiro Crew is not connected right now", tells people what it is not connected to. In shot-03 the reader asked: "Connected to what? My internet? Some server?" [UX-REVIEWED] 8e4604d Description read[DESCRIPTION-READ] 6332b0e24fdb5a9415503061d9461737544ae7161cce4749d66ab8d6d916d14c That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ea9990f to
65fd1e9
Compare
|
|
|
65fd1e9 to
10dea35
Compare
|
|
|
|
10dea35 to
25d2580
Compare
|
|
|
|
|
|
|
Once trust is saved and only the retried action failed, the retry button read "Trust and try again", so the headline had to explain that the button's own word asked for nothing. That state's retry now reads "Try again" on every path (enable, install, update) in every locale, and its headline just names it. On the not-saved failure while the gateway is unreachable, the next step said to wait for the reconnect but the retry stayed on. The retry is now off for exactly that long, and the sentence names it: it stays off until the reconnect. Cancel stays on. A control named inside a sentence is quoted, in the locale's own quote pair, across the dialog's failure and exit sentences in all 12 catalogs. The dialog's grant and consent gate are unchanged. Closes #20798
25d2580 to
8e4604d
Compare
|
|
|
|
Hold at 8e4604d for human review. This changes the app trust consent dialog, a security-related surface reserved for a person even when the code looks sound. All current-head AI concerns are answered, and the answers hold up. The First Principles rebuttal is correct because the not-saved failure renders One point for the human reviewer. In the granted state the button now reads 'Try again' with a plain retry icon (TrustAppModal.tsx#L628-L631), but the click still calls — crew-pr-reviewer (r104) |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved by a maintainer who read the review lane findings on this head and accepted them as follow-up work; the findings stay on the record for whoever picks them up.
Problem / Motivation
Goal: On the trust dialog's failure states, the retry button says what it does, it is off while it cannot work, and a control named in a sentence reads as a name.
After trust is saved and only the action failed, the retry still reads "Trust and try again", so the headline has to explain that the button's own word asks for nothing. While the gateway is unreachable, the not-saved failure says to wait for the reconnect, but its retry stays on. The headlines name controls in running text ("choose Trust and try again"), which reads as part of the sentence.
Why it matters
A button that says "Trust" when no trust is asked makes a consent dialog harder to trust. A button that is on while its own next-step line says to wait invites a retry that can only fail the same way.
Not a goal
What changed (motivation → approach → change)
Once trust is saved, the retry gets its own label, "Try again", on the enable, install and update paths, in all 12 catalogs. The label says what it does, so the three trust-saved headlines no longer explain it: they say the app is trusted but the action failed, then how to remove the trust in Settings. That button carries a plain retry icon, not the trust shield. The not-saved state keeps "Trust and try again" and its shield, because there the retry does ask for trust.
On the not-saved failure, the retry turns off while the gateway is unreachable and back on when it returns. Its offline line names it: "Trust and try again" stays off until it reconnects. Cancel stays on. The not-saved headlines name no control, so they never point at a button that is off: "Choose "Trust and try again"" moves into the connected next step, before the agent hand-off.
A control named inside a sentence is quoted, in the locale's own quote pair (the one its title puts around the app name): the retry labels, "Ask the agent", and "Cancel" where an exit sentence opens on it. Bengali, Hindi, Japanese and Korean exit sentences use the verb, not the label, so they stay as they are; the Bengali hand-off keeps its stem as the verb, because the label's ending is the formal register that catalog keeps out of running copy.
en-XAis regenerated.TrustAppModal.tsxpicks the label by state and disables the retry from the same gateway-connection store the offline line reads.Backwards compatibility
Compatible: copy and one button's disabled state only; no API, key removal or stored data changes. One catalog key is added (
confirm_retry_granted).Removes nothing: the retry is disabled only while the gateway is unreachable on the not-saved failure, and comes back on reconnect; Cancel and every other path are unchanged.
Tests
website/src/i18n/trustModalFailureCopy.test.ts, every authored catalog:confirm_retry_granteddiffers from the not-saved label, and the trust-saved headlines share one clause and name neither retry label; the not-saved headlines do not name the retry, while the connected next step and the offline line name the quoted not-saved label; the connected next step names the quoted hand-off (the Bengali stem otherwise); no exit sentence opens on a bare Cancel label.website/src/test/TrustAppModal.test.tsx: the trust-saved retry showsconfirm_retry_grantedand not the not-saved label on the enable, install and update paths, with the retry icon and no shield; the not-saved retry keeps its label; offline it is disabled, a click does nothing, Cancel stays enabled, and it re-enables on reconnect; the trust-saved retry stays enabled offline.--sequence.shuffle, seeds 7919, 15838, 23757): 117/117 each time. Also run: all ofwebsite/src/i18n/withI18N_BASE_REFset (1061 passed),npm run i18n:checkandlint:i18n(diff-scoped QA 0 findings),tsc -p tsconfig.app.json, eslint on the changed files.Manual verification
website/scripts/capture-trust-modal-update-copy.mjsruns the real built SPA with stubbed APIs and asserts each state before it takes the frame. BEFORE is a dist built from this PR's base, AFTER from this head; both runs passed. BEFORE shows the bug on main: the trust-saved retry reads "Trust and try again", and offline the headline says to choose the retry while it stays on. AFTER asserts nothing offline tells the reader to choose it.Screenshots / video
Trust saved, update failed: the retry is "Try again".
Nothing saved, gateway unreachable: the retry is off.
Other states (after)
Related Issues
Closes #20798
Pattern harvest
Not generalizable: a dialog-specific copy decision about which label a retry carries in each failure state.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)