Skip to content

docs: rfc for crewmate responsive send - #20889

Merged
buluoray merged 1 commit into
mainfrom
docs/rfc-crewmate-responsive-send
Oct 15, 2026
Merged

buluoray merged 1 commit into
mainfrom
docs/rfc-crewmate-responsive-send

Conversation

@buluoray

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record, as an accepted RFC, the product owner's decision that a crewmate DM answers a person who writes while it works: steer first, cancel after a 3-second unread grace, one Send (Stop while empty), and no scheduling machinery drawn.

On main a send to a busy crewmate offers the Steer / Queue / Jev-auto split, a queued message waits 36–38 s on a pod for the running turn to end, and it is drawn as a yellow queue card apart from the bubbles. #20240 changes that shape, and its First Principles lane asks for the decision on record.

Why it matters

A person talking to a crewmate does not know a turn is running. Asking them to pick a scheduling mode and then waiting half a minute makes the crewmate look stuck. The RFC writes down what was decided and what it costs, so the change is reviewed against a decision rather than against itself.

Not a goal

What changed (motivation → approach → change)

Goal → record the decision before the code lands → docs/request-for-change/rfc-crewmate-responsive-send.md, accepted (product owner rayrayxu, 2026-10-15), plus one row in docs/request-for-change/README.md:

  • Send path: queue first, steer, cancel the exact running turn once only if the steer is unread after 3 s; no cancel while a question, approval, compaction or Stop is pending; waiting messages drain as one turn.
  • Composer: Stop while busy and empty, as on main; the plain Send icon once typed, never the split.
  • Transcript: no queue card, scheduling badges or worker cards; questions, approvals, errors, the stop card and main's typing bubble stay.
  • Costs accepted: a tool longer than 3 s is cancelled and re-run (kiro-cli stops it; its result is lost), a fast answer is likely but not guaranteed, and queue editing stays on the Sessions page.

Backwards compatibility

Compatible: documentation only; no code, config or schema changes.

Removes nothing: the PR adds one RFC and one index row.

Tests

N/A — documentation only. scripts/docs-lint.sh passes.

Manual verification

N/A — no runtime change.

Screenshots / video

N/A — documentation only. The implementing PR #20240 carries the pod screenshots.

Related Issues

Tracks #20181. Implementation: #20240.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners October 15, 2026 16:01
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ea02e57c5e56e94ea57cc30a78552940df9f6ef2 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision ea02e57c5e56e94ea57cc30a78552940df9f6ef2 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of ea02e57c5e56e94ea57cc30a78552940df9f6ef2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The RFC is marked accepted on rayrayxu's say-so, but nothing on record backs that, and rayrayxu is not in MAINTAINERS.md.

Watch

  • No record of the acceptance. The RFC says "Status: accepted. This is the product owner's decision, given 2026-10-15 by rayrayxu", but links no issue, PR comment or commit where that was said. The listed maintainers are bolichen97, iamwhatever and CrysisDeu. The point of this PR is that feat: prioritize human messages in crewmate chats #20240's First Principles lane reads the decision from the base branch. With no source for "accepted", that lane gets a status anyone could have typed. Other accepted rows cite where the decision was made, for example the docs(rfc): Python+Rust hybrid backend, starting with a native MCP stub #19611 approval or a document's Open questions.
    Clears when: the RFC links a public comment where rayrayxu, or a listed maintainer, states the decision. If no maintainer confirms it, set the status to draft.
  • The UI decision is not protected yet. Per docs/decisions/README.md, "a decision an RFC settles is protected here only once it also has an entry". Until then, a later fix can bring back the Steer / Queue split or the queue card in the crewmate chat, and no review rule will flag it.
    Clears when: a docs/decisions/ entry for "the crewmate chat offers one Send, steer-then-cancel" lands with a maintainer citation, or the PR says it is deliberately deferred.

[DESIGN-REVIEWED] ea02e57

Description read

[DESCRIPTION-READ] 2f15d652ce4acfabef18112154e364acf7f51fbc49c27d6ab9bc2fbbf6dfa231

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ea02e57c5e56e94ea57cc30a78552940df9f6ef2 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ea02e57

Verdict parsed from the review's SHA-scoped output markers for commit ea02e57c5e56e94ea57cc30a78552940df9f6ef2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ea02e57c5e56e94ea57cc30a78552940df9f6ef2: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ea02e57c5e56e94ea57cc30a78552940df9f6ef2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ea02e57

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ea02e57c5e56e94ea57cc30a78552940df9f6ef2: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 15, 2026
Records the product owner's 2026-10-15 decision for crewmate DMs: a
send to a busy crewmate steers first and cancels only after a 3-second
unread grace, the composer keeps Stop while empty and shows the plain
Send once typed, and the chat draws no scheduling machinery.
@buluoray
buluoray force-pushed the docs/rfc-crewmate-responsive-send branch from a608af6 to ea02e57 Compare October 15, 2026 20:47
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 15, 2026
@buluoray
buluoray enabled auto-merge (squash) October 15, 2026 21:53
@buluoray
buluoray merged commit 10b7fa7 into main Oct 15, 2026
103 checks passed
@buluoray
buluoray deleted the docs/rfc-crewmate-responsive-send branch October 15, 2026 21:55
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants