Skip to content

fix(dashboard): call feature videos by one name in the dialog and Settings - #21016

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/10048-feature-video-name
Oct 19, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/10048-feature-video-name

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The startup video dialog and its Settings row call the feature by one name, so a user can tell they are the same thing.

The dialog header said "Feature intro". Settings ▸ Chat ▸ Discovery said "Feature Videos". A new user could not tell if these were one feature or two.

Why it matters

A user who wants to turn the clips off, or download them, looks in Settings for the name they saw at launch. With two names, that row reads like a different feature. Every one of the 12 shipped locales had the same split.

Not a goal

  • The per-clip title (for example "Feature tips above the composer") stays per clip. This is the name of the feature, not of one clip.
  • No backend change. The docs page, the config labels and the Settings row already say "Feature Videos".
  • No fix to scripts/capture-feature-video-cache-row.mjs. It times out on main because the row moved under the Discovery tab; that is its own fix.

What changed (motivation → approach → change)

The dialog header now reads the Settings row's own string, so both surfaces show the same words in every locale and cannot drift apart.

Surface Before (en) After (en)
Dialog header Feature intro Feature Videos
Settings row Feature Videos Feature Videos
Clip title per clip per clip

StartupVideoModal.tsx calls i18nT('pages.settings.chatPanel.feature_videos') for its header, and components.startupVideoModal.feature_intro is deleted from en.manual.json and the 11 other shipped catalogs; en-XA is regenerated with npm --prefix website run i18n:pseudo. No new string and no new translation.

The test and capture fixtures used "Feature videos" as a clip title, which now repeats the header. They use the real monitor-loops catalog title "Let one session watch a pull request" instead.

Backwards compatibility

Breaking: the i18n key components.startupVideoModal.feature_intro is removed. Writer sweep on origin/main @ b72606c: its only readers were StartupVideoModal.tsx and StartupVideoModal.test.tsx, both moved to pages.settings.chatPanel.feature_videos here. Open PR #17156 has the old key in context lines and will need a rebase.

Reader: website/src/components/StartupVideoModal.tsx:OpenStartupVideoModal -- crew page -- reads pages.settings.chatPanel.feature_videos; StartupVideoModal.test.tsx covers it
Reader: website/src/components/StartupVideoModal.test.tsx:"does not wear the changelog popup's title" -- crew page -- asserts the header shows the Settings string

Tests

  • StartupVideoModal.test.tsx "does not wear the changelog popup's title" now looks the header up by the Settings key, so it fails if the dialog stops showing the Settings name.
  • StartupVideoModal.test.tsx and App.startupVideoSequencing.test.tsx: fixture clip title changed so it no longer repeats the header text.
  • Related UI and i18n set with I18N_BASE_REF=origin/main (24 files, 364 tests, including locale style, catalog parity, dead-key and key-reference tests), npm run i18n:check, tsc -p tsconfig.app.json: all pass.

Manual verification

Ran npm run verify:startup-video-modal against a loopback dev server: all assertions pass, frame below. npm run verify:feature-video-cache-row times out on main and here (the row is under the Discovery tab now), so the Settings frame below was taken by opening Discovery on the same capture page.

Screenshots / video

Dialog header after the change, with a per-clip title under the player:

Startup dialog header reads Feature Videos

Settings ▸ Chat ▸ Discovery row, unchanged, same string:

Settings row reads Feature Videos

Related Issues

Closes #10048

Pattern harvest

Not generalizable: one feature named twice in copy; the dialog now reads the one Settings string, so there is no second copy to drift.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 16, 2026 00:18
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of b8f96750d2ef1f9d02d3e3ec66b4906894bb5572 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that the issue linked by "Closes #10048" is the report of the two names; that issue is the only evidence that someone could not find the feature.

What this change ships

Inventory (4 items) — 4 justified

Intent: let a user see that the startup video dialog and its Settings row are the same feature. This is a FIX.

  1. The dialog header reads "Feature Videos" (the Settings row's string) instead of "Feature intro", in all 12 locales — justified
  2. The components.startupVideoModal.feature_intro key is gone from every catalog. Its only readers were StartupVideoModal.tsx:394 and its test, and both now read the Settings key — justified
  3. The test and capture fixtures use a real clip title instead of "Feature videos" — justified
  4. The header test now asserts the header shows the Settings string — justified

[FIRST-PRINCIPLES-REVIEWED] b8f9675

Description read

[DESCRIPTION-READ] 1ba69db8a10d920daddcf0870b89b9ffe63a7600d79c82a6ecf60ff3c2b6a1ec

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b8f96750d2ef1f9d02d3e3ec66b4906894bb5572 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that every locale's feature_videos value reads as a dialog title as well as a Settings row label. Both surfaces now share that one key.

[DESIGN-REVIEWED] b8f9675

Description read

[DESCRIPTION-READ] af586e07c7ef795ae51086c35958cc372f3c8c697650c2a00fe976109fbd5416

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b8f96750d2ef1f9d02d3e3ec66b4906894bb5572 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b8f9675

Verdict parsed from the review's SHA-scoped output markers for commit b8f96750d2ef1f9d02d3e3ec66b4906894bb5572.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b8f96750d2ef1f9d02d3e3ec66b4906894bb5572: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of b8f96750d2ef1f9d02d3e3ec66b4906894bb5572 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that each locale's Settings string for "Feature Videos" still reads well as a dialog title, now that the dialog header uses it.

Suggestions

  • These problems were already there and this PR doesn't touch them, so they belong in a follow-up. The blind reader couldn't tell "Feature Tips" apart from "Feature Videos" in Settings ▸ Discovery. They also found no way to re-watch a clip from that row. They held back from clicking "Got it" because of "never comes back".

[UX-REVIEWED] b8f9675

Description read

[DESCRIPTION-READ] be77fc8ce90e647b3c1e36327d1570f7e1ad0099703fc13be23ff11c38584678

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b8f96750d2ef1f9d02d3e3ec66b4906894bb5572 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b8f9675

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b8f96750d2ef1f9d02d3e3ec66b4906894bb5572: <one-sentence reason>

@iamwhatever

iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: fixture clip title chosen in this PR

  • fixed span=3d95969e8243: the header collided with the fixture clip title and the Feature Tips switch

fixed in 940f8e5: the fixture clip in capture/startup-video-modal.tsx, StartupVideoModal.test.tsx and App.startupVideoSequencing.test.tsx now carries the real monitor-loops catalog title "Let one session watch a pull request" (src/kiro_crew/feature_videos.py).
The evidence frame now shows the feature name "Feature videos" over a clip title that names no other feature.
The shipped feature-tips clip title stays as shipped: it is per-clip catalog data, out of this PR goal.

@iamwhatever

iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author
  • rebutted span=bcb3c609e82c: recapture so the video area shows a real first frame

The dot on purple is the capture fixture poster, website/capture/assets/placeholder.jpg, unchanged by this PR and the same on main.
The frame was recaptured on 940f8e5 after the poster rendered; the harness waits for the dialog and the player, then 600 ms.
This PR changes the header text only, which the frame shows; a richer poster is out of this PR goal.

@iamwhatever

iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor Author

#10048 asks to "pick one canonical name for the feature and use it in all three places"; it names no new term.
The PR picks the name already used by Settings, the docs page (src/kiro_crew/docs/feature-videos.md, "Feature Videos") and the config labels, so only the dialog header changes.
Each locale's header takes that locale's existing Settings term; no new translation is invented.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 16, 2026
@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from 940f8e5 to ad481dc Compare October 16, 2026 00:50
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/*.json (12 shipped catalogs + en-XA) since this head went green (2a8c936 -> d4d9f99); CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 16, 2026
@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from ad481dc to d3b47c3 Compare October 16, 2026 01:02
@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: dialog-only copy of the Settings string plus a parity test

  • fixed span=857458220e28: the dialog carried its own copy of the Settings string

fixed in d3b47c3: StartupVideoModal.tsx reads pages.settings.chatPanel.feature_videos, the Settings row string, so there is one string per locale and nothing to keep in sync.
The dialog-only key is gone from every catalog and the parity test featureVideoName.test.ts is deleted with it; no casing rule in the repo required a second string.
Components already read pages.settings.* keys (for example ApprovalModePicker.tsx), and no i18n test ties a key namespace to its reader.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: do longer non-English headers fit the dialog header?

The header is a text-sm span in a flex justify-between row of a 560px dialog, beside one 16px close icon; it has no truncate or whitespace-nowrap, so a long name wraps instead of being cut.
The longest shipped value, fr "Vidéos de fonctionnalités" (25 characters), is the same string the Settings row already shows, and it is far below the row width.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: the dialog header reuses a pages.settings.chatPanel key; what if the Settings label is reworded into an action?

Sharing the key is the point of #10048: the dialog and the Settings row name one feature, so a rename of that name should move both together.
pages.settings.chatPanel.feature_videos is the row title, a noun ("Feature Videos"); the row action is a separate key, feature_videos_download_all ("Download all now").
A future edit that turns the title into an action would change what the row names, and should then give the dialog its own noun; that is a later change, not one this PR needs.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Yes. #10048 tables the three surfaces with their text: the startup dialog header "Feature intro" (StartupVideoModal.tsx) and the Settings row "Feature Videos" (ChatPanel.tsx).
It states the confusion directly: a new user reading the Settings row cannot tell whether "Feature Videos" is the same thing as the "Feature intro" dialog they saw at launch.
The split was raised in round-3 review of #9995, accepted, and deferred to #10048 (label deferred-finding).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 16, 2026
@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from d3b47c3 to 11e0ef3 Compare October 16, 2026 01:51
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/*.json and website/capture/ since this head went green (5ddd790 -> 333061b); CI re-running.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 16, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does the Settings row label read as a dialog title in en, de and ja?

The shared string is a bare noun phrase in every shipped locale: en "Feature Videos", de "Feature-Videos", ja "機能紹介動画" (feature introduction videos).
A noun phrase naming the feature is what the old header "Feature intro" was too, so it reads as the title of a dialog that plays one of those videos.
The attached en frame shows the header in place; de and ja use the same span with the same classes.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does every locale Settings string fit the dialog header?

Longest shipped value is fr "Vidéos de fonctionnalités" (25 characters), then it "Video sulle funzionalità" (24); every other locale is 20 or fewer.
The header is a text-sm span in a flex justify-between row of a 560px dialog beside one 16px close icon, with no truncate or whitespace-nowrap, so nothing is cut; 25 characters at text-sm is far below that width.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: do the Got it and X buttons still read as different?

This PR does not touch either control. The X is an icon button with aria-label from components.startupVideoModal.close ("Close") in the header; "Got it" is a filled text button in the footer.
They differ by place, shape and label, unchanged from main; any rework of their wording is outside #10048, which is about the feature name only.

@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from 11e0ef3 to 1ad83e4 Compare October 16, 2026 02:38
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/i18n/locales/*.json (#20441) since this head went green (333061b -> fe87f5b); CI re-running.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does each locale Settings string read naturally as a dialog heading?

In every shipped locale the string is a bare noun phrase naming the feature: en "Feature Videos", de "Feature-Videos", fr "Vidéos de fonctionnalités", ja "機能紹介動画", zh-CN "功能视频", ru "Видео о возможностях".
None is a verb, a sentence or a setting state, so each reads as the title of a dialog that plays one of those videos, the same job the old header "Feature intro" did.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does each locale Settings string also read naturally as a dialog title?

Every shipped value is a bare noun phrase naming the feature (en "Feature Videos", de "Feature-Videos", es "Vídeos de funciones", ja "機能紹介動画", ko "기능 소개 영상"), with no verb or state word.
A noun phrase is what a dialog title is, and the attached en frame shows it in place above the per-clip title.

@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from 1ad83e4 to 95304d2 Compare October 19, 2026 16:39
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: one more re-sync (fe87f5b -> 88914fd) so GitHub CodeQL default setup runs on a fresh head; 1ad83e4 never received the CodeQL check, which held PR Readiness at "waiting on CodeQL (skipped)". CI re-running.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: will the i18n lints accept a component reading a pages.settings key?

Yes. deadKeys.test.ts, keyReference.test.ts, catalogParity.test.ts, duplicateKeys.test.ts and dynamicKeys.test.ts all pass on this head; none ties a key namespace to the file that reads it.
Components already read pages.settings.* keys on main (for example ApprovalModePicker.tsx, pages.settings.securityPanel.yolo_duration_*).
A later edit to the Settings row title renames the dialog header with it; that is the point of #10048, one name for one feature.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: should the Discovery row let users turn the clips off?

Out of this PR goal. #10048 asks for one feature name across the dialog and Settings; its Not-in-scope keeps everything else as shipped.
The off switch today is the instance setting dashboard.feature_videos_enabled (src/kiro_crew/docs/feature-videos.md, Controls table), and closing a clip records it as dismissed for good.
A Settings toggle for that switch is a separate feature, not a naming fix.

@iamwhatever
iamwhatever force-pushed the fix/10048-feature-video-name branch from 95304d2 to b8f9675 Compare October 19, 2026 20:25
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main b72606c, which carries the red-main fix #22178 (3e39e7a), so Harness Parity Gate, Await Fast Gate and Coverage Gate re-run on fixed main (88914fd -> b72606c). CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does every locale feature_videos value read as a dialog title and a Settings row label?

Every shipped value is a bare noun phrase naming the feature: en "Feature Videos", de "Feature-Videos", fr "Vidéos de fonctionnalités", es "Vídeos de funciones", ja "機能紹介動画", ko "기능 소개 영상", zh-CN "功能视频", ru "Видео о возможностях".
None is a verb, a sentence or a setting state, so each reads as a dialog title as well as a row label; the attached en frame shows it in the header.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • answered: does each locale Settings string still read well as a dialog title?

Every shipped value is a bare noun phrase naming the feature: en "Feature Videos", de "Feature-Videos", fr "Vidéos de fonctionnalités", es "Vídeos de funciones", ja "機能紹介動画", ko "기능 소개 영상", zh-CN "功能视频", ru "Видео о возможностях".
None is a verb, a sentence or a setting state, so each reads as a dialog title as well as a row label; the attached en frame shows it in the header.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Yes. #10048 tables the startup dialog header "Feature intro" (StartupVideoModal.tsx) against the Settings row "Feature Videos" (ChatPanel.tsx).
It states that a new user reading the Settings row cannot tell whether it is the same thing as the dialog seen at launch; it was raised in round-3 review of #9995 and deferred there (label deferred-finding).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 19, 2026 22:06

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (17 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the startup video dialog header now uses the same Feature videos string as Settings; the unused feature_intro key is removed from every locale and the test fixtures use a per-clip title so the header and the clip title stay distinct.

@KiroCrewCaptain
KiroCrewCaptain merged commit 512f13c into main Oct 19, 2026
104 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/10048-feature-video-name branch October 19, 2026 22:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature videos have three different names across the modal, the catalog and Settings

2 participants