Repository navigation
fix(dashboard): call feature videos by one name in the dialog and Settings - #21016
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the issue linked by "Closes #10048" is the report of the two names; that issue is the only evidence that someone could not find the feature. What this change shipsInventory (4 items) — 4 justifiedIntent: let a user see that the startup video dialog and its Settings row are the same feature. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] b8f9675 Description read[DESCRIPTION-READ] 1ba69db8a10d920daddcf0870b89b9ffe63a7600d79c82a6ecf60ff3c2b6a1ec That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that every locale's [DESIGN-REVIEWED] b8f9675 Description read[DESCRIPTION-READ] af586e07c7ef795ae51086c35958cc372f3c8c697650c2a00fe976109fbd5416 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that each locale's Settings string for "Feature Videos" still reads well as a dialog title, now that the dialog header uses it. Suggestions
[UX-REVIEWED] b8f9675 Description read[DESCRIPTION-READ] be77fc8ce90e647b3c1e36327d1570f7e1ad0099703fc13be23ff11c38584678 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
fc30c21 to
8e77fa0
Compare
8e77fa0 to
940f8e5
Compare
|
self-added: yes
|
|
|
940f8e5 to
ad481dc
Compare
ad481dc to
d3b47c3
Compare
|
self-added: yes
|
|
|
|
d3b47c3 to
11e0ef3
Compare
|
|
|
11e0ef3 to
1ad83e4
Compare
|
|
1ad83e4 to
95304d2
Compare
|
|
95304d2 to
b8f9675
Compare
|
|
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (17 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the startup video dialog header now uses the same Feature videos string as Settings; the unused feature_intro key is removed from every locale and the test fixtures use a per-clip title so the header and the clip title stay distinct.
Problem / Motivation
Goal: The startup video dialog and its Settings row call the feature by one name, so a user can tell they are the same thing.
The dialog header said "Feature intro". Settings ▸ Chat ▸ Discovery said "Feature Videos". A new user could not tell if these were one feature or two.
Why it matters
A user who wants to turn the clips off, or download them, looks in Settings for the name they saw at launch. With two names, that row reads like a different feature. Every one of the 12 shipped locales had the same split.
Not a goal
scripts/capture-feature-video-cache-row.mjs. It times out on main because the row moved under the Discovery tab; that is its own fix.What changed (motivation → approach → change)
The dialog header now reads the Settings row's own string, so both surfaces show the same words in every locale and cannot drift apart.
StartupVideoModal.tsxcallsi18nT('pages.settings.chatPanel.feature_videos')for its header, andcomponents.startupVideoModal.feature_introis deleted fromen.manual.jsonand the 11 other shipped catalogs;en-XAis regenerated withnpm --prefix website run i18n:pseudo. No new string and no new translation.The test and capture fixtures used "Feature videos" as a clip title, which now repeats the header. They use the real monitor-loops catalog title "Let one session watch a pull request" instead.
Backwards compatibility
Breaking: the i18n key
components.startupVideoModal.feature_introis removed. Writer sweep on origin/main @ b72606c: its only readers wereStartupVideoModal.tsxandStartupVideoModal.test.tsx, both moved topages.settings.chatPanel.feature_videoshere. Open PR #17156 has the old key in context lines and will need a rebase.Reader: website/src/components/StartupVideoModal.tsx:OpenStartupVideoModal -- crew page -- reads
pages.settings.chatPanel.feature_videos;StartupVideoModal.test.tsxcovers itReader: website/src/components/StartupVideoModal.test.tsx:"does not wear the changelog popup's title" -- crew page -- asserts the header shows the Settings string
Tests
StartupVideoModal.test.tsx"does not wear the changelog popup's title" now looks the header up by the Settings key, so it fails if the dialog stops showing the Settings name.StartupVideoModal.test.tsxandApp.startupVideoSequencing.test.tsx: fixture clip title changed so it no longer repeats the header text.I18N_BASE_REF=origin/main(24 files, 364 tests, including locale style, catalog parity, dead-key and key-reference tests),npm run i18n:check,tsc -p tsconfig.app.json: all pass.Manual verification
Ran
npm run verify:startup-video-modalagainst a loopback dev server: all assertions pass, frame below.npm run verify:feature-video-cache-rowtimes out on main and here (the row is under the Discovery tab now), so the Settings frame below was taken by opening Discovery on the same capture page.Screenshots / video
Dialog header after the change, with a per-clip title under the player:
Settings ▸ Chat ▸ Discovery row, unchanged, same string:
Related Issues
Closes #10048
Pattern harvest
Not generalizable: one feature named twice in copy; the dialog now reads the one Settings string, so there is no second copy to drift.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)