Repository navigation
feat(files): open a folder the tree cap still cuts in its folder tab - #21026
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 627efd1 Description read[DESCRIPTION-READ] 1f26d87d8827566aa6329403f19ef2e6e17523e0ae17f4243e3bbc13fa176ae6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS "Open in folder tab" names a place a first-time user has never seen, so the cold reader could only guess where the click goes and whether it shows the missing items. Watch
Suggestions
[UX-REVIEWED] 627efd1 Description read[DESCRIPTION-READ] 9eb01b58ff856197d732c0720a5ec0ec4ed6ac5d4c28f12577be4e679a28cca8 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the root-level folder tab opened from the limit row ( What this change shipsInventory (7 items) — 7 justifiedIntent: let a user reach files deep inside a folder the tree cap still cuts by opening that folder in the folder tab that already lists and searches it. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 627efd1 Description read[DESCRIPTION-READ] 8c18cabd01a7716dc7b69bd90148067753eede4b09e27de0e8b4e8fbeb8e53ec That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
20b2742 to
fa36adb
Compare
|
[operator: bolichen97] fixed in fa36adb
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] fixed in fa36adb
|
|
[operator: bolichen97] fixed (description)
|
|
[operator: bolichen97] fixed (description)
|
|
[operator: bolichen97] rebutted (punchline: Windows mixed separators)
|
fa36adb to
2cb12e5
Compare
|
[operator: bolichen97] fixed in 2cb12e5
|
|
[operator: bolichen97] fixed in 2cb12e5
|
|
[operator: bolichen97] fixed in 2cb12e5
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] fixed in 2cb12e5 (punchline: scope survives a mode switch)
|
2cb12e5 to
a824782
Compare
|
[operator: bolichen97] fixed
|
|
[operator: bolichen97] fixed
|
|
[operator: bolichen97] Rebased: main moved in website/src/i18n/locales/*.json since this head went green (5d899b0 -> 8f63e25); CI re-running. The Design and UX BLOCKs on a824782 read zero images (the body was being re-edited at that moment); the two screenshots are attached in the description and this push re-runs both lanes on it. |
a824782 to
c24922e
Compare
c24922e to
9171391
Compare
|
[operator: bolichen97] fixed
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted (punchline: keyboard and screen reader)
|
|
[operator: bolichen97] rebutted (punchline: the limit text)
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted (punchline: the opened tab lists the cut folder)
|
|
[operator: bolichen97] Rebased: main moved in docs/system-specs/modules/learn-cron-dashboard.md and website/src/i18n/locales/*.json since this head went green (333061b -> e9306a9); CI re-running. Same head fixes the red Frontend Tests (3): hiStyle.test.ts '[changed-values] addresses the reader as तुम' flagged my hi value for row_truncated_open (खोलें, the आप form); it is now खोलो. All style suites pass locally with I18N_BASE_REF=origin/main. |
9171391 to
627efd1
Compare
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted
|
|
[operator: bolichen97] rebutted (punchline: the opened tab lists the folder itself)
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved by a maintainer who read the UX Review finding on this head and accepted it as follow-up work; the finding stays on the record.
Problem / Motivation
Goal: From the Files rail, a folder the project tree's cap still cuts can be opened in one click in its folder tab, where it can be listed and searched on its own.
(Goal amended by the maintainer-side conductor after round 3: the first version added a folder-scoped search inside the rail. #20632's Task 1 is now answered "no" for that, see below.)
#20523 made every folder past the 10,000-row cap reachable from the rail. A folder that is still cut on its own listing shows a limit row, "Some items not shown". The rail's name search answers one ranked page of 50 for the whole project, so a match deep in that folder can stay out of reach. The folder tab (
FolderPanel) already searches one folder by name with a page that grows, but nothing in the rail leads there.Why it matters
Large asset or vendor folders are where the cap bites. Today the user has to know that the folder tab exists and find their way to it. One link on the limit row closes that gap without a second search surface.
Not a goal
openFolderoption and tab field, so it is a possible follow-up./api/file-search,/api/project/tree,FolderPanel, the cap or any path or access check.What changed (motivation → approach → change)
#20632 Task 1 asked whether a folder-scoped name search belongs in the rail. Answer: no.
FolderPanelalready calls/api/file-searchrooted at its folder and widens its page on demand, so a rail copy would be a second scope state for the same job.So the rail only bridges to it. Where the host can open folder tabs, the limit row under a cut folder reads "Open in folder tab", styled as a link, and opens that folder's tab. The label promises only what the click does. The folder keeps its "some items not shown" badge, so the cut is still named. Hosts that pass no opener keep the old inert row.
Where:
website/src/pierre/PierreWorkspaceTreeImpl.tsx(the row and its selection),treeStateRows.tsandconfig.ts(the action row's decoration and link style),tree.tsx(theonOpenFolderprop),website/src/pages/chat/FileBrowserRail.tsx(new optionalonOpenFolder, given the absolute path),FilesHomePanel.tsxandSidePanel.tsx(wire it to the existingopenFolder), onewebsite/src/i18n/locales/*.jsonlabel, the capture harness frame, and the owning specdocs/system-specs/modules/learn-cron-dashboard.md(the one actionable state row, and the badge staying beside it). No new API: the rail gets one optional prop and calls the tab opener the side panel already has.Backwards compatibility
Compatible: one new optional prop on the rail, the shared tree and
FilesHomePanel; hosts that do not pass it render and behave as before. One new catalog key,row_truncated_open, in all 13 locales.Removes nothing: the inert limit row stays for every host without an opener.
Tests
test/test_file_search.py::TestFolderScopedSearchReachesWhatTheProjectPageMisses: 60 louder matches push a deep file out of the project's 50-row page, and a search rooted at its folder (what the folder tab runs) finds it. This is why the row leads to the folder tab.PierreWorkspaceTreeImpl.test.tsx"hands the cut folder to the host when its limit row is selected": the row reads "Open in folder tab" and selecting it callsonOpenFolder('big').FileBrowserRail.test.tsx"opens a cut folder in a folder tab, as an absolute path, from its limit row" and "offers no folder-tab action when the host cannot open one".Determinism: fixed fixtures and mocks, no timers or ordering; the rail and tree files ran 3 times with
--sequence.shuffle, 217/217 each. Also ranvitest run src/i18nplus the SidePanel and FilesHomePanel tests (60 files, 1116 pass),pytest test/test_file_search.py,tsc -p tsconfig.app.json, eslint,lint:i18n,lint:theme-colors,lint:phantom-classes,lint:restyle-ratchet: all exit 0.Manual verification
The real
FileBrowserRailin a browser throughwebsite/scripts/capture-files-rail-past-tree-cap.mjs(stubbed APIs), light and dark. The folder tab itself is unchanged and not in that harness.Screenshots / video
A folder still cut on its own listing: its limit row now opens it in a folder tab; the badge still says items are not shown.
Dark theme
Related Issues
Closes #20632
Task 1 of #20632 is answered "no" for a rail-scoped search; a cut folder is now one click from the folder tab that searches it.
Part of #16819 (Task 3). Follows #20523.
Checklist
learn-cron-dashboard.md