Repository navigation
Conversation
8482b75 to
27b67ed
Compare
|
Friendly nudge for the requested reviewers: this PR is waiting on a reviewer approval to unlock the CI gates and kick off the agentic reviews. There's no outstanding author action — the labels no longer require an author decision. Could you approve to let CI run, or trigger a re-review workflow? Thanks! |
27b67ed to
4aa0056
Compare
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 4aa0056 Description read[DESCRIPTION-READ] 37df0e7b29ff991872c58868edae2b9fff8d08c90cfd02f2d1da5168c11d0c33 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing screenshots of five of the six recoloured warn surfaces; only the secrets note is shown. Evidence gaps
Watch
[UX-REVIEWED] 4aa0056 Description read[DESCRIPTION-READ] 159bfc2599225e0e123290ea57dcec498630b5dbb38d2e38b2c309aec3da97c9 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The real cause is any on-solid Not justified as shipped
What this change shipsInventory (5 items) — 4 justifiedIntent: make the "Agent requested secrets" approval note, and its same-defect siblings, readable in dark mode — FIX (#21057).
[FIRST-PRINCIPLES-REVIEWED] 4aa0056 Description read[DESCRIPTION-READ] fb16e4785bb96c7c3ec8b29fe17da49dfd0c47b5c33907ea5e5fa24125626476 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Screenshots — all six recoloured warn surfaces, before vs after, both themesCaptured against the real components, stylesheet, theme tokens, lucide icons and i18n catalog (no reconstruction) via a Theme named (per the review's watch item): the default dark theme is Dark theme (
|
| # | Surface | Source |
|---|---|---|
| 1 | "Writes to your repos" badge — Schedule preset card | SchedulePage.tsx:709 |
| 2 | Same badge — template gallery | ScheduleTemplateGallery.tsx:58 |
| 3 | Job-dialog writes notice (schedule-writes-notice) |
SchedulePage.tsx:1613 |
| 4 | Secrets pending note | SchedulePage.tsx:1379 |
| 5 | Auto-nudge status line (in-progress warn state) | AutoNudgePopover.tsx:710 |
| 6 | Legacy-loop notice (legacy_notice) |
AutoNudgePopover.tsx:743 |
On the "amber-on-amber contrast at 11–13px" watch item
--warn-text is the token #20184 added specifically so warn-tinted surfaces have a readable foreground; it resolves to the warn hue at full chroma in dark mode (not a muted tint-on-tint). The frames above are at deviceScaleFactor: 2 so the 11px legacy notice and 12.5px writes notice can be judged directly. This PR does not change the tint (bg-warn-subtle) or the font sizes — it only swaps the foreground token from the fill-foreground (--warn-fg) to the on-tint token (--warn-text), which is strictly more readable on the subtle tint than what shipped.
The capture fixture/driver is intentionally not committed to the PR — it was only used to generate this evidence; the diff stays the minimal six-site token swap + its coupled test.
|
Thanks for this fix, @tmack8001! Closing it because the change has already landed on main. #21483 (merge commit 4630066) switched the Schedule page and ScheduleTemplateGallery warn notes and badges from |




Problem / Motivation
Goal: Make the Schedule page's "Agent requested secrets" warn note readable in the default dark Kiro theme.
When a job has a pending secret-request approval, the warn note renders its text near-black on the dark warn tint: the title, the direction caption, the env ← vault list, the help paragraph and the "Script this approval covers" heading are all effectively unreadable in dark mode.
Why it matters
The secret-request note is a security-relevant approval surface — it tells the user which vault secrets a job will receive. In the default dark theme its text is dark-on-dark, so the person deciding whether to approve cannot read what they are approving without switching themes.
Not a goal
--warn-textvalue it already established (the light text does shift from the old--warn-fg, by design — that is fix(ui): keep warn text readable on warn tints in light palettes #20184's value, not a regression).bg-warn-subtle): the fill does not change.bg-warnbuttons/badges withtext-warn-fg: already correct black-or-white on the saturated hue, left unchanged.What changed (motivation → approach → change)
The note paints its text with
text-warn-fg, which resolves to--warn-fg—#000in every dark palette, meant for a saturatedbg-warnfill, not for the translucentbg-warn-subtletint over a dark surface. So the text came out black on dark.The fix swaps
text-warn-fgfortext-warn-texton everybg-warn-subtlecontainer carrying this defect.--warn-textisvar(--warn)at:root(the readable warn hue) and darkens tocolor-mix(warn 50%, #000)only under[data-mode="light"], so dark mode now paints the warn hue and light mode keeps #20184's darkened value. This is the same utility #20184 established for warn-text-on-warn-tint across the dashboard.The sites are six, across three files, all
bg-warn-subtle+text-warn-fg, all the same defect: the Schedule page's pending-secrets note, its "writes to your repos" badge, and the job-dialog writes notice (SchedulePage.tsx); the same writes badge in the schedule template gallery (ScheduleTemplateGallery.tsx); and the auto-nudge status line and legacy-loop notice (AutoNudgePopover.tsx). Othertext-warn-fguses in the tree sit on a solidbg-warnfill, where it is correct, and are left unchanged.Backwards compatibility
Compatible: a CSS utility-class swap on six elements across three files; no contract, prop, type or data shape changes.
Removes nothing: no path, record, key, validator or function is removed or tightened — six class strings change value.
Tests
No new automated test — the change is a painted-colour utility value that unit tests do not assert. The existing
website/src/pages/SchedulePage.secrets.test.tsx(6 tests) still passes, andwebsite/src/test/SessionAutomationPopover.test.tsxis updated in this PR: its assertion pinning the legacy-notice's oldtext-warn-fgnow assertstext-warn-text(the intentional swap; the warn hue the test guards as the cost cue is preserved — only the token that makes it readable in dark mode changes). The before/after screenshots below are the readability evidence.Note: the earlier revision carried a one-off Playwright capture script that only drove the local session to produce these screenshots. It was session scaffolding, not a maintained repo harness, so it has been removed; the uploaded screenshots are the deliverable.
Manual verification
Captured the before/after panes against the production build (see Screenshots). Static gates (isort, flake8, mypy --platform linux, tsc) pass, and the
SchedulePage.secrets+SessionAutomationPopovervitest suites (107 tests) pass locally.Screenshots / video
Real pane, full application chrome: the actual
/schedulejob dialog with the "Agent requested secrets" note, reached through the genuine flow (a real script cron carrying a real pending secret request), both themes. Secret/env names are generic placeholders (EXAMPLE_API_TOKEN/example_api_token).Before —
text-warn-fg, the note's text is near-black on the dark warn tint (dark mode):After —
text-warn-text, readable:Light theme (keeps #20184's darkened value)
Before (light):
After (light):
Related Issues
Closes #21057
Pattern harvest
Rule candidate: review-prompt
Pattern:
text-warn-fg(the on-solid foreground,#000in dark palettes) paired with abg-warn-subtle/bg-warn/Ntint instead oftext-warn-text— dark-on-dark in dark mode. #20184 fixed the light-palette half fortext-warn; this is the dark-modetext-warn-fgsibling.Checklist