Repository navigation
fix(session-control): backport worker template selection - #21085
Closed
luisgabriel wants to merge 1 commit into
Closed
luisgabriel wants to merge 1 commit into
luisgabriel wants to merge 1 commit into
Conversation
Backport the explicit template namespace used by conductor worker dispatch to the maintained 0.9 release line. Preserve member-first bare-name resolution and private-memory delegation refusal. (cherry picked from commit 870140d)
luisgabriel
force-pushed
the
backport/0.9.0-session-agent-kind
branch
from
October 16, 2026 17:37
9a6fb42 to
a8cd99d
Compare
Author
|
Closing this release-branch backport because the fix is already merged on main and we can wait for the next regular release. We also validated the change end to end with a temporary hot patch on 0.9.0.4; the previously blocked nested conductor dispatch succeeded while preserving the intended template selection path. Thanks for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Enable maintained 0.9 installations to dispatch nested conductor workers without weakening private-memory isolation.
A conductor that explicitly intends to start the shared
kirocrew-workertemplate is currently blocked when a private crewmate has the same name, because bare agent-name resolution remains member-first.Why it matters
Nested conductors on the 0.9 release line cannot create leaf workers in this valid same-name configuration, so delegated goal execution stops before work begins.
Not a goal
What changed (motivation → approach → change)
The failure comes from an ambiguous bare agent name, so this backports the explicit
templatenamespace from #18454 instead of relaxing the memory fence.src/kiro_crew/dashboard/handlers/session_control.pyandsrc/kiro_crew/dashboard/session_control.pyvalidate and carryagent_kind;src/kiro_crew/mcp_dashboard.pyexposes and forwards it; andsrc/kiro_crew/validation.pyapplies the closed-set schema.src/kiro_crew/agent.pypersists the resolved namespace in slot birth metadata, whilesrc/kiro_crew/builtin_skills/goal-conductor/SKILL.mdmakes conductor dispatch explicit.src/kiro_crew/docs/session-control.mdand the system specification document the contract. Bare names remain member-first and delegation refusals remain fail-closed. Release-specific generated conductor digests were regenerated from the 0.9 materializer.Backwards compatibility
Compatible:
agent_kindis optional, so existing session-create callers keep their current behavior; the new value only disambiguates an explicit template selection.Removes nothing: the backport adds a namespace selector and preserves all existing bare-name behavior.
Tests
loadgrouprepetitions.mypy,flake8, changed-fileisort, documentation, repository policy, and Semgrep 1.78 checks pass.Manual verification
N/A — the behavior is exercised through the real resolver plus HTTP and MCP boundaries, with deterministic repeat coverage.
Screenshots / video
N/A — this is a backend session-control and agent-prompt backport with no rendered UI change.
Related Issues
Part of #18204
Backport of PR #18454 (
870140d712b1360b5a4ff1580418013cc1d739ae).Pattern harvest
Rule candidate: review-prompt
Pattern: When private members and shared templates can share a name, privileged dispatch must select the intended namespace explicitly rather than weakening isolation or relying on fallback order.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of
CONTRIBUTING.md.