Repository navigation
feat(app-sdk): ChatEmbed re-reads its slot on a host push signal - #21109
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes when [UX-REVIEWED] d5825ca Description read[DESCRIPTION-READ] 0606d879ce93355c3b57d83b6c8f87032ecb6592f8bc9d1536fd6946c29111db That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The one open question is whether the base RFC covers "push over poll". It is listed as Notes
Inventory (7 items) — 6 justifiedIntent: an app's embedded chat should show a streaming reply live, the way the dashboard does. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] d5825ca Description read[DESCRIPTION-READ] 9b789ab3b6c47d236ddba5b6ab37708380e91c0ae60d8d12518adea884c24ef4 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The signal carries no content, ownership is checked against the gateway's own-slot set, and any slot that is not signalled falls back to the existing poll. Notes
[DESIGN-REVIEWED] d5825ca Description read[DESCRIPTION-READ] 2194a6610fdefcf86ff4b46a43806687a9cad3718933ac6ecc435072abc1364e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] d5825ca Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
25bdcdf to
50621c9
Compare
|
Review dispositions for Opus BLOCKING — Opus FINDING / Design CONCERNS — "socket up" read as "my slot is covered". Fixed at the source as Design suggested: First Principles item 8 — IncidentChat wiring that never fires. Removed: First Principles item 5 — barrel export with no consumer. Removed as above (types kept, reason given). CI reds on the old head: |
50621c9 to
fc492c5
Compare
|
First Principles on
E2E (stub ACP backend, offline) on |
|
First Principles on
If the owner prefers push as an extra on top of the unchanged poll, the subtraction listed in the verdict is mechanical and I can make it; until then this stays as the brief specified. |
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at fc492c5.
Blocking: a renamed or auto-titled slot now shows its old title for longer. SLOT_CHANGE_FRAMES leaves out slot_title, but the embed header renders shown?.title from the slot read. While the channel is up, the idle poll is 15 s, so the title can lag up to 15 s where main lags 5 s. Smallest fix: add slot_title to the set, and read data.key when data.slot is absent in noteAppSlotFrame. slot_title carries its slot in key (ws_event_scope.py). Add a case to appSlotPush.test.ts and let test_app_slot_push_frames.py pin the new entry.
Also needs a reply on this head:
- Design Watch: a streamed reply can drive about 4 slot reads per second per embed (250 ms gap), against 1 per second on main. The description still says push makes an open embed cost less. State the streaming cost and why it is acceptable, or tune the gap.
- Design punchline: confirm that Spec Builder slots appear in
dashboard.slotswithappset. The backend does create them withapp=spec-builder, but nothing shows the store list carries it. - UX punchline: the body says a live Spec Builder stream was never checked. A short manual check, or a reply saying why it is not needed, clears it.
The First Principles backstop concern has a reasoned reply. Whether to keep the slower backstop is the owner's call. All checks on this head are green.
— crew-pr-reviewer (r107)
bolichen97
left a comment
There was a problem hiding this comment.
Not ready yet. The push seam is a good shape: the signal carries nothing, the slot read stays the only permission gate, and test_app_slot_push_frames.py pins the frame set against ws_event_scope.
Head reviewed: fc492c5. Bots read: Design PASS, First Principles CONCERNS, UX PASS, Opus no blocking, GPT no blocking, readiness action required.
🔴 0 must-fix · 🟡 1 should-fix (inline, on ChatEmbed.tsx).
I agree with the open slot_title point from the earlier review on this head. I checked it: ws_event_scope.py reads the slot from key for slot_title, and noteAppSlotFrame reads only data.slot, so both the set and the key lookup need the change. The Design Watch item (about 4 reads per second per embed while streaming) and the unverified live Spec Builder check also still need a reply on this head.
Verified: every frame in SLOT_CHANGE_FRAMES is slot-scoped in the gateway gate and carries slot; ownership is read at delivery; no file hits the security path list; main does not contain this change.
| refetchInterval: (query) => embedPollInterval( | ||
| query.state, | ||
| embedOutageMs(failureRunsRef.current, `${String(query.queryKey[1])}:${String(query.queryKey[2])}`, query.state), | ||
| pushLive && (slotPush?.connected(slotKey) ?? false), |
There was a problem hiding this comment.
🟡 A slot that is listed after the embed mounts never moves to the backstop cadence.
pushLive is set from connected(slotKey) at mount and is changed again only by onConnection, which fires only when the socket goes up or down. If the slot is not yet in dashboard.slots at mount (for example a spec chat created just before the embed renders), pushLive is false. When the slot list later carries it, connected(slotKey) turns true, but pushLive && connected(slotKey) stays false until the next reconnect. Push signals still arrive, so nothing breaks, but the poll keeps its 1 s / 5 s cadence on top of the push reads.
pushLive && (slotPush?.connected(slotKey) ?? false),Why it matters: the spec section added here says the embed reads connected(slotKey) again at each tick and moves cadence on the next tick. That holds for a slot that leaves the app, not for one that arrives. A new chat is a common Spec Builder path, so the lower idle cost does not apply there.
Suggestion: use slotPush?.connected(slotKey) ?? false alone for the cadence, and keep pushLive only as the state that makes a connection change re-render. Add a case beside "returns to the normal cadence when the slot stops being signalled mid-life" where the slot becomes signalled after mount and the idle poll moves to 15 s. If Spec Builder always has the slot in the list before the embed mounts, say so and I will withdraw this.
Rule: SAGE description and diff fidelity; docs/system-specs/modules/app-kit-platform.md (ChatEmbed live updates)
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: Fixed in 64f921b. The poll cadence now reads slotPush?.connected(slotKey) alone at each tick, so a slot listed after mount moves to the 15 s backstop with no reconnect. The pushLive state only re-renders on a connection change. New test: "moves to the backstop once a slot listed after mount becomes signalled" (red before the fix). The spec sentence is updated.
fc492c5 to
64f921b
Compare
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: Reply to @iamwhatever's review (r107, at fc492c5) and @bolichen97's review, now on head 64f921b (rebased onto current main, still two commits). Blocking: Design Watch: streaming read rate (cost stated, gap kept). While a reply streams, one embed reads up to 4 times a second, not once. Each read is the since-cursor delta: only the rows after the held cursor. Idle, an embed reads once per 15 s, not once per 5 s. The 250 ms gap is the cost of the PR's goal, showing a reply as it is written. A 1 s gap would make streaming no faster than the poll. The PR body no longer says an open embed simply costs less. It now states both rates, and the spec section records the cost. Design punchline: Spec Builder slots in UX punchline: live Spec Builder stream (not run; reason). I did not run a live dashboard on this host. Push changes only when the embed reads. What it reads and renders is the same read and the same rows as without push. That timing is pinned by @bolichen97 inline ( First Principles backstop: unchanged. Left for the owner, as the review says. Re-requesting review. |
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: First Principles CONCERNS on 64f921b. The two description claims did conflict: "push only adds reads" is gone from Backwards compatibility. It now says push adds reads while the slot changes and the poll slows to the 5 s / 15 s backstop while it does not. The backstop itself is unchanged on this head. The maintainer review (r107) left keeping it as the owner's call, and the earlier reasoned reply still stands, so this is not overridden and not removed here. The idle saving it buys: one embed reads 4 times a minute instead of 12. |
be5c781 to
2a840f6
Compare
|
HOLD at 2a840f6, on an active change request only. The code looks sound. The blocker from my r107 change request is fixed: Blocker: @bolichen97's CHANGES_REQUESTED review at f41f01c is still the active review state. Their later COMMENTED reviews say the hidden-page hold is addressed, but a comment does not clear a change request. What clears this: @bolichen97 approves or dismisses that review. Optional: Design suggests one spec line saying a slot not yet in — crew-pr-reviewer (r127) |
CrysisDeu
left a comment
There was a problem hiding this comment.
Review at 2a840f64: Approve (code-level)
Head is a pure rebase of ea316c48 (range-diff =), the last head @bolichen97 reviewed. Every item from bolichen97's three rounds is resolved or explicitly accepted at this head — the post-mount backstop move (ChatEmbed.tsx:466), slot_title in SLOT_CHANGE_FRAMES read from key (appSlotPush.ts:28-43), the reverse frame check with _READ_UNCHANGED, hidden-page reads held behind one pending bit (ChatEmbed.tsx:495-545, four tests), and the api-reference.md:280 rewording. Boundary check: there is no cross-frame channel — AppHost mounts in the same React tree, the vendored iframe SDK gets no slotPush, the signal carries no arguments, every row still comes from the scoped slot GET with permissions.api applied, and test_gateway_admits_push_frame_for_own_slot_only pins the frame set both ways. Storm handling (one in flight + one trailing, 250 ms) is pinned. CI and all AI lanes green; MERGEABLE.
One MINOR, fine as a follow-up: ChatEmbed.tsx:499-519 — push reads ignore status === 'error', so a failing slot read with frames still arriving is re-read up to 4/s while the poll alone would back off to 30 s, and api-reference.md:193,311 promise back-off "whether or not a channel is up". Skip or space push reads while the query is in error, plus a test.
Note: this approval does not clear the two stale CHANGES_REQUESTED (bolichen97 at f41f01c8, iamwhatever at fc492c57); both reviewers said their blockers are fixed, so each needs to approve or dismiss their own.
Posted by code-reviewer (Kiro Crew member) on behalf of @CrysisDeu. Full report on file.
2a840f6 to
010d0fa
Compare
CrysisDeu
left a comment
There was a problem hiding this comment.
Approve at 010d0fad (re-approval after rebase).
010d0fad is a pure rebase of 2a840f64 (which I approved at 02:46Z) to clear a merge conflict: commit 2 identical, commit 1 differs by one context line in useWebSocket.ts. No new code.
Security re-checked at this head: no cross-frame channel is added (no postMessage/message listener); the push signal comes from the dashboard's own authenticated /api/ws socket and flows via React context, so the vendored iframe SDK never receives it. Slot ownership is re-read from store.dashboard.slots on every frame (utils/appSlotPush.ts:61-73); the signal carries no payload, so every row still comes through the app's scoped GET and deny_app_slot_access stays the only gate. Frame set pinned both ways by test/test_app_slot_push_frames.py. 97 checks pass, readiness passed; the one red row is a Sensitive Change Review run cancelled by the review dismissal, and its re-run on this head passed. No BLOCK overridden.
What still blocks auto-merge is not code: @bolichen97's CHANGES_REQUESTED at f41f01c8 and @iamwhatever's at fc492c57 are still standing although both of you wrote that your points are fixed. Please dismiss them (or re-review), and resolve the 2 open inline threads bolichen97 already confirmed.
Carry-over MINOR, fine as a follow-up: website/src/app-sdk/ChatEmbed.tsx:499-518 push run()/schedule() never checks query.status === 'error', so while the slot read fails and frames keep arriving it re-reads up to 4/s where embedPollInterval (:366-372) would back off; docs/app-kit/api-reference.md promises back-off "whether or not a channel is up".
Posted by code-reviewer (Kiro Crew member) on behalf of @CrysisDeu. Full report on file.
iamwhatever
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES at 010d0fa.
The head is a pure rebase of 2a840f6, which r127 found sound: the changed lines are identical, all AI lanes pass with no findings, and every workflow on this head is green (the cancelled Sensitive Change Review runs were superseded by a passing one).
One follow-up is open without a reply or an issue. @CrysisDeu noted that push reads ignore a failing query: run()/schedule() never check status === 'error', so while the slot read fails and frames keep arriving, the embed re-reads every 250 ms, where embedPollInterval backs off to 30 s. Either skip or space push reads while the query is in error, with a test, or open an issue for it and link it in the description.
Also still blocking merge: @bolichen97's CHANGES_REQUESTED review at f41f01c is active. Their later comments say it is addressed, but they need to approve or dismiss it.
— crew-pr-reviewer (r129)
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#ce473fca]: Reply to @iamwhatever's r129 review at Push reads ignore a failing query (raised by @CrysisDeu): fixed in this PR, head
Local runs: the 21 ChatEmbed/appSlotPush frontend test files (279 tests) and @bolichen97's CHANGES_REQUESTED at |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed at ac88ecd.
Range-diff against 010d0fa: the first commit is unchanged; the second commit adds one change, the push loop now skips reads while the slot query is in error.
This resolves the follow-up from the latest change request. failing() is checked in both schedule() and run(), so neither a change signal, a connect, nor a timer that was already armed can send a read while the query status is error. A failed in-flight push read that had dirty set falls back to schedule(), which also returns early, so there is no retry loop at the 250 ms gap. Recovery stays with embedPollInterval and its back-off, and the new test covers both halves: eight frames during the outage send no read, and a signal after the poll recovers reads again at once. The spec paragraph matches the code.
One non-blocking note: a signal dropped while a poll is already in flight can be answered by that poll's response, which was requested before the change. After recovery the change then shows on the next backstop read (5 s running, 15 s idle) rather than immediately. That bound is acceptable for an outage path, so I am not asking for a change.
No blocking findings from me on this head. My earlier change request from f41f01c is addressed by the later heads; I am leaving this as a comment because another reviewer's change request is still open on the PR.
CrysisDeu
left a comment
There was a problem hiding this comment.
Approve at ac88ecd7 (third approval; the two earlier ones were dismissed by pushes).
Delta since 010d0fad is +34 lines: failing() in website/src/app-sdk/ChatEmbed.tsx:503 stops push reads while the slot read is in error, with a test and a spec line. That closes the one carry-over MINOR from my earlier reviews. The security invariants are untouched by the delta: no cross-frame channel, slot ownership re-read on every frame (utils/appSlotPush.ts), empty signal, frame set pinned by test/test_app_slot_push_frames.py. CI green on this SHA; the red row is a cancelled Sensitive Change Review run superseded by a passing one.
Optional follow-up: a socket reconnect during an outage is now dropped too, so recovery after a long outage can lag up to 30 s. Letting a connect send exactly one read would close that.
Auto-merge still waits on two stale blocks that both reviewers have said are addressed: @iamwhatever at 010d0fad and @bolichen97 at f41f01c8. Please dismiss.
Posted by code-reviewer (Kiro Crew member) on behalf of @CrysisDeu. Full report on file.
|
HOLD at ac88ecd, on an active change request only. The r129 item is fixed: Still blocking merge: @bolichen97's CHANGES_REQUESTED review at f41f01c is active. Their review at this head says it is addressed, but a comment does not clear it. @bolichen97, please approve or dismiss it. PR Readiness is also still pending on this head. — crew-pr-reviewer (r131) |
The dashboard socket signals an app embed when a frame changes a slot the app owns; the embed issues its since-cursor read at once and polls only as a backstop while the channel is up. The signal is content-free, so the scoped read stays the permission gate.
connected(slotKey) and onConnection now report live only while the socket is up AND the slot is the watching app's, so an unowned or unlisted slot keeps the 1 s / 5 s cadence. The embed re-reads that at each poll tick. useSlotPush and the SlotPush types leave the public barrel, and IncidentChat no longer wires a channel that never signals its slot.
|
HOLD at d5825ca, on an active change request only. This head is a pure rebase of ac88ecd: the second commit is identical, and the first changes only the import and context lines main moved in Still blocking merge: @bolichen97's CHANGES_REQUESTED review at f41f01c is active. Their review at ac88ecd says it is addressed, but a COMMENTED review does not clear a change request. @bolichen97, please approve or dismiss it. AI findings judged non-blocking:
— crew-pr-reviewer (r133) |
Problem / Motivation
Goal: An app's embedded chat (
ChatEmbed) shows a streaming reply as it is written, like the dashboard chat, instead of catching up once per poll.ChatEmbedlearns about new rows only from its poll: one read per second while a turn runs, one every five seconds when idle. A reply in a Spec Builder chat therefore arrives in one-second jumps, and a new message or approval on an idle slot can take up to five seconds to appear. The dashboard chat, mounted on the same session, updates live from/api/ws.Why it matters
Every app that embeds a chat looks laggier than the dashboard for the same session, and the idle poll is the floor on how fast a person sees an approval card in an app. A live update also lets the poll back off while nothing changes, so an idle open embed reads a third as often (once per 15 s, not once per 5 s). While a reply streams it reads more: up to four since-cursor delta reads a second, not one, each carrying only the rows after the held cursor.
Not a goal
chat_*frame payloads insideChatEmbed. Rows still come only from the slot read.slots:user,slots:all,slots:app:<name>visibility). Those keep polling.useAppEvents(AppHost'ssubscribeFnis unchanged)./api/ws, the event scope gate, or the slot-detail read.What changed (motivation → approach → change)
Goal → push the change, not the content. The RFC's P5-f row (
docs/request-for-change/rfc-chat-core-extraction.md) chose the since-cursor poll over the WebSocket stream because foldingchat_*frames needs a store-free copy of the chat frame reducer and aslots:*event grant. Both costs come from sending frame CONTENT to the app. A content-free "this slot changed" signal needs neither: the embed answers it with the same incremental read it already makes, so the read's checks (permissions.api,deny_app_slot_access) keep deciding what the app sees. The session list already works this way (mc:app:slotsinhooks/websocket/slotList.ts).How app event access is gated today: an app token's
/api/wssocket receives slot-scoped events for slots it owns with no declaration (ws_event_scope._slot_visible); wider scopes needslots:*. In-host apps do not hold an app token: they run in the dashboard and fetch with the dashboard user's session, andAppHost'ssubscribeFndelivers nothing from the socket. So the boundary for this change is client-side, and it is drawn at exactly the gateway's no-declaration set.app-sdk/slotPush.ts(new): theSlotPushseam on the SDK context —watch(slotKey, {onChange, onConnection})andconnected(slotKey), both live only while the socket is up AND the slot is the watching app's — and an internaluseSlotPush(). Neither the hook nor theSlotPushtypes are on the public barrel.AppScopedApiProvider/AppApiProvidertake it as an optionalslotPushprop. A host that passes none (the vendored iframe SDK, session controls) is unchanged.utils/appSlotPush.ts(new): the dashboard's provider.useWebSocketfeeds it every decoded frame;markGatewayConnected/markGatewayDisconnectedfeed it the connection flag. It signals an app only for a frame inSLOT_CHANGE_FRAMESwhose slot'sChatSlot.appis that app, ownership read at each delivery.slot_titleis in the set (the embed header shows the read's title) and is read fromkey, as the gateway gate reads it. The signal has no arguments.ChatEmbed: a signal re-reads at once; signals during an in-flight read collapse into one trailing read, at least 250 ms after the last, joining (not aborting) an in-flight request. Each connect, reconnects included, re-reads once. While the page is hidden (React Query'sfocusManager) or the host tab is inactive (info.active === false) no push read is sent: signals only mark one read pending, sent once both are visible. The poll itself pauses only for a hidden page; an inactive host tab keeps its cadence, as on main. While the channel is up and reads succeed the poll is a 5 s / 15 s backstop. A failing read ignores the channel and keeps the 1 s / 5 s cadence and the outage back-off, so the stalled-connection notice still appears 10 s into an outage even when the socket is up (a deleted session or lost access fails the read, not the socket).AppHostandSpecBuilderPagepassuseAppSlotPush(<app>). Spec Builder's slots are app-owned, so it gets live updates.IncidentChatpasses none: its incident slot is created by the genericPOST /api/chatand is unowned, so it keeps the full 1 s / 5 s poll. Any embed on a slot the host does not signal keeps that cadence, sinceconnected(slotKey)readsfalsefor it.docs/app-kit/api-reference.md(Live updates, polling),docs/system-specs/modules/app-kit-platform.md(new ChatEmbed live updates section),history.md(the delta read's caller), the RFC table.No new permission is needed: the provider never signals outside the gateway's own-slot default, and
test/test_app_slot_push_frames.pypins that set againstws_event_scope.Backwards compatibility
Compatible:
slotPushis an optional new prop and context field; without it every embed polls exactly as on main, and no API, permission, or wire format changes.Removes nothing: the poll, its cadence without a channel, the stall notice and the read path all remain. With a live channel, push adds reads while the slot changes, and the poll slows to the 5 s / 15 s backstop while it does not.
Tests
website/src/test/ChatEmbed.pushRead.test.tsx: a signal re-reads before the poll would; ten signals during an in-flight read give one trailing read; the idle poll is 15 s while the channel is up and 5 s once it drops; reconnect re-reads once; no host channel polls at 5 s; a failing read under a live channel still shows the stalled notice withinEMBED_STALL_MS; a slot that becomes signalled after mount moves to the 15 s backstop with no reconnect; a hidden page sends zero reads under 20 signals and a reconnect, then one catch-up read on focus; a read scheduled just before the page hides is held until focus returns; an inactive host tab sends zero reads, then one when it turns active; focus returning with nothing pending sends nothing;embedPollIntervalunit cases. Mutations checked: lettingpushedoverride the error cadence reddens the stall test and its unit case; removing the in-flight coalescing reddens the burst test; removing thefocusManagersubscription reddens the two hidden-page tests, removing the visibility check in the timer callback reddens the held-read test, and removing the host-active flush reddens the inactive-tab test.website/src/test/appSlotPush.test.ts: own slot signalled with no payload; aslot_titleframe signals throughkey, andkeyis not read for frames that useslot; another app's slot, an unowned slot and an unlisted slot are not; ownership change stops signalling; non-change frames and malformed frames ignored; unwatch; connectivity fan-out including repeatedtrue; the socket router calls it before its switch. Mutation checked: dropping the ownership comparison reddens two cases.website/src/hooks/websocket/gatewayConnectivity.test.tsx: the connect/disconnect helpers move the push flag too.test/test_app_slot_push_frames.py: every name in the client'sSLOT_CHANGE_FRAMESis slot-scoped and outside the subagent family inws_event_scope, and the gateway admits each for an own slot with no declaration and refuses it for another app's or a person's slot;slot_titleis in the set and is checked with its slot inkey.Local: scoped frontend suite 12224/12224,
tsc, fulleslint src/,i18n:check,jscpd,build, docs lint, comment-history, file-line-cap, feature-map gates pass. The backend related run on this host had 74 failures in unrelated modules (test_file_explorer_app.py,test_design_tweak_devproc.py, steering/skill projection) that read host paths; this diff adds no backend source.Manual verification
Not done in a running dashboard; behaviour is covered by the unit tests above. Checked on the backend: a slot made by
get_or_create_slot(app="spec-builder")(the Spec Builder runtime's call) is inserialize_slots()withapp: "spec-builder", which is what the provider's ownership check reads fromdashboard.slots. Unverified end to end: that a Spec Builder chat in a live dashboard streams visibly faster.Screenshots / video
Why no screenshot: nothing on screen changes shape or style; the embed shows the same rows sooner, which a still image cannot show and the unit tests pin by read timing.
Related Issues
Closes #24130
Refs the chat-core extraction RFC, phase P5-f (
docs/request-for-change/rfc-chat-core-extraction.md).Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.