Repository navigation
fix(dashboard): retry a failed recents read in the project picker - #21148
Conversation
The picker now says the recents list could not be read instead of silently falling back to Browse, and pairs that notice with a Retry that re-reads it. (cherry picked from commit e2d9750)
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 56b2107 Description read[DESCRIPTION-READ] d358f9f1f78216c77e4b0d10a6a1c016a901aec4e9ab3d5d3c191a6e918b137f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check before merge: the favourites read ( What this change shipsInventory (4 items) — 4 justifiedIntent: when the recent-projects read fails, the user can re-read it from inside the picker instead of closing and reopening it. This is an ADDITION: a new control, though the title calls it a fix.
[FIRST-PRINCIPLES-REVIEWED] 56b2107 Description read[DESCRIPTION-READ] c815977b4a916464460774e247c75843f58f33ae0873d37d6416ecc9730b3971 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check one thing before merge: no screenshot shows the recents Retry's inert "Retrying…" state, or the notice coming back after a second failed read. [UX-REVIEWED] 56b2107 Description read[DESCRIPTION-READ] adfd3c1eb4fb547374afac8087d2242fdc5037863254ff634571b312ce700bb1 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Drop the holdTab landing-tab guard: it changes how the opening read lands, which the Retry never settles, so it belongs in its own change. Also drop the Recent-row commit guard: every recents failure clears the rows first, so no row exists for it to block. (First Principles review on #21148.) Co-authored-by: rnoack1 <69695077+rnoack1@users.noreply.github.com>
b05ddcd to
56b2107
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds a Retry for a failed recents read on the project picker Browse notice, with tests; no change to other reads.
Problem / Motivation
Goal: When the project picker cannot read the recent-projects list, the user can re-read it from the picker itself instead of closing and reopening it.
Main already names a failed recents read (#7068 added
recentFailureand the notice on both tabs). But the notice has no way to ask again: the only recovery is to close and reopen the popover, which re-runs the same read with no hint that a read is what failed. The listing notice beside it has a Retry; the recents notice does not.Why it matters
A gateway hiccup at open time leaves the Recent tab empty for the whole session of that popover. Users who rely on recents must guess that a close/reopen will fix it.
Not a goal
useQuerymigration of the recents read.What changed (motivation → approach → change)
Replaces #10842 by @rnoack1, carried onto current main with authorship kept (commit 1 is a
cherry-pick -xof the fork's commit, authored by rnoack1). The naming half of the fork already landed on main via #7068, so only the retry half is new here.retryRecentsre-reads the recents list under a freshrecentSeqticket, so a reply after a reopen cannot paint over a newer read. It never settles the landing tab.noticeRetry): the listing read as before, or the recents read. Same inert-but-focusablearia-disabled"Retrying…" pattern as the listing Retry.holdTablanding-tab guard (a separate behaviour on the opening read, which Retry never settles; it can ship on its own) and a Recent-row commit guard that could never fire (every recents failure clears the rows first).Backwards compatibility
Compatible: adds a Retry; every existing picker path behaves as before.
Removes nothing: the change only adds a re-ask of the recents read; no field, key, row or function is removed.
Tests
website/src/test/ProjectPicker.recentsRetry.test.tsx(4 cases): Retry re-reads and drops the notice; a failed re-ask keeps the notice and re-enables Retry; "Retrying…" is inert and a second press sends nothing; no Retry on the Recent pane.Local:
npx vitest run src/test/ProjectPicker src/test/FolderConfigModal src/test/WorkspacePicker src/test/ImeEnterGuard→ 13 files, 339 tests pass.tsc -p tsconfig.app.jsonclean;eslintclean on both touched files.Manual verification
Rendered the real
ProjectPickerin an isolated Vite capture entry (same shape aswebsite/capture/favorites-picker.tsx) with the firstrecentProjectscall rejecting and later calls answering, then drove it with Playwright. Before =origin/main's component, after = this branch.Screenshots / video
Before (main): the recents failure is named on Browse, but there is no way to re-ask.
After: the same notice carries a Retry.
After pressing Retry: the notice clears and the Recent tab shows the rows.
Light theme
Related Issues
Replaces #10842. No linked issue.
Credit: @rnoack1 wrote the retry, the tab guard and the test suite in #10842; this PR carries their work onto current main.
Pattern harvest
Rule candidate: lint
Pattern: a list read with a failure notice but no re-ask, so the only recovery is remounting the surface; the fork's own harvest also names
.catchhandlers onapi.*calls that drop the rejection.Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.