Skip to content

fix(dashboard): retry a failed recents read in the project picker - #21148

Merged
KiroCrewCaptain merged 2 commits into
mainfrom
replace/10842
Oct 16, 2026
Merged

KiroCrewCaptain merged 2 commits into
mainfrom
replace/10842

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When the project picker cannot read the recent-projects list, the user can re-read it from the picker itself instead of closing and reopening it.

Main already names a failed recents read (#7068 added recentFailure and the notice on both tabs). But the notice has no way to ask again: the only recovery is to close and reopen the popover, which re-runs the same read with no hint that a read is what failed. The listing notice beside it has a Retry; the recents notice does not.

Why it matters

A gateway hiccup at open time leaves the Recent tab empty for the whole session of that popover. Users who rely on recents must guess that a close/reopen will fix it.

Not a goal

What changed (motivation → approach → change)

Replaces #10842 by @rnoack1, carried onto current main with authorship kept (commit 1 is a cherry-pick -x of the fork's commit, authored by rnoack1). The naming half of the fork already landed on main via #7068, so only the retry half is new here.

  • retryRecents re-reads the recents list under a fresh recentSeq ticket, so a reply after a reopen cannot paint over a newer read. It never settles the landing tab.
  • The Browse notice's Retry button now serves whichever read the notice names (noticeRetry): the listing read as before, or the recents read. Same inert-but-focusable aria-disabled "Retrying…" pattern as the listing Retry.
  • Commit 2 (co-authored) narrows the carried commit to the Retry alone. It drops the fork's holdTab landing-tab guard (a separate behaviour on the opening read, which Retry never settles; it can ship on its own) and a Recent-row commit guard that could never fire (every recents failure clears the rows first).

Backwards compatibility

Compatible: adds a Retry; every existing picker path behaves as before.

Removes nothing: the change only adds a re-ask of the recents read; no field, key, row or function is removed.

Tests

website/src/test/ProjectPicker.recentsRetry.test.tsx (4 cases): Retry re-reads and drops the notice; a failed re-ask keeps the notice and re-enables Retry; "Retrying…" is inert and a second press sends nothing; no Retry on the Recent pane.

Local: npx vitest run src/test/ProjectPicker src/test/FolderConfigModal src/test/WorkspacePicker src/test/ImeEnterGuard → 13 files, 339 tests pass. tsc -p tsconfig.app.json clean; eslint clean on both touched files.

Manual verification

Rendered the real ProjectPicker in an isolated Vite capture entry (same shape as website/capture/favorites-picker.tsx) with the first recentProjects call rejecting and later calls answering, then drove it with Playwright. Before = origin/main's component, after = this branch.

Screenshots / video

Before (main): the recents failure is named on Browse, but there is no way to re-ask.

Before: recents failure notice on Browse, no Retry (dark)

After: the same notice carries a Retry.

After: recents failure notice on Browse with Retry (dark)

After pressing Retry: the notice clears and the Recent tab shows the rows.

After Retry: Recent tab lists the recovered projects (dark)

Light theme

Before, light
After, light
After Retry, light

Related Issues

Replaces #10842. No linked issue.

Credit: @rnoack1 wrote the retry, the tab guard and the test suite in #10842; this PR carries their work onto current main.

Pattern harvest

Rule candidate: lint
Pattern: a list read with a failure notice but no re-ask, so the only recovery is remounting the surface; the fork's own harvest also names .catch handlers on api.* calls that drop the rejection.

Checklist

  • At most two commits, with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) — N/A
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

The picker now says the recents list could not be read instead of silently
falling back to Browse, and pairs that notice with a Retry that re-reads it.

(cherry picked from commit e2d9750)
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 56b21073073866aa58e20900902afe785cf58dd5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 56b2107

Description read

[DESCRIPTION-READ] d358f9f1f78216c77e4b0d10a6a1c016a901aec4e9ab3d5d3c191a6e918b137f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 56b21073073866aa58e20900902afe785cf58dd5 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check before merge: the favourites read (favoriteFailure, ProjectPicker.tsx:478) still has the same notice with no way to ask again. This PR fixes one of two siblings.

What this change ships

Inventory (4 items) — 4 justified

Intent: when the recent-projects read fails, the user can re-read it from inside the picker instead of closing and reopening it. This is an ADDITION: a new control, though the title calls it a fix.

  1. The Browse tab's recents-failure notice now has a Retry button that re-reads the list and clears the notice when the read succeeds — justified
  2. While the re-read is in flight, Retry shows an inert "Retrying…" and a second press sends nothing; the notice reports itself busy — justified
  3. Reopening the picker cancels a retry that is still in flight, so its late reply cannot paint over the newer read — justified
  4. A test pins that the Recent pane offers no Retry — justified

[FIRST-PRINCIPLES-REVIEWED] 56b2107

Description read

[DESCRIPTION-READ] c815977b4a916464460774e247c75843f58f33ae0873d37d6416ecc9730b3971

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 56b21073073866aa58e20900902afe785cf58dd5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check one thing before merge: no screenshot shows the recents Retry's inert "Retrying…" state, or the notice coming back after a second failed read.

[UX-REVIEWED] 56b2107

Description read

[DESCRIPTION-READ] adfd3c1eb4fb547374afac8087d2242fdc5037863254ff634571b312ce700bb1

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 56b21073073866aa58e20900902afe785cf58dd5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 56b2107

Verdict parsed from the review's SHA-scoped output markers for commit 56b21073073866aa58e20900902afe785cf58dd5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 56b21073073866aa58e20900902afe785cf58dd5: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 56b21073073866aa58e20900902afe785cf58dd5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 56b2107

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 56b21073073866aa58e20900902afe785cf58dd5: <one-sentence reason>

Drop the holdTab landing-tab guard: it changes how the opening read lands,
which the Retry never settles, so it belongs in its own change. Also drop
the Recent-row commit guard: every recents failure clears the rows first,
so no row exists for it to block. (First Principles review on #21148.)

Co-authored-by: rnoack1 <69695077+rnoack1@users.noreply.github.com>
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 16, 2026
@iamwhatever
iamwhatever marked this pull request as ready for review October 16, 2026 08:57
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 16, 2026 08:57
@iamwhatever
iamwhatever requested a review from buluoray October 16, 2026 08:57
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 16, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 16, 2026 10:06

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: adds a Retry for a failed recents read on the project picker Browse notice, with tests; no change to other reads.

@KiroCrewCaptain
KiroCrewCaptain merged commit 5c1f997 into main Oct 16, 2026
105 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the replace/10842 branch October 16, 2026 10:08
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants