Repository navigation
test: scan mcp_core's owners in the auth-coverage and bound scans - #21168
Conversation
mcp_core.py became a mirror facade over mcp_core_parts/ (#20555), but two universal source scans still read only mcp_core.py: the call-site auth-coverage walk (_SOURCES) and the synchronous tool-bound sweep in the inflight-report test. Code added later to an owner module would escape both. Join mcp_core_parts/*.py into each scan's file list; the assertions are unchanged.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 93358c9 Description read[DESCRIPTION-READ] 5939bea1947e0d0284d36b6fd90186a9a13eed8fd0a237083136ceb6fe61dfc3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change: the auth-coverage and bound scans now include the mcp_core_parts owner modules.
Problem / Motivation
Goal: Keep two repository scans covering all of
mcp_core's code now that it lives inmcp_core_parts/as well asmcp_core.py.#20555 turned
mcp_core.pyinto a mirror facade over owner modules inmcp_core_parts/. Two universal source scans still list onlymcp_core.py: the call-site auth-coverage walk intest/test_mcp_call_site_auth_coverage.py(_SOURCES) and the synchronous tool-bound sweep intest/test_mcp_gateway_inflight_report.py(_synchronous_tool_bounds). The Design review on #20555 raised this (suggestion span0f05171a2445).Why it matters
Nothing escapes either scan today: no owner holds a dashboard transport call or a
*_TIMEOUT_SECSbound. But the spec now sends new MCP plumbing to the owner modules, so the next transport call or timeout added there would be checked by neither scan, silently: an ungranted route or a bound that outlives the wedge ceiling would pass CI.Not a goal
What changed (motivation → approach → change)
Both scans now read
mcp_core_parts/*.pyalongsidemcp_core.py, globbed so a new owner module is scanned the day it is added, the same waytest_deploy_round15_fixes.pyalready joins the facade with its owners._SOURCESgains the owner glob;_synchronous_tool_boundsadds it to its file list. The assertions are unchanged.Backwards compatibility
Removes nothing: the change only adds files to two test scans; no product code, public name or behaviour is touched.
Tests
Mutation proof on main, both ways (each plant added to an owner, run with
-n0):_post("/api/scan-probe-ungranted-route", {})inmcp_core_parts/crew.pytest_every_resolved_path_is_grantedfails_SCAN_PROBE_TIMEOUT_SECS = 9999inmcp_core_parts/gateway.pytest_ceiling_outlives_every_synchronous_tool_boundfailsUnplanted, both files pass: 46 passed.
test_flake_pattern_ratchet(56 passed), black, isort, flake8, the comment-history and brand gates, semgrep andcheck_file_line_cap.pyare clean.Manual verification
N/A — unit coverage sufficient: the change is two test file lists, proven by the mutation table above.
Related Issues
Part of #20192
Follow-up to the Design review on #20555 (suggestion span
0f05171a2445).Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)