Skip to content

test: scan mcp_core's owners in the auth-coverage and bound scans - #21168

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/linecap-s10-scan-joins
Oct 16, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/linecap-s10-scan-joins

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Keep two repository scans covering all of mcp_core's code now that it lives in mcp_core_parts/ as well as mcp_core.py.

#20555 turned mcp_core.py into a mirror facade over owner modules in mcp_core_parts/. Two universal source scans still list only mcp_core.py: the call-site auth-coverage walk in test/test_mcp_call_site_auth_coverage.py (_SOURCES) and the synchronous tool-bound sweep in test/test_mcp_gateway_inflight_report.py (_synchronous_tool_bounds). The Design review on #20555 raised this (suggestion span 0f05171a2445).

Why it matters

Nothing escapes either scan today: no owner holds a dashboard transport call or a *_TIMEOUT_SECS bound. But the spec now sends new MCP plumbing to the owner modules, so the next transport call or timeout added there would be checked by neither scan, silently: an ungranted route or a bound that outlives the wedge ceiling would pass CI.

Not a goal

  • No production code change.
  • No change to what either scan asserts.
  • Not sweeping other split facades for the same pattern (tracked separately by the line-cap campaign).

What changed (motivation → approach → change)

Both scans now read mcp_core_parts/*.py alongside mcp_core.py, globbed so a new owner module is scanned the day it is added, the same way test_deploy_round15_fixes.py already joins the facade with its owners. _SOURCES gains the owner glob; _synchronous_tool_bounds adds it to its file list. The assertions are unchanged.

Backwards compatibility

Removes nothing: the change only adds files to two test scans; no product code, public name or behaviour is touched.

Tests

Mutation proof on main, both ways (each plant added to an owner, run with -n0):

Plant With this change Without it
_post("/api/scan-probe-ungranted-route", {}) in mcp_core_parts/crew.py test_every_resolved_path_is_granted fails passes (the plant escapes)
_SCAN_PROBE_TIMEOUT_SECS = 9999 in mcp_core_parts/gateway.py test_ceiling_outlives_every_synchronous_tool_bound fails passes (the plant escapes)

Unplanted, both files pass: 46 passed. test_flake_pattern_ratchet (56 passed), black, isort, flake8, the comment-history and brand gates, semgrep and check_file_line_cap.py are clean.

Manual verification

N/A — unit coverage sufficient: the change is two test file lists, proven by the mutation table above.

Related Issues

Part of #20192

Follow-up to the Design review on #20555 (suggestion span 0f05171a2445).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

mcp_core.py became a mirror facade over mcp_core_parts/ (#20555), but
two universal source scans still read only mcp_core.py: the call-site
auth-coverage walk (_SOURCES) and the synchronous tool-bound sweep in
the inflight-report test. Code added later to an owner module would
escape both. Join mcp_core_parts/*.py into each scan's file list; the
assertions are unchanged.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 16, 2026 08:33
@bolichen97
bolichen97 requested a review from buluoray October 16, 2026 08:33
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 93358c9834702ff3330e4cdb61a6052ee250f79f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 93358c9834702ff3330e4cdb61a6052ee250f79f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 93358c9834702ff3330e4cdb61a6052ee250f79f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 93358c9

Description read

[DESCRIPTION-READ] 5939bea1947e0d0284d36b6fd90186a9a13eed8fd0a237083136ceb6fe61dfc3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@bolichen97
bolichen97 enabled auto-merge (squash) October 16, 2026 08:35
@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 93358c9834702ff3330e4cdb61a6052ee250f79f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 93358c9

Verdict parsed from the review's SHA-scoped output markers for commit 93358c9834702ff3330e4cdb61a6052ee250f79f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 93358c9834702ff3330e4cdb61a6052ee250f79f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 93358c9834702ff3330e4cdb61a6052ee250f79f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 93358c9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 93358c9834702ff3330e4cdb61a6052ee250f79f: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 16, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change: the auth-coverage and bound scans now include the mcp_core_parts owner modules.

@bolichen97
bolichen97 merged commit 3a058bb into main Oct 16, 2026
101 checks passed
@bolichen97
bolichen97 deleted the refactor/linecap-s10-scan-joins branch October 16, 2026 10:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants