Repository navigation
fix(dashboard): say nothing is broken on the empty capped project tree - #21175
iamwhatever merged 1 commit into
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS This is a copy-only change to one catalog value: the key, the render condition and the testid stay the same, and committed before/after screenshots show the result. [DESIGN-REVIEWED] fc2e150 Description read[DESCRIPTION-READ] 1583d7bd985a51023bf4db6da317d779db95cf0586b9624bf1cfd268b65b9f1a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this is a one-sentence copy fix tracked by #21025. Every other file touched either pins that sentence or is the before/after evidence for it. What this change shipsInventory (5 items) — 5 justifiedIntent: let a user looking at an empty, capped project tree see that nothing is broken and what the limit counts. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] fc2e150 Description read[DESCRIPTION-READ] 09add5f9c92c9d0543bf88e209db63cc8da96d3537c44d97f0c83e51752840c8 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS The after screenshot (attachment-01) shows the one changed string. No first-time reader has seen it, because this fork lane has no blind read; pushing the branch to this repository would add one. Notes
[UX-REVIEWED] fc2e150 Description read[DESCRIPTION-READ] 721e4d36ad4d4b99cc64a5d41ae8429f98caf4657de8a74ffd220afe2ecb14f2 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
c3821be to
7e3be4b
Compare
7e3be4b to
df49deb
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 66a3d91.
One catalog value is reworded and translated in every locale; the spec quote, the capture-script assertion and the unit test pin the new sentence, and no key, testid or render condition changes. All current-head checks are green and no change request is active.
AI findings judged non-blocking
- Design Review: 'Nothing is wrong' only holds if
truncatednever marks a real failure. read failures go tounreadableDirectories, and the root notice keys ontruncatedfrom the scan budget only. - First Principles Review: sibling strings
row_truncated/workspace_truncatedstill say 'items'. those sit beside a visible tree whose rows are the items; wording nit, out of this PR's goal, no user harm.KiroCrew/website/src/i18n/locales/en.manual.json
Line 3886 in 66a3d91
- UX Review: 'project' here vs 'workspace' in
root_hidden_only/root_unreadable. word-consistency nit; each sentence is understandable on its own.KiroCrew/website/src/i18n/locales/en.manual.json
Line 3895 in 66a3d91
— crew-pr-reviewer (r145)
|
@leonlaiyc thanks, 66a3d91 is ready apart from one thing. Every check passes, including Sensitive Change Review, and all five AI review lanes pass. Main has since moved, though, and the branch now conflicts in |
66a3d91 to
7e5e806
Compare
When the project tree's payload is truncated with no row at all, the panel shows only one sentence in the tree's place. "Workspace too large to list: limit of 10,000 items reached" read as a failure, and "items" names nothing the user can see. The sentence now says nothing is wrong first and counts files and folders, keeping the limit as a parenthetical. It is translated in all twelve catalogs, en-XA is regenerated, and the spec and the frame-32 capture assertion quote the new wording. Closes kirodotdev#21025 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7e5e806 to
fc2e150
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (18 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: fix: the empty capped project tree copy says nothing is broken, in every locale, with the spec, test and capture script updated. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/learn-cron-dashboard.md.
#21175) When the project tree's payload is truncated with no row at all, the panel shows only one sentence in the tree's place. "Workspace too large to list: limit of 10,000 items reached" read as a failure, and "items" names nothing the user can see. The sentence now says nothing is wrong first and counts files and folders, keeping the limit as a parenthetical. It is translated in all twelve catalogs, en-XA is regenerated, and the spec and the frame-32 capture assertion quote the new wording. Closes #21025 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e6e1038)
#21175) When the project tree's payload is truncated with no row at all, the panel shows only one sentence in the tree's place. "Workspace too large to list: limit of 10,000 items reached" read as a failure, and "items" names nothing the user can see. The sentence now says nothing is wrong first and counts files and folders, keeping the limit as a parenthetical. It is translated in all twelve catalogs, en-XA is regenerated, and the spec and the frame-32 capture assertion quote the new wording. Closes #21025 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e6e1038)
Problem / Motivation
Goal: A reader of the empty capped project tree can tell that nothing is broken and what the limit is about, in words they already know.
When a project is too big for the tree's row cap and the payload has no row at all, the panel shows only "Workspace too large to list: limit of 10,000 items reached" in place of the tree. The UX Review of #21018 found that a blind reader could not tell whether something was broken, or what "items" means. #21018 added the next step under it ("Type a file name in the box above to find it.") and deliberately left this sentence alone, which is what #21025 tracks.
Why it matters
The state replaces the whole tree, so this sentence is the only thing on the panel. A user with a large repository opens the Files rail or the folder panel, sees a sentence about a limit with no folder and no file, and reasonably reads it as a failure. They may then file a bug, restart the gateway, or stop using the panel.
Not a goal
root_truncated_search_hint) or to the other truncation strings (workspace_truncated,row_truncated). Those sit beside a tree that does show rows, so the "nothing is broken" question does not arise there.What changed (motivation → approach → change)
components.workspaceTree.root_truncatednow reads "Nothing is wrong. This project has too many files and folders to list here (the limit is 10,000)." It is updated inen.manual.jsonand translated in all 11 other catalogs (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN), reusing each catalog's existing word for project and for files and folders, and each locale's own thousands separator.en-XA.jsonis regenerated withnpm run i18n:pseudo, which changes only this key.docs/system-specs/modules/learn-cron-dashboard.mdquotes this sentence in the project-tree contract. It is updated in the same commit, with a clause saying why the wording leads with "nothing is broken".website/scripts/capture-files-tree-empty-folder.mjsasserts this sentence for frame 32. It is updated so the harness still passes against a current dist.Backwards compatibility
Compatible: only the rendered text of one catalog value changes. The key, the
data-testidand the render condition are unchanged.Removes nothing: no key, path, record or behaviour is removed. One catalog value is reworded.
Tests
website/src/test/PierreWorkspaceTreeImpl.test.tsx,names the limit, not an empty workspace, when a truncated payload has no row: the assertion now pins the new sentence. The file passes, 139/139.npm run i18n:check: every sub-check ok (pseudolocale, key-refs, extractable, plurals, source-strings, added-lines, dnt, manifest-sync, unit-literals, untranslated-passthrough).Manual verification
Frame 32 of
website/scripts/capture-files-tree-empty-folder.mjswas rendered against two real SPA builds with the same route-intercepted fixture (treeState = 'root-truncated'). The "before" frame comes fromorigin/main's script and catalogs, and the "after" frame from this branch's. See the screenshots below.Screenshots / video
Side panel, Files tab, project tree payload truncated with no row (frame 32 of
capture-files-tree-empty-folder.mjs, same fixture both times). The images are committed undertemp-screenshots/capped-tree-21025/.Before (
origin/maincatalogs):After (this branch):
Captured in English only. The capture script finds its controls by English placeholder text, so a
ja-JPrun stops before frame 32. The translations are checked bynpm run i18n:checkabove.Note on the harness: run as committed,
capture-files-tree-empty-folder.mjsfails at frame 10 on currentorigin/main, before reaching frame 32. Its frame-10 expectation predates theOpen in folder tabrow. Both frames above were taken with a throwaway copy that logs its assertions instead of throwing, which was then deleted. Frame 32's own assertion held in both runs: the limit notice was present, the empty-workspace notice was absent, and no tree was mounted. Fixing frame 10 is outside this PR.Related Issues
Closes #21025
Pattern harvest
Not generalizable: this is one sentence a UX review flagged on a specific empty state; the reviewer named no other string with the same problem.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
🤖 Generated with Claude Code