Skip to content

fix(dashboard): say nothing is broken on the empty capped project tree - #21175

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
leonlaiyc:fix/capped-tree-says-nothing-is-broken
Nov 6, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
leonlaiyc:fix/capped-tree-says-nothing-is-broken

Conversation

@leonlaiyc

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A reader of the empty capped project tree can tell that nothing is broken and what the limit is about, in words they already know.

When a project is too big for the tree's row cap and the payload has no row at all, the panel shows only "Workspace too large to list: limit of 10,000 items reached" in place of the tree. The UX Review of #21018 found that a blind reader could not tell whether something was broken, or what "items" means. #21018 added the next step under it ("Type a file name in the box above to find it.") and deliberately left this sentence alone, which is what #21025 tracks.

Why it matters

The state replaces the whole tree, so this sentence is the only thing on the panel. A user with a large repository opens the Files rail or the folder panel, sees a sentence about a limit with no folder and no file, and reasonably reads it as a failure. They may then file a bug, restart the gateway, or stop using the panel.

Not a goal

  • No change to the row cap, to when the server truncates, or to which state renders.
  • No change to the next-step line (root_truncated_search_hint) or to the other truncation strings (workspace_truncated, row_truncated). Those sit beside a tree that does show rows, so the "nothing is broken" question does not arise there.
  • No folding of the next step into this sentence. feat(files): give the empty capped tree a search next step #21018 already renders it as its own line directly below, and folding it would say it twice.

What changed (motivation → approach → change)

  • Symptom → cause: the sentence leads with "too large" and a limit, names no reassurance, and counts "items", which a user cannot map to anything they see.
  • Approach: say first that nothing is wrong, then count files and folders (the user's own words for what the tree lists), and keep the limit as a parenthetical fact. "Too many … to list" keeps it true when the project holds exactly the cap.
  • Change: components.workspaceTree.root_truncated now reads "Nothing is wrong. This project has too many files and folders to list here (the limit is 10,000)." It is updated in en.manual.json and translated in all 11 other catalogs (bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN), reusing each catalog's existing word for project and for files and folders, and each locale's own thousands separator. en-XA.json is regenerated with npm run i18n:pseudo, which changes only this key.
  • docs/system-specs/modules/learn-cron-dashboard.md quotes this sentence in the project-tree contract. It is updated in the same commit, with a clause saying why the wording leads with "nothing is broken".
  • website/scripts/capture-files-tree-empty-folder.mjs asserts this sentence for frame 32. It is updated so the harness still passes against a current dist.

Backwards compatibility

Compatible: only the rendered text of one catalog value changes. The key, the data-testid and the render condition are unchanged.

Removes nothing: no key, path, record or behaviour is removed. One catalog value is reworded.

Tests

  • website/src/test/PierreWorkspaceTreeImpl.test.tsx, names the limit, not an empty workspace, when a truncated payload has no row: the assertion now pins the new sentence. The file passes, 139/139.
  • npm run i18n:check: every sub-check ok (pseudolocale, key-refs, extractable, plurals, source-strings, added-lines, dnt, manifest-sync, unit-literals, untranslated-passthrough).

Manual verification

Frame 32 of website/scripts/capture-files-tree-empty-folder.mjs was rendered against two real SPA builds with the same route-intercepted fixture (treeState = 'root-truncated'). The "before" frame comes from origin/main's script and catalogs, and the "after" frame from this branch's. See the screenshots below.

Screenshots / video

Side panel, Files tab, project tree payload truncated with no row (frame 32 of capture-files-tree-empty-folder.mjs, same fixture both times). The images are committed under temp-screenshots/capped-tree-21025/.

Before (origin/main catalogs):

before: Workspace too large to list: limit of 10,000 items reached

After (this branch):

after: Nothing is wrong. This project has too many files and folders to list here (the limit is 10,000).

Captured in English only. The capture script finds its controls by English placeholder text, so a ja-JP run stops before frame 32. The translations are checked by npm run i18n:check above.

Note on the harness: run as committed, capture-files-tree-empty-folder.mjs fails at frame 10 on current origin/main, before reaching frame 32. Its frame-10 expectation predates the Open in folder tab row. Both frames above were taken with a throwaway copy that logs its assertions instead of throwing, which was then deleted. Frame 32's own assertion held in both runs: the limit notice was present, the empty-workspace notice was absent, and no tree was mounted. Fixing frame 10 is outside this PR.

Related Issues

Closes #21025

Pattern harvest

Not generalizable: this is one sentence a UX review flagged on a specific empty state; the reviewer named no other string with the same problem.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

🤖 Generated with Claude Code

@leonlaiyc
leonlaiyc requested review from a team and KiroCrewCaptain as code owners October 16, 2026 08:53
@leonlaiyc
leonlaiyc requested a review from CrysisDeu October 16, 2026 08:53
@github-actions github-actions Bot added the fork Pull request from a fork (external contributor) label Oct 16, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of fc2e15040e3c0e4ec5706e6f32c9130580d5247d via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a copy-only change to one catalog value: the key, the render condition and the testid stay the same, and committed before/after screenshots show the result.

[DESIGN-REVIEWED] fc2e150

Description read

[DESCRIPTION-READ] 1583d7bd985a51023bf4db6da317d779db95cf0586b9624bf1cfd268b65b9f1a

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of fc2e15040e3c0e4ec5706e6f32c9130580d5247d via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: this is a one-sentence copy fix tracked by #21025. Every other file touched either pins that sentence or is the before/after evidence for it.

What this change ships

Inventory (5 items) — 5 justified

Intent: let a user looking at an empty, capped project tree see that nothing is broken and what the limit counts. This is a FIX.

  1. The empty capped-tree sentence now says "Nothing is wrong", counts files and folders instead of items, and keeps the 10,000 limit as a parenthetical, in all 12 catalogs plus the regenerated pseudolocale — justified
  2. The project-tree contract in learn-cron-dashboard.md quotes the new sentence and says why it reads that way — justified
  3. The frame-32 assertion in capture-files-tree-empty-folder.mjs now expects the new sentence — justified
  4. The PierreWorkspaceTreeImpl.test.tsx pin now expects the new sentence — justified
  5. Before/after screenshots committed under temp-screenshots/capped-tree-21025/ — justified

[FIRST-PRINCIPLES-REVIEWED] fc2e150

Description read

[DESCRIPTION-READ] 09add5f9c92c9d0543bf88e209db63cc8da96d3537c44d97f0c83e51752840c8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of fc2e15040e3c0e4ec5706e6f32c9130580d5247d via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

The after screenshot (attachment-01) shows the one changed string. No first-time reader has seen it, because this fork lane has no blind read; pushing the branch to this repository would add one.

Notes

  • Term drift: root_truncated now says "This project", but its sibling empty states on the same panel say "workspace" ("No files in this workspace yet", root_hidden_only "This workspace contains only hidden items…", root_unreadable "…workspace folder"). Pick one noun for the same container across these strings.

[UX-REVIEWED] fc2e150

Description read

[DESCRIPTION-READ] 721e4d36ad4d4b99cc64a5d41ae8429f98caf4657de8a74ffd220afe2ecb14f2

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed fc2e15040e3c0e4ec5706e6f32c9130580d5247d via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] fc2e150

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed fc2e15040e3c0e4ec5706e6f32c9130580d5247d via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] fc2e150

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 17, 2026
@iamwhatever
iamwhatever force-pushed the fix/capped-tree-says-nothing-is-broken branch from c3821be to 7e3be4b Compare October 23, 2026 08:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@iamwhatever
iamwhatever force-pushed the fix/capped-tree-says-nothing-is-broken branch from 7e3be4b to df49deb Compare October 28, 2026 17:19
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 4, 2026
@iamwhatever iamwhatever self-assigned this Nov 4, 2026
iamwhatever
iamwhatever previously approved these changes Nov 4, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at 66a3d91.

One catalog value is reworded and translated in every locale; the spec quote, the capture-script assertion and the unit test pin the new sentence, and no key, testid or render condition changes. All current-head checks are green and no change request is active.

AI findings judged non-blocking

  • Design Review: 'Nothing is wrong' only holds if truncated never marks a real failure. read failures go to unreadableDirectories, and the root notice keys on truncated from the scan budget only.
    unreadable.append(directory or ".")
  • First Principles Review: sibling strings row_truncated/workspace_truncated still say 'items'. those sit beside a visible tree whose rows are the items; wording nit, out of this PR's goal, no user harm.
    "row_truncated": "Some items not shown: limit of 10,000 items reached",
  • UX Review: 'project' here vs 'workspace' in root_hidden_only/root_unreadable. word-consistency nit; each sentence is understandable on its own.
    "root_hidden_only": "This workspace contains only hidden items (skipped tool and cache folders, protected entries)",

— crew-pr-reviewer (r145)

@iamwhatever
iamwhatever enabled auto-merge (squash) November 4, 2026 07:39
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 4, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

@leonlaiyc thanks, 66a3d91 is ready apart from one thing. Every check passes, including Sensitive Change Review, and all five AI review lanes pass. Main has since moved, though, and the branch now conflicts in docs/system-specs/modules/learn-cron-dashboard.md. Could you rebase onto main? I will approve as soon as the rebased head is green.

@iamwhatever
iamwhatever force-pushed the fix/capped-tree-says-nothing-is-broken branch from 66a3d91 to 7e5e806 Compare November 6, 2026 01:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision labels Nov 6, 2026
When the project tree's payload is truncated with no row at all, the
panel shows only one sentence in the tree's place. "Workspace too large
to list: limit of 10,000 items reached" read as a failure, and "items"
names nothing the user can see.

The sentence now says nothing is wrong first and counts files and
folders, keeping the limit as a parenthetical. It is translated in all
twelve catalogs, en-XA is regenerated, and the spec and the frame-32
capture assertion quote the new wording.

Closes kirodotdev#21025

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@iamwhatever
iamwhatever force-pushed the fix/capped-tree-says-nothing-is-broken branch from 7e5e806 to fc2e150 Compare November 6, 2026 04:10
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 6, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (18 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: fix: the empty capped project tree copy says nothing is broken, in every locale, with the spec, test and capture script updated. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/learn-cron-dashboard.md.

@iamwhatever
iamwhatever merged commit e6e1038 into kirodotdev:main Nov 6, 2026
129 of 131 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
buluoray pushed a commit that referenced this pull request Nov 9, 2026
#21175)

When the project tree's payload is truncated with no row at all, the
panel shows only one sentence in the tree's place. "Workspace too large
to list: limit of 10,000 items reached" read as a failure, and "items"
names nothing the user can see.

The sentence now says nothing is wrong first and counts files and
folders, keeping the limit as a parenthetical. It is translated in all
twelve catalogs, en-XA is regenerated, and the spec and the frame-32
capture assertion quote the new wording.

Closes #21025

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e6e1038)
buluoray pushed a commit that referenced this pull request Nov 9, 2026
#21175)

When the project tree's payload is truncated with no row at all, the
panel shows only one sentence in the tree's place. "Workspace too large
to list: limit of 10,000 items reached" read as a failure, and "items"
names nothing the user can see.

The sentence now says nothing is wrong first and counts files and
folders, keeping the limit as a parenthetical. It is translated in all
twelve catalogs, en-XA is regenerated, and the spec and the frame-32
capture assertion quote the new wording.

Closes #21025

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e6e1038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty capped project tree: say plainly that nothing is broken

4 participants