Skip to content

fix(dashboard): stop resolving project-report for an unadopted crewmate - #21191

Merged
iamwhatever merged 1 commit into
mainfrom
fix/21119-crewmate-no-default-page
Oct 18, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/21119-crewmate-no-default-page

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate that has not adopted a dashboard page stops carrying the built-in project report behind its suggestions page: nothing composes it, offers its fields, or accepts writes to it.

#21119 reported the built-in Project report as an unexpected page in the Dashboard tab of every crewmate that never adopted one. The tab now draws the suggestions page instead, but the gateway still resolves project-report as that crewmate's page. Every read composes the 147 KB page and throws it away, dashboard_fields and dashboard_write keep answering for it, and the Profile notes list its upkeep.

Why it matters

Every unadopted crewmate pays for a page that no reader sees, on every poll of its tab. A crewmate that writes to it fills a page nobody will look at, and its Profile shows upkeep for a page that is not there.

Not a goal

  • Changing the suggestions page on the tab.
  • Removing project-report from the catalog. A crewmate can still adopt it.
  • Changing a root session's Overview, which keeps project-report as its default.
  • Changing the page named for a crewmate: kirocrew-conductor keeps its board.
  • Cleaning up helper scripts an earlier default copied to disk.

What changed (motivation → approach → change)

An unadopted crewmate now has no page behind its suggestions page, so nothing composes it, offers its fields or accepts writes to it. The cause was default_template_id in dashboard_templates/instance.py: it fell back to DEFAULT_TEMPLATE_ID for every key, and the read route, the turn block, the field list, the field write and the Profile's upkeep all serve that pick. The fallback now applies to a root session's key only. A crewmate gets the shipped page named for it, or no page.

Surface Unadopted crewmate, before After
Dashboard tab suggestions page suggestions page
Dashboard read composes project-report, says suggestions composes nothing, says suggestions
[DASHBOARD] turn block suggestions line suggestions line
dashboard_fields / dashboard_write answer for project-report "no dashboard yet" / refused no_instance
Profile notes, upkeep project-report's three fields none
Its own page: dashboard_save, then dashboard_apply goes live, with project-report kept as the template copy unchanged
Older record whose bound page a person cut: turn block names project-report names that page
Crewmate named like a page; root session Overview that page; project-report unchanged

With no page in force, _read_page hands back the stored record, so turn_block asks shows_suggestions the same question the read route asks, and package_on_screen the same package rule. tab_shows_suggestions had no case left and is removed. apply_package keeps a template copy beside every pin, so it asks default_instance(slug, for_package=True), which still answers project-report for a crewmate with no page named for it; that copy is drawn only when the pinned page cannot be read, as on main. A missing session default still logs a warning; a crewmate's no-page answer logs nothing, because its tab polls this read. The spec, dashboard_templates/builtin/README.md, the feature map, crew-mode, the pipeline-conductor skill's Dashboard line and the comments at each fallback say the same.

docs/request-for-change/rfc-crewmate-dynamic-dashboard.md records a default page for every unadopted crewmate. The tab already stopped drawing it on a maintainer's decision (#19865); this PR stops resolving it at the maintainer's request, so the First Principles lane may need a maintainer's override.

Backwards compatibility

Breaking: a dashboard_write from a crewmate that adopted no page, and has none named for it, is refused no_instance, where main wrote it to project-report's for_you, verdict or ci. Writer sweep on origin/main @ 503e9e3:

  • Crewmate agents through dashboard_write (@kirocrew-panel): the [DASHBOARD] block names their fields, and an unadopted crewmate's block is the suggestions line, which names none. Member prompt item 7 defers to that block. A write that still arrives is refused with its remedy and lands in the mistake book.
  • project-report/helpers/project_report_ci.py and pr-watch/helpers/pr_watch_lanes.py: copied only for a page that names them.
  • Template upkeep text (goal-board, office, session-ledger, standup, project-report manifests): shown only for the page in force.
  • builtin_skills/pipeline-conductor/SKILL.md: writes to the tab only when its [DASHBOARD] block names a page.
  • builtin_skills/goal-conductor/SKILL.md and builtin_skills/dashboard/SKILL.md: write to the page in force, which for the conductor is the kirocrew-conductor page named for it.

Taken away: the composed default behind an unadopted crewmate's suggestions page, its fields in dashboard_fields, writes to them, and its upkeep in the Profile notes. Values already written stay in the crew log and show once a page that reads them is adopted. Helper scripts an earlier default copied stay on disk; nothing points a crewmate at them.

Reader: website/src/pages/members/CrewDynamicDashboard.tsx:CrewDynamicDashboard -- crew page -- suggestions with no rendered_html draws the suggestions page | capture below; CrewDynamicDashboard.test.tsx (its suggestions cases)
Reader: src/kiro_crew/dashboard/handlers/member_dashboard.py:_serve -- crew page -- composes nothing and still says suggestions | test_dashboard_default_by_slug.py::TestTheSuggestionsDecisionIsMadeOnce::test_no_page_is_the_suggestions_page_on_both
Reader: src/kiro_crew/dashboard_agentic.py:turn_block -- chat|cron|subagent -- the suggestions line, no fields | TestTheSeam::test_the_turn_block_tells_any_other_crewmate_it_shows_suggestions
Reader: src/kiro_crew/dashboard_package.py:read_package_model -- chat|cron|subagent -- empty with no Model, so dashboard_write is refused | TestTheSeam::test_a_write_finds_no_page_for_any_other_crewmate
Reader: src/kiro_crew/dashboard/handlers/agent_panel.py:read_instance -- chat -- None, so dashboard_fields says there is no dashboard yet | test_agent_panel_routes.py (its no-dashboard cases)
Reader: src/kiro_crew/dashboard_upkeep.py:view -- crew page -- None, so the Profile notes show no upkeep | TestTheSuggestionsDecisionIsMadeOnce::test_the_profile_view_shows_no_upkeep_for_the_suggestions_page
Reader: src/kiro_crew/dashboard/handlers/member_dashboard.py:api_session_dashboard -- chat -- a root session is still served project-report | TestTheSeam::test_a_root_session_is_still_shown_the_default, test_session_dashboard.py
Reader: src/kiro_crew/dashboard_templates/instance.py:apply_package -- chat -- a crewmate's first package apply still keeps a template copy beside its pin | test_dashboard_save_tool.py::test_a_save_stores_the_page_and_apply_puts_it_live, TestTheSeam::test_a_package_apply_still_keeps_a_template_copy_beside_its_pin
Reader: src/kiro_crew/dashboard_agentic.py:turn_block -- chat|cron|subagent -- an older record's bound page a person cut is named, as the tab draws it | TestTheSuggestionsDecisionIsMadeOnce::test_an_older_records_bound_page_is_what_the_turn_block_names
Reader: src/kiro_crew/builtin_skills/goal-conductor/SKILL.md -- chat|cron -- the kirocrew-conductor page named for it | TestTheShippedRegistry::test_the_conductor_gets_its_board

Tests

  • test/test_dashboard_default_by_slug.py: a crewmate with no page named for it gets none from the pick, the seam, the read route, the write path's read and the Profile's upkeep, and its turn block and read both say suggestions; a root session still gets the default; the no-page read logs nothing, while a session's missing default still warns; the conductor keeps its board; an adopted project-report still serves, and the template still ships; a package apply still keeps a template copy beside its pin; an older record's bound page a person cut is what the turn block names.
  • The upkeep, structure-lock, dynamic-dashboard and agent-panel tests that need a page now adopt one, or stand in a page named for the crewmate where the case is about a page that never commits.
  • test/test_member_dashboard_package_route.py: the bound-draft case now expects the suggestions page, because that crewmate never adopted a page and has none named for it.
  • Determinism, over the 26 test functions this diff adds or changes: 10/10 green at -n0, 5/5 green at -n 4 --dist loadgroup, and green in reverse order. prove.py reverts the production hunks and the tests go red.

Manual verification

The real read route and dashboard_upkeep.view ran in-process against the shipped registry for an unadopted crewmate, on main and on this branch, and their answers drove the real MembersPage (gateway-free capture). main composes project-report and lists its upkeep; this branch composes nothing and lists none; both draw the suggestions page.

Screenshots / video

Dashboard tab of an unadopted crewmate: the same suggestions page before (main, left) and after (this branch, right). The chat on the left of each frame is a fixture.

Dashboard tab before
Dashboard tab after

Profile, Notes: main lists project-report's upkeep for a page nobody sees; this branch shows only the notes.

Profile notes before
Profile notes after

Related Issues

Fixes #21119

Pattern harvest

Not generalizable: the default page was a deliberate product default, now changed by a maintainer decision; no code shape tells a wanted default from an unwanted one.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f9e71016fc594104123890f55812869f9f4b95a6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

The new for_package carve-out in default_instance: check that a crewmate's first package apply still keeps a project-report copy, and that the RFC conflict gets a maintainer sign-off.

Watch

  • The description itself says the change goes against docs/request-for-change/rfc-crewmate-dynamic-dashboard.md, which records a default page for every unadopted crewmate. The PR stops resolving that page "at the maintainer's request". A recorded decision should only be reversed by a superseding entry a maintainer wrote. Without one, the RFC and the code will disagree, and a later PR could restore the default by citing the RFC.
    Clears when: a maintainer approves the override on the PR, or the RFC gets a superseding note saying an unadopted crewmate resolves no page.

[DESIGN-REVIEWED] f9e7101

Description read

[DESCRIPTION-READ] ebe20b787cb57e0d0e74f7372b16018d08022b8e548e127015bb74ab6539c4d3

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@iamwhatever overrode this lane for f9e71016fc594104123890f55812869f9f4b95a6 via /ai-review override (this commit only).

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f9e71016fc594104123890f55812869f9f4b95a6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that the Profile Notes panel of an unadopted crewmate with no standing notes still says it is empty, rather than rendering a blank space where "Dashboard upkeep" was.

[UX-REVIEWED] f9e7101

Description read

[DESCRIPTION-READ] afd3742227035e7e89ec10d5231ae2be6dcf8d6e0bcada7c23e446d6959b34b2

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f9e71016fc594104123890f55812869f9f4b95a6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f9e7101

Verdict parsed from the review's SHA-scoped output markers for commit f9e71016fc594104123890f55812869f9f4b95a6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f9e71016fc594104123890f55812869f9f4b95a6: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f9e71016fc594104123890f55812869f9f4b95a6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f9e7101

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f9e71016fc594104123890f55812869f9f4b95a6: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=efba87a3bf74 needs-a-decision: the read stops composing project-report for an unadopted crewmate

The tab already draws the suggestions page for this crewmate (#19866), so the composed default is a page no reader sees.
Reversing Decision 4 of rfc-crewmate-dynamic-dashboard.md for crewmates is a maintainer ruling; the maintainer asked for this cleanup.
Root sessions keep the default, and a shipped page named for a crewmate is kept.
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=1b65fb0674ba needs-a-decision: dashboard_write from an unadopted crewmate is refused no_instance

On main such a write lands on project-report, which the tab never draws for that crewmate, so the value reaches no reader.
The refusal carries its remedy, the [DASHBOARD] block names no fields there, and values already written stay in the crew log.
Removing that write path follows from removing the default page; it is the same maintainer ruling as span efba87a3bf74.
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=067ddf0eed28 needs-a-decision: product-shape change without an accepted RFC

Correct that no accepted RFC on main records "no default page for an unadopted crewmate"; the PR body names the RFC it departs from.
The maintainer requested this change after the suggestions page landed; the decision is theirs to record.
Ruling needed: a maintainer posts the first-principles override on this head, or an RFC amendment merges on main and this PR rebases.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 16, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: maintainer sign-off on departing from rfc-crewmate-dynamic-dashboard.md

Agreed: dropping the default page for an unadopted crewmate departs from the RFC's Decision 4, and only a maintainer can record that.
It is the same ruling the three First Principles spans on this head wait on; the maintainer asked for this cleanup.
It lands as a maintainer override of first-principles on this head, or as an RFC amendment on main.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 16, 2026
@iamwhatever
iamwhatever force-pushed the fix/21119-crewmate-no-default-page branch from 154bf42 to 85d632e Compare October 16, 2026 22:43
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/feature-map/README.md since this head went green (5c1f997 -> 7bb3166). #21014 edited the row next to this PR's row, so the PR conflicted; both edits are kept and the change itself is unchanged. Writer sweep re-run on 7bb3166: same writers. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 16, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=b77e6fe433e9 needs-a-decision: default_template_id returns no page for an unadopted crewmate

The RFC keeps a default page so that such a crewmate's tab is not empty. Since #19866 that tab draws the suggestions page instead, on main and on this branch, so the tab is not empty here either.
On main the default is still composed but never drawn for this crewmate. Root sessions keep project-report, and a shipped page named for a crewmate (kirocrew-conductor) is still served.
Leaving the RFC's partial-status rule before piece 7 of #18642 is a maintainer ruling; the maintainer asked for this cleanup (#21119).
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=3324761fab1a needs-a-decision: dashboard_write from an unadopted crewmate is refused no_instance

On main that write lands in project-report fields the tab never draws for this crewmate, so no person sees the value.
The refusal names its remedy, the crewmate's [DASHBOARD] block lists no fields, and values already written stay in the crew log for a page adopted later.
This follows from span b77e6fe433e9 and needs the same maintainer ruling.
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=ac1121e0e89b needs-a-decision: product-shape change without an accepted RFC

Correct: no accepted RFC on main records that an unadopted crewmate resolves no page and refuses writes. The PR body names the RFC it departs from.
The maintainer asked for this change after the suggestions page landed (#21119); recording that decision is theirs.
Ruling needed: a maintainer posts the first-principles override on this head, or an RFC amendment merges on main and this PR rebases.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: maintainer sign-off on departing from rfc-crewmate-dynamic-dashboard.md

Agreed: only a maintainer can confirm that dropping the default page for an unadopted crewmate is intended.
It is the same ruling the three First Principles spans on this head wait on; the maintainer asked for this cleanup.
It lands as a maintainer override of first-principles on this head, or as an RFC amendment on main.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 17, 2026
A crewmate that never adopted a dashboard page still resolved the built-in
project-report as its page. Its Dashboard tab already draws the suggestions
page instead, so every read composed a 147 KB page nothing drew, and
dashboard_fields, dashboard_write and the profile's upkeep kept answering
for that unseen page.

instance.default_template_id now gives a crewmate only the shipped page
named for it (kirocrew-conductor keeps its board), and nothing otherwise.
With no page in force the read composes nothing and still answers
suggestions, the turn block keeps its suggestions line, dashboard_write is
refused no_instance, and the profile shows no upkeep. A root session's
Overview keeps project-report as its default, and the template stays in
the catalog for a crewmate to adopt. Only a missing session default logs a
warning, since a crewmate's no-page read runs on every poll.

Fixes #21119
@iamwhatever
iamwhatever force-pushed the fix/21119-crewmate-no-default-page branch from 85d632e to f9e7101 Compare October 17, 2026 02:34
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/dashboard_agentic.py and docs/feature-map/README.md since this head went green (7bb3166 -> 503e9e3); #20974 merged its go-live-on-save change into the same code, so the PR conflicted. Kept both: the turn block asks package_on_screen; apply_package keeps a template copy beside a first pin via default_instance(slug, for_package=True); an older record's bound page a person cut is now named in the turn block. The bound-draft route test expects the suggestions page. Writer sweep re-run on 503e9e3. CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=1962d03259c7 needs-a-decision: dashboard_write and dashboard_fields no longer answer for an unadopted crewmate

Correct that RFC Decision 4 gives every unadopted crewmate the default page, and this PR departs from it.
Since #19866 that page is never drawn for such a crewmate: its tab shows the suggestions page, so a value written to the default reaches no reader.
A crewmate with a page named for it (kirocrew-conductor) keeps it, and adopting any template or applying its own package gives it fields again.
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=288fc1ca9003 needs-a-decision: the read no longer composes project-report for an unadopted crewmate

The read composed the 147 KB page on every poll of the tab and threw it away, because the tab draws the suggestions page instead.
It now answers the stored record with suggestions true, and the route's test pins it (TestTheSuggestionsDecisionIsMadeOnce::test_no_page_is_the_suggestions_page_on_both).
The lane calls this item justified; it waits on the same maintainer ruling as span 78cc683720d8.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=021ff34b7316 needs-a-decision: dashboard_write is refused no_instance and dashboard_fields reports no dashboard

On main those writes land in project-report fields the tab never draws for this crewmate, so no person sees them.
The refusal names its remedy and lands in the mistake book, the crewmate's [DASHBOARD] block lists no fields, and values already written stay in the crew log for a page adopted later.
Departing from RFC Decision 4 here is the maintainer ruling span 78cc683720d8 waits on.
Ruling needed: a maintainer override of first-principles on this head, or an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=30045c7d22f1 needs-a-decision: the Profile notes show no upkeep for the suggestions page

The upkeep text described the fields of a page nobody sees; with no page in force there is nothing to keep up.
The notes and their empty state still render (CrewNotesTab.test.tsx, the no-notes-yet case), and TestTheSuggestionsDecisionIsMadeOnce::test_the_profile_view_shows_no_upkeep_for_the_suggestions_page pins the empty view.
The lane calls this item justified; it waits on the same maintainer ruling as span 78cc683720d8.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=df5542eafefc needs-a-decision: a first package apply still keeps a project-report template copy

apply_package (#20974) stores a template copy beside every pin, so the record stays readable and a rollback has a page to re-check.
for_package keeps that copy for a crewmate with no page named for it, at its one caller; the copy is drawn only when the pinned page cannot be read, as on main.
Pinned by test_dashboard_save_tool.py::test_a_save_stores_the_page_and_apply_puts_it_live and TestTheSeam::test_a_package_apply_still_keeps_a_template_copy_beside_its_pin.
The lane calls this item justified; it waits on the same maintainer ruling as span 78cc683720d8.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=19a1d9816016 needs-a-decision: an older record's bound page is now named in the turn block

The read route draws an older record's bound page that a person cut, and the write check reads that page's Model; the turn block now names the same page.
On main the block named project-report while the tab drew the package. TestTheSuggestionsDecisionIsMadeOnce::test_an_older_records_bound_page_is_what_the_turn_block_names pins it.
The lane calls this item justified; it waits on the same maintainer ruling as span 78cc683720d8.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=271418ee58a7 needs-a-decision: a crewmate with no page no longer logs a warning on each poll

No page is now the ordinary answer for an unadopted crewmate, and its tab polls this read, so a warning per poll would be noise in every log.
A root session's missing default, which is a packaging fault, still warns (TestTheSeam::test_a_session_without_the_default_still_warns).
The lane calls this item justified; it waits on the same maintainer ruling as span 78cc683720d8.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=78cc683720d8 needs-a-decision: product-shape change without an accepted RFC

Correct: no accepted RFC on main records that an unadopted crewmate resolves no page and refuses writes. The PR body names the RFC it departs from.
The maintainer asked for this change after the suggestions page landed (#21119); recording that decision is theirs.
Ruling needed: a maintainer posts the first-principles override on this head, or an RFC amendment merges on main and this PR rebases.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • span=fb81e0879661 needs-a-decision: maintainer sign-off on departing from rfc-crewmate-dynamic-dashboard.md

Agreed: only a maintainer can confirm that an unadopted crewmate resolving no page is intended; it is the same ruling the First Principles spans on this head wait on.
The first package apply still keeps a project-report copy beside its pin: test_dashboard_save_tool.py::test_a_save_stores_the_page_and_apply_puts_it_live applies a never-adopted crewmate's package, and TestTheSeam::test_a_package_apply_still_keeps_a_template_copy_beside_its_pin pins the copy.
It lands as a maintainer override of first-principles on this head, or as an RFC amendment on main.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • verified: an unadopted crewmate's Profile Notes still says it is empty

The upkeep block and the notes empty state render separately in CrewNotesTab.tsx: with upkeep null the block is not drawn, and with no notes text the empty line is.
CrewNotesTab.test.tsx, the no-notes-yet case, renders exactly that answer (no upkeep, no text) and finds "oncall hasn't written any notes yet."; the upkeep-null case shows no upkeep section.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles f9e7101: maintainer decision: an unadopted crewmate has no default page; its tab shows the suggestions page, root sessions keep project-report

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for f9e71016fc594104123890f55812869f9f4b95a6.

maintainer decision: an unadopted crewmate has no default page; its tab shows the suggestions page, root sessions keep project-report

This decision applies only to this commit. A new push requires a new judgment.

@iamwhatever
iamwhatever merged commit 279ff5c into main Oct 18, 2026
103 of 105 checks passed
@iamwhatever
iamwhatever deleted the fix/21119-crewmate-no-default-page branch October 18, 2026 05:52
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crewmate Dashboard tab shows an unexpected default project report page

2 participants