Repository navigation
fix(dashboard): stop resolving project-report for an unadopted crewmate - #21191
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS The new Watch
[DESIGN-REVIEWED] f9e7101 Description read[DESCRIPTION-READ] ebe20b787cb57e0d0e74f7372b16018d08022b8e548e127015bb74ab6539c4d3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@iamwhatever overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that the Profile Notes panel of an unadopted crewmate with no standing notes still says it is empty, rather than rendering a blank space where "Dashboard upkeep" was. [UX-REVIEWED] f9e7101 Description read[DESCRIPTION-READ] afd3742227035e7e89ec10d5231ae2be6dcf8d6e0bcada7c23e446d6959b34b2 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
|
|
|
154bf42 to
85d632e
Compare
|
|
|
|
A crewmate that never adopted a dashboard page still resolved the built-in project-report as its page. Its Dashboard tab already draws the suggestions page instead, so every read composed a 147 KB page nothing drew, and dashboard_fields, dashboard_write and the profile's upkeep kept answering for that unseen page. instance.default_template_id now gives a crewmate only the shipped page named for it (kirocrew-conductor keeps its board), and nothing otherwise. With no page in force the read composes nothing and still answers suggestions, the turn block keeps its suggestions line, dashboard_write is refused no_instance, and the profile shows no upkeep. A root session's Overview keeps project-report as its default, and the template stays in the catalog for a crewmate to adopt. Only a missing session default logs a warning, since a crewmate's no-page read runs on every poll. Fixes #21119
85d632e to
f9e7101
Compare
|
Rebased: main moved in src/kiro_crew/dashboard_agentic.py and docs/feature-map/README.md since this head went green (7bb3166 -> 503e9e3); #20974 merged its go-live-on-save change into the same code, so the PR conflicted. Kept both: the turn block asks package_on_screen; apply_package keeps a template copy beside a first pin via default_instance(slug, for_package=True); an older record's bound page a person cut is now named in the turn block. The bound-draft route test expects the suggestions page. Writer sweep re-run on 503e9e3. CI re-running. |
|
|
|
|
|
|
|
|
|
|
|
/ai-review override first-principles f9e7101: maintainer decision: an unadopted crewmate has no default page; its tab shows the suggestions page, root sessions keep project-report |
Human judgment recorded@iamwhatever marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Problem / Motivation
Goal: A crewmate that has not adopted a dashboard page stops carrying the built-in project report behind its suggestions page: nothing composes it, offers its fields, or accepts writes to it.
#21119 reported the built-in Project report as an unexpected page in the Dashboard tab of every crewmate that never adopted one. The tab now draws the suggestions page instead, but the gateway still resolves
project-reportas that crewmate's page. Every read composes the 147 KB page and throws it away,dashboard_fieldsanddashboard_writekeep answering for it, and the Profile notes list its upkeep.Why it matters
Every unadopted crewmate pays for a page that no reader sees, on every poll of its tab. A crewmate that writes to it fills a page nobody will look at, and its Profile shows upkeep for a page that is not there.
Not a goal
project-reportfrom the catalog. A crewmate can still adopt it.project-reportas its default.kirocrew-conductorkeeps its board.What changed (motivation → approach → change)
An unadopted crewmate now has no page behind its suggestions page, so nothing composes it, offers its fields or accepts writes to it. The cause was
default_template_idindashboard_templates/instance.py: it fell back toDEFAULT_TEMPLATE_IDfor every key, and the read route, the turn block, the field list, the field write and the Profile's upkeep all serve that pick. The fallback now applies to a root session's key only. A crewmate gets the shipped page named for it, or no page.suggestionssuggestions[DASHBOARD]turn blockdashboard_fields/dashboard_writeno_instancedashboard_save, thendashboard_applyWith no page in force,
_read_pagehands back the stored record, soturn_blockasksshows_suggestionsthe same question the read route asks, andpackage_on_screenthe same package rule.tab_shows_suggestionshad no case left and is removed.apply_packagekeeps a template copy beside every pin, so it asksdefault_instance(slug, for_package=True), which still answers project-report for a crewmate with no page named for it; that copy is drawn only when the pinned page cannot be read, as on main. A missing session default still logs a warning; a crewmate's no-page answer logs nothing, because its tab polls this read. The spec,dashboard_templates/builtin/README.md, the feature map, crew-mode, the pipeline-conductor skill's Dashboard line and the comments at each fallback say the same.docs/request-for-change/rfc-crewmate-dynamic-dashboard.mdrecords a default page for every unadopted crewmate. The tab already stopped drawing it on a maintainer's decision (#19865); this PR stops resolving it at the maintainer's request, so the First Principles lane may need a maintainer's override.Backwards compatibility
Breaking: a
dashboard_writefrom a crewmate that adopted no page, and has none named for it, is refusedno_instance, where main wrote it to project-report'sfor_you,verdictorci. Writer sweep on origin/main @ 503e9e3:dashboard_write(@kirocrew-panel): the[DASHBOARD]block names their fields, and an unadopted crewmate's block is the suggestions line, which names none. Member prompt item 7 defers to that block. A write that still arrives is refused with its remedy and lands in the mistake book.project-report/helpers/project_report_ci.pyandpr-watch/helpers/pr_watch_lanes.py: copied only for a page that names them.goal-board,office,session-ledger,standup,project-reportmanifests): shown only for the page in force.builtin_skills/pipeline-conductor/SKILL.md: writes to the tab only when its[DASHBOARD]block names a page.builtin_skills/goal-conductor/SKILL.mdandbuiltin_skills/dashboard/SKILL.md: write to the page in force, which for the conductor is thekirocrew-conductorpage named for it.Taken away: the composed default behind an unadopted crewmate's suggestions page, its fields in
dashboard_fields, writes to them, and its upkeep in the Profile notes. Values already written stay in the crew log and show once a page that reads them is adopted. Helper scripts an earlier default copied stay on disk; nothing points a crewmate at them.Reader: website/src/pages/members/CrewDynamicDashboard.tsx:CrewDynamicDashboard -- crew page --
suggestionswith norendered_htmldraws the suggestions page | capture below; CrewDynamicDashboard.test.tsx (its suggestions cases)Reader: src/kiro_crew/dashboard/handlers/member_dashboard.py:_serve -- crew page -- composes nothing and still says
suggestions| test_dashboard_default_by_slug.py::TestTheSuggestionsDecisionIsMadeOnce::test_no_page_is_the_suggestions_page_on_bothReader: src/kiro_crew/dashboard_agentic.py:turn_block -- chat|cron|subagent -- the suggestions line, no fields | TestTheSeam::test_the_turn_block_tells_any_other_crewmate_it_shows_suggestions
Reader: src/kiro_crew/dashboard_package.py:read_package_model -- chat|cron|subagent --
emptywith no Model, sodashboard_writeis refused | TestTheSeam::test_a_write_finds_no_page_for_any_other_crewmateReader: src/kiro_crew/dashboard/handlers/agent_panel.py:read_instance -- chat --
None, sodashboard_fieldssays there is no dashboard yet | test_agent_panel_routes.py (its no-dashboard cases)Reader: src/kiro_crew/dashboard_upkeep.py:view -- crew page --
None, so the Profile notes show no upkeep | TestTheSuggestionsDecisionIsMadeOnce::test_the_profile_view_shows_no_upkeep_for_the_suggestions_pageReader: src/kiro_crew/dashboard/handlers/member_dashboard.py:api_session_dashboard -- chat -- a root session is still served project-report | TestTheSeam::test_a_root_session_is_still_shown_the_default, test_session_dashboard.py
Reader: src/kiro_crew/dashboard_templates/instance.py:apply_package -- chat -- a crewmate's first package apply still keeps a template copy beside its pin | test_dashboard_save_tool.py::test_a_save_stores_the_page_and_apply_puts_it_live, TestTheSeam::test_a_package_apply_still_keeps_a_template_copy_beside_its_pin
Reader: src/kiro_crew/dashboard_agentic.py:turn_block -- chat|cron|subagent -- an older record's bound page a person cut is named, as the tab draws it | TestTheSuggestionsDecisionIsMadeOnce::test_an_older_records_bound_page_is_what_the_turn_block_names
Reader: src/kiro_crew/builtin_skills/goal-conductor/SKILL.md -- chat|cron -- the
kirocrew-conductorpage named for it | TestTheShippedRegistry::test_the_conductor_gets_its_boardTests
test/test_dashboard_default_by_slug.py: a crewmate with no page named for it gets none from the pick, the seam, the read route, the write path's read and the Profile's upkeep, and its turn block and read both say suggestions; a root session still gets the default; the no-page read logs nothing, while a session's missing default still warns; the conductor keeps its board; an adoptedproject-reportstill serves, and the template still ships; a package apply still keeps a template copy beside its pin; an older record's bound page a person cut is what the turn block names.test/test_member_dashboard_package_route.py: the bound-draft case now expects the suggestions page, because that crewmate never adopted a page and has none named for it.-n0, 5/5 green at-n 4 --dist loadgroup, and green in reverse order.prove.pyreverts the production hunks and the tests go red.Manual verification
The real read route and
dashboard_upkeep.viewran in-process against the shipped registry for an unadopted crewmate, on main and on this branch, and their answers drove the real MembersPage (gateway-free capture). main composes project-report and lists its upkeep; this branch composes nothing and lists none; both draw the suggestions page.Screenshots / video
Dashboard tab of an unadopted crewmate: the same suggestions page before (main, left) and after (this branch, right). The chat on the left of each frame is a fixture.
Profile, Notes: main lists project-report's upkeep for a page nobody sees; this branch shows only the notes.
Related Issues
Fixes #21119
Pattern harvest
Not generalizable: the default page was a deliberate product default, now changed by a maintainer decision; no code shape tells a wanted default from an unwanted one.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)