Repository navigation
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concern blocks this. Every reader of the leave channel I could find that now gets an async answer is either changed in this patch or ignores the return value. A new lint rule refuses future boolean misreads, and 10 committed screenshots cover the reshaped dialogs. Notes
[DESIGN-REVIEWED] d275fd1 Description read[DESCRIPTION-READ] d0e4ba488b857572acbd548ea6478cad1d955dd4e404a2dfe3b2b1574faac097 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The 10 committed sheets show every migrated dialog, notice and changed label in both themes. This fork lane has no blind read, so nobody has yet judged whether a first-time user understands them. Pushing the branch to this repository runs that read. Notes
[UX-REVIEWED] d275fd1 Description read[DESCRIPTION-READ] 19c09e8cc822d357f7db5058b2cbbf62ad0482a84a77072e46e06d79403e2c4c That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The base's own ESLint allowlist already scheduled these 35 modules for migration under #15662. The two riders below are relabels with no named failure. Notes
What this change shipsInventory (9 items) — 6 justifiedIntent: replace the browser's native confirm, alert and prompt dialogs in the renderer with themed in-app UI. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] d275fd1 Description read[DESCRIPTION-READ] 0b025726f6c8c9ebe0a65c577486fd07d8d07439d4f0df39171dd138546ef366 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging. BLOCKING -- website/src/pages/members/MembersPage.tsx:610 -- Leave confirmation cannot take focus above an active Radix dialog [BLOCK-MERGE] d275fd1 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — UPHOLD (MEDIUM). Keyboard users lose the ability to answer the leave prompt on a common path: pressing Back with unsaved edits. Before this change that path used
|
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
f061753 to
92ee064
Compare
92ee064 to
752c19d
Compare
752c19d to
d5de4f5
Compare
|
Thanks for the reviews. Design review (BLOCK) and UX review (BLOCK): missing rendered evidence. The description now embeds eight dark and light screenshots, committed under UX review: confirm labels.
Design review: the two sites the old ratchet kept on purpose. Both now use the themed confirmation with the same decision as before, and the PR notes that #700's undo question stays open. First-principles review. I removed the surface that had no callers: the unused GPT review: Opus review.
Validation on the rebased head: ESLint with zero warnings, TypeScript, the i18n key check and the affected frontend suites (67 files, 2,230 tests) pass. |
d5de4f5 to
7012f17
Compare
|
Pushed Design review (BLOCK): nested UX review (BLOCK): UX review (evidence gaps). The capture page now renders all 33 migrated call sites with their shipped strings and options: every leave-without-saving dialog, the Prompts and Memory discards, all three text prompts, every delete or remove confirmation, Restart, replace-import, Tear down, and the new inline notices. They are laid out as contact sheets in the description, in both themes. UX review (Tear down title repeats the button). Fixed. The title is now "Tear down this deployment?", a new key in every locale, and the button keeps "Tear down application". GPT review (fenced): error hand-offs could discard an unsent Nudge. Fixed. Research Lab's campaign view registers a leave guard while a nudge draft is non-empty, so a hand-off to chat asks first. GPT and Opus: the row ✕ close confirmation was never mounted. Fixed. Opus: the Tear down resource list collapsed onto one line. Fixed. The body keeps one resource per line. First-principles (undeclared): the ErrorNotice menu stayed open after a hand-off. Fixed. The menu closes as before when the hand-off completes in the click. It stays open only while the page's leave confirmation is still pending. CI. The frontend shards and E2E failures came from tests and specs that still drove a browser Fork workflow-change guard. This blocks the PR because the screenshots live under |
|
I added the evidence the UX review asked for and rebased on current main.
Backend shard 2 hit the same |
|
Hi @KiroCrewCaptain and @dodgeblaster, Thank you for your patience with this one. I think the PR is ready for a maintainer review. On the current head, no bot review is blocking, the branch is rebased on Two things still need a maintainer, since I can't do them from a fork:
Would you review it when you have a moment, and merge it if it looks good to you? I'm happy to make any changes you'd like. Thanks. |
71118c3 to
4cf1483
Compare
|
Rebased on current
There are no other changes. The type check, lint, the i18n and feature-map checks and the related frontend tests pass. The earlier asks for the fork label and the backend shard 2 rerun still stand. |
|
Rebased on current
The type check, lint over |
|
Rebased onto current
The leave guard keeps #24786's multi-step history jumps: the Back trap still asks only for a one-step Back, and any other jump is asked about in-app. The type check, lint, the i18n checks and the 2,230 related frontend test files pass. |
|
I rebased onto current Opus 5.5 Review (blocking)
Frontend Tests 1-4 (i18n)
Conflicts with
|
|
Heads-up on one overlapping hunk: PR #25951 moves the ChannelPage per-agent Clear context confirm to 🤖 AI-assisted comment 🤖 |
|
Rebased onto current
Two new upstream tests were updated for this PR: the Mates swipe tests answer "Keep editing" (the leave dialog's cancel label here), and the session-menu reference test renders the menu with its actions. I also added the |
|
I added a second commit with fixes from another review pass, and rebased onto current
|
|
Rebased onto current
Two Knowledge tests now answer the in-app dialog instead of stubbing |
The Add to knowledge and Export as artifact error notices in Research Lab offer an agent hand-off. The campaign can still hold an unsent Nudge or answer at that point. Opening the chat unmounts the campaign and loses that text. The lint rules flag the bare dialog names and window.confirm(), but globalThis.confirm() and self.confirm() pass. The same holds for alert and prompt. The prompt() message tells developers to use "the native text-entry dialog", which names no component. Five side-panel leave checks are async functions, so they return a Promise even when nothing is unsaved. A clean pane then waits on that Promise before it changes tabs. Drop the hand-off from those two Research Lab notices. Add globalThis and self to the lint rules, and name useTextPrompt() in the prompt() message. Add a test that lints each spelling. Return a plain true from a clean leave check, and a Promise only while a confirmation is open. Move duplicated test helpers into shared files and merge repeated tests. Shorten stale and overlong comments.
|
This push fixes the two blocking review findings on the previous head, and the wider cases behind them:
Each fix has a test that fails without it. I also rebased onto current |
|
Closing this in favor of a series of small PRs. At 209 files it was too large to review, and it needed a rebase every few days. The series is tracked as
The per-area migrations follow one at a time, each removing its own rows from the native-dialog allowlist in |
Problem / Motivation
Goal: Replace every production renderer browser dialog with KiroCrew-native confirmation, notice, or text-entry UI.
KiroCrew desktop still invoked browser-native confirmation, alert, and prompt APIs in renderer workflows. Those dialogs are unthemed and can interrupt the renderer. The remaining session-close and draft-leave paths also could not await an in-app confirmation safely.
Why it matters
Users see a consistent KiroCrew UI for destructive actions, errors, acknowledgements, and one-line input. Pending confirmations now remain bound to the initiating navigation or history action, so a later route or Back action cannot apply a stale approval.
Not a goal
beforeunloadwarnings, which must remain synchronous.What changed
This PR migrates confirmations across dashboard and app surfaces, routes alerts to inline notices or the notification feed, and adds
TextPromptDialogfor one-line input.no-restricted-propertiesnow covers every renderer file with no exemptions, and ano-restricted-syntaxrule refuses a leave check tested as a plain boolean (!mayLeave…()), which would skip an open confirmation.The shared navigation leave channel is asynchronous and owns one provider-scoped exit attempt. Route rows, side-panel tabs, the palette, hand-offs, native and popout navigation, history controls and browser Back all settle through one helper,
lib/settleNavigationExit.ts. It takes the leave check itself, so a check that throws or rejects counts as "stay" and still releases the attempt. With no confirmation shown, the action runs in the same click, as onmain. While a confirmation is open, a second exit is dropped, and an approval applies only if the page that asked is still on screen. Browser Back restores its trap before awaiting.Implementation spans
website/eslint.config.js,website/src/App.tsx,website/src/apps/,website/src/components/,website/src/hooks/,website/src/lib/,website/src/pages/,website/src/shell/, andwebsite/src/utils/;website/src/store/installs the feed sinkappNoticewrites through, andwebsite/src/i18n/carries the catalog changes. The related coverage lives inwebsite/src/test/andwebsite/src/guide/, and the screenshots in.github/screenshots/15662/.Wording:
components.confirmDialog.keep_editing); the New crewmate form keeps "Cancel" while a create is in flight, since nothing is editable then.gitops.DEFAULT_COMMIT_MESSAGE, and it is not translated because the backend commits that literal.The Mochi windows load no dashboard stylesheet, so their gallery delete uses an inline-styled confirm with the same contract. Failures with no mounted owner (session duplicate and reload, a blocked pop-out) go to the notification feed and also raise the live banner; a banner note with no body now wraps its title instead of cutting it to one line, and its timestamp parses in the bell feed. The sidebar's session menus close through the sidebar's one action owner, so a close confirmation survives its row moving lane.
This changes presentation only for the destructive confirmations #700 discusses: each still asks before acting. Whether some should become undo flows stays open in #700.
Backwards compatibility
Compatible: existing actions and their browser
beforeunload/ Electron exceptions remain available, with renderer dialogs replaced by equivalent in-app surfaces.Removes nothing: no documented capability is removed. Renderer dialog calls are internally migrated to in-app UI.
useGuardedLeavereaders (SettingsLink, notifications,MembersPageProfile,KiroSignInNotice,GuideContext, and the rest): with no confirmation shown,performruns synchronously in the click, as onmain. While a confirmation is open, a second exit attempt from anywhere is ignored rather than stacking a second dialog, andperformruns only after the user agrees and only if the page that asked is still the one on screen. Aperformmay itself calluseGuardedLeave: the attempt is released first, so the guide's claim-then-enter reachesenter().Visible label changes beyond the dialogs: the channel header's clear button reads "Clear context", and the web-app card's tear-down button reads "Tear down deployment" instead of "Cancel / Tear down". Each shares its key with the dialog's confirm button, so the card names the action the dialog confirms.
Tests
window.confirm/prompt/alertdrives the rendered dialog instead. No test scenario was dropped. Playwright specs that accepted a browser dialog click the themed dialog's button.main: ESLint (--max-warnings 0),tsc,npm run i18n:check, the comment-history, brand and file-line-cap gates pass, and the 464 test files touching changed code pass (9,197 tests). Strict act mode is clean for every test file this PR adds or changes, except 8 cases insrc/guide/GuideLayer.offerAndFinish.test.tsxthat fail identically onmain.Manual verification
The sheets below were rendered in headless Chromium from the real
ConfirmDialog,TextPromptDialog,ErrorNotice,StatusNoticeandNotificationBannercomponents, with the exact strings and options each call site ships, throughwebsite/capture/native-dialog-migration.html(runnode capture/shoot-native-dialog-migration.mjsfromwebsite/). They cover every migrated call site in 53 scenes; call sites with identical wording share a scene. Two scenes render the real component in place: the channel header row, and the web-app card footer with its tear-down button, whose tooltip text is painted beside it because headless shots do not render native tooltips. A running gateway dashboard was not used: minting its dashboard token is blocked by the agent host's policy.Screenshots / video
Each frame is captioned with its call site. Sheets are grouped by area, one per theme.
The files are committed under
.github/screenshots/15662/.Related Issues
Part of #15662
Related to #15976
Pattern harvest
Rule candidate: lint rule (already enforced)
Pattern: Production renderer code must not call browser-native
confirm,alert, orprompt; component-local native surfaces own their equivalent interaction.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
I agree that this contribution is provided under the repository's Apache-2.0 license.