Repository navigation
feat(dashboard): show when a PR's checks are still running - #21357
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: Notes
[DESIGN-REVIEWED] f5ac587 Description read[DESCRIPTION-READ] a690fea6f904251305144a1ac093575be23b5ca4f61b37f42ead661ced781f77 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. All three changed surfaces (chip, banner, Checks tab) appear in light and dark screenshots, and the blind reader read each one correctly. Notes
[UX-REVIEWED] f5ac587 Description read[DESCRIPTION-READ] 18bf204adaca4ee329cbde1523740232f95d514cad587cb75019e6c5cb4a28da That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Every item traces back to the reproduced 101-check case: the chip, the tab and the banner could not tell "failed, still running" apart from "failed, finished". No item duplicates an existing mechanism. What this change shipsInventory (9 items) — 9 justifiedIntent: let someone driving a PR from the dashboard see that CI is still running after a check has failed, without opening GitHub. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] f5ac587 Description read[DESCRIPTION-READ] 445e0c94cc1931962eacdeabccc00dd82e7a3eede47e261b91bd2ae773a6a815 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
ebd8a36 to
92e25d3
Compare
|
|
|
|
|
|
|
|
92e25d3 to
d227c9a
Compare
|
|
|
|
|
|
d227c9a to
dae1ffc
Compare
|
|
|
|
|
cb27ad6 to
edb872d
Compare
|
Rebased onto main 3e39e7a (head edb872d) to pick up #22178, which clears main's Harness Parity Gate red (the proven claude MEMBER_CAPABILITIES allowlist entry) that failed this PR's previous round. No conflicts; range-diff vs cb27ad6 shows the patch identical. Scoped backend tests (1038), flake8/black/isort/mypy, check_harness_parity.py, tsc, eslint, focused vitest, i18n style and i18n:check pass locally. |
|
|
edb872d to
d34a549
Compare
|
Rebased onto main (bdb1c87); new head d34a549. One conflict: |
|
|
|
|
|
d34a549 to
f5ac587
Compare
|
Rebased onto main 8241440 (head d34a549 -> f5ac587). One conflict: docs/system-specs/modules/learn-cron-dashboard.md, where main rewrote the adjacent Chat Folders paragraph next to this PR's ciPending edits to the Pull-request sources paragraph; kept main's text and re-applied the ciPending additions. The PR's own changed lines are byte-identical to d34a549. Backup: backup/feat/pr-checks-running-clarity-d34a549a36. Local gates: tsc, eslint, i18n:check, flake8, mypy, focused vitest (129) and pytest (139), push_guard all pass. |
|
HOLD at f5ac587. The change still reads sound after the rebase. To clear:
— crew-pr-reviewer (r117) |
Problem / Motivation
Goal: While a pull request's checks are still running, the dashboard says so — in the sidebar chip, the Checks tab and the merge banner — even after one check has already failed.
On a PR with 101 checks where one has failed and one is still running, the sidebar chip shows only a red ×, the same as a run that has finished. The Checks tab reads
Checks running 99/101: the fraction counts a failed check as "not complete", so it cannot say whether two checks are still running or one failed and one is running. The merge banner says "Branch protection requirements (approving reviews or required checks) are not yet satisfied", even when the only thing in the way is checks that have not finished.Why it matters
Anyone driving a PR from the dashboard has to open GitHub to learn whether CI is still moving or has stopped. A red × that hides running checks reads as "done, failed", so people act on a run that is not over yet.
Not a goal
runninguntil the pipeline ends.What changed (motivation → approach → change)
Failure wins the CI rollup, so the status the sidebar reads (
ci: failed) could not tell "still running" from "finished". The gateway now projects one more chip-status field,ciPending: "1", when a rollup is failed and a check is still in flight. The PR panel'scheckInFlightalso leaves out a GitLabMANUALgate, which waits on a person, when it counts running checks. Every writer of the chip cache (the GitHub and Bitbucket Server chip reads and the full-payload write-through) sets it through one shared function, a degraded read carries it forward together withci. It is projected for GitHub and Bitbucket Server only, the providers whose chip read computes it; a third-party provider plugin's chip status staysciandstate, so its two reads keep agreeing.Checks failed; others still runningChecks running 99/101Checks 1 running · 1 failed(with nothing failed it keepsChecks running 7/10)blocked), a check failed while others runChecks failed; others still running. 1 failed and 1 still running, of 101 checks. Merging stays blocked until required checks pass and any required reviews are approved.blocked), checks running, none failedMerge blocked.+ branch-protection copyMerge blocked.+Checks are still running. Merging unblocks once required checks pass and any required reviews are approved.(a manual gate alone keeps the branch-protection copy)GitLab and other providers keep the generic
blockedbanner: GitLab reports a merge-gating running pipeline asunstable, so itsblockedmeans something else blocks the MR.ciPendingrides the same allowlists asci(state_parts/source_links.pyprojects it onto source links,ws_event_scope.pystrips it for app tokens). On the client it is typed intypes/index.chat.ts,types/index.sources.tsandchat-sidebar/types.ts, parsed byutils/pullRequestStatusDelta.ts, patched withcibystore/dashboardSlice.tsfromhooks/websocket/serverState.ts, and rendered bychat-sidebar/SessionSourceChips.tsx;components/PullRequestPanel.tsxreads the loaded check list directly. The chip-status shapes indocs/system-specs/modules/learn-cron-dashboard.mdlistciPending. New copy is inen.manual.jsonand every shipped translation underwebsite/src/i18n/locales/.Backwards compatibility
Compatible:
ciPendingis a new optional field. An older client ignores it and keeps renderingciexactly as before; an older gateway never sends it, so a newer client renders today's glyphs.Removes nothing: no field, key or endpoint is removed or tightened; the Checks tab swaps its
complete/totalfraction for explicit counts only while a check has failed and others still run.Tests
test/test_chip_ci_pending.py: the marker is set only for a failed rollup with a check still pending; the chip read and the full payload project it identically; GitLab's aggregate never gets it; a degraded read carries it withci; it is on both wire allowlists.test/test_source_providers_chip_status.py: the full-payload projection's failed-with-pending case keeps its expectation (no provider named, so no marker); its comment now says so.test/test_source_provider_plugin.py: a third-party plugin's chip read never carries the marker, so an older plugin stays steady while a check has failed and others run.test/test_source_providers_bitbucket_server.py: the Bitbucket Server chip read marks a failed-plus-in-progress build like the full payload.website/src/test/PullRequestPanel.test.tsx: the tab says1 running · 1 failed; the tab keepsChecks running N/Mwith nothing failed; the blocked banner leads with the failure when one has failed, says checks are still running otherwise, and keeps the branch-protection copy for a manual gate and for a GitLab MR.website/src/test/ChatSidebar.sourceLinkChip.test.tsx: the chip shows × plus a static dot while checks run, with a tooltip matching its accessible name, and a bare × once they finish.website/src/test/pullRequestStatusDelta.test.ts,website/src/test/dashboardSlice.sourceLinkCiPending.test.ts: a delta keeps the marker only besidefailed, and a CI delta without it clears the sidebar chip's marker.Determinism: the new backend file passed 20 runs at
-n0and 10 at-n 4 --dist loadgroup --max-worker-restart=2beside two sibling files; it andtest_source_providers.py(703 ids) passed shuffled withseed=26744;test_source_provider_plugin.pypassed 20 runs at-n0. The four changed frontend files passed 10 repeats andvitest --sequence.shuffle --sequence.seed=26744. Flake-pattern ratchet and CI-pinned semgrep (1.78.0, diff-scoped) are clean.Manual verification
Ran
website/scripts/capture-pr-checks-still-running.mjsagainst the built SPA with stubbed APIs, in light and dark themes. Each scene is asserted on the rendered page before its frame is written:failing: 101 checks, 99 passed, 1 failed, 1 running,mergeStateStatus: blocked. Asserts the red banner with both counts,Checks 1 running · 1 failed, and the chip's × plus dot.waiting: 101 checks, 100 passed, 1 running, nothing failed,blocked. AssertsMerge blocked.withChecks are still runningand the tab'sChecks running 100/101.Screenshots / video
A check failed while others run (101 checks): sidebar chip
#7001shows × plus the amber dot (#7000, a finished failure, a bare ×), the banner is red with both counts, the Checks tab reads1 running · 1 failed.Checks still running with nothing failed (101 checks): amber
Merge blocked. Checks are still running. …, the tab keepsChecks running 100/101, the chip shows only the amber dot.Dark theme
Related Issues
None: no tracking issue was filed for this change, at the author's request.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)