Skip to content

fix(capabilities): offer the mate tools to an existing crewmate - #21404

Closed
rubencu wants to merge 2 commits into
kirodotdev:mainfrom
rubencu:fix-mate-tools-existing-crewmate
Closed

rubencu wants to merge 2 commits into
kirodotdev:mainfrom
rubencu:fix-mate-tools-existing-crewmate

Conversation

@rubencu

@rubencu rubencu commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An existing crewmate whose template lacks the goal tools (kirocrew-mate) can be given them from its Capabilities page, with the same rows a new crewmate gets at creation.

Reported from a live 0.10.0.1 install. #20611 gives new crewmates the kirocrew-mate tools at creation, and its "Not a goal" says an existing crewmate "can still add the server from its Capabilities page". That option does not exist:

Cause: CapabilityService.get builds the pane's rows from the member's own spec, so a server that spec lacks never appears. The PUT path already accepts a MEMBER_PLATFORM_SERVERS key the Parent lacks (the platform branch in CapabilityService._project), but nothing in the pane sends it, and grant_mate_tools_to_new_member runs only from the three create paths.

Why it matters

A crewmate created before 0.10, or bound later to a template without the server, cannot propose goals, milestones or check-ins, or record milestone readings, so its owner sets everything by hand on the Goals tab. For a conductor crewmate, Goals-tab check-ins are the only cadence that outlives its 7-day patrol loop. Every conductor-template crewmate on an upgraded install is in this state.

Not a goal

  • Granting the server to existing crewmates automatically (a backfill, a doctor fix or a gateway-start migration). fix(crew): give every new crewmate its goal tools and prompts #20611 excludes changing existing crewmates; here the owner opts in per crewmate.
  • Changing what a crewmate gets: the offer carries exactly the rows creation writes, under creation's skip rules.
  • Changing what creation does; it only shares its eligibility rule with the offer now.
  • Rewording the note every managed row shows ("Comes with the template — read-only here"), which this server's row also shows once saved.
  • Any other platform server: MEMBER_PLATFORM_SERVERS holds only kirocrew-mate.

What changed (motivation → approach → change)

Symptom (no way to add the server) → cause (rows come only from the member's spec, so the platform branch is unreachable from the pane) → change (the view carries the missing rows as an opt-in the pane renders):

  • member_mate_tools.platform_offer(snap, view) (new). Returns None, or the mate set as {value, operations}: operations are exactly the rows creation saves (the server's {"disabled": false} set, the @kirocrew-mate tools reference and each _MATE_AUTO_GRANTS approval not already covered), and value is the safe view of the copy's entry, display only. It offers only when the Parent carries no entry for the server (mounted or muted) and the member has no row for it (set or removed), and never for the default kirocrew template or the default member, when POLICY ∩ PROFILE withholds the server (fail-closed, as creation asks), when a build would not emit it, or when member_backend_warning flags the member's spec. It never raises: no offer instead.
  • _mate_operations (extracted from _grant): the eligibility rule creation and the offer share, so the pane never offers rows creation would refuse. _grant keeps its order and outcome codes.
  • CapabilityService.get (agent_capabilities.py) attaches platform_offer (null when there is none), so the GET, PUT and stop-following replies carry it; previews do not.
  • Pane (CrewCapabilitiesPane.tsx, crewCapabilities.ts). The offer is one checkbox atop the MCP Servers tab, behind every row's read-only gate, which a line beside it names (Follow the parent template). Its first line says saving adds the tools to this crewmate only, not to others on the template, and auto-approves them; its help names each (the goal tools, update_self, the change-card tools), and neither is muted. Ticking adds the offer's operations to the draft and unticking drops only them; it reads ticked only while the draft holds each unchanged, so removing or muting the added server unticks it. The added server renders through a new optional addedNote prop on CapabilityRowEditor: while set, its note ("Added for {name} only — not part of the template") replaces the template's; with nothing in the Parent to inherit or restore, it has no Inherited state and, once Removed, no restore button; the box adds it back, as do the row's own Enabled box and Override. Once saved, the row is read from the member's spec like any managed row, with the managed-row note, as "Not a goal" says.
  • Five crewCapabilities.platformOffer* catalog keys in all 12 website/src/i18n locales; en-XA regenerated.
  • Docs: docs/system-specs/modules/crew-mode.md, src/kiro_crew/docs/agent-spec-fields.md, src/kiro_crew/docs/crew-members.md.

Security: no new route or listener; the GET, preview and PUT handlers and their require_owner_dashboard_request owner gate are unchanged. The offer is an informational field on the owner's view, and the PUT path does not read it. Granting still takes the owner's reviewed preview token and PUT, which refuses any managed transport other than {"disabled": bool} (managed_transport_locked) and takes the entry from managed_member_transport. The approvals are exactly _MATE_AUTO_GRANTS, which creation already grants and config/defaults.json ships on the default template; governance still filters the saved copy (_sanitize_projection). test_only_the_owner_sees_or_saves_the_offer pins the 403s.

Backwards compatibility

Compatible: the view gains an optional platform_offer field (null when there is no offer); every request shape, validator and saved file format is unchanged, and creation returns the same outcomes.

Removes nothing: the diff adds a view field, a pane control, an optional row-editor prop, five catalog keys and docs; _grant's inline checks moved into a shared helper with the same order and results.

Tests

test/test_member_mate_tools.py:

  • test_an_existing_member_is_offered_what_creation_grants: a shared member on a template without the server, with no private copy, has no row for it and is offered exactly creation's operations as {value, operations}; offering writes nothing.
  • test_saving_the_offer_gives_the_next_session_the_mate_tools: saving the offer writes a copy with the default template's entry (no disabled key, native_mount_withholding is None), @kirocrew-mate and every _MATE_AUTO_GRANTS approval. The chat-start seam (prepare_member_capabilities) launches the server, member_has_mate_tools turns true, the offer becomes null, and peer B is untouched.
  • test_a_member_of_an_owned_conductor_template_gets_the_refreshed_entry: the report's shape (owned kirocrew-conductor with a derived permissions block) goes through the owned-parent refresh and lands the same rows.
  • test_an_enrolled_member_is_offered_it_too.
  • test_a_member_with_a_legacy_private_copy_is_offered_it_and_keeps_its_choices: a member bound to a private copy from before enrollment (legacy_snapshot) has no row for the server and is offered exactly what a shared member on that template is; saving it enrolls the member with the server, @kirocrew-mate and every approval, keeps the copy's own prompt, and the offer becomes null.
  • test_no_offer_where_creation_would_skip[mounted|muted|removed|default_template|policy|unavailable|backend]; for the two per-member cases, B is still offered.
  • test_a_parent_that_gains_the_server_is_a_parent_change_not_an_offer.
  • test_an_offer_that_cannot_be_worked_out_is_not_made.
  • test_only_the_owner_sees_or_saves_the_offer[intruder-|owner-some-app]: 403 on GET, preview and PUT for a non-owner and an app-scoped request, nothing written; the owner's GET carries the offer, and its preview and PUT land it over HTTP.

website/src/test/CrewCapabilitiesPane.test.tsx (a platform server the member lacks):

  • for a shared and a legacy_snapshot member: offered behind the enroll box, with a description that reads the enroll line (only while that box is unticked), then the approval line, then the help that names every tool the box auto-approves, neither muted; ticking adds every creation row in one draft, and the added server shows as an enabled managed row with a read-only transport and its own note instead of "Comes with the template — read-only here"; the preview and save bodies carry exactly the offer's operations; after the save the offer is gone and the saved row is enabled;
  • unticking drops the offer's rows and keeps the owner's other edits;
  • unticks once the added server is removed|muted, and ticking again restores every row (fails against a key-only check);
  • gives the added row nothing to inherit or restore, and adds it back through the box|its Enabled box|Override: no Inherited state; once Removed, neither note and no button at all; each way back ticks the box again, and the preview carries every operation of the offer (with the editor's restore button let back onto that row, all three fail);
  • no offer block when the view offers nothing.

Local gates on this head (base 28262982f1): comment-history, brand, focus-cue, feature-map, harness parity, memory-store seam, changelog and decision-ledger history, file-line cap, docs-lint, npm run typecheck, eslint, npm run i18n:check, the src/i18n tests (including the locale style tests), the pseudolocale check, lint:i18n, the theme-color, phantom-class and restyle lints, jscpd, npm run build, the flake-pattern ratchet, black, isort and flake8 on the changed Python files, and mypy. git merge-tree with main 6432cad9ea is clean.

Related sets from scripts/run_scoped_tests.py, run on base 6257f698fe: frontend 399 files, 12,064 tests passed. Backend 1,000 files: 52,721 passed, 32 failed and 15 errors, every one specific to this host and reproduced on a clean origin/main worktree at afed43d2c0: test_cloud_source.py (18; this host's / is owned by uid 65534, which the cloud staging checks refuse), test_dashboard_gallery_approvals.py (15 errors; PlatformCompositionError from this host's enterprise-profile config), test_cli.py doctor tests (10), test_ci_file_shards.py (1), test_ci_pytest_progress.py (1), test_prompt_override_encoding.py (1; an extra warning from this host's installed playwright-cli), and test_skill_search_index.py (1; a timing test that passes when run alone). After the rebase onto main (the same patch), the frontend set passed again on 02eeb00d15 (400 files, 12,004 tests). On this head, the frontend set passed again (400 files, 12,010 tests), and so do the capability test files (test_member_mate_tools.py, the four test_agent_capabilities*.py files and test_session_capabilities.py: 695 tests).

Manual verification

  • Reproduced first on main: the new test_an_existing_member_is_offered_what_creation_grants, run against origin/main 27ab938 sources, finds no kirocrew-mate row for the member and no offer.
  • Checked the reporter's install state, read-only: career-coach and kirocrew-maintainer are both bound to kirocrew-conductor, whose spec carries no kirocrew-mate entry or tools reference, and whose permissions block equals its derivation, so the enroll save is not refused with alternate_permissions_require_review.
  • A save with the offered server set to Removed keeps none of the offer's approvals: the projection drops allowedTools entries whose server is absent, and the preview names all ten as not_connected (checked with a scratch test against the capability editor fixture).
  • Rendered the real CrewCapabilitiesPane in Chromium (Playwright on a static build served through request interception, no listener) for a synthetic crewmate, in both themes, each frame asserting the state it shows: the offer greyed behind the enroll box, with the line naming that box and the approval line; ticked, with the added row and its own note; the review listing the server, the tools reference and every approval; the box unticked after the added server is set to Removed, where the row drops its note and has no button; and, after ticking the box again, saved, where the row shows the managed-row note.
  • Measured what the offer adds to a capabilities read with the capability editor fixture (real transport resolution and policy probe, 200 runs): about 2.3 ms mean per get, run off the event loop by the dashboard handlers. The pane's query never goes stale on its own (staleTime: Infinity), so that read runs when the editor opens a crewmate or its template changes; a save writes its reply into the cache instead of reading again.

Not verified: an isolated pod gateway run (the worktree CLI refuses to boot against this host's enterprise-profile config without the companion package), and a live kiro-cli session loading the saved copy, which the tests cover through prepare_member_capabilities and native_mount_withholding.

Screenshots / video

A synthetic crewmate (atlas-writer, made-up data) on kirocrew-conductor with no private copy, the report's shape. The offer sits at the top of the MCP Servers tab, greyed like every row until Follow the parent template is ticked, which a line beside the box names. Its first line says saving adds the tools to this crewmate only and auto-approves them, and the help below it, in the same body text, names every one:

The offer, greyed until the member follows its parent

Ticked: the server joins the draft as the managed row it becomes (Override, enabled), noted "Added for atlas-writer only — not part of the template", with the Review control live:

The offer ticked, the kirocrew-mate row added to the draft

Review lists the server entry, the tools reference and each approval, flagged before anything is saved:

The review listing the server, the tools reference and every approval

Setting the added server to Removed unticks the box, so it never claims rows the draft no longer holds. The row drops its note and, with nothing in its parent to restore, has no button. The box adds the goal tools back, and so do the row's own Enabled box and Override:

The box unticked after the added kirocrew-mate row is set to Removed

Ticked again and saved: the row is read from the member's spec like any other managed row, so it shows the managed-row note, which "Not a goal" leaves as it is:

The saved kirocrew-mate row with the managed-row note

The other theme of each frame, and the added row's read-only connection settings
light dark
offer, light offer, dark
ticked, light ticked, dark
added row, light added row, dark
review, light review, dark
unticked after Removed, light unticked after Removed, dark
saved, light saved, dark

Committed under temp-screenshots/ with git add -f, as the template prescribes for a fork PR; the maintainer may drop the directory from the tip after merge.

Related Issues

Follow-up to #20611, whose "Not a goal" names this path. Related: #19539. #21430 also edits src/kiro_crew/member_mate_tools.py; the two branches merge cleanly in either order.

Pattern harvest

Rule candidate: review-prompt
Pattern: a PR's "Not a goal" sends the users it excludes to an existing surface ("can still add it from X"), and nobody checks that X offers it; the review should confirm the named path exists before accepting the exclusion.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@rubencu
rubencu requested review from a team and KiroCrewCaptain as code owners October 16, 2026 22:16
@rubencu
rubencu requested a review from bolichen97 October 16, 2026 22:16
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 16, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to ship. Head reviewed: e019681.

What I checked on this head:

  • platform_offers reuses _mate_operations, the same rule creation now runs, so the pane cannot offer rows creation would refuse. _grant keeps its order and outcome codes.
  • The offer is skipped for the kirocrew template, the default member, a Parent that mounts or mutes the server, a member row for it (set or removed), a policy that withholds it, a missing transport, and a backend warning. Any exception gives no offer.
  • value passes through safe_view, and the save still takes the transport from managed_member_transport. The GET, preview and PUT handlers keep the owner gate, and the new HTTP test pins 403 for a non-owner and an app-scoped caller.
  • The handler calls service.get through drained_to_thread, so the extra policy probe does not run on the event loop.
  • The pane renders the offer inside the same disabled fieldset as every row. Ticking adds all of the offer's operations, and unticking drops only those keys.
  • The committed screenshots follow the PR template rule for a fork PR.

No blocking or should-fix findings from me. Approval waits on the remaining required checks and the readiness label for this head. Backend, frontend and E2E jobs are still queued, and the review lanes have not posted a verdict for this head yet.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of faec428c44b6bf3126f0d3d9196d1a7f8dfe1291 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] faec428

Description read

[DESCRIPTION-READ] 5630723b705f0d064785fab9924e4480231dd9ec2aebd8d9797e201f02331be2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of faec428c44b6bf3126f0d3d9196d1a7f8dfe1291 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

After saving, the added kirocrew-mate row says "Comes with the template — read-only here", which contradicts the "not part of the template" note shown just before.

Watch

  • The row's note flips to its opposite on save. Before saving, the added row reads "Added for atlas-writer only — not part of the template" (attachment-05/06). After saving it reads "Comes with the template — read-only here" (attachment-12, kirocrew-mate row). The user just read that this server is not from the template, and one save later the page says it is. They can no longer tell whether the tools belong to this crewmate or to every crewmate on the template, which is the exact fact the offer's approval line stressed. This hits every owner who uses the offer, and the note stays wrong for as long as the row exists. The PR's "Not a goal" chose to leave this wording alone, but that choice is what produces the contradiction. Smallest fix: once saved, keep showing platformOfferRow on a managed row the Parent doesn't carry, instead of the template note.
  • Removing the added row leaves no way back on the row itself. In attachment-09/10 the row shows only "Removed" and an unticked "Enabled": no note, no restore button. The way back is the box above, which has now quietly unticked. This is a rare path and the user can recover, so it's low severity. Smallest fix: when state === 'removed' on the added row, keep a one-line note under it pointing to "Add the goal tools" above.

Suggestions

  • The label platformOffer "Add the goal tools ({{server}})" undersells what the box does. It also auto-approves set_model, set_approval_mode and request_capabilities, and only the third line of help text says so. Name both jobs in the label, e.g. "Add goal and self-update tools ({{server}})".

The screenshots show every new control and state: offered, enroll-first, ticked, added row, review, removed/unticked and saved. No first-time reader has looked at them in this lane, so the verdict can't go above CONCERNS.

[UX-REVIEWED] faec428

Description read

[DESCRIPTION-READ] 12bff9983c76f4a760acc84c1f1cbf39444a4c8000bf456aac1d3a204a51cfad

That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of faec428c44b6bf3126f0d3d9196d1a7f8dfe1291 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check on a real upgraded install that career-coach (on the owned kirocrew-conductor template) actually shows the offer: the report came from that path, and only a fixture covers it.

What this change ships

Inventory (8 items) — 8 justified

Intent: let an owner give an existing crewmate, whose template lacks them, the goal tools a new crewmate gets at creation. FIX.

  1. "Add the goal tools" checkbox at the top of the MCP Servers tab, greyed until "Follow the parent template" is ticked — justified
  2. Ticking adds exactly creation's rows (the server, @kirocrew-mate, _MATE_AUTO_GRANTS approvals) to the draft; unticking drops only those — justified
  3. The added server row shows "Added for {name} only" with no Inherited state or restore button — justified
  4. Capabilities GET, PUT and stop-following replies carry platform_offer (null when there is none) — justified
  5. Creation and the offer now share one eligibility rule (_mate_operations) — justified
  6. Row-editor state labels now come from the capabilityLabels.state map instead of inline keys — undeclared, harm-free refactor
  7. Five new catalog strings in 12 locales — justified
  8. Spec and user-doc paragraphs, plus committed screenshots under temp-screenshots/ — justified

[FIRST-PRINCIPLES-REVIEWED] faec428

Description read

[DESCRIPTION-READ] a540ae598c4b9ab8e5d7406036e65afd0ef3b9db6430950d03c42575f7e2564e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed faec428c44b6bf3126f0d3d9196d1a7f8dfe1291 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] faec428

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed faec428c44b6bf3126f0d3d9196d1a7f8dfe1291 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] faec428

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD (policy-sensitive) at e019681.

This PR adds a way to give an existing crewmate the kirocrew-mate server, its tools and every _MATE_AUTO_GRANTS auto-approval. Those approvals include set_model, set_approval_mode, request_capabilities and update_self. A change to what a member is allowed to do is reserved for a human reviewer. The owner gate, the server-chosen transport and governance filtering are unchanged. The eligibility rule is shared with creation (member_mate_tools.py#L230).

Open items on this head, none answered:

  1. UX CONCERNS: the label and help (en.manual.json#L193) describe goal tools only, while ticking the box also auto-approves the self-management tools. The saved row's "Comes with the template" note also contradicts the help text.
  2. Opus advisory: offerAdded (CrewCapabilitiesPane.tsx#L238) checks keys only. If the owner sets the server row to Removed, the save still sends the tools reference and approvals.
  3. First Principles CONCERNS: the list-shaped platform_offers field can only ever hold one item.
  4. Design PASS ask: the cost of the extra policy probe on every GET and PUT.

This clears when a maintainer has reviewed it and each item has a disposition or a fix.

— crew-pr-reviewer (r110)

@rubencu
rubencu force-pushed the fix-mate-tools-existing-crewmate branch from e019681 to dd6bcf1 Compare October 19, 2026 15:15
@rubencu

rubencu commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Dispositions for the findings on e0196813b4, numbered as in the HOLD comment above. The fixes are in dd6bcf16e6 (rebased on main 6257f698fe; still two commits, the fix and the screenshots).

1. UX CONCERNS

  • The label promises less than the box grants. Fixed. The help now names every tool the box auto-approves: "Lets {name} propose its goal, milestones and check-ins and track its progress. It can also change its own name, description and face when you ask, and request a different model, approval mode or tools on a card you confirm. Its parent template does not include these tools. Saving adds them to {name}'s own copy and auto-approves them." crew-members.md and crew-mode.md say the same. I kept the label "Add the goal tools (kirocrew-mate)": the suggested "Let {name} manage its goals" would narrow the promise further, which is this same concern.
  • The saved row's "Comes with the template" note contradicts the help. Deferred. That note is the one every managed row shows. On main, a crewmate enrolled at creation by fix(crew): give every new crewmate its goal tools and prompts #20611 already shows it on this same server, and this PR's "Not a goal" names it. Fixing it needs the row view to say when the Parent lacks a platform server, so the pane can give that row its own note (for example "{productName} keeps this connection current — read-only here"). That is a follow-up rather than part of this PR.
  • No first-time reader has looked at this. No action from me. The refreshed frames, five per theme including the new unticked state, are under temp-screenshots/mate-tools-offer/ for the lane's next run. Every frame uses a synthetic crewmate.

2. Opus advisory: offerAdded checks keys only. Fixed. The box reads ticked only while every offer operation is in the draft with the same row, action and value (sameOperation). Setting the added server to Removed or Inherited, or muting it, unticks the box, and ticking again restores every row. New test: unticks once the added server is removed|inherited|muted, and ticking again restores every row, which fails against the key-only check. Frame 04-edited-unticked-* shows it. A save in that state keeps none of the approvals: the projection drops allowedTools entries whose server is absent, and the preview names all ten as not_connected.

3. First Principles CONCERNS: the list-shaped field. Fixed. The view carries platform_offer: {value, operations} | null. The id field is gone and the pane renders one checkbox.

4. Design PASS ask: the cost on every GET and PUT. Measured on this branch with the capability editor fixture (real transport resolution and policy probe; 200 runs per part, 100 per whole get). The offer adds about 2.3 ms mean per get: transport resolution about 1.0 ms, member_backend_warning about 0.5 ms, the policy probe about 0.05 ms. A whole get went from about 8.6 ms to 11.1 ms mean. PUT and stop-following return get, so each pays it once; previews do not build an offer. The dashboard handlers run get through drained_to_thread, off the event loop.

HOLD gate (policy-sensitive). Only a maintainer can clear this. The offer gives an existing crewmate the _MATE_AUTO_GRANTS approvals, including set_model, set_approval_mode, request_capabilities and update_self, and only on the owner's reviewed save. That is the set #20611 already gives every new crewmate at creation and that config/defaults.json ships on the default kirocrew template; the offer adds no approval outside it. Next step: a maintainer review of dd6bcf16e6. If maintainers want existing crewmates to get fewer approvals than creation grants, that is a decision entry under docs/decisions/, and the offer's operations can follow it.

Note on CI for this head: main's own Fast Gate currently fails its Harness Parity Gate (a stale claude x-capture allowlist row from #22102; #22178 clears it). A run of that gate on this head before #22178 lands fails the same way. This diff touches no harness file.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at head dd6bcf1. I read the incremental diff from e019681 (range-diff of the fix commit; the screenshot commit was regenerated).

The four open items now each have a fix or a disposition:

  1. Help text: platformOfferHelp now names update_self and the change-card tools and says saving auto-approves them, in en.manual.json and all 13 locales. crew-members.md and crew-mode.md match. Deferring the shared "Comes with the template" note is reasonable: every managed row shows it today, and changing it needs a new row signal.
  2. offerAdded now uses sameOperation (same key, action and value). Removed, Inherited or muted unticks the box. The new parametrized pane test covers all three and checks that ticking again restores the full offerOps.
  3. platform_offers (list) is now platform_offer: {value, operations} | null. The id field is gone. Backend, HTTP and pane tests were updated, and the 403 test now checks the new key.
  4. The cost measurement (about 2.3 ms per get, still off the event loop through drained_to_thread) answers the Design ask.

I found no new blocking or should-fix issues in the incremental change. The eligibility rule still comes from _mate_operations, and the save still takes the transport from the server.

Approval waits on these items:

  • The fork CI runs for this head are held for maintainer approval. Readiness is action required and no required check has run on this head yet.
  • The policy-sensitive hold still stands. This offer grants an existing crewmate the same _MATE_AUTO_GRANTS that creation grants, including set_model, set_approval_mode, request_capabilities and update_self. A human maintainer has to sign off on that permission change. An AI review cannot clear it.

@rubencu
rubencu force-pushed the fix-mate-tools-existing-crewmate branch from dd6bcf1 to 94c3280 Compare October 19, 2026 19:15

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 94c3280.

This head is a clean rebase of the previous head dd6bcf1 onto newer main. git range-diff shows both commits identical (=) to the ones reviewed last time, so the PR's own diff is unchanged: the same 32 files, with no .github/ hunk among them. The branch still merges cleanly into current main.

Permission scope: unchanged. The tools offered to an existing crewmate are the same set as on the previous head (set_model, set_approval_mode, request_capabilities, update_self), offered through the same mate server row, with the same opt-in tick and review step.

No new findings: 0 blocking, 0 suggestions. The earlier findings remain fixed.

Not approving yet, for two reasons:

  1. Granting these mate tools to existing crewmates is a permission change. It needs explicit sign-off from a human maintainer rather than an automated approval.
  2. Fork CI on this head is still waiting for approval (readiness: action required), so the build, test and review lanes have not run on it yet.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@rubencu
rubencu force-pushed the fix-mate-tools-existing-crewmate branch from 94c3280 to 5b1efee Compare October 20, 2026 00:27
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 93fabc8, incremental since abdb865. Both heads sit on the same base, so this is a direct interdiff.

What changed:

  • New mark_platform_rows sets platform: true on a kirocrew-mate row the member carries while its Parent has no entry for it, so a saved offer or a creation grant is no longer described as coming with the template. It is skipped when the Parent could not be read, and it drops off once the Parent gains the server.
  • The pane now treats such a saved row like the added row: same note, no Inherited state, and a restore button labelled "Add back" (a new locale key in every file), so no second control on the tab carries the offer's name.
  • "Add back" on a saved row drops a removal made in the draft, and on a saved removal sends set {disabled: false}. I checked that path on the backend: a managed platform server with no Parent entry takes its transport from Crew through _platform_entry, so the draft value still cannot carry a transport.
  • Backend test covers the grant, a saved removal and a Parent that gains the server; pane tests cover the saved row, the draft undo and the saved removal. The spec paragraph matches.

No findings on this increment.

Still open for a human maintainer: this change lets the owner add the mate tools to an existing crewmate with auto approval on save. That permission call is a product decision, so I am leaving it as a comment rather than an approval. Readiness is not passed on this head, and the fork CI runs for it are still waiting for approval.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 20, 2026
@rubencu
rubencu force-pushed the fix-mate-tools-existing-crewmate branch from 93fabc8 to 3fa1693 Compare October 20, 2026 05:36
@rubencu

rubencu commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Dispositions for the review lanes and the review on 93fabc84c7. The fixes are in 3fa1693dcc, on the same base 28262982f1, folded into the PR's two commits again because PR Hygiene allows at most two (MAX_COMMITS: "2" in code-review.yml).

First Principles CONCERNS: the saved row's note contradicts the frozen "Not a goal". Fixed by removing the mechanism, as the lane's "Clears when" names. mark_platform_rows, the platform row flag, the pane's saved-row handling and their tests are gone; the backend files are byte-identical to round 4's dd749a667c. A saved kirocrew-mate row, whether from the offer or from creation's grant, now reads like any managed row, with "Comes with the template — read-only here", as the bullet says (frame 05-saved-*). This also withdraws my previous disposition's note that the bullet's last clause no longer held. Kept: the note on the draft's added row. That row is not saved and is not part of the template, so the template note there would be false, and the bullet scopes the managed note to the row "once saved". The note is now the prop's only field (addedNote).

UX CONCERNS

  • "Copy" jargon. Fixed with the lane's wording, in all 12 languages. platformOfferApproval reads "Saving adds these tools to {name} only (not other crewmates on this template) and auto-approves them." platformOfferRow reads "Added for {name} only — not part of the template". Frames 01 to 04.
  • Two controls for one job. Fixed by removing the row's button. Its Parent has nothing to restore, so the removed added row has no restore button, and the unticked box is the one control that adds the tools back (frame 04-edited-unticked-*). The pane test asserts the row has no button, and it fails when the editor's restore button is let back onto that row. crewCapabilities.platformOfferRestore ("Add back") is gone from every locale.
  • Ambiguous "Override". Kept. "Override" is the state the select shows for every row the member sets itself (crewCapabilities.local). That includes rows its Parent has no entry for, such as a custom connection, an added skill or a tool reference. The legend on the tab defines it as "sets this member's own value", which is what this row does. Renaming it for this row alone would make it the one member-set row that reads differently, and renaming it for every row is outside this fix.
  • Suggestion: "face" → "avatar" in platformOfferHelp. Kept. update_self changes the crewmate's ghost face only. Its schema says "your ghost face", and a crewmate wearing an uploaded picture or an appearance pack keeps it (crew-members.md). "Avatar" is the crew editor's name for the whole setting, picture and pack included, which the tool cannot replace. When the tool runs, the chat line reads "{name} changed its face" (components.selfChange.changed_avatar).

Design PASS: keep CapabilityService.get fast. Same answer as in the previous disposition. The offer costs about 2.3 ms mean per get, and the handler runs get off the event loop. The pane reads it when the editor opens a crewmate or its template changes (staleTime: Infinity), and a save writes its reply into the cache. Removing mark_platform_rows takes its row pass back out of get.

GPT 6.1 and Opus 5.5: no findings.

bolichen97 on 93fabc84c7: no findings, the permission call left to a human maintainer. That is the HOLD (policy-sensitive) above, a maintainer-only gate. Next step: a maintainer review of 3fa1693dcc. Its fork runs also wait for a maintainer's approval.

CI on 93fabc84c7. Every run finished, and CI passed. The first Fork PR Description and PR Readiness runs failed on GitHub API errors, not on the PR: "could not list check-runs … refusing to POST", and "Failed to publish the readiness status" after a read-failed evaluation. Their next runs on the same head passed (39367439307, 39367439357). Sensitive Change Review on the review event waits for a maintainer to approve the fork run.

Rerun on this head:

  • Python, unchanged from dd749a667c: the capability test files (495 tests); black, isort and flake8 on the changed Python files; the black and subprocess-encoding gates, the flake ratchet and mypy.
  • Frontend: the pane tests (90), the src/i18n tests (1,022), typecheck, eslint, i18n:check, the pseudolocale check, the i18n, theme-color, phantom-class and restyle lints, jscpd, the build, and the related frontend set (400 files, 12,008 tests).
  • Diff and docs gates: the Fast Gate diff checks, docs-lint and the file-line cap.
  • Screenshots: the runner passed every frame's assertions in both themes. All 12 frames use a synthetic crewmate, and frame 06 is gone with the saved-row handling.
  • Merges: git merge-tree with main 453cc4b1cc and with fix(members): no briefing upkeep for crewmates without file tools #21430's head a8c833c174 is clean.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention labels Oct 20, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental review since 93fabc8 (rebased onto current main; range-diff read in full). Head 3fa1693.

What changed: mark_platform_rows and the platform: true view marking are gone, the offer and row copy now say the tools go to this crewmate only, and the added row drops its restore button so the checkbox is the one way back. The rebase itself carried no other changes. Backend tests and the pane tests were updated to match.

One 🟡 inline below: with the marking removed, a saved offer row falls back to the generic managed-row note, which describes it as coming with the template.

Still open, unchanged from the last round: auto-granting the mate tools needs a human maintainer to sign off. I am not approving that part. Readiness has not passed on this head yet, and the fork CI is still running.

</div>
{managed && <label className="mt-2 flex items-center gap-2 text-[13px]"><Checkbox disabled={disabled} checked={state !== 'removed' && transport?.disabled !== true} onChange={e => set({ disabled: !e.target.checked })} /><span>{t('pages.hooksPage.enabled')}</span></label>}
{managed && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>}
{managed && !added && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 A saved offer row now claims it comes with the template

Removing mark_platform_rows means nothing tells the pane, once the offer is saved, that kirocrew-mate is the member's own entry for a server its Parent lacks. The view sets managed: true for it (it is in _MANAGED_MCP_SERVERS) and addedNote is only set while the draft holds the offer, so after save this line renders:

{managed && !added && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>}

The owner who just ticked "adds these tools to this crewmate only" then reads "Comes with the template, read-only here" on the same row, and the row is not read-only (its state select and Enabled box both work). The row also offers Inherited again, which for a server the Parent does not carry just drops it. The spec text was updated to accept this ("with the managed-row note"), so this may be deliberate, but the copy contradicts itself across one save.

Suggestion: keep a minimal backend mark for a MEMBER_PLATFORM_SERVERS row the Parent lacks (the old mark_platform_rows did this) and pass offerNote for it as well, or at least suppress the template note for such rows. The removed test assertion that the template note is absent after save is the right check to bring back.

Rule: UI copy must match the state the user just set.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept: this is the PR's frozen goal, which only a human can amend.

  • ## Not a goal, written when the PR opened, keeps this note: "Rewording the note every managed row shows ("Comes with the template — read-only here"), which this server's row also shows once saved."
  • Round 5 did what you suggest. mark_platform_rows marked the saved row, which kept its "Added for {name}" note (bb0181d5ac). First Principles flagged that on 93fabc84c7 as contradicting the bullet, also on the rows creation's fix(crew): give every new crewmate its goal tools and prompts #20611 grant already writes: "Clears when: the mechanism is removed, or a human amends the Goal." Round 6 removed it, and First Principles passes on 3fa1693dcc.
  • A saved offer row is the row creation writes, and main renders that row the same way today. CapabilityRowEditor.tsx on main (6432cad9ea) shows comes_with_the_template_read_only_here on every managed row and offers Inherited on every row, so every crewmate created since fix(crew): give every new crewmate its goal tools and prompts #20611 on a template without the server already reads this note.
  • "Read-only here" refers to the connection settings: a managed row's transport form is disabled (disabled={disabled || managed}), while its state select and Enabled box work. kirocrew-core, kirocrew-dashboard and kirocrew-work read the same in 05-saved-*.

Next step: a maintainer who wants the saved row to keep its own note says so on this PR. I then amend the bullet, with a comment saying why, and bring back the round-5 mark, the note on the saved row and the assertion that the template note is absent after save, in one push. The other way is a follow-up issue that also covers the rows creation writes.

A crewmate whose template lacks kirocrew-mate had no way to get it
after creation: the Capabilities pane builds its rows from the
member's spec, so a server the spec does not carry never shows up,
and the connection picker lists it as managed and disabled. The put
path already accepts that server on a member whose Parent lacks it
(MEMBER_PLATFORM_SERVERS), but nothing in the pane sends it, although
kirodotdev#20611 names the Capabilities page as the way in for crewmates that
existed before it.

The GET view now carries platform_offer: the rows creation grants
(the server, its @kirocrew-mate tools reference and the
_MATE_AUTO_GRANTS approvals) when the member and its Parent both lack
the server and the member has no row of its own for it, and null
otherwise. Creation and the offer share one rule (_mate_operations),
so the default template, a mounted or muted server, a withholding
policy, an unavailable build and a backend that cannot load a private
copy all mean no offer. The pane shows the offer as a checkbox at the
top of the MCP Servers tab, behind the same enroll gate as every
other row, and names that gate while it holds. Its first line says
saving adds the tools to this crewmate only and auto-approves them,
and its help names every one; neither is muted. Ticking it adds the
rows to the draft, where the added server notes that it is this
crewmate's only, not part of the template. Its Parent has nothing to
inherit or restore, so that row offers no Inherited state and, once
removed, no restore button; the box adds it back, as do the row's own
Enabled box and Override. Saving goes through the existing preview and
put; the box reads ticked only while the draft holds those rows
unchanged. Once saved, the row reads like any other managed row.
Evidence for the fork PR, committed under temp-screenshots/ as the
pull request template prescribes when attachments are unavailable.
Every frame uses synthetic data.
@rubencu
rubencu force-pushed the fix-mate-tools-existing-crewmate branch from 3fa1693 to faec428 Compare October 20, 2026 06:58
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@rubencu

rubencu commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Dispositions for the review lanes and the review on 3fa1693dcc. The fix is in faec428c44, on the same base 28262982f1, folded into the PR's two commits again (PR Hygiene allows two).

bolichen97's inline 🟡 and UX Watch 1: the saved row reads "Comes with the template". Kept, answered in the thread: #21404 (comment). The frozen ## Not a goal keeps that note on this server's saved row. Round 5's mark for the row was removed on First Principles' finding ("Clears when: the mechanism is removed, or a human amends the Goal"), and main shows the same note on the row creation writes. Gate: the frozen goal. Next step: a maintainer asks on this PR to amend it, or a follow-up issue that covers creation's rows too.

UX Watch 2: no blind read. The blind read runs for a branch in this repository, and this PR comes from the rubencu/KiroCrew fork. Next step: a maintainer pushes the branch here or waives the read.

UX suggestion: the Removed added row. Kept the row, and corrected a claim of mine that made it look like a dead end. The PR said the box was the one control that adds the row back. In fact the row's own Enabled box and its Override option bring it back too, as on any managed row, and the box reads ticked again because the draft holds the whole offer once more. My previous disposition repeated the claim. crew-mode.md, the pane's comment, the commit message and this description are corrected, and the pane test adds the row back all three ways; each case fails when the editor's restore button is put back on that row. A note sending the owner only to the box would repeat the error. Taking the row out of the draft on Removed would make it vanish while the owner picks a state, where every other row stays with "Removed".

Design PASS: check the screenshots before merge. I opened all 12 committed frames. In 01-offered-light and 01-offered-dark, the offer's label, the line naming Follow the parent template, the approval line and the help are body text and legible; the box is drawn disabled like the other disabled boxes on the page.

First Principles PASS; GPT 6.1 and Opus 5.5: no findings.

bolichen97's review. One correction: there was no rebase. 93fabc84c7, 3fa1693dcc and faec428c44 all sit on base 28262982f1; each push folds that round's fixes into the two commits. The permission call stays with a human maintainer: the HOLD (policy-sensitive) above, a maintainer-only gate. Next step: a maintainer review of faec428c44, whose fork runs also wait for a maintainer's approval.

CI on 3fa1693dcc. Every run finished once a maintainer approved them: CI, Build, Fast Gate and every review lane passed. Four duplicate runs (Code Review, Issue Gate, Screenshot Evidence, Sensitive Change Review) were cancelled, each beside a passing run of the same workflow, and Sensitive Change Review on the review event waits for a maintainer to approve the fork run.

Rerun on this head:

  • Frontend: the pane tests (92), typecheck, eslint on the changed files, jscpd, and the related frontend set (400 files, 12,010 tests).
  • Python, unchanged since dd749a667c: the six capability test files (695 tests; the 495 in my previous disposition left out test_agent_capabilities_publication.py).
  • Diff and docs gates: the Fast Gate diff checks, docs-lint and the file-line cap.
  • Screenshots: unchanged, since the change is a comment, a spec paragraph and the test.
  • Merges: git merge-tree with main 6432cad9ea and with fix(members): no briefing upkeep for crewmates without file tools #21430's head a8c833c174 is clean.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incremental review since 3fa1693. Head faec428.

What changed: no product code. The pane comment and the crew-mode spec now say the added row can be brought back by the offer box, the row's own Enabled box, or Override, which matches what the editor actually does. The pane test is now parameterised over all three ways back and asserts the box reads ticked again and the preview holds the whole offer. That replaces the earlier claim that the box was the only control, so the docs and the behaviour agree again.

My earlier yellow (a saved offer row shows the generic "comes with the template" note) is not changed in code. I accept the disposition: the PR's frozen "Not a goal" explicitly leaves that note alone, the row mark that addressed it was removed on the First Principles finding, and main already shows the same note on the row that creation writes. A follow-up that rewords the managed-row note for both creation and this offer would be the right place for it.

Still open: auto-granting the mate tools to an existing crewmate is a permission call for a human maintainer. I am not approving that part. Readiness is "action required" on this head and the fork CI has not finished.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 20, 2026
@rubencu

rubencu commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Dispositions for the review lanes and the review on faec428c44. No code change this round.

UX Watch 1: the saved row's note flips on save. Unchanged, for the reasons in the thread (#21404 (comment)). The frozen ## Not a goal keeps the managed-row note on this server's saved row, and only a human can amend it. bolichen97 accepts that on this head and names the follow-up: reword the managed-row note for creation's rows and the offer's together. Next step: that follow-up, or a maintainer amending the bullet here.

UX Watch 2: "no way back on the row itself". Not so: the removed row's own controls bring it back. Its unticked Enabled box and the Override option in its state select each re-add the server, and the box above reads ticked again because the draft holds the whole offer once more. The pane test pins all three ways (adds it back through the box|its Enabled box|Override), and the description says so above frame 04. A note pointing only to the box would leave out the two controls on the row.

UX suggestion: name both jobs in the label. Kept "Add the goal tools ({server})". "Goal tools" is the name the code and this PR's user guide give the kirocrew-mate server's tools (member_goals.py and mcp_routes.py on main, crew-members.md here). Under the label, in body text and in the box's accessible description, the approval line says saving auto-approves them, and the help names the other job: "It can also change its own name, description and face when you ask, and request a different model, approval mode or tools on a card you confirm." set_model, set_approval_mode and request_capabilities only offer a change card, which does nothing until the owner presses it.

First Principles PASS: check career-coach on a real upgraded install. Not verified on a live gateway. What is verified: read-only, career-coach on the reporter's install is bound to kirocrew-conductor, whose spec carries no kirocrew-mate entry or tools reference, and test_a_member_of_an_owned_conductor_template_gets_the_refreshed_entry takes the report's shape (an owned kirocrew-conductor with a derived permissions block) through the offer and the save. The branch's gateway does not start against that host's enterprise-profile config without its companion package, as the description says under "Not verified". Next step: open career-coach's Capabilities page on an install running this branch, or on that install once it ships.

Design PASS; GPT 6.1 and Opus 5.5: no findings.

bolichen97 on faec428c44. No new finding. The permission call stays with a human maintainer: the HOLD (policy-sensitive) above, a maintainer-only gate. Next step: a maintainer review of faec428c44.

CI on faec428c44. CI failed on one backend shard and, from it, the Coverage Gate; neither comes from this diff. Backend Tests (3.12, 3) fails test_chat_follow_default_slot_kinds.py::TestSlotCreatorRegistry::test_no_stale_entry and ::test_every_creator_is_classified, both about _import_thread_to_slot. Main's own CI on 6432cad9ea fails the same two tests (https://github.com/kirodotdev/KiroCrew/actions/runs/39378186978): #22110 registered that function under slack/interactions.py, and #22079 then moved it into slack/interactions_options.py. #22433 fixes it and is open. The Coverage Gate fails closed on that shard ("backend-test=failure -- failing closed"), as on main. Every other run passed, apart from cancelled duplicates beside passing runs of the same workflow and Sensitive Change Review on the review events, which waits for a maintainer to approve the fork run. Next step: once #22433 is on main, this head needs a fresh merge ref. A re-run tests the same merge commit (ccaf61b6, this head merged into 6432cad9ea).

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
@rubencu

rubencu commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Merge conflict with #21748, and a design gate. #21748 (merged 19:12Z) retired the Capabilities pane this PR adds the offer to. It deleted CrewCapabilitiesPane.tsx, CapabilityRowEditor.tsx and the pane's test, along with the catalog keys next to this PR's five, so the frontend half has nothing to rebase onto. The backend half still merges cleanly, including with #21430's spec_has_file_write in member_mate_tools.py, but nothing on main reads platform_offer any more.

Gate: main's design now excludes this surface. crew-mode.md says "No dashboard surface edits enrollment, Stop following the parent, per-member MCP or skill rows, or a private copy's template", with agent config edited on the Custom agents tab. CrewApprovalsEditor, the shared editor's only writer of these routes, calls adding an MCP server a custom-agent concern, "so there is deliberately no 'add' affordance here", and has no enrollment checkbox. The offer is exactly a per-member MCP row plus enrollment, so I am not porting it into the shared editor against that. The frozen Goal also names the Capabilities page.

The reported gap is still open on main: an existing crewmate whose template lacks kirocrew-mate has no way to get the goal tools, and #20611's "can still add the server from its Capabilities page" now points at a retired pane.

Next step: a maintainer decides where an existing crewmate gets the goal tools now, for example a decision entry that allows a per-crewmate opt-in for this platform server in the shared editor's Approvals section, or another route. I then port this PR to it, with the Goal amended, or close it. The HOLD (policy-sensitive) above is unchanged.

@rubencu

rubencu commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #21748 removed the Capabilities pane this PR adds the offer to. The gap it fixes, existing crewmates with no way to get the goal tools, is tracked in #22996.

@rubencu rubencu closed this Oct 22, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants