Repository navigation
Conversation
bolichen97
left a comment
There was a problem hiding this comment.
Looks good to ship. Head reviewed: e019681.
What I checked on this head:
platform_offersreuses_mate_operations, the same rule creation now runs, so the pane cannot offer rows creation would refuse._grantkeeps its order and outcome codes.- The offer is skipped for the
kirocrewtemplate, thedefaultmember, a Parent that mounts or mutes the server, a member row for it (set or removed), a policy that withholds it, a missing transport, and a backend warning. Any exception gives no offer. valuepasses throughsafe_view, and the save still takes the transport frommanaged_member_transport. The GET, preview and PUT handlers keep the owner gate, and the new HTTP test pins 403 for a non-owner and an app-scoped caller.- The handler calls
service.getthroughdrained_to_thread, so the extra policy probe does not run on the event loop. - The pane renders the offer inside the same disabled fieldset as every row. Ticking adds all of the offer's operations, and unticking drops only those keys.
- The committed screenshots follow the PR template rule for a fork PR.
No blocking or should-fix findings from me. Approval waits on the remaining required checks and the readiness label for this head. Backend, frontend and E2E jobs are still queued, and the review lanes have not posted a verdict for this head yet.
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] faec428 Description read[DESCRIPTION-READ] 5630723b705f0d064785fab9924e4480231dd9ec2aebd8d9797e201f02331be2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS After saving, the added Watch
Suggestions
The screenshots show every new control and state: offered, enroll-first, ticked, added row, review, removed/unticked and saved. No first-time reader has looked at them in this lane, so the verdict can't go above CONCERNS. [UX-REVIEWED] faec428 Description read[DESCRIPTION-READ] 12bff9983c76f4a760acc84c1f1cbf39444a4c8000bf456aac1d3a204a51cfad That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check on a real upgraded install that What this change shipsInventory (8 items) — 8 justifiedIntent: let an owner give an existing crewmate, whose template lacks them, the goal tools a new crewmate gets at creation. FIX.
[FIRST-PRINCIPLES-REVIEWED] faec428 Description read[DESCRIPTION-READ] a540ae598c4b9ab8e5d7406036e65afd0ef3b9db6430950d03c42575f7e2564e That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
HOLD (policy-sensitive) at e019681. This PR adds a way to give an existing crewmate the Open items on this head, none answered:
This clears when a maintainer has reviewed it and each item has a disposition or a fix. — crew-pr-reviewer (r110) |
e019681 to
dd6bcf1
Compare
|
Dispositions for the findings on 1. UX CONCERNS
2. Opus advisory: 3. First Principles CONCERNS: the list-shaped field. Fixed. The view carries 4. Design PASS ask: the cost on every GET and PUT. Measured on this branch with the capability editor fixture (real transport resolution and policy probe; 200 runs per part, 100 per whole HOLD gate (policy-sensitive). Only a maintainer can clear this. The offer gives an existing crewmate the Note on CI for this head: main's own Fast Gate currently fails its Harness Parity Gate (a stale |
bolichen97
left a comment
There was a problem hiding this comment.
Re-reviewed at head dd6bcf1. I read the incremental diff from e019681 (range-diff of the fix commit; the screenshot commit was regenerated).
The four open items now each have a fix or a disposition:
- Help text:
platformOfferHelpnow namesupdate_selfand the change-card tools and says saving auto-approves them, in en.manual.json and all 13 locales.crew-members.mdandcrew-mode.mdmatch. Deferring the shared "Comes with the template" note is reasonable: every managed row shows it today, and changing it needs a new row signal. offerAddednow usessameOperation(same key, action and value). Removed, Inherited or muted unticks the box. The new parametrized pane test covers all three and checks that ticking again restores the fullofferOps.platform_offers(list) is nowplatform_offer: {value, operations} | null. Theidfield is gone. Backend, HTTP and pane tests were updated, and the 403 test now checks the new key.- The cost measurement (about 2.3 ms per
get, still off the event loop throughdrained_to_thread) answers the Design ask.
I found no new blocking or should-fix issues in the incremental change. The eligibility rule still comes from _mate_operations, and the save still takes the transport from the server.
Approval waits on these items:
- The fork CI runs for this head are held for maintainer approval. Readiness is
action requiredand no required check has run on this head yet. - The policy-sensitive hold still stands. This offer grants an existing crewmate the same
_MATE_AUTO_GRANTSthat creation grants, includingset_model,set_approval_mode,request_capabilitiesandupdate_self. A human maintainer has to sign off on that permission change. An AI review cannot clear it.
dd6bcf1 to
94c3280
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Re-reviewed at 94c3280.
This head is a clean rebase of the previous head dd6bcf1 onto newer main. git range-diff shows both commits identical (=) to the ones reviewed last time, so the PR's own diff is unchanged: the same 32 files, with no .github/ hunk among them. The branch still merges cleanly into current main.
Permission scope: unchanged. The tools offered to an existing crewmate are the same set as on the previous head (set_model, set_approval_mode, request_capabilities, update_self), offered through the same mate server row, with the same opt-in tick and review step.
No new findings: 0 blocking, 0 suggestions. The earlier findings remain fixed.
Not approving yet, for two reasons:
- Granting these mate tools to existing crewmates is a permission change. It needs explicit sign-off from a human maintainer rather than an automated approval.
- Fork CI on this head is still waiting for approval (readiness: action required), so the build, test and review lanes have not run on it yet.
94c3280 to
5b1efee
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Re-reviewed at 93fabc8, incremental since abdb865. Both heads sit on the same base, so this is a direct interdiff.
What changed:
- New
mark_platform_rowssetsplatform: trueon akirocrew-materow the member carries while its Parent has no entry for it, so a saved offer or a creation grant is no longer described as coming with the template. It is skipped when the Parent could not be read, and it drops off once the Parent gains the server. - The pane now treats such a saved row like the added row: same note, no Inherited state, and a restore button labelled "Add back" (a new locale key in every file), so no second control on the tab carries the offer's name.
- "Add back" on a saved row drops a removal made in the draft, and on a saved removal sends
set {disabled: false}. I checked that path on the backend: a managed platform server with no Parent entry takes its transport from Crew through_platform_entry, so the draft value still cannot carry a transport. - Backend test covers the grant, a saved removal and a Parent that gains the server; pane tests cover the saved row, the draft undo and the saved removal. The spec paragraph matches.
No findings on this increment.
Still open for a human maintainer: this change lets the owner add the mate tools to an existing crewmate with auto approval on save. That permission call is a product decision, so I am leaving it as a comment rather than an approval. Readiness is not passed on this head, and the fork CI runs for it are still waiting for approval.
93fabc8 to
3fa1693
Compare
|
Dispositions for the review lanes and the review on First Principles CONCERNS: the saved row's note contradicts the frozen "Not a goal". Fixed by removing the mechanism, as the lane's "Clears when" names. UX CONCERNS
Design PASS: keep GPT 6.1 and Opus 5.5: no findings. bolichen97 on CI on Rerun on this head:
|
bolichen97
left a comment
There was a problem hiding this comment.
Incremental review since 93fabc8 (rebased onto current main; range-diff read in full). Head 3fa1693.
What changed: mark_platform_rows and the platform: true view marking are gone, the offer and row copy now say the tools go to this crewmate only, and the added row drops its restore button so the checkbox is the one way back. The rebase itself carried no other changes. Backend tests and the pane tests were updated to match.
One 🟡 inline below: with the marking removed, a saved offer row falls back to the generic managed-row note, which describes it as coming with the template.
Still open, unchanged from the last round: auto-granting the mate tools needs a human maintainer to sign off. I am not approving that part. Readiness has not passed on this head yet, and the fork CI is still running.
| </div> | ||
| {managed && <label className="mt-2 flex items-center gap-2 text-[13px]"><Checkbox disabled={disabled} checked={state !== 'removed' && transport?.disabled !== true} onChange={e => set({ disabled: !e.target.checked })} /><span>{t('pages.hooksPage.enabled')}</span></label>} | ||
| {managed && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>} | ||
| {managed && !added && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>} |
There was a problem hiding this comment.
🟡 A saved offer row now claims it comes with the template
Removing mark_platform_rows means nothing tells the pane, once the offer is saved, that kirocrew-mate is the member's own entry for a server its Parent lacks. The view sets managed: true for it (it is in _MANAGED_MCP_SERVERS) and addedNote is only set while the draft holds the offer, so after save this line renders:
{managed && !added && <p className="mt-1 text-[12px] text-muted">{t('pages.agentsPage.comes_with_the_template_read_only_here')}</p>}The owner who just ticked "adds these tools to this crewmate only" then reads "Comes with the template, read-only here" on the same row, and the row is not read-only (its state select and Enabled box both work). The row also offers Inherited again, which for a server the Parent does not carry just drops it. The spec text was updated to accept this ("with the managed-row note"), so this may be deliberate, but the copy contradicts itself across one save.
Suggestion: keep a minimal backend mark for a MEMBER_PLATFORM_SERVERS row the Parent lacks (the old mark_platform_rows did this) and pass offerNote for it as well, or at least suppress the template note for such rows. The removed test assertion that the template note is absent after save is the right check to bring back.
Rule: UI copy must match the state the user just set.
There was a problem hiding this comment.
Kept: this is the PR's frozen goal, which only a human can amend.
## Not a goal, written when the PR opened, keeps this note: "Rewording the note every managed row shows ("Comes with the template — read-only here"), which this server's row also shows once saved."- Round 5 did what you suggest.
mark_platform_rowsmarked the saved row, which kept its "Added for {name}" note (bb0181d5ac). First Principles flagged that on93fabc84c7as contradicting the bullet, also on the rows creation's fix(crew): give every new crewmate its goal tools and prompts #20611 grant already writes: "Clears when: the mechanism is removed, or a human amends the Goal." Round 6 removed it, and First Principles passes on3fa1693dcc. - A saved offer row is the row creation writes, and main renders that row the same way today.
CapabilityRowEditor.tsxon main (6432cad9ea) showscomes_with_the_template_read_only_hereon every managed row and offers Inherited on every row, so every crewmate created since fix(crew): give every new crewmate its goal tools and prompts #20611 on a template without the server already reads this note. - "Read-only here" refers to the connection settings: a managed row's transport form is disabled (
disabled={disabled || managed}), while its state select and Enabled box work. kirocrew-core, kirocrew-dashboard and kirocrew-work read the same in05-saved-*.
Next step: a maintainer who wants the saved row to keep its own note says so on this PR. I then amend the bullet, with a comment saying why, and bring back the round-5 mark, the note on the saved row and the assertion that the template note is absent after save, in one push. The other way is a follow-up issue that also covers the rows creation writes.
A crewmate whose template lacks kirocrew-mate had no way to get it after creation: the Capabilities pane builds its rows from the member's spec, so a server the spec does not carry never shows up, and the connection picker lists it as managed and disabled. The put path already accepts that server on a member whose Parent lacks it (MEMBER_PLATFORM_SERVERS), but nothing in the pane sends it, although kirodotdev#20611 names the Capabilities page as the way in for crewmates that existed before it. The GET view now carries platform_offer: the rows creation grants (the server, its @kirocrew-mate tools reference and the _MATE_AUTO_GRANTS approvals) when the member and its Parent both lack the server and the member has no row of its own for it, and null otherwise. Creation and the offer share one rule (_mate_operations), so the default template, a mounted or muted server, a withholding policy, an unavailable build and a backend that cannot load a private copy all mean no offer. The pane shows the offer as a checkbox at the top of the MCP Servers tab, behind the same enroll gate as every other row, and names that gate while it holds. Its first line says saving adds the tools to this crewmate only and auto-approves them, and its help names every one; neither is muted. Ticking it adds the rows to the draft, where the added server notes that it is this crewmate's only, not part of the template. Its Parent has nothing to inherit or restore, so that row offers no Inherited state and, once removed, no restore button; the box adds it back, as do the row's own Enabled box and Override. Saving goes through the existing preview and put; the box reads ticked only while the draft holds those rows unchanged. Once saved, the row reads like any other managed row.
Evidence for the fork PR, committed under temp-screenshots/ as the pull request template prescribes when attachments are unavailable. Every frame uses synthetic data.
3fa1693 to
faec428
Compare
|
Dispositions for the review lanes and the review on bolichen97's inline 🟡 and UX Watch 1: the saved row reads "Comes with the template". Kept, answered in the thread: #21404 (comment). The frozen UX Watch 2: no blind read. The blind read runs for a branch in this repository, and this PR comes from the rubencu/KiroCrew fork. Next step: a maintainer pushes the branch here or waives the read. UX suggestion: the Removed added row. Kept the row, and corrected a claim of mine that made it look like a dead end. The PR said the box was the one control that adds the row back. In fact the row's own Enabled box and its Override option bring it back too, as on any managed row, and the box reads ticked again because the draft holds the whole offer once more. My previous disposition repeated the claim. Design PASS: check the screenshots before merge. I opened all 12 committed frames. In First Principles PASS; GPT 6.1 and Opus 5.5: no findings. bolichen97's review. One correction: there was no rebase. CI on Rerun on this head:
|
bolichen97
left a comment
There was a problem hiding this comment.
Incremental review since 3fa1693. Head faec428.
What changed: no product code. The pane comment and the crew-mode spec now say the added row can be brought back by the offer box, the row's own Enabled box, or Override, which matches what the editor actually does. The pane test is now parameterised over all three ways back and asserts the box reads ticked again and the preview holds the whole offer. That replaces the earlier claim that the box was the only control, so the docs and the behaviour agree again.
My earlier yellow (a saved offer row shows the generic "comes with the template" note) is not changed in code. I accept the disposition: the PR's frozen "Not a goal" explicitly leaves that note alone, the row mark that addressed it was removed on the First Principles finding, and main already shows the same note on the row that creation writes. A follow-up that rewords the managed-row note for both creation and this offer would be the right place for it.
Still open: auto-granting the mate tools to an existing crewmate is a permission call for a human maintainer. I am not approving that part. Readiness is "action required" on this head and the fork CI has not finished.
|
Dispositions for the review lanes and the review on UX Watch 1: the saved row's note flips on save. Unchanged, for the reasons in the thread (#21404 (comment)). The frozen UX Watch 2: "no way back on the row itself". Not so: the removed row's own controls bring it back. Its unticked Enabled box and the Override option in its state select each re-add the server, and the box above reads ticked again because the draft holds the whole offer once more. The pane test pins all three ways ( UX suggestion: name both jobs in the label. Kept "Add the goal tools ({server})". "Goal tools" is the name the code and this PR's user guide give the First Principles PASS: check Design PASS; GPT 6.1 and Opus 5.5: no findings. bolichen97 on CI on |
|
Merge conflict with #21748, and a design gate. #21748 (merged 19:12Z) retired the Capabilities pane this PR adds the offer to. It deleted Gate: main's design now excludes this surface. The reported gap is still open on main: an existing crewmate whose template lacks Next step: a maintainer decides where an existing crewmate gets the goal tools now, for example a decision entry that allows a per-crewmate opt-in for this platform server in the shared editor's Approvals section, or another route. I then port this PR to it, with the Goal amended, or close it. The HOLD (policy-sensitive) above is unchanged. |
Problem / Motivation
Goal: An existing crewmate whose template lacks the goal tools (
kirocrew-mate) can be given them from its Capabilities page, with the same rows a new crewmate gets at creation.Reported from a live 0.10.0.1 install. #20611 gives new crewmates the
kirocrew-matetools at creation, and its "Not a goal" says an existing crewmate "can still add the server from its Capabilities page". That option does not exist:career-coach(templatekirocrew-conductor, created before feat: crewmate goals with milestones, check-ins and reports #19539 and fix(crew): give every new crewmate its goal tools and prompts #20611, no private agent copy) loads none ofgoal_read,set_goal,set_key_results,set_check_ins,key_result_progress,save_goal_reportorupdate_self. Its identity text uses the fallback that sends the owner to the Goals tab.kirocrew-materow and no way to add one. The connection picker listskirocrew-mategreyed out as "Managed by the system; not editable here".kirocrew-maintainer, on the same template, has the same gap.Cause:
CapabilityService.getbuilds the pane's rows from the member's own spec, so a server that spec lacks never appears. The PUT path already accepts aMEMBER_PLATFORM_SERVERSkey the Parent lacks (the platform branch inCapabilityService._project), but nothing in the pane sends it, andgrant_mate_tools_to_new_memberruns only from the three create paths.Why it matters
A crewmate created before 0.10, or bound later to a template without the server, cannot propose goals, milestones or check-ins, or record milestone readings, so its owner sets everything by hand on the Goals tab. For a conductor crewmate, Goals-tab check-ins are the only cadence that outlives its 7-day patrol loop. Every conductor-template crewmate on an upgraded install is in this state.
Not a goal
MEMBER_PLATFORM_SERVERSholds onlykirocrew-mate.What changed (motivation → approach → change)
Symptom (no way to add the server) → cause (rows come only from the member's spec, so the platform branch is unreachable from the pane) → change (the view carries the missing rows as an opt-in the pane renders):
member_mate_tools.platform_offer(snap, view)(new). ReturnsNone, or the mate set as{value, operations}:operationsare exactly the rows creation saves (the server's{"disabled": false}set, the@kirocrew-matetools reference and each_MATE_AUTO_GRANTSapproval not already covered), andvalueis the safe view of the copy's entry, display only. It offers only when the Parent carries no entry for the server (mounted or muted) and the member has no row for it (set or removed), and never for the defaultkirocrewtemplate or thedefaultmember, when POLICY ∩ PROFILE withholds the server (fail-closed, as creation asks), when a build would not emit it, or whenmember_backend_warningflags the member's spec. It never raises: no offer instead._mate_operations(extracted from_grant): the eligibility rule creation and the offer share, so the pane never offers rows creation would refuse._grantkeeps its order and outcome codes.CapabilityService.get(agent_capabilities.py) attachesplatform_offer(nullwhen there is none), so the GET, PUT and stop-following replies carry it; previews do not.CrewCapabilitiesPane.tsx,crewCapabilities.ts). The offer is one checkbox atop the MCP Servers tab, behind every row's read-only gate, which a line beside it names (Follow the parent template). Its first line says saving adds the tools to this crewmate only, not to others on the template, and auto-approves them; its help names each (the goal tools,update_self, the change-card tools), and neither is muted. Ticking adds the offer's operations to the draft and unticking drops only them; it reads ticked only while the draft holds each unchanged, so removing or muting the added server unticks it. The added server renders through a new optionaladdedNoteprop onCapabilityRowEditor: while set, its note ("Added for {name} only — not part of the template") replaces the template's; with nothing in the Parent to inherit or restore, it has no Inherited state and, once Removed, no restore button; the box adds it back, as do the row's own Enabled box and Override. Once saved, the row is read from the member's spec like any managed row, with the managed-row note, as "Not a goal" says.crewCapabilities.platformOffer*catalog keys in all 12website/src/i18nlocales;en-XAregenerated.docs/system-specs/modules/crew-mode.md,src/kiro_crew/docs/agent-spec-fields.md,src/kiro_crew/docs/crew-members.md.Security: no new route or listener; the GET, preview and PUT handlers and their
require_owner_dashboard_requestowner gate are unchanged. The offer is an informational field on the owner's view, and the PUT path does not read it. Granting still takes the owner's reviewed preview token and PUT, which refuses any managed transport other than{"disabled": bool}(managed_transport_locked) and takes the entry frommanaged_member_transport. The approvals are exactly_MATE_AUTO_GRANTS, which creation already grants andconfig/defaults.jsonships on the default template; governance still filters the saved copy (_sanitize_projection).test_only_the_owner_sees_or_saves_the_offerpins the 403s.Backwards compatibility
Compatible: the view gains an optional
platform_offerfield (nullwhen there is no offer); every request shape, validator and saved file format is unchanged, and creation returns the same outcomes.Removes nothing: the diff adds a view field, a pane control, an optional row-editor prop, five catalog keys and docs;
_grant's inline checks moved into a shared helper with the same order and results.Tests
test/test_member_mate_tools.py:test_an_existing_member_is_offered_what_creation_grants: a shared member on a template without the server, with no private copy, has no row for it and is offered exactly creation's operations as{value, operations}; offering writes nothing.test_saving_the_offer_gives_the_next_session_the_mate_tools: saving the offer writes a copy with the default template's entry (nodisabledkey,native_mount_withholdingisNone),@kirocrew-mateand every_MATE_AUTO_GRANTSapproval. The chat-start seam (prepare_member_capabilities) launches the server,member_has_mate_toolsturns true, the offer becomesnull, and peerBis untouched.test_a_member_of_an_owned_conductor_template_gets_the_refreshed_entry: the report's shape (ownedkirocrew-conductorwith a derivedpermissionsblock) goes through the owned-parent refresh and lands the same rows.test_an_enrolled_member_is_offered_it_too.test_a_member_with_a_legacy_private_copy_is_offered_it_and_keeps_its_choices: a member bound to a private copy from before enrollment (legacy_snapshot) has no row for the server and is offered exactly what a shared member on that template is; saving it enrolls the member with the server,@kirocrew-mateand every approval, keeps the copy's own prompt, and the offer becomesnull.test_no_offer_where_creation_would_skip[mounted|muted|removed|default_template|policy|unavailable|backend]; for the two per-member cases,Bis still offered.test_a_parent_that_gains_the_server_is_a_parent_change_not_an_offer.test_an_offer_that_cannot_be_worked_out_is_not_made.test_only_the_owner_sees_or_saves_the_offer[intruder-|owner-some-app]: 403 on GET, preview and PUT for a non-owner and an app-scoped request, nothing written; the owner's GET carries the offer, and its preview and PUT land it over HTTP.website/src/test/CrewCapabilitiesPane.test.tsx(a platform server the member lacks):sharedand alegacy_snapshotmember: offered behind the enroll box, with a description that reads the enroll line (only while that box is unticked), then the approval line, then the help that names every tool the box auto-approves, neither muted; ticking adds every creation row in one draft, and the added server shows as an enabled managed row with a read-only transport and its own note instead of "Comes with the template — read-only here"; the preview and save bodies carry exactly the offer's operations; after the save the offer is gone and the saved row is enabled;unticks once the added server is removed|muted, and ticking again restores every row(fails against a key-only check);gives the added row nothing to inherit or restore, and adds it back through the box|its Enabled box|Override: no Inherited state; once Removed, neither note and no button at all; each way back ticks the box again, and the preview carries every operation of the offer (with the editor's restore button let back onto that row, all three fail);Local gates on this head (base
28262982f1): comment-history, brand, focus-cue, feature-map, harness parity, memory-store seam, changelog and decision-ledger history, file-line cap, docs-lint,npm run typecheck, eslint,npm run i18n:check, thesrc/i18ntests (including the locale style tests), the pseudolocale check,lint:i18n, the theme-color, phantom-class and restyle lints, jscpd,npm run build, the flake-pattern ratchet, black, isort and flake8 on the changed Python files, and mypy.git merge-treewith main6432cad9eais clean.Related sets from
scripts/run_scoped_tests.py, run on base6257f698fe: frontend 399 files, 12,064 tests passed. Backend 1,000 files: 52,721 passed, 32 failed and 15 errors, every one specific to this host and reproduced on a clean origin/main worktree atafed43d2c0:test_cloud_source.py(18; this host's/is owned by uid 65534, which the cloud staging checks refuse),test_dashboard_gallery_approvals.py(15 errors;PlatformCompositionErrorfrom this host's enterprise-profile config),test_cli.pydoctor tests (10),test_ci_file_shards.py(1),test_ci_pytest_progress.py(1),test_prompt_override_encoding.py(1; an extra warning from this host's installedplaywright-cli), andtest_skill_search_index.py(1; a timing test that passes when run alone). After the rebase onto main (the same patch), the frontend set passed again on02eeb00d15(400 files, 12,004 tests). On this head, the frontend set passed again (400 files, 12,010 tests), and so do the capability test files (test_member_mate_tools.py, the fourtest_agent_capabilities*.pyfiles andtest_session_capabilities.py: 695 tests).Manual verification
test_an_existing_member_is_offered_what_creation_grants, run against origin/main 27ab938 sources, finds nokirocrew-materow for the member and no offer.career-coachandkirocrew-maintainerare both bound tokirocrew-conductor, whose spec carries nokirocrew-mateentry or tools reference, and whosepermissionsblock equals its derivation, so the enroll save is not refused withalternate_permissions_require_review.allowedToolsentries whose server is absent, and the preview names all ten asnot_connected(checked with a scratch test against the capability editor fixture).CrewCapabilitiesPanein Chromium (Playwright on a static build served through request interception, no listener) for a synthetic crewmate, in both themes, each frame asserting the state it shows: the offer greyed behind the enroll box, with the line naming that box and the approval line; ticked, with the added row and its own note; the review listing the server, the tools reference and every approval; the box unticked after the added server is set to Removed, where the row drops its note and has no button; and, after ticking the box again, saved, where the row shows the managed-row note.get, run off the event loop by the dashboard handlers. The pane's query never goes stale on its own (staleTime: Infinity), so that read runs when the editor opens a crewmate or its template changes; a save writes its reply into the cache instead of reading again.Not verified: an isolated pod gateway run (the worktree CLI refuses to boot against this host's enterprise-profile config without the companion package), and a live kiro-cli session loading the saved copy, which the tests cover through
prepare_member_capabilitiesandnative_mount_withholding.Screenshots / video
A synthetic crewmate (
atlas-writer, made-up data) onkirocrew-conductorwith no private copy, the report's shape. The offer sits at the top of the MCP Servers tab, greyed like every row until Follow the parent template is ticked, which a line beside the box names. Its first line says saving adds the tools to this crewmate only and auto-approves them, and the help below it, in the same body text, names every one:Ticked: the server joins the draft as the managed row it becomes (Override, enabled), noted "Added for atlas-writer only — not part of the template", with the Review control live:
Review lists the server entry, the tools reference and each approval, flagged before anything is saved:
Setting the added server to Removed unticks the box, so it never claims rows the draft no longer holds. The row drops its note and, with nothing in its parent to restore, has no button. The box adds the goal tools back, and so do the row's own Enabled box and Override:
Ticked again and saved: the row is read from the member's spec like any other managed row, so it shows the managed-row note, which "Not a goal" leaves as it is:
The other theme of each frame, and the added row's read-only connection settings
Committed under
temp-screenshots/withgit add -f, as the template prescribes for a fork PR; the maintainer may drop the directory from the tip after merge.Related Issues
Follow-up to #20611, whose "Not a goal" names this path. Related: #19539. #21430 also edits
src/kiro_crew/member_mate_tools.py; the two branches merge cleanly in either order.Pattern harvest
Rule candidate: review-prompt
Pattern: a PR's "Not a goal" sends the users it excludes to an existing surface ("can still add it from X"), and nobody checks that X offers it; the review should confirm the named path exists before accepting the exclusion.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.