Skip to content

docs(history): list every real-body member history.py keeps - #21456

Merged
iamwhatever merged 1 commit into
mainfrom
refactor/linecap-g17-history-p2
Oct 17, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
refactor/linecap-g17-history-p2

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the history spec name every ConversationLog member with a real body that still lives in history.py, so a reader looking for init, has_log or _cache_key_identities is not sent to the history_* owner modules.

docs/system-specs/modules/history.md lists the members with real bodies that stay on the class after the split (#21014) and says "the rest lives in flat history_*.py siblings". The list left out init, has_log and _cache_key_identities, which history.py still defines.

Why it matters

The spec is where AGENTS.md sends a contributor before they touch session history. A wrong location costs the next reader a search and invites new code in the wrong module.

Not a goal

  • No code change.
  • No other spec edits.

What changed (motivation → approach → change)

The composition section's list of kept members gains the three members history.py still defines (init, has_log, _cache_key_identities). This is the follow-up to #21014, which shipped without this correction.

Backwards compatibility

Removes nothing: a docs-only edit to one sentence of docs/system-specs/modules/history.md.

Tests

N/A — docs only. scripts/docs_lint.py (with --test), the comment-history gate and the brand gate pass on this branch.

Manual verification

N/A — checked that src/kiro_crew/history.py on main defines init, has_log and _cache_key_identities on ConversationLog.

Related Issues

Part of #20192

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The history spec's composition section names the ConversationLog
members with real bodies that stay in the facade and says the rest
live in the history_* owners. It left out init, has_log and
_cache_key_identities, which are still defined in history.py, so the
text pointed a reader at owner modules that do not hold them.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 17, 2026 02:39
@bolichen97
bolichen97 requested a review from buluoray October 17, 2026 02:39
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d775341647541c9241427a081612f2937f6f141b ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d775341647541c9241427a081612f2937f6f141b touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — 🟡 CONCERNS

Design-level review of d775341647541c9241427a081612f2937f6f141b — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The list is still incomplete: _path (the legacy Slack thread_ts filename fallback) has a real body on ConversationLog but stays left out.

Watch

  • The edit leaves out a real-body member. The goal says it will "name every ConversationLog member with a real body that still lives in history.py". But history.py:569 _path has its own logic: the back-compat lookup that returns the bare legacy_key file. The new sentence ("init, has_log, has_messages, session_mtime, _cache_key_identities, delete_session…") doesn't name it. The spec says "the rest lives in flat history_*.py siblings", so a reader looking for the session-file resolution (and the Slack migration fallback) gets sent to the owner modules. That is the harm this PR exists to remove, and the next follow-up would fix the same sentence again.
    Clears when: the sentence also names \_path`, or the PR checks every non-delegating `def` in `ConversationLog` and states that the list is complete.`

[DESIGN-REVIEWED] d775341

Description read

[DESCRIPTION-READ] c6c95a4b38c870257fa8506b574fbc79e9a90aefa18767445fe145b57ec251b4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d775341647541c9241427a081612f2937f6f141b and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d775341

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d775341647541c9241427a081612f2937f6f141b: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d775341647541c9241427a081612f2937f6f141b — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d775341

Verdict parsed from the review's SHA-scoped output markers for commit d775341647541c9241427a081612f2937f6f141b.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d775341647541c9241427a081612f2937f6f141b: <one-sentence reason>

@bolichen97

bolichen97 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor Author
  • The edit leaves out a real-body member — rebutted (the paragraph already names _path; the list is complete)

_path is named in the sentence right before the list: "It keeps the class's identity and construction (__init__ ...), the transcript path (_path and its pre-migration Slack fallback), the process-wide lock and cache-generation registries ..., the thin delegates ...". The "A few members with real bodies stay on the class too" list adds the members those categories do not cover.
Checked every def in ConversationLog at this head by AST (72 defs, overloads excluded): 62 are a single forwarding call; of the 10 others, __init__ and _path are named in the first sentence, has_log, has_messages, get_unconsolidated, delete_session, delete_memory_consolidation_session and _cache_key_identities are in the list, and list_sessions (two-branch forward to _catalog_projection) and _cache_fill_lock (yields from _read_projection._cache_fill_lock) are thin delegates. init and session_mtime forward to one helper each and are listed because they carry the module's file-system behaviour.
So with this PR the paragraph names every non-delegating member; nothing else is left out.

@bolichen97
bolichen97 enabled auto-merge (squash) October 17, 2026 03:05
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at d775341.

Docs-only edit to one sentence of docs/system-specs/modules/history.md. The three added members (init, has_log, _cache_key_identities) are defined on ConversationLog in history.py at this head. The Design lane's CONCERNS that _path is left out does not hold: the preceding sentence already names _path and its Slack fallback (history.md#L65-L80). I parsed the class at this head and every multi-statement member is either named in the paragraph or a thin delegate, matching the author's disposition. GPT and Opus have no findings, all checks are green, and the base is main.

Reviewed head: d775341

— crew-pr-reviewer (r108)

@iamwhatever
iamwhatever merged commit 4a3b368 into main Oct 17, 2026
102 checks passed
@iamwhatever
iamwhatever deleted the refactor/linecap-g17-history-p2 branch October 17, 2026 06:12
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants