Repository navigation
docs(history): list every real-body member history.py keeps - #21456
Conversation
The history spec's composition section names the ConversationLog members with real bodies that stay in the facade and says the rest live in the history_* owners. It left out init, has_log and _cache_key_identities, which are still defined in history.py, so the text pointed a reader at owner modules that do not hold them.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The list is still incomplete: Watch
[DESIGN-REVIEWED] d775341 Description read[DESCRIPTION-READ] c6c95a4b38c870257fa8506b574fbc79e9a90aefa18767445fe145b57ec251b4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at d775341.
Docs-only edit to one sentence of docs/system-specs/modules/history.md. The three added members (init, has_log, _cache_key_identities) are defined on ConversationLog in history.py at this head. The Design lane's CONCERNS that _path is left out does not hold: the preceding sentence already names _path and its Slack fallback (history.md#L65-L80). I parsed the class at this head and every multi-statement member is either named in the paragraph or a thin delegate, matching the author's disposition. GPT and Opus have no findings, all checks are green, and the base is main.
Reviewed head: d775341
— crew-pr-reviewer (r108)
Problem / Motivation
Goal: Make the history spec name every
ConversationLogmember with a real body that still lives inhistory.py, so a reader looking forinit,has_logor_cache_key_identitiesis not sent to thehistory_*owner modules.docs/system-specs/modules/history.mdlists the members with real bodies that stay on the class after the split (#21014) and says "the rest lives in flathistory_*.pysiblings". The list left outinit,has_logand_cache_key_identities, whichhistory.pystill defines.Why it matters
The spec is where AGENTS.md sends a contributor before they touch session history. A wrong location costs the next reader a search and invites new code in the wrong module.
Not a goal
What changed (motivation → approach → change)
The composition section's list of kept members gains the three members
history.pystill defines (init,has_log,_cache_key_identities). This is the follow-up to #21014, which shipped without this correction.Backwards compatibility
Removes nothing: a docs-only edit to one sentence of
docs/system-specs/modules/history.md.Tests
N/A — docs only.
scripts/docs_lint.py(with--test), the comment-history gate and the brand gate pass on this branch.Manual verification
N/A — checked that
src/kiro_crew/history.pyon main definesinit,has_logand_cache_key_identitiesonConversationLog.Related Issues
Part of #20192
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)