Skip to content

refactor(dashboard): re-point state_parts comments at moved modules - #21492

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/linecap-g04-state-cites
Oct 17, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/linecap-g04-state-cites

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Eight comments in dashboard/state_parts/ name the file that now holds the code they describe.

Two splits that merged after #20507 moved code these comments point at. The S11 split of chat_utils (#21094) moved the injected-row and turn-recovery message bodies into chat_utils_injected_rows.py and chat_utils_turn_recovery.py. The G02 split of slack/gateway.py (#21176) moved the sub-agent slots debouncer into slack/gateway_runtime/subagent_wiring.py. The comments in state_parts/injected_turns.py and state_parts/slots_frame.py still named the old homes.

Why it matters

A reader who follows a comment to find the body it describes lands in a file that no longer has it. These cites were folded into #20507's last refresh and then dropped by a later rebase of that PR, so this restores them.

Not a goal

  • No code or behaviour change.
  • No other comment, doc or spec edits.

What changed (motivation → approach → change)

The two splits moved code. The comments that name it were not updated, because they live in files the splits did not touch. So this PR edits only the comments:

  • seven cites in state_parts/injected_turns.py: chat_utils becomes chat_utils_injected_rows or chat_utils_turn_recovery, matching where each _*_MSG body lives on main;
  • one cite in state_parts/slots_frame.py: slack/gateway.py becomes slack/gateway_runtime/subagent_wiring.py, rewrapped to stay under 100 columns.

Backwards compatibility

Compatible: comment-only edits; no import path, name or behaviour changes.

Removes nothing: only comment text changes.

Tests

No test changes. test_recovery_card_prefixes.py, test_recovery_marker_parity.py and test_state_parts_facade.py read these files and pass (38 passed). flake8, black, docs-lint, comment-history and brand checks pass.

Manual verification

N/A: comment-only change. Each new path was checked against main: _BUSY_RECOVER_MSG, _POSTTOKEN_RECOVER_MSG, _PROMISE_ONLY_CONTINUE_MSG, _COMPACTION_CONTINUE_MSG and _CONN_RECOVER_MSG are defined in chat_utils_injected_rows.py; _MANUAL_RESUME_MSG and _REFUSAL_FALLBACK_RESUME_MSG are defined in chat_utils_turn_recovery.py; the 0.2 s slots flush is in subagent_wiring.py.

Related Issues

Part of #20192

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Eight comments in dashboard/state_parts name the module that holds a
body or constant they describe. Two splits moved those homes:
- chat_utils into chat_utils_injected_rows and chat_utils_turn_recovery;
- slack/gateway.py's sub-agent slots debouncer into
  slack/gateway_runtime/subagent_wiring.py.
The comments now name the new files. Comments only; no code changes.

Part of #20192
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 17, 2026 06:04
@bolichen97
bolichen97 requested a review from mbriones98 October 17, 2026 06:04
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@bolichen97
bolichen97 enabled auto-merge (squash) October 17, 2026 06:05
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 203017a

Description read

[DESCRIPTION-READ] c333753eecb249d554ec522e1926ae647a311e19937496554eb2dfa6818d3fec

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: A reader following a comment should land in the file that actually holds the code it describes. This is a FIX.

  1. Seven comments in injected_turns.py now point at chat_utils_injected_rows / chat_utils_turn_recovery, where each _*_MSG body is defined (verified: 5 in chat_utils_injected_rows.py, 2 in chat_utils_turn_recovery.py) — justified
  2. The comment above _SLOTS_BROADCAST_INTERVAL_S in slots_frame.py now points at slack/gateway_runtime/subagent_wiring.py, which holds the 0.2 s call_later flush (verified at line 481) — justified

[FIRST-PRINCIPLES-REVIEWED] 203017a

Description read

[DESCRIPTION-READ] 793ce30cf7f179a85f55874ce64e0f0054f2ef712312705529ee77e872c72781

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 203017a

Verdict parsed from the review's SHA-scoped output markers for commit 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 203017a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 203017a9d3f1dcf89ddf3e63c226c3398faf8a2d: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: refactor (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits in two state_parts modules re-pointing references at moved modules; no executable line changed.

@bolichen97
bolichen97 merged commit 8c4a3d9 into main Oct 17, 2026
103 checks passed
@bolichen97
bolichen97 deleted the refactor/linecap-g04-state-cites branch October 17, 2026 08:28
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants