Repository navigation
refactor(dashboard): re-point state_parts comments at moved modules - #21492
Conversation
Eight comments in dashboard/state_parts name the module that holds a body or constant they describe. Two splits moved those homes: - chat_utils into chat_utils_injected_rows and chat_utils_turn_recovery; - slack/gateway.py's sub-agent slots debouncer into slack/gateway_runtime/subagent_wiring.py. The comments now name the new files. Comments only; no code changes. Part of #20192
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 203017a Description read[DESCRIPTION-READ] c333753eecb249d554ec522e1926ae647a311e19937496554eb2dfa6818d3fec That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: A reader following a comment should land in the file that actually holds the code it describes. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 203017a Description read[DESCRIPTION-READ] 793ce30cf7f179a85f55874ce64e0f0054f2ef712312705529ee77e872c72781 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: refactor (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits in two state_parts modules re-pointing references at moved modules; no executable line changed.
Problem / Motivation
Goal: Eight comments in
dashboard/state_parts/name the file that now holds the code they describe.Two splits that merged after #20507 moved code these comments point at. The S11 split of
chat_utils(#21094) moved the injected-row and turn-recovery message bodies intochat_utils_injected_rows.pyandchat_utils_turn_recovery.py. The G02 split ofslack/gateway.py(#21176) moved the sub-agent slots debouncer intoslack/gateway_runtime/subagent_wiring.py. The comments instate_parts/injected_turns.pyandstate_parts/slots_frame.pystill named the old homes.Why it matters
A reader who follows a comment to find the body it describes lands in a file that no longer has it. These cites were folded into #20507's last refresh and then dropped by a later rebase of that PR, so this restores them.
Not a goal
What changed (motivation → approach → change)
The two splits moved code. The comments that name it were not updated, because they live in files the splits did not touch. So this PR edits only the comments:
state_parts/injected_turns.py:chat_utilsbecomeschat_utils_injected_rowsorchat_utils_turn_recovery, matching where each_*_MSGbody lives on main;state_parts/slots_frame.py:slack/gateway.pybecomesslack/gateway_runtime/subagent_wiring.py, rewrapped to stay under 100 columns.Backwards compatibility
Compatible: comment-only edits; no import path, name or behaviour changes.
Removes nothing: only comment text changes.
Tests
No test changes.
test_recovery_card_prefixes.py,test_recovery_marker_parity.pyandtest_state_parts_facade.pyread these files and pass (38 passed). flake8, black, docs-lint, comment-history and brand checks pass.Manual verification
N/A: comment-only change. Each new path was checked against main:
_BUSY_RECOVER_MSG,_POSTTOKEN_RECOVER_MSG,_PROMISE_ONLY_CONTINUE_MSG,_COMPACTION_CONTINUE_MSGand_CONN_RECOVER_MSGare defined inchat_utils_injected_rows.py;_MANUAL_RESUME_MSGand_REFUSAL_FALLBACK_RESUME_MSGare defined inchat_utils_turn_recovery.py; the 0.2 s slots flush is insubagent_wiring.py.Related Issues
Part of #20192
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)