Repository navigation
fix(cloud): lead the AWS pre-flight helper row with the edit, link the guide - #21568
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the hardcoded [DESIGN-REVIEWED] 68fd5a2 Description read[DESCRIPTION-READ] 5a49fee2ae96e3d1ba4134702ad8acab57b3a8002c282b5f4bc90fff484e6519 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS One thing to check: What this change shipsInventory (5 items) — 5 justifiedIntent: a user whose Remote Crew set-up pre-flight fails can see which file to edit, or which guide entry to read, without asking anyone. This is a FIX (copy), and it closes #20239.
[FIRST-PRINCIPLES-REVIEWED] 68fd5a2 Description read[DESCRIPTION-READ] 2d08d5bc545e9e00f1dfe1166f03a584d1977e672f551659ebfc8363dd1f4eb5 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The command and file path users must type, Watch
[UX-REVIEWED] 68fd5a2 Description read[DESCRIPTION-READ] 78078e078c7bc456ba1ac86b49bc6a062c75796c0c4d3fe7358d1bcd768b317a That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
b3ca7da to
1e76a69
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
[operator: bolichen97] Disposition: rebutted (not a defect)
|
|
[operator: bolichen97] Disposition: rebutted (the PASS punchline's check, answered)
|
|
[operator: bolichen97] Disposition: rebutted (disproportionate to the frozen goal)
|
|
[operator: bolichen97] Disposition: rebutted (out of the frozen goal)
|
|
[operator: bolichen97] Disposition: rebutted (suggestion kept as is)
|
435ce77 to
91e16e2
Compare
…e guide The credential-helper-missing row now names the AWS config file and the credential_process setting first, drops the hedge, and says how to find the full path (which <name>). A refused Session Manager plugin with no known fix command links the Remote Crew on EC2 guide's pre-flight entry. All 12 catalogs updated. Closes #20239.
|
[operator: bolichen97] Disposition: rebutted (the PASS punchline's Windows check, answered)
|
|
[operator: bolichen97] Disposition: fixed in 68fd5a2
|
|
[operator: bolichen97] Disposition: rebutted (disproportionate to the frozen goal)
|
|
[operator: bolichen97] Disposition: rebutted (suggestion kept as is)
|
91e16e2 to
68fd5a2
Compare
|
[operator: bolichen97] Disposition: rebutted (the PASS punchline's anchor check, answered: disproportionate)
|
|
[operator: bolichen97] Disposition: rebutted (the PASS punchline's Windows check, answered: not a defect)
|
|
[operator: bolichen97] Disposition: rebutted (disproportionate to the frozen goal; same class as spans bda81d2c79f3 and 21baf3433a10)
|
|
[operator: bolichen97] Disposition: rebutted (out of the frozen goal; same class as span ee0eac3d069f)
|
Problem / Motivation
Goal: the Remote Crew set-up pre-flight tells a user exactly which file and setting to edit when their credential helper is not found, and points them at the guide when a refused Session Manager plugin has no known fix command.
Two UX Review findings deferred from #19960:
Why it matters
These rows are the first thing a user sees when Remote Crew set-up fails. A vague sentence sends them hunting for which file to edit, or to "Ask the agent" for something the guide already answers.
Not a goal
cloud/iam.py), which still shows as the row's monospace detail line.What changed (motivation → approach → change)
credentials_helper_missing(all 12 catalogs): leads with the edit, "Give<name>its full path in the credential_process line of your AWS config file (usually~/.aws/config), then re-check.", then why ("The AWS CLI could not find it on the gateway's PATH."), then how and where ("To get the full path, runwhich <name>in a terminal on the computer that runs Kiro Crew, from the account that runs it.":whichonly sees the gateway's PATH there). The hedge is gone. The file path and the command are typed by the user, so they are code constants interpolated as{{file}}/{{command}}(remoteCrewPluginRefusal.ts,credentialHelperMissingSentence), never catalog text.plugin_refused_guidelink label (all 12 catalogs): when a refused plugin has no fix command, the row's step now also linksdocs/guides/remote-crew-on-ec2.md#set-up-pre-flight-credential-helper-not-found-or-plugin-refused, the guide entry that covers both rows.en.context.jsonupdated for both keys;en-XA.jsonregenerated withnpm run i18n:pseudo.Backwards compatibility
Compatible: copy and one added link; no API, setting or behavior change.
Removes nothing: the only removed text is the hedge sentence in one message.
Tests
RemoteCrewPanelPluginRefusal.test.tsx: the no-command refusal row shows the guide link with the exact anchor, outside the alert; a refusal with a command shows no guide link;credentialHelperMissingSentenceleads with the edit, names~/.aws/configandwhich <name>, says to run it on the gateway's computer from its account, and has no hedge.RemoteCrewPanel.test.tsx: the panel-level helper-missing test matches the new lead sentence ("Give sso-cred-helper its full path …") and still pins the CLI's own error on its own monospace line.scripts/capture-aws-preflight-honest.mjsasserts the new copy and the guide link before writing each PNG.npm ci:vitest run src/i18n src/test/RemoteCrewPanel.test.tsx src/test/RemoteCrewPanelPluginRefusal.test.tsx1105 passed;tsc -p tsconfig.app.json, eslint on the touched files,i18n:check,i18n:renderand the related frontend set clean.Manual verification
Rendered the real built SPA with the capture harness above (fixture API), dark and light.
Screenshots / video
Credentials row, helper not found (light):
Refused plugin with no fix command, now linking the guide (dark):
Related Issues
Closes #20239
Pattern harvest
Not generalizable: two copy findings on one row, deferred from #19960's UX review.
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.