Repository navigation
refactor: split llm_helpers.py and mcp_cron.py into owner modules - #21598
Conversation
Sensitive change review
|
Sensitive Change ReviewSensitive files changed:
|
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the full CI suite is green. The facade-mirror patch seams decide whether the many [DESIGN-REVIEWED] 83d1d44 Description read[DESCRIPTION-READ] 4ecec60aca494c7fa90bcddffd4f798597b1dd1370169f42bcb60ea662d2848a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS
Not justified as shipped
What this change shipsInventory (8 items) — 7 justifiedIntent: keep two oversized modules under the 2,000-line cap without changing any caller or patch seam. This is a refactor (mandated by AGENTS.md's line cap), not a fix or an addition.
[FIRST-PRINCIPLES-REVIEWED] 83d1d44 Description read[DESCRIPTION-READ] 57ceaf422afa98c8a01c8e15de3352c20479e607fcdb16987f99060039b32ac1 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
|
|
HOLD at 6aa44e0. This PR has a merge conflict with What I checked at this head: the moved code is near-verbatim by line-multiset comparison, and the This PR also moves the tool-approval gate and the cron shell gate, and it is not purely mechanical: What would clear this: rebase onto — crew-pr-reviewer (r109) |
6aa44e0 to
643c678
Compare
Sensitive change review
|
|
Rebased: main changed |
|
|
|
|
Both files were over the 2,000-line cap (4,042 and 3,870 lines). Each stays the import path and the patch surface as a _facade_mirror facade: a write through it reaches every owner that binds the name, so moved code reads its own globals unchanged. llm_helpers.py becomes a pure facade over llm_helpers_parts/: backend errors, turn usage, model fallback, tool-input denials, tool approval, turn results, turn stream and background turns. The owners read the ACP layer's names from the new agent_sdk/drivers/acp_turn_vocab.py, so llm_helpers.py has no agent-sdk boundary edge left. mcp_cron.py keeps the server itself (call path, caller checks, tool bodies, entry point) over four sibling owners: the shell scanners, the cron gate, the tool list and the cron_list renderings. Source pins that read moved code by path or module text are re-pointed or joined to the owners; registry rows, baselines, the owning specs and doc citations follow the move. Part of #20192
1d35245 to
83d1d44
Compare
Sensitive change review
|
|
Rebased onto main 1862203: #21672 and #21951 rewrote lines next to two of this PR's edits (the |
|
|
iamwhatever
left a comment
There was a problem hiding this comment.
Approving 83d1d44.
This PR touches the tool-approval gate, the cron shell gate and security_posture.py, so I checked that it is a pure move. An AST comparison against merge base 1862203 found every top-level definition from both original files in the facade or an owner module: 107 for llm_helpers.py and 98 for mcp_cron.py. Apart from two docstring-only edits, the loggers' literal names, and _provider_label reaching the same provider_label through the SDK wrapper, they are identical. That includes _resolve_permission and _vet_shell_command. There are no global rebinds or duplicate definitions, and pyflakes finds no undefined names. The NON_EGRESS_REDACTION_MODULES rows follow the redactor calls, whose counts are unchanged (8 in llm_helpers, 20 in mcp_cron).
The First Principles concern about acp_turn_vocab.py is answered at this head with a concrete harm: merging it into acp_vocab would give the provider interface to that module's unfenced importers. The Design check is also answered. CodeQL 1105-1107 are dismissed false positives on byte-identical moved code. CI is green with nothing pending, and the earlier conflict is gone. #21371 tracks the pre-existing order-dependent test.
I did not run the suite locally.
— crew-pr-reviewer (r112)
…me_grant patch-scan spelling) #21753 committed a live claude saved-member-spec capture that a test replays, so the x-capture gate fails main with "allowlisted but now proven; delete the entry". Delete that one row from scripts/check_harness_parity.py. #21598 split llm_helpers.py, and its facade now serves name_grant from llm_helpers_parts/tool_approval.py through its TYPE_CHECKING manifest. test_name_grant_facade's spelling scan read only module-level imports, so it lost the llm_helpers.name_grant spelling (which test_llm_helpers_deny_notice.py patches) and its helper-binding case fails. Count a module-level if TYPE_CHECKING: block as module level. Part of #20192
… edits #21753 committed a live claude saved-member-spec capture that a test replays, so the x-capture gate fails main with "allowlisted but now proven; delete the entry". Delete that row from scripts/check_harness_parity.py. The same commit's three claude captures carry agent_version but no agent_name in their _meta header, so test_acp_frame_replay's live-header check fails against their own initialize agentInfo. Add "agent_name": "@agentclientprotocol/claude-agent-acp" to each header. test_backend_cards_advertised's SET_GATE_ALLOWLIST overstates three counts after recent backend edits (its shrink half fails): drop the acp_cli_overlay.py and model_choice.py KIRO_SLASH_COMMANDS rows (now 0) and lower acp_model_effort.py to 2. #21598 split llm_helpers.py, and its facade now serves name_grant from llm_helpers_parts/tool_approval.py through its TYPE_CHECKING manifest. test_name_grant_facade's spelling scan read only module-level imports, so it lost the llm_helpers.name_grant spelling (which test_llm_helpers_deny_notice.py patches) and its helper-binding case fails. Count a module-level if TYPE_CHECKING: block as module level. Part of #20192
… edits (#22178) #21753 committed a live claude saved-member-spec capture that a test replays, so the x-capture gate fails main with "allowlisted but now proven; delete the entry". Delete that row from scripts/check_harness_parity.py. The same commit's three claude captures carry agent_version but no agent_name in their _meta header, so test_acp_frame_replay's live-header check fails against their own initialize agentInfo. Add "agent_name": "@agentclientprotocol/claude-agent-acp" to each header. test_backend_cards_advertised's SET_GATE_ALLOWLIST overstates three counts after recent backend edits (its shrink half fails): drop the acp_cli_overlay.py and model_choice.py KIRO_SLASH_COMMANDS rows (now 0) and lower acp_model_effort.py to 2. #21598 split llm_helpers.py, and its facade now serves name_grant from llm_helpers_parts/tool_approval.py through its TYPE_CHECKING manifest. test_name_grant_facade's spelling scan read only module-level imports, so it lost the llm_helpers.name_grant spelling (which test_llm_helpers_deny_notice.py patches) and its helper-binding case fails. Count a module-level if TYPE_CHECKING: block as module level. Part of #20192
Problem / Motivation
Goal: Bring
llm_helpers.py(4,008 lines) andmcp_cron.py(3,870) under the 2,000-line cap by moving their definitions into focused owner modules, with every import path and patch seam unchanged.Both files were among the largest hand-written modules in the tree.
llm_helpers.pychanged 13 times in the last week, so each feature PR added to a file nobody could read in one sitting, and the line-cap guard already listed both files as over the cap.Why it matters
The user's rule is that no hand-written file exceeds 2,000 lines. These two files also hold security-relevant code that reviewers have to read whole: the unattended tool-approval gate (
_resolve_permission, 573 lines) and the cron shell gate (_vet_shell_commandand its scanners). Splitting them by responsibility gives each new change one obvious home and keeps the next feature PR from landing on a 4,000-line file.Not a goal
kiro_crew.llm_helpersandkiro_crew.mcp_cronoffer, or to how tests patch them.What changed (motivation → approach → change)
Both files become
kiro_crew._facade_mirrorfacades: the module path stays the import path and the patch surface, and a write through it (monkeypatch.setattr,mock.patch) reaches every owner that binds the name, so moved code reads its own globals unchanged.src/kiro_crew/llm_helpers.pyllm_helpers_parts/:backend_errors427,turn_usage317,model_fallback875,tool_input_denials328,tool_approval797,turn_results250,turn_stream608,background_turns633src/kiro_crew/mcp_cron.pymcp_cron_shell_scan.py938,mcp_cron_vet.py831,mcp_cron_tool_list.py430,mcp_cron_list_render.py430The
llm_helpersowners need the ACP layer's names at run time (EVENT_*,LLMEvent,LLMProvider,AcpError,TurnUsage,resolve_billing_stats, ...), and the agent-sdk boundary gate refuses a newkiro_crew.acp/kiro_crew.providersimport. They read them from a newagent_sdk/drivers/acp_turn_vocab.py, which re-exports exactly the objectsllm_helpers.pyimported (theacp_vocab.pypattern), and_provider_labelreachesprovider_labelthrough theagent_sdk/drivers/acp.pywrapper the sub-agent split added.llm_helpers.pydrops from 5 boundary edges to 0. The facade also imports each owner module under a private alias (from kiro_crew.llm_helpers_parts import turn_usage as _turn_usage): without a real import edge, mypy checked the facade's importers before the owners and reported[has-type]wherehistory_consolidation,subagentandchat_runnerread an owner's name at import time inside one import cycle. Themcp_cronowners are top-level siblings rather than a package. The owner maps and "new work goes to" lines are indocs/system-specs/modules/providers.md(Turn helpers) anddocs/architecture/mcp.md.Backwards compatibility
Compatible: every BASE public name of both modules still resolves on the facade to the same object, pinned by
test/campaign_facade_inventories/kiro_crew.llm_helpers.jsonandkiro_crew.mcp_cron.json; every name the test trees patch through either facade reaches every module that binds it (test_llm_helpers_facade.py,test_mcp_cron_facade.py,test_facade_mirror_guards.py).The public module-level defs below moved out of
llm_helpers.py/mcp_cron.py; each is still served by the facade:Reader: src/kiro_crew/llm_helpers.py:is_transient_backend_error -- chat -- served from
llm_helpers_parts/backend_errors.py(same object); pinned by test/test_acp_credential_propagation_retry.pyReader: src/kiro_crew/llm_helpers.py:is_prompt_busy -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);channel.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:is_context_overflow_error -- chat -- served from
llm_helpers_parts/backend_errors.py(same object); pinned by test/test_context_overflow_recovery.pyReader: src/kiro_crew/llm_helpers.py:acp_error_is_transient -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);acp/session_handle.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:acp_error_is_session_not_found -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);acp/transport_errors.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:acp_error_needs_fresh_credentials -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);channel.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:credential_give_up_text -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);channel.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:acp_error_after_tool_activity -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);slack/gateway.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:transient_retry_delay -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:acp_error_is_connection_failure -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:connection_recovery_open -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:connection_retry_delay -- chat -- served from
llm_helpers_parts/backend_errors.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:first_advertised_fallback -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:fallback_rewound_transient_budget -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:fallback_story_of -- chat -- served from
llm_helpers_parts/model_fallback.py(same object); pinned by test/test_llm_helpers.pyReader: src/kiro_crew/llm_helpers.py:append_fallback_story -- cron -- served from
llm_helpers_parts/model_fallback.py(same object);heartbeat.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:annotate_model_fallback -- cron -- served from
llm_helpers_parts/model_fallback.py(same object);slack/gateway_runtime/cron_dispatch.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_fallback_active -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_model_pin_refused -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_handlers.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_model_pin_partial -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);slack/gateway.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:next_fallback_candidate -- chat -- served from
llm_helpers_parts/model_fallback.py(same object); pinned by test/test_llm_helpers.pyReader: src/kiro_crew/llm_helpers.py:advance_fallback_candidate -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_turn/model_fallback.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:pick_epoch_host -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);decisions/points/model_route.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:route_baseline_latch -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:latch_route_baseline -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:slot_switch_session_lock -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/session_control.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:resolve_substitute_set_model -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_advertised_ids -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);decisions/points/model_route.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_backend -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);decisions/points/model_route.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_active_model -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_raw_model -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:probe_fallback_restore -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_turn/model_fallback.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:configured_fallback_chain -- chat -- served from
llm_helpers_parts/model_fallback.py(same object);dashboard/chat_turn/model_fallback.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:record_interaction_event -- chat -- served from
llm_helpers_parts/turn_usage.py(same object);dashboard/chat_runner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:run_bg_oneliner -- chat -- served from
llm_helpers_parts/background_turns.py(same object);dashboard/card_lifecycle.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:usage_has_billing -- chat -- served from
llm_helpers_parts/turn_usage.py(same object);dashboard/chat_utils_turn_recovery.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:provider_last_turn_usage -- chat -- served from
llm_helpers_parts/turn_usage.py(same object);providers/base.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:background_turn -- chat -- served from
llm_helpers_parts/background_turns.py(same object);history_consolidation_pass.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:unfinished_turn_error -- chat -- served from
llm_helpers_parts/turn_stream.py(same object);cli_chat.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:stream_and_collect -- app -- served from
llm_helpers_parts/turn_stream.py(same object);apps/builtins/issue_radar/backend/http_routes/ai.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:stream_and_collect_json -- subagent -- served from
llm_helpers_parts/turn_stream.py(same object);taskrunner.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:parse_llm_json -- app -- served from
llm_helpers_parts/turn_results.py(same object);apps/builtins/issue_radar/backend/http_routes/ai.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:parse_llm_json_list -- chat -- served from
llm_helpers_parts/turn_results.py(same object); pinned by test/test_llm_helpers.pyReader: src/kiro_crew/llm_helpers.py:save_conversation_turn -- chat -- served from
llm_helpers_parts/turn_results.py(same object);slack/transport_dispatch.pyimports it from the facadeReader: src/kiro_crew/llm_helpers.py:save_conversation_turn_off_loop -- chat -- served from
llm_helpers_parts/turn_results.py(same object);slack/transport_dispatch.pyimports it from the facadeReader: src/kiro_crew/mcp_cron.py:vet_job_at_fire_time -- cron -- served from
mcp_cron_vet.py(same object);slack/gateway.pyimports it from the facadeLogger names are unchanged: every owner binds
logging.getLogger("kiro_crew.llm_helpers")/("kiro_crew.mcp_cron")(L25), so thecaplogcaptures keyed on those names (test_llm_helpers_deny_notice.py,test_cron_app_disabled_fire_time_gate.py) still see the records. Moved classes (FallbackState,ToolApprovalPolicy,PromptBusyExhaustedError,_ScanTooComplex) report their owner's__module__; nothing reads it (no pickling,__module__/__qualname__assertion or user-visible class path; checked by the patch-seam sweep).Move audit
_provider_label: its two lazy ACP imports becomekiro_crew.agent_sdk.drivers.acp.provider_labelandkiro_crew.agent_sdk.drivers.acp_turn_vocab.PROVIDER_LABEL_DEFAULT, still lazy inside itstry(providers.acpis still read at call time); its docstring's "this module" nameskiro_crew.llm_helpers.usage_has_billing: docstring reworded for the comment-history gate (drops(#6758))._steer_host_deny: docstring only -- "this module" / "the file" now namekiro_crew.llm_helpers, since its deny sites span two owners (this edit takesllm_helpers.pyfrom 98.5% to 96.4% moved unchanged; both targets together 98.3%).If: BASE's oneTYPE_CHECKINGblock (ConversationLog,HookManager) goes to the owners that annotate with them._TRANSIENT_MARKERS' two#1550references reworded (comment-history); the# ── Stream and Collect ──header dropped frombackground_turns(it would head the wrong owner).loggerper owner, the facades' owner loop, mirror install andTYPE_CHECKINGmanifests, andllm_helpers.py's private owner-module aliases (the mypy ordering above).L36 (default vs
--minimaladded lines, per file):mcp_cron.py164/164; every other changed file equal;llm_helpers.py249/243 — the six differing added lines are all blank (a pure-glue facade). Layout search: 72 glue-order/logger layouts, 256 top-level blank-line layouts, 31 in-block blank-line patterns and the no-facade-logger shape; none is equal, and the closest equal layout needsgetLogger(__name__), which breakspython -m kiro_crew.llm_helpers.Diff: 798,447 bytes.
Prose citations (L29):
CONTRIBUTING.md:253now says cron tools live inmcp_cron.py(their bodies) andmcp_cron_tool_list.py(their schemas). The other doc edits are the owning specs' file-form citations (sel.md,history.md,subagent.md,governance.md,platform-context.md,learn-cron-dashboard.md,resource-protection.md) and the RFC line citellm_helpers.py:299->llm_helpers.run_bg_oneliner.Upstream ports (L16), each carried byte for byte by re-running the recipe on the new main: #19745's READ_ONLY
deepseek_read_only_issuebranch moves with_resolve_permissionintollm_helpers_parts/tool_approval.py; #20973'scloud_credential_errorrecycle (acp_error_is_session_not_found,acp_error_needs_fresh_credentials,credential_give_up_text,CREDENTIAL_RELOAD_RETRY_NOTICE) moves intollm_helpers_parts/backend_errors.py; #20687'ssensitive_write_path_refusalimport and_edit_target_denialwrite-path branch move intollm_helpers_parts/tool_input_denials.py; #21907's throttle pieces (THROTTLE_RETRY_BASE_DELAY,throttle_retry_delay,acp_error_is_throttle, and theprovider_error_clientimport they read) move intollm_helpers_parts/backend_errors.py.Baselined growth (L56 addendum 1b):
src/kiro_crew/security_posture.pymain row 3,181, BASE 3,449, HEAD 3,452 —NON_EGRESS_REDACTION_MODULESpath rows only:llm_helpers.pybecomesllm_helpers_parts/model_fallback.py(same reason comment) plusllm_helpers_parts/tool_approval.py;mcp_cron_list_render.pyandmcp_cron_vet.pybesidemcp_cron.py.Baselines: line-cap rows for both targets deleted;
.github/agent-sdk-boundary-baseline.txtrow5 src/kiro_crew/llm_helpers.pydeleted (0 edges); theline-refdocs-lint row forrfc-resumable-subagent-sessions.md/llm_helpers.py:299deleted (the cite is nowllm_helpers.run_bg_oneliner).Tests
test/test_llm_helpers_facade.py,test/test_mcp_cron_facade.py: every name the test trees patch through the facade reaches every module holding it (with a known-seams non-vacuity check), owners = the package /mcp_cron_*.pysiblings in layer order, each served outside name is visible to type checkers, one logger named for the facade,python -m <facade>still imports, and (llm_helpers) eachacp_turn_vocabnameisitskiro_crew.acp/kiro_crew.providersobject and onlyllm_helpers_partsimports it at run time.test_llm_helpers_deny_notice.py(deny-site walk over facade + owners),test_crew_log_resolver.py,test_meetings_session.py,test_name_grant_surfaces.py(facade +llm_helpers._OWNERS),test_start_priority.py(path),test_transport_permission_floor.pyandtest_hooks.py(row re-key),test_mcp_call_site_auth_coverage.py(mcp_cron_*.pyglob),test_skill_home_paths.py,test_instance_credential_pairing.py(owner rows),test_security_posture.py(census row) andsecurity_posture.py(NON_EGRESS_REDACTION_MODULESrows).security_posture, plus everyrglob/source_corpustree scanner;scripts/local-gate.py --dry-runselects 2,156 backend files, so the full set is CI's): 39,744 passed, 1 failed —test_external_logout_detection_retirement.py::TestRetirementCoverage::test_every_sid_writer_is_registration_or_identity_fencedhit the 120 s timeout at host load 52 and passes alone in 44 s (environmental, not this change). Coldmypy src/kiro_crew: no issues in 2,695 files. Facade and mirror guards re-run after the last facade edit: 320 passed.tmp_path/monkeypatch, and read sets sorted; the two new files passed 5 runs at-n0and one at-n 3;test_flake_pattern_ratchet.pypasses.Manual verification
N/A — a structural move proven by the move audit and the facade/seam tests; an
env -iimport smoke and an installed-wheel import of every new module ran clean (15 modules imported from the wheel built from agit archiveexport).Related Issues
Part of #20192
Follow-up: #21371 (pre-existing order-dependent
selbinding;test/test_name_grant_surfaces.py::TestGatewayReadsModeSurface::test_refused_grant_falls_to_the_human_promptfails aftertest/test_llm_helpers_deny_notice.pyin one process, on unmodified main too)Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)