Repository navigation
Conversation
4045910 to
53fbe6c
Compare
|
The remaining Cross-Platform Portability hits are the fallback install locations in |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The 14 attachments show every new Signal settings state and both Services rows. No first-time reader has looked at them, because this fork lane has no blind read; pushing the branch to this repository would get one. Notes
[UX-REVIEWED] d81cec1 Description read[DESCRIPTION-READ] 26a4e373025ede142988b4f6c6e7f2846358ecff7111fe36a3f4e8df9ae855ea That sha256 names everything this verdict read: the PR description, plus the 17 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the channel copies the iMessage local-CLI bridge pattern, is off by default, admits nobody until numbers are allow-listed, and adds no listening port. Notes
[DESIGN-REVIEWED] d81cec1 Description read[DESCRIPTION-READ] 73c03562ce2f1df9b3047c52f4893aef40d1b78ff521eb1e024e5169f8ad9268 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The system-prompt rewrite repeats in Notes
What this change shipsInventory (10 items) — 7 justifiedIntent: let a Signal user get notifications from their instance and chat with it through a local signal-cli. ADDITION.
BlockersRe-inlined send_message routes — duplicate of [FIRST-PRINCIPLES-REVIEWED] d81cec1 Description read[DESCRIPTION-READ] d45e27cc926ddaef1a26063664d6726b6b63a67652eabbda1fe342f23652918c That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging. BLOCKING -- src/kiro_crew/signal_cli/client.py:654 -- Disabling Signal leaves its status reporting active
[BLOCK-MERGE] d81cec1 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — MEDIUM rung: a feature reports the wrong thing on a common path (disabling a channel). The status is silently wrong, but nothing is lost. |
53fbe6c to
aaeaefc
Compare
aaeaefc to
eb9e893
Compare
|
Thanks for the reviews. The latest push addresses every finding, each with a regression test that fails without the fix. The fix is still one commit, so the PR stays at a single commit. Opus review
GPT review
Design review
UX review
First Principles review (status reactions) |
bfd2465 to
de2ff2b
Compare
de2ff2b to
352d65a
Compare
ebc8197 to
92ec359
Compare
|
Rebased onto current GPT finding: "Re-adopt Signal configuration after the deferred import" (
This PR used to make
Other rebase fixes
Local verification on
Could the GPT review lane take another look? Still open for maintainers: CI approval for this push, the |
|
@KiroCrewCaptain @chenmingwei23 — this is ready for another look, and it needs a maintainer to unblock CI. Head: What changed since the last bot review (
Adapted to recent
Local verification
Needs a maintainer
Thanks! |
|
For the maintainer taking over Sensitive Change Review: as a fork PR it can't clear the gate itself, so here is the filled template for the current head, ready to paste into an approving review (or to adapt on the takeover branch's head). |
|
For the maintainer taking over Sensitive Change Review: as a fork PR it can't clear the gate itself, so here is the filled template for the current head, ready to paste into an approving review (or to adapt on the takeover branch's head). |
|
@KiroCrewCaptain @chenmingwei23 Gentle ping. This needs one of you to review so we can make progess. |
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 20% chance that this change introduces a defect, above the 12% limit for approving on its own. Additive Signal channel modelled on the iMessage local-CLI bridge, off by default. Trust boundaries checked in code: the allow-list is deny-by-default and matches on number or ACI; groups are refused; Note to Self needs a trusted self identity at both ends, and no envelope can add itself to that set; the echo check runs after the authorization gates; approvals, steering and every command except /help are operator-only; attachments are fetched only after the governance gate; send_document re-checks the allow-list. The settings PUT works only from the local machine, accepts a fixed set of fields with no binary path, and audits. The binary comes from an environment variable or a fixed source list, following the existing KIROCREW_KIRO_BIN precedent. Signal is added to the pod seed-disabled sections and the AWS-control CHANNEL_SECTIONS. The earlier-head blockers are fixed: close() now reports the disconnect through _set_state, the prompt.md rewrite is gone, and the description now matches the code. Shared-module edits mostly add 'signal' to lists, plus one behaviour-preserving filename-screen refactor. Test coverage is extensive. Test/lint/build CI has not run yet because the fork workf An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
Thanks — the config-set note is right: the description was stale. |
Sensitive change review
|
Add Signal as a messaging channel so Kiro Crew can send notifications over Signal and the owner can chat with their instance in the same conversation. The gateway spawns a local signal-cli in jsonRpc mode and speaks newline-framed JSON-RPC over its stdio, like the iMessage bridge, so there is no new inbound network surface. Two setups are supported: a dedicated bot number the owner DMs, or signal-cli linked as a secondary device of the owner's account using Note to Self. Access is a deny-by-default allow-list of E.164 numbers and ACIs; groups and unknown senders get no reply. Note to Self is only recognised from envelopes whose source is an already trusted self identity, and an echo ledger keeps the agent from answering its own replies. A failed start is retried with capped backoff and reported on System > Services. The channel matches WhatsApp's feature set: tool approval by typed reply and /stop, /cancel, /status, /commands, limited to the operator (the account itself, or the sole allow-listed number); inbound pictures, voice notes and documents via getAttachment, outbound files through the shared upload gate, and status reactions; and a Signal section in kirocrew doctor. Each conversation is bound as its session's mirror and origin, so send_message, file_send, cron results and notices reach it. Signal also appears under Settings > Messaging Channels, with live status and a panel for the account, the allow-list and enabling the channel; a save applies without a gateway restart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRUQ2gKoHktUBhx3GDgvqT
Sensitive change review
|
|
@KiroCrewCaptain @chenmingwei23 — rebased again and ready for a look; it needs a maintainer to unblock CI. Head: Changes since the head the approver recommendation was computed on (
Every change above has a test that fails against the code before it. Locally on this head: 3,378 backend tests (Signal suites plus the channel-roster tests Needs a maintainer
Thanks! |
Problem / Motivation
Goal: Let Kiro Crew send notifications over Signal and let the owner chat with their instance in that same Signal conversation, through a local signal-cli.
Kiro Crew can be reached over Slack, Discord, Telegram, WhatsApp, iMessage and others, but not Signal. Someone who uses Signal as their messenger has no way to get cron results, completion notices or
send_messageoutput there, and cannot talk to the agent from it.Why it matters
Signal is a widely used end-to-end-encrypted messenger, and for privacy-minded users often the only one they want an agent on. Without a channel they fall back to the dashboard, or to a messenger they would rather not use, for notifications and for remote control of their instance.
Not a goal
What changed (motivation → approach → change)
Approach. The channel is modelled on iMessage, the existing channel that also drives a local CLI bridge: the gateway spawns
signal-cli -a <account> jsonRpcand speaks newline-framed JSON-RPC over its stdio (reusingimessage.rpc.JsonRpcPeer). There is no listening port and no hosted relay, so no new inbound network surface. A child process was chosen over signal-cli's HTTP daemon mode so there is nothing to bind, authenticate or secure.Setups. Two are supported: a dedicated bot number the owner DMs, or signal-cli linked as a secondary device of the owner's own account, used through Note to Self.
What was built (
src/kiro_crew/signal_cli/):signal.allowed_numbers); an empty list admits nobody. Unknown senders and groups get no reply. Note to Self is recognised only from envelopes whose source is an already trusted self identity, and an echo ledger keeps the agent from answering its own replies.KIROCREW_SIGNAL_CLIenvironment variable, never aconfig.jsonpath (that file is not owner-gated).signal-cli trusthint there.1/2/3,yes/no; 300s, timeout denies), plus/stop,/cancel,/status,/commands. Only the operator may approve, trust, stop or steer: the account itself in the linked setup, else the sole allow-listed number.getAttachment; outbound files through the shared extractor and upload gate; status reactions.kirocrew doctor: offline and redacted.enabled,account,allowed_numbersandsession_folder, and explains both setups. It is backed byGET/PUTendpoints indashboard/handlers/signal_settings.py(its own module, becausehandlers/messaging.pyis over the line cap). The save validates numbers and stores them as+E.164strings, and it refuses unknown keys, so no binary path can be set. A saved allow-list applies live;enabled/accountrestart only the Signal channel.send_message(session="signal"),file_send, cron results and notices reach it.Wiring: config section and builder, channel descriptor, gateway hoist, the cross-cutting channel lists (SEL sources, posture, pod isolation, autonudge, dashboard slots and labels, AWS control
CHANNEL_SECTIONS), and a Services label in the frontend.Phone numbers through
kirocrew config set: no CLI change. As onmain(#25036),config setrefuses an unquoted number, which would otherwise parse as an integer and lose its+and leading zeros, and stores a quoted one as typed.signal-integration.mdshows the quoted form,kirocrew config set signal.account '"+447700900001"', andtest_cli_config_set_strings.pypins both outcomes forsignal.account.Config loading: an unquoted number in
config.json(e.g."allowed_numbers": [447700900001]) is read as+447700900001. Quoting is still recommended: the settings panel writes quoted strings, andkirocrew config setrefuses an unquoted number.Backwards compatibility
Compatible: the channel is off unless
signal.enabledis set, and the newsignalconfig section defaults to disabled.Removes nothing: the diff adds a channel and its wiring; no key, path, record or public function is hidden, renamed, tightened or deleted.
Tests
test_signal_client.py,test_signal_transport.py,test_signal_dispatch.py,test_signal_renderer.py,test_signal_bridge_path.py,test_signal_gateway.py: envelope parsing in both receive shapes, allow-list matching on number or ACI, forged-sync rejection, echo suppression, operator scope, backoff, binary resolution, rendering and splitting.test_signal_e2e.py,test_signal_files_e2e.py,test_signal_approvals.py: the realJsonRpcPeer, client, transport andTurnDriveragainst a fake signal-cli child. They cover:1, deny withno, deny on timeout;test_signal_attachments.py,test_signal_files.py: size caps against the JSON-RPC line limit, filename sanitising, temp-file cleanup including on cancellation, long-text attachments delivered once.test_signal_file_send_origin.py: a Signal-born session'sfile_send(/api/channel/upload-file) is delivered natively instead ofno_channel_destination; Note to Self binds the account; a unified bucket binds nothing.test_signal_config_handlers.py: the settings API keeps+, normalizes and validates numbers, refuses unknown and binary-path keys, writes the audit log, and says which fields restart the channel and which apply live.website/src/test/SettingsSignalPanel.test.tsxcovers the panel's states and warnings; the ChannelsPanel, deep-link, brand-icon and API-surface tests include Signal.test_signal_doctor.py: the doctor section with an injected runner; no full number ever printed.test_signal_config.py,test_cli_config_set_strings.py:enabledneeds a real bool; the loader keeps a quoted phone number's+and leading zeros;config setrefuses an unquoted number with nothing written and stores a quoted one as typed.Manual verification
send_messageand cron delivery.Screenshots / video
Settings → Messaging Channels with the new Signal entry, and the working Signal panel:
Failure, validation and setup states
Failed to start (signal-cli reports the account is not registered):
Saved, but the channel is not running yet:
Account without a leading

+(validation warning, Save disabled):Enabled with no account set:

Bot-number setup with two allowed numbers, so nobody can approve tools or use /stop:

Needs setup (signal-cli not found, empty allow-list):

Note-to-Self hint, which now appears only with an empty allow-list:

Save, read-only and session folder
Save confirmation:
Read-only when opened from a remote session:

Session-folder toggle on:

Signal row on Developer → System → Services
Connected:

Failing, with the reason:
Related Issues
N/A — no tracking issue.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TRUQ2gKoHktUBhx3GDgvqT
Add Signal as a messaging channel so Kiro Crew can send notifications over Signal and the owner can chat with their instance in the same conversation. The gateway spawns a local signal-cli in jsonRpc mode and speaks newline-framed JSON-RPC over its stdio, like the iMessage bridge, so there is no new inbound network surface.
Two setups are supported: a dedicated bot number the owner DMs, or signal-cli linked as a secondary device of the owner's account using Note to Self. Access is a deny-by-default allow-list of E.164 numbers and ACIs; groups and unknown senders get no reply. Note to Self is only recognised from envelopes whose source is an already trusted self identity, and an echo ledger keeps the agent from answering its own replies. A failed start is retried with capped backoff and reported on System > Services.
The channel matches WhatsApp's feature set: tool approval by typed reply and /stop, /cancel, /status, /commands, limited to the operator (the account itself, or the sole allow-listed number); inbound pictures, voice notes and documents via getAttachment, outbound files through the shared upload gate, and status reactions; and a Signal section in kirocrew doctor. Each conversation is bound as its session's mirror and origin, so send_message, file_send, cron results and notices reach it.
Signal also appears under Settings > Messaging Channels, with live status and a panel for the account, the allow-list and enabling the channel; a save applies without a gateway restart.
Claude-Session: https://claude.ai/code/session_01TRUQ2gKoHktUBhx3GDgvqT