Skip to content

fix(doctor): stop flagging skills and the MCP daemon as stale across two installs - #21680

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/20629-doctor-cross-install
Oct 18, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/20629-doctor-cross-install

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a machine with both a source checkout and the desktop app, kirocrew doctor stops reporting byte-identical built-in skills as "does not match" and stops reporting the other install's MCP gateway daemon as stale.

With an app install and a source checkout on one machine, the gateway (and its skill sync) runs from the checkout while kirocrew doctor runs from the app. Doctor then flags 12 built-in skills as "does not match" and flags the MCP gateway daemon as running a different code revision. Neither clears after a restart, or after moving the skills out and letting the sync reinstall them.

Why it matters

Doctor exits with issues on a healthy machine, and its prescribed fixes (restart, move the skill out) cannot clear them. An operator learns to ignore the Installed Skill Currency and MCP daemon rows, so a real stale skill or a real stale daemon goes unnoticed.

Not a goal

  • Changing the provenance marker format or what the sync records.
  • Teaching doctor to judge the other install's daemon against the gateway that owns it.
  • Telling apart two different source checkouts on one machine (both answer with a git revision and still compare).

What changed (motivation → approach → change)

Doctor stops reporting a false mismatch when the skill sync and doctor come from two installs built from the same sources.

Doctor row Why it fired Now
Installed Skill Currency The app build precompiles its tree, so only its packaged skills carry scripts/__pycache__. The marker records the checkout's tree, and the 12 flagged skills are exactly the ones with scripts/*.py. When the marker and the packaged tree differ, the check compares installed and packaged trees with every __pycache__ left out of both. Equal means in step.
MCP gateway daemon The checkout stamps its code with a git revision and the app with an mtime: stamp. Two stamps from different rules are never equal. code_fingerprint.same_scheme spots stamps from different rules. When a live gateway owns that daemon, doctor prints it as another install's, names the owner pid to stop if that gateway should no longer run, adds no issue and prescribes no restart. With no live owner it stays an issue, since this install's gateway may have adopted it.

The skill half lives in src/kiro_crew/skills_builtin_provenance.py: _tree_entries and _skill_tree_fingerprint take a skip_bytecode_caches flag that only the currency check sets. That comparison runs only after the ownership check passed with caches included, so a cache added to the installed copy still reads as edited, and the sync is unchanged. The daemon half is same_scheme in src/kiro_crew/code_fingerprint.py and its one caller in src/kiro_crew/doctor_checks/mcp.py. The doctor rows are described in docs/system-specs/modules/cli.md and docs/system-specs/modules/mcp-gateway-daemon-lifecycle.md.

Backwards compatibility

Compatible: doctor output only. Two rows move from ❌ to ✅ or ⏹ in the cross-install case; every same-install verdict is unchanged.

Removes nothing: no key, marker, function or verdict state is removed, and the provenance marker format is unchanged.

Tests

  • test/test_skill_install_currency.py: a checkout-synced copy judged against an app tree with caches reads in sync, and the reverse direction does too. A carried Context-budget opt-out across installs reads in sync. A real script change across installs still reads behind. A cache added to the installed copy still reads edited.
  • test/test_mcp_gateway_daemon_control.py: a git-stamped daemon under an mtime: doctor (and the reverse) with a live owner is printed as another install's with no issue. The same daemon with no owner or a gone owner is still an issue naming kirocrew restart, and so are two mtime: stamps that differ.
  • Without the source change, the 3 in-sync skill cases and both live-owner daemon cases fail; the guard cases pass either way, as intended.
  • Determinism: the new tests passed 5 runs in a row and once in reversed order (results in a PR comment).

Manual verification

N/A — unit coverage sufficient: both rows are pure functions of on-disk trees and the daemon pong, which the tests build directly.

Related Issues

Closes #20629

Pattern harvest

Rule candidate: review-prompt
Pattern: an identity check that compares two installs' build outputs (bytecode caches, stamps from different rules) instead of their sources reports a mismatch no restart can clear.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Determinism evidence for the tests this PR adds (head df833265a437d1f29be82fbe9f03cf1a9584554e, run locally on Linux, Python 3.12.13).

Node ids (10 items, counting parametrized cases):

test/test_skill_install_currency.py::test_doctor_from_the_app_reads_a_checkout_synced_copy_in_sync
test/test_skill_install_currency.py::test_doctor_from_the_checkout_reads_an_app_synced_copy_in_sync
test/test_skill_install_currency.py::test_a_script_change_across_installs_still_reads_behind
test/test_skill_install_currency.py::test_a_cache_added_to_the_installed_copy_still_reads_edited
test/test_skill_install_currency.py::test_a_carried_opt_out_across_installs_reads_in_sync
test/test_mcp_gateway_daemon_control.py::TestDoctorShowsTheDaemonRevision::test_another_installs_daemon_is_information_not_an_issue  (2 cases)
test/test_mcp_gateway_daemon_control.py::TestDoctorShowsTheDaemonRevision::test_an_ownerless_cross_install_daemon_is_still_an_issue  (2 cases)
test/test_mcp_gateway_daemon_control.py::TestDoctorShowsTheDaemonRevision::test_same_scheme_mismatch_is_still_an_issue
run 1:    10 passed
run 2:    10 passed
run 3:    10 passed
run 4:    10 passed
run 5:    10 passed
reversed: 10 passed

The tests use only temp directories and monkeypatched fingerprints and pids. They use no clock, sleep, network or real daemon.

Related set after rebasing onto 15491f182d54: test_skill_install_currency.py, test_mcp_gateway_daemon_control.py, test_builtin_skill_sync_safety.py, and both test_cli_doctor_refactor_* files. Result: 500 passed, 2 skipped. Before the rebase, the wider related set (39 files touching these modules) gave 1691 passed and 15 skipped.

Local review on the pre-rebase head 62f794480bc5: the GPT lane reported no findings. The Opus lane reported one Medium: a cross-scheme daemon with no live owner skipped the issue. That is fixed in this head, where the info branch also requires info.owner_alive, and a verifier confirmed it closed.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ec3f90621934a05b5f5c42daedaed76c2beccb33 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ec3f90621934a05b5f5c42daedaed76c2beccb33 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Before merging, confirm that a gateway from this install cannot adopt a daemon with a git stamp when it runs an mtime: build (or the reverse). The new ⏹ row assumes it cannot.

[DESIGN-REVIEWED] ec3f906

Description read

[DESCRIPTION-READ] 3502bc12ef79ece901ae990481b947b7062b7d3f3b6a70bdd8c052237f39423c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ec3f90621934a05b5f5c42daedaed76c2beccb33 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (6 items) — 6 justified

Intent: stop kirocrew doctor from flagging a healthy machine that has both a source checkout and the desktop app (#20629). This is a FIX.

  1. The Installed Skill Currency row now reads a skill as in sync when the only difference between the two installs is __pycache__ — justified
  2. A carried Context-budget opt-out line is also tolerated on that cross-install path — justified
  3. A skill copy with a cache added after the sync still reads as edited — justified
  4. When a live gateway owns a daemon stamped by the other rule (git revision vs mtime:), doctor shows it as ⏹ another install's and records no issue — justified
  5. That row names the owning gateway's pid to stop and prescribes no restart; a daemon with no live owner is still an issue — justified
  6. code_fingerprint.same_scheme is a new helper with one consumer (doctor_checks/mcp.py) — justified

[FIRST-PRINCIPLES-REVIEWED] ec3f906

Description read

[DESCRIPTION-READ] 61f95f2fe757ca27023c46ebae25d33cec82dc8e4d06966444a88aa6acab754c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ec3f90621934a05b5f5c42daedaed76c2beccb33 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ec3f906

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ec3f90621934a05b5f5c42daedaed76c2beccb33: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ec3f90621934a05b5f5c42daedaed76c2beccb33 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ec3f906

Verdict parsed from the review's SHA-scoped output markers for commit ec3f90621934a05b5f5c42daedaed76c2beccb33.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ec3f90621934a05b5f5c42daedaed76c2beccb33: <one-sentence reason>

@iamwhatever
iamwhatever force-pushed the fix/20629-doctor-cross-install branch from df83326 to f51a296 Compare October 17, 2026 19:33
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • fixed: a gateway left running from a removed checkout had no remedy on the info line

Fixed in f51a296: the info line now names the owner gateway's pid and says to stop it if it should no longer run, because the daemon exits once its owner is gone (manager.py passes --owner-pid; daemon/sweepers.py drains the daemon after its owner's liveness misses).
kirocrew restart stays off this line on purpose: while that other gateway lives it respawns a daemon on its own code, so a restart from here cannot clear it, which is the false remedy issue #20629 reports.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: this install's gateway never adopts a daemon a live gateway owns

Confirmed in code: GatewayManager.start refuses the broker when _owned_by_a_live_other(incumbent) is true (src/kiro_crew/mcp_gateway/manager.py, "owned by another LIVE gateway -- not adopting it"), before _repair_or_adopt can reach its _ADOPT fail-open. The exceptions there are this process itself and its own exec supervisor, and both share this install's stamp rule.
So a cross-rule daemon with a live owner never serves this install's sessions. The doctor branch also requires info.owner_alive, so an ownerless or orphaned one still records the issue (test_an_ownerless_cross_install_daemon_is_still_an_issue).

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Pushed f51a29674f6d, rebased onto ccb5d346, after cancelling the CI run that was still in progress on df833265a437.

This head fixes the Opus spec finding and the Design punchline, and answers the First Principles punchline with code evidence. See the three disposition comments above.

Process disclosure: the repair-routing rule says AI-review fixes go to a model-pinned fix subagent. I made both edits in the parent session instead. One is a doc sentence and the other is one wording line on the doctor info row, with its test assertion. A separate claude-opus-5.5 verifier then read both diffs and reported both items closed with no new Critical/High findings.

After the rebase, the related tests (535) and the black, isort, flake8, mypy, comment-history and docs-lint checks are green locally.

@iamwhatever

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: spec sentence describing the doctor daemon row

  • span=4155ffe8792e fixed: lifecycle spec named the old always-an-issue rule

Fixed in f51a296: docs/system-specs/modules/mcp-gateway-daemon-lifecycle.md:45 now states the exception. A daemon stamped by the other rule (code_fingerprint.same_scheme) with a live owner is printed as information with no issue. One with no or a gone owner still records the issue.
The spec test list names the new cross-install cases, and docs/system-specs/modules/cli.md names the pycache rule of the skill-currency row. Same commit as the code, per AGENTS.md.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: a live owner that is this install's own supervising launcher never carries the other stamp rule

The rule is picked by where the package root sits: code_fingerprint._git_fingerprint answers only when kiro_crew/ is inside a git worktree, else the mtime rule. The exec-supervisor exception in manager._owned_by_a_live_other is this gateway's own previous image (is_exec_supervisor_of_this_process), so its daemon was spawned from the same package root and stamps by the same rule as doctor here.
Such a daemon therefore takes the same-scheme branch: equal stamps print as same code, different ones still record the issue. The info branch needs both a different rule and a live owner (doctor_checks/mcp.py), which only a second install produces.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: this install's own gateway does not spawn a daemon stamped by the other rule

GatewayManager spawns the daemon from its own interpreter and package root, and code_fingerprint picks git vs mtime from that root (git only inside a worktree). So a daemon whose live owner is this install's gateway stamps by doctor's rule and reaches the same-scheme path, where any mismatch still records the issue (test_same_scheme_mismatch_is_still_an_issue).
The one way one root yields both rules is git failing in one process (5 s timeout, error) but not the other. The stamps then differ while the code is identical, so the base row's issue was equally false there and no real stale daemon is hidden.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in same-directory docs/system-specs/modules/ and src/kiro_crew/ files (no shared file) since this head went green (ccb5d34 -> 2e50054); CI re-running. New head 2741dd4, related tests (500) and docs-lint green locally.

@iamwhatever
iamwhatever force-pushed the fix/20629-doctor-cross-install branch from f51a296 to 2741dd4 Compare October 18, 2026 04:56
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted (same ruling as on f51a296): the owner_alive exemption cannot cover this install's own gateway

The exemption needs a different stamp rule as well as a live owner. code_fingerprint picks git or mtime from where the package root sits, and this install's gateway spawns its daemon from its own root, so that daemon stamps by doctor's rule.
It therefore takes the same-scheme branch, where any mismatch still records the issue (test_same_scheme_mismatch_is_still_an_issue). No code change on this head.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted (same ruling as on f51a296): this install's gateway does not adopt a daemon whose spawning gateway is still live

GatewayManager.start checks _owned_by_a_live_other(incumbent) first and refuses the broker ("owned by another LIVE gateway -- not adopting it") before _repair_or_adopt can reach _ADOPT. Adoption is reachable only for an ownerless or orphaned daemon.
Those have no live owner, so info.owner_alive is falsy and doctor still prints the issue with the restart remedy (test_an_ownerless_cross_install_daemon_is_still_an_issue). No code change on this head.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 2741dd4. The range-diff against f51a296 shows the same patch rebased onto current main with no code change. The skill-currency change only leaves pycache out of a comparison reached after the installed copy is proven to be the one the sync wrote, so any source or SKILL.md difference still reads behind and a cache added to the installed copy still reads edited. Mutating owner liveness, same_scheme, the cache filter in both directions, the opt-out fallback and the cache-free comparison each reddens a named test; the daemon-control and skill-currency tests pass on this head. CI was still running with 0 failed when I checked.

Follow-up, not blocking: the stamp rule is not fixed by where the package root sits. _git_fingerprint returns None and code_fingerprint falls back to the mtime rule when no trusted git is found, rev-parse fails, git diff errors, or a call hits the 5 s timeout (code_fingerprint.py:84, 96, 123-127). A daemon this install spawned in such a moment carries an mtime stamp while doctor computes a git one; its owner is this install own live gateway, so doctor_checks/mcp.py:375 reports it as another install and records no issue even if it is truly stale. Requiring that the owner is not this install gateway (or that the daemon root differs) before that branch, with a test for git-vs-mtime under the local gateway, would close it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in same-directory src/kiro_crew/ files (cron.py, no shared file) since this head's run, which ended red only on the known Windows flake #21742 (2e50054 -> 96c9588); CI re-running in full. New head 48797d0, related tests (500) green locally.

@iamwhatever
iamwhatever force-pushed the fix/20629-doctor-cross-install branch from 2741dd4 to 48797d0 Compare October 18, 2026 05:44
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 18, 2026
@iamwhatever

iamwhatever commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/cli.md (same file, no conflict), src/kiro_crew/doctor_checks/ and test/test_cli_doctor_refactor_report.py since this head started CI (96c9588 -> 175e6f6); the stale head's runs were cancelled and CI is re-running. New head 117806c; related tests (571 passed, including test_cli_doctor_refactor_report.py and test_ledger_sweep.py) and docs-lint green locally.

@iamwhatever
iamwhatever force-pushed the fix/20629-doctor-cross-install branch 2 times, most recently from 117806c to 5b5d602 Compare October 18, 2026 06:44
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/cli.md, a file this PR edits (no conflict), since this head went green (175e6f6 -> 9d088c8); CI re-running. New head 5b5d602; related tests (500) and docs-lint green locally.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted (same ruling as earlier heads): a leftover gateway of this install cannot reach the cross-install branch

The branch needs a stamp from the OTHER rule. code_fingerprint picks the rule from where the running package sits (git only inside a worktree), so a leftover gateway from this same install stamps its daemon by doctor's rule and lands on the same-scheme branch, where a mismatch still records the issue.
When a user switches between checkout and app, the gateway still running IS the other install, which is the case this row names. The line prints that gateway's pid and says to stop it if it should no longer run. No code change.

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted: the pycache cause is checked against the issue's own evidence, not assumed

Issue #20629 hashed every file of browser-recording across installed, app and checkout trees: all byte-identical, the only extra installed file being the marker. That rules out source drift. The 12 flagged names equal exactly the builtin skills that ship scripts/*.py (find src/kiro_crew/builtin_skills -type d -name scripts lists the same 12), and packaging/build-desktop.sh runs compileall over the whole shipped tree, so only the app's packaged copies carry scripts/pycache.
No two-install machine is available to this author; the reporter is asked on the issue to confirm on theirs. Both directions are pinned by tests (checkout-synced vs app tree, app-synced vs checkout tree).

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Backend Tests (3.12, 1) and (Windows) (1) are red on head 5b5d602 at test/test_history_bindings.py::test_the_member_set_is_the_frozen_inventory@tree_scan_history_bindings. That is main's red, not this PR's: the frozen inventory lacks the members added by 8335fa0 (#21108), the test fails the same way locally, and this PR touches no history module. The fix is open in #21792. This PR waits for it: no rerun and no override. Once #21792 merges, it rebases onto that fix.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto 943a4e5, which carries the main-red fix #21792 for test/test_history_bindings.py::test_the_member_set_is_the_frozen_inventory (the two Backend Tests reds and the Coverage Gate fail-closed on head 5b5d602). New head ec3f906; related tests plus test_history_bindings.py (712) green locally; CI re-running.

@iamwhatever
iamwhatever force-pushed the fix/20629-doctor-cross-install branch from 5b5d602 to ec3f906 Compare October 18, 2026 07:28
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • rebutted (same ruling as earlier heads): an adopted cross-rule daemon never reaches the info row

This install's gateway CAN adopt a daemon of the other rule, but only one with no live owner: GatewayManager.start refuses any incumbent where _owned_by_a_live_other is true before _repair_or_adopt reaches _ADOPT.
The info row needs info.owner_alive, so an adopted ownerless or orphaned daemon falls through to the issue with the restart remedy (test_an_ownerless_cross_install_daemon_is_still_an_issue, no-owner and owner-gone cases). No code change.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Review-ready at head ec3f90621934a05b5f5c42daedaed76c2beccb33 (base 943a4e5c0e3d, which carries the main-red fix #21792).

  • pr_status.py --reviewers gpt,opus: CLEAN. PR Readiness passed, 103 checks, 0 failing, mergeable.
  • green_age.py: fresh. The base has not moved in any file this PR touches.
  • Approved by a maintainer. GPT and Opus report no findings on this head. Design and First Principles pass. Each Design punchline has a disposition on this head, and First Principles raised no ask on it.
  • Flaky-test record: Flaky: test_two_stubs_on_one_backend_are_told_apart (Windows, stub closed stdout before replying) #21742 (test_two_stubs_on_one_backend_are_told_apart, Windows). It passed on this head.

This Crew does not merge, approve or enable auto-merge. The merge is the maintainer's call. CREW-22688 and #20629 stay open until the merge.

@KiroCrewCaptain
KiroCrewCaptain merged commit fc64b9d into main Oct 18, 2026
103 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/20629-doctor-cross-install branch October 18, 2026 09:06

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: doctor no longer flags byte-identical built-in skills (bytecode caches excluded) or another install's MCP daemon (different fingerprint scheme, live owner) as stale; tests added. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/cli.md, docs/system-specs/modules/mcp-gateway-daemon-lifecycle.md.

@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctor: skill-currency false positive when gateway sync (source checkout) and doctor (app bundle) come from different installs

3 participants