Repository navigation
docs: align delayed-task-brief RFC with the two-message warm design - #21712
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. This PR only changes docs: it updates the RFC status and index row to match what shipped, and it takes nothing away. [DESIGN-REVIEWED] fe77cfd Description read[DESCRIPTION-READ] edd1acef248fb2c5365f50215c55718d6b713f75042b4b996a0ad39285a888e6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
HOLD at b545349: the Design lane's check on this head has no reply. The wording changes are accurate. The README row and §3.5 now match the RFC's 2026-10-16 amendment. Still open: the Design PASS asks about the audit stamp mismatch. The README row still says "Verified at — crew-pr-reviewer (r110) |
b545349 to
0f03b0d
Compare
|
Addressed at head Took the preferred route: updated the README row's stamp and added the dated sentence.
Rebased onto current |
0f03b0d to
206b9b4
Compare
|
self-added: no README row implementation-status (span=e23818f24c1e)
|
|
self-added: no RFC §1 audit-commit contradiction (span=d951251201bc)
|
206b9b4 to
1ab59cc
Compare
|
self-added: yes README row trigger-amendment contradiction (span=e23818f24c1e)
|
1ab59cc to
9fe8a80
Compare
|
self-added: no README row trigger prose vs 2026-10-18 amendment (span=e23818f24c1e)
|
9fe8a80 to
8acfee6
Compare
fde282a to
bd348e6
Compare
|
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]: @dodgeblaster this conflicts with main now. Please rebase onto main; I will review it on the rebased head. |
Bring the delayed-task-brief RFC and its directory index into agreement with the document's amendments and with what shipped on main. The warm task brief shipped in #20422 and its amendments shipped in #21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode scope), #26500 (fixed progress orb) and #26652 (first part of the 2026-10-31 redesign), yet the front matter and README row still read `accepted` ("nothing built yet") with implementation-prs [] and a 2026-10-14 audit stamp. Not built on main: the 2026-10-28 writer amendment (section 3.8; main has no wake turn and no `dashboard.warm_brief_wake` setting), the 2026-11-01 trigger amendment (#26938 is open), and the live checks, links and copied option buttons of section 3.9.3. So the front matter now records status partial, those ten PRs, and last-audited 2026-11-01 at fed53fc; the section 1 status line names what shipped and what is not built; the "Audited on" line matches; and the snapshot's third field is renamed "Suggested actions" to match the section 3.5 output it feeds. The README index row no longer describes the superseded preparing-status design or says implementation waits for the RFC. It reads partial, names the shipped PRs, summarises the shipped trigger, the one-message brief with its fixed card and quiet return, and names the unbuilt parts. The audit paragraph gains a dated re-audit sentence for the row. Closes #20887
bd348e6 to
fe77cfd
Compare
|
Rebased onto main at |
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at fe77cfd.
The RFC front matter, its status line and the README row now agree with main. Status is partial, the audit stamp is fed53fcd3b90, and implementation-prs lists the ten shipped PRs (rfc-delayed-task-brief.md L3-L17, README.md L107). I checked the claims: all ten PRs are merged, #26938 is still open, and no dashboard.warm_brief_wake exists under src/. No later commit on main touches the RFC. This clears the r128 conflict hold. Every AI lane passes or is skipped, and all checks are success or skipped.
— crew-pr-reviewer (r140)
Problem / Motivation
Goal: Make the delayed-task-brief RFC front matter, its status lines and its README index row agree with what main ships, with no leftover "preparing status" or "Next steps" wording for the warm path.
The warm task brief shipped in #20422, and its amendments shipped in #21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode scope, 2026-10-29), #26500 (fixed progress orb, 2026-10-31) and #26652 (first part of the 2026-10-31 redesign). Not built: the 2026-10-28 writer amendment (§3.8), the 2026-11-01 trigger amendment (#26938, open), and the live checks, links and copied option buttons of §3.9.3. The RFC still reads
status: accepted(the README vocabulary says that means "Nothing built yet"),implementation-prs: [], and a 2026-10-14 audit stamp. The README index row still says the return shows "deterministic preparing status" and publishes "1–3 next steps", says "implementation waits for this RFC to merge", and is verified atd06b611f549d. §3.5 item 3 is still labelled "Next steps" while the output it feeds is "Suggested actions".Why it matters
An implementer or auditor reads the index row and the front matter first. A reader who trusts them builds the old status-banner shape, or thinks nothing has shipped. The First Principles lane also reads
statusfrom the base.Not a goal
What changed (motivation → approach → change)
status: partial,implementation-prs: [20422, 21750, 22828, 22839, 23847, 24512, 24307, 25881, 26500, 26652],last-audited: 2026-11-01,audited-at: fed53fcd3b90;tracking-issueskeeps main's[20156, 25306].fed53fcd3b90/ 2026-11-01, so the document names one audit commit. Every amendment line main added is kept unchanged.partial; names the shipped PRs and the unbuilt parts; verified atfed53fcd3b90; summarises the shipped trigger (crewmate threads and Crew Mode roots, 30 minutes off screen), the single message that replaces a preparing indicator, the fixed card with the goal-scoped count, the quiet one-line return, and theis_warm_task_brief_messagereader filter.Verified at
fed53fcd3b90:crew_mode.slot_is_crew_mode_rootand the warm-brief eligibility it feeds,dashboard/warm_task_brief.pywith the sectioned inputs ofwarm_task_brief_inputs.py, thecomponents.chatPane.preparing_catch_upindicator,website/src/components/chat/WarmBriefCard.tsx, andwarm_task_brief_contract.pywith itsis_warm_task_brief_messagereaders. Nodashboard.warm_brief_wakesetting exists undersrc/. #25881, #26500 and #26652 are merged; #26938 is open.Backwards compatibility
Compatible: documentation-only; no contract, type, key, or behaviour changes.
Removes nothing: no code path, record, key, or public symbol is removed or renamed.
Tests
N/A — documentation-only.
./scripts/docs-lint.shpasses.Manual verification
N/A — unit coverage sufficient. Each claim in the new README row was checked against the files named above on
fed53fcd3b90.Screenshots / video
N/A — no user-visible frontend surface is touched; this changes only
docs/request-for-change/markdown.Related Issues
Closes #20887
Pattern harvest
Not generalizable: a one-off audit refresh of a single RFC whose implementation PRs did not update its front matter.
Checklist
Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.