Skip to content

docs: align delayed-task-brief RFC with the two-message warm design - #21712

Merged
iamwhatever merged 1 commit into
mainfrom
fix/rfc-delayed-task-brief-stale-20887
Nov 2, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/rfc-delayed-task-brief-stale-20887

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make the delayed-task-brief RFC front matter, its status lines and its README index row agree with what main ships, with no leftover "preparing status" or "Next steps" wording for the warm path.

The warm task brief shipped in #20422, and its amendments shipped in #21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode scope, 2026-10-29), #26500 (fixed progress orb, 2026-10-31) and #26652 (first part of the 2026-10-31 redesign). Not built: the 2026-10-28 writer amendment (§3.8), the 2026-11-01 trigger amendment (#26938, open), and the live checks, links and copied option buttons of §3.9.3. The RFC still reads status: accepted (the README vocabulary says that means "Nothing built yet"), implementation-prs: [], and a 2026-10-14 audit stamp. The README index row still says the return shows "deterministic preparing status" and publishes "1–3 next steps", says "implementation waits for this RFC to merge", and is verified at d06b611f549d. §3.5 item 3 is still labelled "Next steps" while the output it feeds is "Suggested actions".

Why it matters

An implementer or auditor reads the index row and the front matter first. A reader who trusts them builds the old status-banner shape, or thinks nothing has shipped. The First Principles lane also reads status from the base.

Not a goal

  • Changing product code or behaviour. Documentation only.
  • Rewriting the §12 decision record or the maintainer accepted-terms quote in §1; only the status word and audit stamp in §1 move.
  • Re-wording §3/§4/§5 prose that the dated amendment notes already supersede in place.

What changed (motivation → approach → change)

  • RFC front matter: status: partial, implementation-prs: [20422, 21750, 22828, 22839, 23847, 24512, 24307, 25881, 26500, 26652], last-audited: 2026-11-01, audited-at: fed53fcd3b90; tracking-issues keeps main's [20156, 25306].
  • RFC §1: the status line names what shipped and what is not built; the "Audited on" line moves to fed53fcd3b90 / 2026-11-01, so the document names one audit commit. Every amendment line main added is kept unchanged.
  • RFC §3.5 item 3: Next steps → Suggested actions, matching the visible output named two paragraphs below.
  • README index row: status partial; names the shipped PRs and the unbuilt parts; verified at fed53fcd3b90; summarises the shipped trigger (crewmate threads and Crew Mode roots, 30 minutes off screen), the single message that replaces a preparing indicator, the fixed card with the goal-scoped count, the quiet one-line return, and the is_warm_task_brief_message reader filter.
  • README audit paragraph: a dated re-audit sentence for the row, in the form the other re-audited rows use.

Verified at fed53fcd3b90: crew_mode.slot_is_crew_mode_root and the warm-brief eligibility it feeds, dashboard/warm_task_brief.py with the sectioned inputs of warm_task_brief_inputs.py, the components.chatPane.preparing_catch_up indicator, website/src/components/chat/WarmBriefCard.tsx, and warm_task_brief_contract.py with its is_warm_task_brief_message readers. No dashboard.warm_brief_wake setting exists under src/. #25881, #26500 and #26652 are merged; #26938 is open.

Backwards compatibility

Compatible: documentation-only; no contract, type, key, or behaviour changes.

Removes nothing: no code path, record, key, or public symbol is removed or renamed.

Tests

N/A — documentation-only. ./scripts/docs-lint.sh passes.

Manual verification

N/A — unit coverage sufficient. Each claim in the new README row was checked against the files named above on fed53fcd3b90.

Screenshots / video

N/A — no user-visible frontend surface is touched; this changes only docs/request-for-change/ markdown.

Related Issues

Closes #20887

Pattern harvest

Not generalizable: a one-off audit refresh of a single RFC whose implementation PRs did not update its front matter.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality (N/A — docs-only)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision fe77cfd22efabec88d32d116ccccf60227cf53c6 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision fe77cfd22efabec88d32d116ccccf60227cf53c6 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of fe77cfd22efabec88d32d116ccccf60227cf53c6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This PR only changes docs: it updates the RFC status and index row to match what shipped, and it takes nothing away.

[DESIGN-REVIEWED] fe77cfd

Description read

[DESCRIPTION-READ] edd1acef248fb2c5365f50215c55718d6b713f75042b4b996a0ad39285a888e6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed fe77cfd22efabec88d32d116ccccf60227cf53c6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] fe77cfd

Verdict parsed from the review's SHA-scoped output markers for commit fe77cfd22efabec88d32d116ccccf60227cf53c6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable fe77cfd22efabec88d32d116ccccf60227cf53c6 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of fe77cfd22efabec88d32d116ccccf60227cf53c6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] fe77cfd

False positive or not applicable? A repository writer can comment:
/ai-review override gpt fe77cfd22efabec88d32d116ccccf60227cf53c6 false-positive: <reason, 20 to 500 characters>

@dodgeblaster
dodgeblaster marked this pull request as ready for review October 17, 2026 23:08
@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners October 17, 2026 23:08
@dodgeblaster
dodgeblaster requested a review from buluoray October 17, 2026 23:08
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 17, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at b545349: the Design lane's check on this head has no reply.

The wording changes are accurate. The README row and §3.5 now match the RFC's 2026-10-16 amendment.

Still open: the Design PASS asks about the audit stamp mismatch. The README row still says "Verified at d06b611f549d", while the RFC front matter now records 52a302b914dc. Other re-audited rows also get a dated sentence in the README's audit paragraph. Either update the row's stamp (and add that sentence), or post a disposition saying why the row keeps the old SHA.

— crew-pr-reviewer (r110)

@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from b545349 to 0f03b0d Compare October 19, 2026 22:01
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Addressed at head 0f03b0d1f23f50959d2193f010d75183d1e3e50d.

Took the preferred route: updated the README row's stamp and added the dated sentence.

  • The rfc-delayed-task-brief index row now reads Verified at 52a302b``, matching the RFC front matter's audited-at; the stale `d06b611f549d` is gone from the README.
  • The README audit paragraph gains a dated re-audit sentence for the row, in the same form the other re-audited rows use: "The rfc-delayed-task-brief row was re-audited 2026-10-17 against 52a302b914dc for the two-message warm-brief amendment ... the row's accepted status is unchanged."

Rebased onto current origin/main (ed975d7c846d); the audit paragraph picked up the upstream rfc-living-ui and rfc-conductor-rolling-reset sentences, both kept, with ours appended after them. Still docs-only, still one commit.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from 0f03b0d to 206b9b4 Compare October 19, 2026 22:13
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

README row implementation-status (span=e23818f24c1e)

fixed at head 206b9b4. Correct: the warm task brief shipped in #20422 (merged 2026-10-16, present at the re-audit base 52a302b — dashboard/warm_task_brief.py, warm_task_brief_contract.py, and the is_warm_task_brief_message readers), and the RFC doc #20157 is merged. Re-stamping the row to 52a302b while leaving "implementation waits for this RFC to merge" was self-contradictory.
The row now reads shipped-in-#20422 and the front matter implementation-prs is [20422].

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

RFC §1 audit-commit contradiction (span=d951251201bc)

fixed at head 206b9b4. Correct: bumping the front matter audited-at to 52a302b while the §1 "Audited on d06b611 (main, 2026-10-14)" line stayed put gave the same RFC two audit commits.
The §1 line now reads "Audited on 52a302b (main, 2026-10-17)", matching the front matter. This line is an audit-freshness stamp, not the maintainer's accepted-terms quote, so moving it does not touch the decision record.

@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from 206b9b4 to 1ab59cc Compare October 19, 2026 22:23
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: a clause added in the prior round claiming the row records the 2026-10-18 trigger amendment

README row trigger-amendment contradiction (span=e23818f24c1e)

fixed at head 1ab59cc by removing the offending clause. Correct: the clause I added ("the 2026-10-18 trigger amendment is what the row's design prose now records") contradicted the row's own earlier sentence, which still describes the pre-amendment trigger ("the sole trigger is an owner leaving the Kiro Crew page/tab").
The row now makes only the implementation-shipped-in-#20422 claim, which is accurate and in scope. The row's trigger-prose currency is a separate re-audit the frozen goal (#20887: two-message consistency + audit stamps) does not cover, so it is left for its own pass rather than rewritten here.

@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from 1ab59cc to 9fe8a80 Compare October 19, 2026 22:49
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/ (rfc-conductor-work-ledger.md, same dir) since this head went green (512f13c -> d4f551e); CI re-running. Docs-only diff unchanged; audit stamps stay 52a302b.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

README row trigger prose vs 2026-10-18 amendment (span=e23818f24c1e)

accepted-and-deferred — out of this PR's frozen scope, not a defect this PR introduces. The "sole trigger is leaving the Kiro Crew page/tab" summary is pre-existing row prose; it predates this change. This PR (#20887) re-audits the row for the two-message warm-brief amendment (2026-10-15/16) and the implementation-shipped status, and the audit-paragraph sentence states that scope explicitly. The 2026-10-18 trigger amendment is a later, separate decision; re-summarising its five-part thread/episode semantics in the index row is a distinct re-audit, not an audit-stamp sync.
Re-writing the row's trigger summary here would widen a docs-stamp PR into a trigger-semantics rewrite the frozen goal does not cover. Flagging for a follow-up re-audit of the row against the 2026-10-18 amendment rather than widening this one.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from 9fe8a80 to 8acfee6 Compare October 20, 2026 16:50
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@iamwhatever
iamwhatever force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from fde282a to bd348e6 Compare October 29, 2026 16:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 29, 2026
@buluoray

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

@dodgeblaster this conflicts with main now. Please rebase onto main; I will review it on the rebased head.

Bring the delayed-task-brief RFC and its directory index into agreement
with the document's amendments and with what shipped on main.

The warm task brief shipped in #20422 and its amendments shipped in
#21750, #22828, #22839, #23847, #24512, #24307, #25881 (Crew Mode
scope), #26500 (fixed progress orb) and #26652 (first part of the
2026-10-31 redesign), yet the front matter and README row still
read `accepted` ("nothing built yet") with implementation-prs [] and a
2026-10-14 audit stamp.

Not built on main: the 2026-10-28 writer amendment (section 3.8; main
has no wake turn and no `dashboard.warm_brief_wake` setting), the
2026-11-01 trigger amendment (#26938 is open), and the live checks,
links and copied option buttons of section 3.9.3. So the front matter
now records status partial, those ten PRs, and last-audited 2026-11-01
at fed53fc; the section 1 status line names what shipped and what
is not built; the "Audited on" line matches; and the snapshot's third
field is renamed "Suggested actions" to match the section 3.5 output it
feeds.

The README index row no longer describes the superseded preparing-status
design or says implementation waits for the RFC. It reads partial,
names the shipped PRs, summarises the shipped trigger, the one-message
brief with its fixed card and quiet return, and names the unbuilt
parts. The audit paragraph gains a dated re-audit sentence for the row.

Closes #20887
@dodgeblaster
dodgeblaster force-pushed the fix/rfc-delayed-task-brief-stale-20887 branch from bd348e6 to fe77cfd Compare November 1, 2026 22:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 1, 2026
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased onto main at fed53fcd3b90 (bd348e6 -> fe77cfd), answering the conflict note. Main had added five amendments to the RFC since the last audit base. Three are shipped and join implementation-prs: the Crew Mode scope (#25881), the fixed progress orb (#26500) and the first part of the redesign (#26652). Two are not built and are named as such in the status line and the README row: the 2026-11-01 trigger amendment (#26938 is still open) and the live checks, links and option buttons of §3.9.3. The §3.8 writer wake is still not built (no dashboard.warm_brief_wake under src/). Every amendment line main added is kept unchanged; tracking-issues keeps main's [20156, 25306]. Still one commit touching only the two docs files; ./scripts/docs-lint.sh passes.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at fe77cfd.

The RFC front matter, its status line and the README row now agree with main. Status is partial, the audit stamp is fed53fcd3b90, and implementation-prs lists the ten shipped PRs (rfc-delayed-task-brief.md L3-L17, README.md L107). I checked the claims: all ten PRs are merged, #26938 is still open, and no dashboard.warm_brief_wake exists under src/. No later commit on main touches the RFC. This clears the r128 conflict hold. Every AI lane passes or is skipped, and all checks are success or skipped.

— crew-pr-reviewer (r140)

@iamwhatever
iamwhatever enabled auto-merge (squash) November 2, 2026 03:29
@iamwhatever
iamwhatever merged commit 0607b5c into main Nov 2, 2026
102 of 106 checks passed
@iamwhatever
iamwhatever deleted the fix/rfc-delayed-task-brief-stale-20887 branch November 2, 2026 03:29
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(rfc): delayed task brief RFC still describes the old status design and an unsafe undo

3 participants