Repository navigation
docs(rfc): move crewmate export and import into owner UI - #21746
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this changes only RFC docs and adds no code, route or file format. It touches nothing under Notes
[DESIGN-REVIEWED] 1aacb2c Description read[DESCRIPTION-READ] d666c38b1a245cd596928104ac673ee1a4bbadf9d73f3dd2648f8f5300ace77c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
8a6f642 to
e41a3f3
Compare
e41a3f3 to
8df76ae
Compare
|
|
|
8df76ae to
0974a98
Compare
|
Rebased onto main carrying #22951; CI re-running. |
e02cb17 to
bf6883d
Compare
The product owner ruled out a Crewmate Share app. Export becomes a button on the crewmate's profile card with a confirm view that lists what leaves, and Import becomes an item in the crewmate dropdown that raises the crewmate.import card. Both run over owner-only core routes. The App SDK capability, its two permissions and the app: card slot are dropped, because owner UI is already owner-authenticated. The bundle format and every security rule are unchanged. Mock screens of the four entries are added.
bf6883d to
1aacb2c
Compare
Problem / Motivation
Goal: The mate-sharing RFC describes Export on the crewmate profile card and Import in the crewmate dropdown, as the product owner ruled, instead of a Crewmate Share app; and an imported crewmate arrives whole, not hollow.
rfc-crewmate-share.md(merged in #21508) puts export and import in an App Kit app over a newpropose_crewmateApp SDK capability. The product owner ruled there is no such app: both entries are core owner UI. Review on this PR then found four parts the receiver needs that the bundle left out: cron scripts, skills the sender wrote, lessons, and auser:dashboard id that cannot resolve. Implementation PRs (#21721) build against this document, so it must say what is actually being built.Why it matters
Without the amendment, the implementation keeps coding against an app path the owner rejected. And a receiver gets a crewmate with no schedule, "missing" skills forever and a dashboard id that dangles.
Not a goal
acceptedflip is docs(rfc): record crewmate-share RFC as accepted #21655.What changed (motivation → approach → change)
POST /api/members/{slug}/exportand the browser saves<name>.crewmatePOST /api/members/importraises onecrewmate.importcard under slotowner:crewmate-importctx.crewmateandproposeCrewmatedropped; tenet 8 says why these entries are corescriptcron carries itscrons/<file>.py, shown in full,code_exec, landing paused under a free nameapp:skills stay references; skills the sender wrote travel asskills/<name>/files into the new member's workspaceSKILL.mddrafted by the crewmate, off by defaultbuiltin:ids travel; auser:id is dropped with a noteThe bundle gains two one-level folders and larger caps (§5.2). Open questions 1 and 2 are resolved. The status line records what #21721 built, the duplicated Phase 3 blocker line is gone, and file citations follow the
portability_*.pysplit. The README row matches the document'sacceptedfront matter: #21646 had restored the row's olddrafttext over #21655.Backwards compatibility
Compatible: docs only. No code, route or file format changes on main.
formatVersionstays1because no version-1 writer has shipped.Tests
N/A. Docs only.
scripts/docs_lint.pypasses.Manual verification
Re-checked every cited symbol against
origin/mainatdde25d826f:crewmate_import_params(crewmate_bundle.py),PREVIEW_ENABLED = False(apps/crewmate_sdk.py),_sanitize_imported_cronsand itscrons/docstring (portability_vetting.py),skills_dir(skills_discovery.py), workspace-scoped skills (member_workspace.py),RENDERABLE_SOURCES(dashboard_templates/instance.py),_validate_crewmate_create(guide_catalog.py).Screenshots / video
Mock screens committed with the RFC under
docs/request-for-change/assets/. The export confirm view predates the crons, skills and lessons rows; the RFC caption says so. The first three render the realCrewProfilePanelandCrewmateSwitcherin Storybook with the new control added on a scratch copy. The import card is #21721's card.Dropdown with Import, the import card, and the Chinese frame
Related Issues
Refs #21718, #21508, #21721, #21655
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.