Skip to content

docs(rfc): move crewmate export and import into owner UI - #21746

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-crewmate-share-core-entries
Oct 22, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-crewmate-share-core-entries

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The mate-sharing RFC describes Export on the crewmate profile card and Import in the crewmate dropdown, as the product owner ruled, instead of a Crewmate Share app; and an imported crewmate arrives whole, not hollow.

rfc-crewmate-share.md (merged in #21508) puts export and import in an App Kit app over a new propose_crewmate App SDK capability. The product owner ruled there is no such app: both entries are core owner UI. Review on this PR then found four parts the receiver needs that the bundle left out: cron scripts, skills the sender wrote, lessons, and a user: dashboard id that cannot resolve. Implementation PRs (#21721) build against this document, so it must say what is actually being built.

Why it matters

Without the amendment, the implementation keeps coding against an app path the owner rejected. And a receiver gets a crewmate with no schedule, "missing" skills forever and a dashboard id that dangles.

Not a goal

  • No code. Phases 1–3 stay separate implementation PRs.
  • No change to the trust model in §8: the owner's press is still the only gate, nothing installs live, no secret or grant travels.
  • No status change. The accepted flip is docs(rfc): record crewmate-share RFC as accepted #21655.
  • No future App SDK capability for sharing. §5.5 says a later RFC adds one if an app asks.

What changed (motivation → approach → change)

Part Change
Export (§5.3) "Export as file" on the profile card opens a confirm view; the owner's press calls owner-only POST /api/members/{slug}/export and the browser saves <name>.crewmate
Import (§5.4) "Import from file" in the crewmate dropdown; owner-only POST /api/members/import raises one crewmate.import card under slot owner:crewmate-import
App path (§5.5, §5.6) ctx.crewmate and proposeCrewmate dropped; tenet 8 says why these entries are core
Crons toggle on by default; each script cron carries its crons/<file>.py, shown in full, code_exec, landing paused under a free name
Skills app: skills stay references; skills the sender wrote travel as skills/<name>/ files into the new member's workspace
Lessons never rows; an owner-edited SKILL.md drafted by the crewmate, off by default
Dashboard only builtin: ids travel; a user: id is dropped with a note

The bundle gains two one-level folders and larger caps (§5.2). Open questions 1 and 2 are resolved. The status line records what #21721 built, the duplicated Phase 3 blocker line is gone, and file citations follow the portability_*.py split. The README row matches the document's accepted front matter: #21646 had restored the row's old draft text over #21655.

Backwards compatibility

Compatible: docs only. No code, route or file format changes on main. formatVersion stays 1 because no version-1 writer has shipped.

Tests

N/A. Docs only. scripts/docs_lint.py passes.

Manual verification

Re-checked every cited symbol against origin/main at dde25d826f: crewmate_import_params (crewmate_bundle.py), PREVIEW_ENABLED = False (apps/crewmate_sdk.py), _sanitize_imported_crons and its crons/ docstring (portability_vetting.py), skills_dir (skills_discovery.py), workspace-scoped skills (member_workspace.py), RENDERABLE_SOURCES (dashboard_templates/instance.py), _validate_crewmate_create (guide_catalog.py).

Screenshots / video

Mock screens committed with the RFC under docs/request-for-change/assets/. The export confirm view predates the crons, skills and lessons rows; the RFC caption says so. The first three render the real CrewProfilePanel and CrewmateSwitcher in Storybook with the new control added on a scratch copy. The import card is #21721's card.

Profile card with Export as file

Export confirm view

Dropdown with Import, the import card, and the Chinese frame

Crewmate dropdown with Import from file

crewmate.import card

Export confirm view, Chinese

Related Issues

Refs #21718, #21508, #21721, #21655

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1aacb2c254a309f11d78d9de35072201c8a415c9 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 1aacb2c254a309f11d78d9de35072201c8a415c9 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 18, 2026
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1aacb2c254a309f11d78d9de35072201c8a415c9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this changes only RFC docs and adds no code, route or file format. It touches nothing under website/src/, so the rendered-evidence trigger does not apply.

Notes

[DESIGN-REVIEWED] 1aacb2c

Description read

[DESCRIPTION-READ] d666c38b1a245cd596928104ac673ee1a4bbadf9d73f3dd2648f8f5300ace77c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1aacb2c254a309f11d78d9de35072201c8a415c9 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1aacb2c

Verdict parsed from the review's SHA-scoped output markers for commit 1aacb2c254a309f11d78d9de35072201c8a415c9.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1aacb2c254a309f11d78d9de35072201c8a415c9: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1aacb2c254a309f11d78d9de35072201c8a415c9 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1aacb2c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1aacb2c254a309f11d78d9de35072201c8a415c9: <one-sentence reason>

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 18, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-core-entries branch from 8a6f642 to e41a3f3 Compare October 18, 2026 06:34
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-core-entries branch from e41a3f3 to 8df76ae Compare October 18, 2026 07:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever

iamwhatever commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=988c701468b6 — Acceptance carried onto a design nobody accepted — needs-a-decision

The amended design (no app, owner-only routes, the owner:crewmate-import slot) comes from the product owner's ruling. That ruling was given in the owner's own session, not on this repository, so the status line has no link to cite. This needs a maintainer decision, and no push.
@iamwhatever, please choose one: (a) comment on this PR that you accept the amended design, and the status line will cite that comment; or (b) ask for the amendment as its own rfc-crewmate-share-owner-ui.md, and this PR will move it there.

@iamwhatever

iamwhatever commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=da5adf4d2d04 — Undocumented status change — rebutted

The README row change is a catch-up, not a status change. On origin/main the document's front matter already reads status: accepted (#21655, 5f47ff8c59). The index row still reads draft, because #21646 (2d378bf4b6) restored the neighbouring row's newer text over #21655's row edit. This PR sets the row to match the document it indexes. The PR description now says so too.

@iamwhatever

iamwhatever commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=cde84a63cce9 — Several pending imports under one slot — rebutted (disproportional for a docs push)

GET /api/cards/pending?slot=owner:crewmate-import returns every card on that key that is live or finished within 24 hours (ChangeCardStore.pending in dashboard/change_cards.py). So the Import dialog lists each pending import, and the owner presses or declines each one. The 17th unpressed import within 24 hours gets the store's own too_many_cards 429, which the dropdown shows as a refusal; that fails closed. Pushing a docs commit for this one sentence would rerun every lane. It is a build detail for #21721, which renders the dialog, and is recorded here for that PR.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 18, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-core-entries branch from 8df76ae to 0974a98 Compare October 19, 2026 02:36
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Real Adapter Contract Tests red on e02cb17091 is main's, not this docs-only PR's: test/test_pi_real_adapter.py setup raises SandboxUnavailableError on every PR since #22807 (#22958, #22959). Fix in flight: #22951. This PR waits for it, then rebases onto main and re-runs.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main carrying #22951; CI re-running.

@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-core-entries branch from e02cb17 to bf6883d Compare October 22, 2026 01:58
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 22, 2026
@iamwhatever
iamwhatever enabled auto-merge (squash) October 22, 2026 06:08
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 22, 2026
The product owner ruled out a Crewmate Share app. Export becomes a
button on the crewmate's profile card with a confirm view that lists
what leaves, and Import becomes an item in the crewmate dropdown that
raises the crewmate.import card. Both run over owner-only core routes.

The App SDK capability, its two permissions and the app: card slot
are dropped, because owner UI is already owner-authenticated. The
bundle format and every security rule are unchanged. Mock screens of
the four entries are added.
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/request-for-change/rfc-crewmate-share.md (#22845 split change_card_catalog.py) since this head went green (bf6883d -> 1aacb2c); citations follow the split. CI re-running.

@iamwhatever
iamwhatever force-pushed the docs/rfc-crewmate-share-core-entries branch from bf6883d to 1aacb2c Compare October 22, 2026 17:01
@iamwhatever
iamwhatever disabled auto-merge October 22, 2026 17:02
@iamwhatever
iamwhatever enabled auto-merge (squash) October 22, 2026 17:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 22, 2026
@chenmingwei23
chenmingwei23 merged commit 66b3698 into main Oct 22, 2026
107 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-crewmate-share-core-entries branch October 22, 2026 20:37
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 22, 2026
@rubencu rubencu mentioned this pull request Oct 22, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants