Repository navigation
feat(chat): [PENDING] bring back Crew Mode with its board in the side panel - #21889
bolichen97 wants to merge 2 commits into
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that a chat created directly on [DESIGN-REVIEWED] a2021b1 Description read[DESCRIPTION-READ] 719690cf027a687e7ad39902307c4d497075ef27503657141269f45e7037fb28 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Every root Not justified as shipped
What this change shipsInventory (7 items) — 6 justifiedIntent: let a user turn a chat into a Conductor with one switch and watch its task board in the side panel, not in its replies. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] a2021b1 Description read[DESCRIPTION-READ] 2e8fb6574e8191f3d3b396f1ae1769569a1c913b0229c79e088897cd69216742 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS In shot-02 the side panel board says "No item on this board yet" right after the reply says an item was recorded, so users can't tell whether Crew Mode worked. Watch
Suggestions
[UX-REVIEWED] a2021b1 Description read[DESCRIPTION-READ] 1f2a109c436ff7d9e250d9d4784228cd34212c335a374b7b02796bb6ee3830f9 That sha256 names everything this verdict read: the PR description, plus the 26 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
99d339c to
9b48e1f
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.
On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.
The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.
The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.
The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.
Re-lands the switch backed out in #16257 on the current page owners.
Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
79571ab to
a2021b1
Compare
|
|
|
|
|
|
|
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Held at the author's request: this PR is marked [PENDING] and brings back Crew Mode, a change to an experience users already have. It needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. This review is dismissed once the design is agreed.
Crew Mode is now chosen once, on a new chat's welcome state. Pressing the composer chip hides both the memory-mode chip and the Crew Mode chip for that chat and neither comes back: there is no off control and no off note. A refused switch brings both chips back. The agent picker is unchanged. The welcome page is pictures, not prose: the Crew Mode hero, the slogan, a five-step flow (Goal, Split, Own chats, Board, Needs you) and one "Task board" button, shown as its icon alone where room is tight with its name kept on aria-label and title and a 44px touch target. Everything plays once within 3.5s, once per chat, and settles on its final frame as soon as the person starts typing; reduced motion draws only the final frame. The page stays on screen from the chip press to the first message. Specs and docs that described the off switch, the four capability labels and the old button text are updated to match.
|
Closing: Crew Mode is being redesigned. A new pull request will replace this one. |
Problem / Motivation
Goal: Let a user turn a chat into a Conductor with one switch next to "Choose memory mode", and see that Conductor's task board in the side panel Dynamic Dashboard instead of in its replies.
The Conductor (
kirocrew-conductor) splits a goal into tasks, runs each in its own chat, and reports back. Today the only way in is the agent picker, which lists several conductor agents under technical names. The Crew Mode switch that fixed this shipped in #16088 and was backed out in #16257. The restore attempt, #21526, was approved and then closed unmerged. Its review found that the welcome page's sample board looked like live work, and the Conductor still drew its board inline in every reply, while the side panel already has a Dynamic Dashboard (#18105) that can draw the real one.Why it matters
The Conductor is how a big goal gets split up and tracked without the user reading every transcript. Hidden behind the agent picker, almost nobody reaches it. And a board drawn inline in each reply repeats itself every turn, while the side panel board stays current from the work ledger on its own.
Not a goal
goal-conductorskill or the dashboard templates.What changed (motivation → approach → change)
Turning Crew Mode on now puts the Conductor's task board where it stays current: the side panel Overview, drawn from the chat's own work ledger. A chat is in Crew Mode exactly when it runs on
kirocrew-conductor; the switch is the ordinary agent switch, so memory and history stay, and off puts the chat back on the default template.components/CrewModeChip.tsx,pages/chat/page/crewModeSwitch.ts,ComposerDockView.tsxaria-pressedfor on and off. While a reply runs it stays focusable and a visible line says "Available after the reply."; with the mode on it says "Turning off Crew Mode makes this a normal chat. Chats it opened keep running."crewModeSwitch.ts,ChatPage.tsx,command-center/CommandCenterPanel.tsx,command-center/model.ts+menu does.isRootSessionis the panel's existing root test, moved intomodel.ts. Off leaves the panel opendashboard_agentic.py,dashboard/chat_api/agent_switch.pygoal-boardwith the ordinaryinstance.adopt, only while nothing is adopted yet, and tells an open Overview to re-read[DASHBOARD]blockdashboard_agentic.py,dashboard/chat_runner.py,context_assembly/turn.py,context_assembly/turn_message.py[DASHBOARD]block, keyed by the session's store key, so the Conductor's existing rules skip its inline board and its introduction, and each reply carries only the "Needs you" lines and one line on what changed. Off, the page stays and the block stopscomponents/CrewModeWelcome.tsx,ChatTranscriptView.tsxpages/chat/memoryModeSwitch.tsThe switch is offered only on a plain local Persistent chat on the default template or the Conductor, never in a crewmate, app, mode or remote-instance chat, and not when the Conductor is itself the default agent.
CREW_MODE_AGENTlives inlib/crewMode.tsalone. Specs and docs say the same incontext-management.md,memory-skills-hooks.md,dashboard-instances.md,session.md,learn-cron-dashboard.md,crew-mode.md,agents.md,work-ledger.mdand the feature map. i18n adds the Crew Mode keys to every catalog ini18n/locales/anden-XA; "Crew Mode" joinsi18n/glossary.json.Backwards compatibility
Compatible: no route, field, config key or template changes. The switch calls the existing
POST /api/chat/slots/{slot}/agent; a root session's page getsgoal-boardonly when it had none, and the per-turn block reaches only a Crew Mode chat with an adopted page.Reader: website/src/pages/chat/memoryModeSwitch.ts:runMemorySwitch -- chat -- a
kirocrew-conductortemplate chat switched to Incognito or Temporary is recreated on the default template, since such a session may not create sessions;ChatPage.crewMode.test.tsx"leaves the conductor when the chat switches to Incognito" and "keeps a plain chat on its agent when it switches to Incognito".Reader: website/src/pages/chat/command-center/CommandCenterPanel.tsx:CommandCenterPanel -- chat -- its inline root test moved to
isRootSessioninmodel.ts, same two fields; the existingCommandCenterPaneltests are unchanged and green.Tests
test/test_crew_mode_board.py: no adopted page means no block; a root chat on the default template (Crew Mode off) or on a crewmate named like the conductor gets no block; Crew Mode adoptsgoal-boardand the block names it; a page already adopted is kept; a root session gets the block, a dispatched, adopted or crewmate DM slot does not; the switch adopts only for the conductor template on a root Persistent session (an Incognito or Temporary chat adopts nothing), and tells the open Overview once; the turn rail andbuild_messagecarry the block on its own line before the request; the agent-switch route calls the adoption. Each of 10 removals (root test, member skip, adopted-page gate, keep-adopted, forwarding, rail append, adopt root test, template namespace, conductor-only, the route call) turns a named test red.ChatPage.crewMode.test.tsx: on goes throughchatSlotAgent(slot, 'kirocrew-conductor', 'template')and opens the side panel in a root chat; a dispatched chat switches and opens nothing; off leaves the panel open; the welcome button opens the board. The follow-ups from the approval on feat: bring back the Crew Mode switch above the chat input #21526 (review): "is busy, still focusable, with a visible hint while this composer runs a reply the slot list has not seen" (the localslotRunningterm), "is not offered on a remote-instance chat" (instance_id), "is held back while the chat is still loading" (slotLoading). Each turns red when its term is removed.CrewModeChip.test.tsx: one accessible name witharia-pressed; the described-by line is the accessible description; busy isaria-disabledand ignores clicks; the welcome page has no sample board and its button opens the board.test/test_crew_mode.py,lib/crewMode.test.ts,ChatPage.pageOwners.test.ts: the prompt section, the constant and the owner order.Determinism:
test_crew_mode_board.pyandtest_crew_mode.py20/20 at-n0and 10/10 at-n 4 --dist loadgroupbesidetest_session_dashboard.py; the four frontend files 20/20 and green shuffled (--sequence.shuffle --sequence.seed=20817, 45 tests).Manual verification
On a pod built from this branch: a new chat, then the Crew Mode chip. The side panel Overview opened, the page read back
goal-boardv1, and after one turn asking the Conductor to record three items it drew those three items. All four Conductor turns carried this block, and the worker and plain chats carried none:The Conductor's replies carried no inline task board. Its dispatched worker chat answered the dashboard read with 404
not_root_sessionand drew no Overview. A dispatched chat on the default agent, where the chip shows, could not be produced on the pod (the Conductor dispatches only onkirocrew-worker, where the chip is not offered by design); that path is covered by "turns on in a dispatched chat without opening a board it does not have".Local gates: every static gate in the prepare-pr profile passed, the frontend related suite (875 files) passed, semgrep and the flake-pattern ratchet passed. The backend related suite (2,425 files) had 71 failures; each is red on a clean
origin/maincheckout on this host too, or passes when rerun alone, excepttest_the_dashboard_boot_keeps_its_chain_hooks_and_order, which differs only because this worktree holds a builtwebsite/dist. CI is the authority on the full suites.Screenshots / video
The whole flow: a new chat, Crew Mode on (the side panel opens on the goal board), the first send (the memory chip leaves and the Crew Mode chip moves to the centre), the busy state, then the reply with the note under the chip.
crew-mode-flow.webm
While a reply runs: the chip keeps its on look, takes keyboard focus, and the visible line says "Available after the reply."
After the reply: the note says what turning it off does.
Crew Mode on: the side panel Overview draws the Conductor's goal board from its work ledger, and the reply carries no board.
The welcome page with no sample board, and its side panel button (phone, dark):
A new chat with the chip off:
A dispatched worker chat: no Overview, and no chip on a non-default agent.
Turned off mid-conversation: the chat is back on the default agent (the agent picker under the composer reads
kirocrew), the chip leaves with the mode as on main, and the side panel page is left as it was. The agent picker is the way back to the Conductor in a chat that already has messages; the chip is offered on a new chat.Every scene, desktop and 390x844, light and dark
Findings from #21526
sampleCrew()and theboard_*,sample_*,state_*keys are removed, a2021b1. Rebutted for the ghost art: it is the welcome design this PR asks a maintainer to sign offaria-pressed, a visible described-by hint,aria-disabledwhile busy, a2021b1Related Issues
Part of #21503
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.
crew-mode-flow.webm