Skip to content

feat(chat): [PENDING] bring back Crew Mode with its board in the side panel - #21889

Closed
bolichen97 wants to merge 2 commits into
mainfrom
feat/crew-mode-side-panel
Closed

bolichen97 wants to merge 2 commits into
mainfrom
feat/crew-mode-side-panel

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

PENDING, do not merge. This PR waits for a design sign-off from a maintainer and may change.

Problem / Motivation

Goal: Let a user turn a chat into a Conductor with one switch next to "Choose memory mode", and see that Conductor's task board in the side panel Dynamic Dashboard instead of in its replies.

The Conductor (kirocrew-conductor) splits a goal into tasks, runs each in its own chat, and reports back. Today the only way in is the agent picker, which lists several conductor agents under technical names. The Crew Mode switch that fixed this shipped in #16088 and was backed out in #16257. The restore attempt, #21526, was approved and then closed unmerged. Its review found that the welcome page's sample board looked like live work, and the Conductor still drew its board inline in every reply, while the side panel already has a Dynamic Dashboard (#18105) that can draw the real one.

Why it matters

The Conductor is how a big goal gets split up and tracked without the user reading every transcript. Hidden behind the agent picker, almost nobody reaches it. And a board drawn inline in each reply repeats itself every turn, while the side panel board stays current from the work ledger on its own.

Not a goal

What changed (motivation → approach → change)

Turning Crew Mode on now puts the Conductor's task board where it stays current: the side panel Overview, drawn from the chat's own work ledger. A chat is in Crew Mode exactly when it runs on kirocrew-conductor; the switch is the ordinary agent switch, so memory and history stay, and off puts the chat back on the default template.

Part Where What changes
Crew Mode chip components/CrewModeChip.tsx, pages/chat/page/crewModeSwitch.ts, ComposerDockView.tsx Right of "Choose memory mode". One accessible name, "Crew Mode", with aria-pressed for on and off. While a reply runs it stays focusable and a visible line says "Available after the reply."; with the mode on it says "Turning off Crew Mode makes this a normal chat. Chats it opened keep running."
Side panel crewModeSwitch.ts, ChatPage.tsx, command-center/CommandCenterPanel.tsx, command-center/model.ts Turning it on in a ROOT session opens the side panel Dashboard view, the way the + menu does. isRootSession is the panel's existing root test, moved into model.ts. Off leaves the panel open
Board page dashboard_agentic.py, dashboard/chat_api/agent_switch.py The switch to the conductor template on a root session adopts the shipped goal-board with the ordinary instance.adopt, only while nothing is adopted yet, and tells an open Overview to re-read
[DASHBOARD] block dashboard_agentic.py, dashboard/chat_runner.py, context_assembly/turn.py, context_assembly/turn_message.py Each dashboard turn of a Crew Mode chat (a root session on the conductor template, not a crewmate) with an adopted page carries the crewmate's [DASHBOARD] block, keyed by the session's store key, so the Conductor's existing rules skip its inline board and its introduction, and each reply carries only the "Needs you" lines and one line on what changed. Off, the page stays and the block stops
Welcome page components/CrewModeWelcome.tsx, ChatTranscriptView.tsx Title, tagline, four labels and ghost art. No sample board: one line, "Your task board shows in the side panel", and an Open task board button
Memory switch pages/chat/memoryModeSwitch.ts Leaving Persistent also leaves the Conductor

The switch is offered only on a plain local Persistent chat on the default template or the Conductor, never in a crewmate, app, mode or remote-instance chat, and not when the Conductor is itself the default agent. CREW_MODE_AGENT lives in lib/crewMode.ts alone. Specs and docs say the same in context-management.md, memory-skills-hooks.md, dashboard-instances.md, session.md, learn-cron-dashboard.md, crew-mode.md, agents.md, work-ledger.md and the feature map. i18n adds the Crew Mode keys to every catalog in i18n/locales/ and en-XA; "Crew Mode" joins i18n/glossary.json.

Backwards compatibility

Compatible: no route, field, config key or template changes. The switch calls the existing POST /api/chat/slots/{slot}/agent; a root session's page gets goal-board only when it had none, and the per-turn block reaches only a Crew Mode chat with an adopted page.

Reader: website/src/pages/chat/memoryModeSwitch.ts:runMemorySwitch -- chat -- a kirocrew-conductor template chat switched to Incognito or Temporary is recreated on the default template, since such a session may not create sessions; ChatPage.crewMode.test.tsx "leaves the conductor when the chat switches to Incognito" and "keeps a plain chat on its agent when it switches to Incognito".
Reader: website/src/pages/chat/command-center/CommandCenterPanel.tsx:CommandCenterPanel -- chat -- its inline root test moved to isRootSession in model.ts, same two fields; the existing CommandCenterPanel tests are unchanged and green.

Tests

  • test/test_crew_mode_board.py: no adopted page means no block; a root chat on the default template (Crew Mode off) or on a crewmate named like the conductor gets no block; Crew Mode adopts goal-board and the block names it; a page already adopted is kept; a root session gets the block, a dispatched, adopted or crewmate DM slot does not; the switch adopts only for the conductor template on a root Persistent session (an Incognito or Temporary chat adopts nothing), and tells the open Overview once; the turn rail and build_message carry the block on its own line before the request; the agent-switch route calls the adoption. Each of 10 removals (root test, member skip, adopted-page gate, keep-adopted, forwarding, rail append, adopt root test, template namespace, conductor-only, the route call) turns a named test red.
  • ChatPage.crewMode.test.tsx: on goes through chatSlotAgent(slot, 'kirocrew-conductor', 'template') and opens the side panel in a root chat; a dispatched chat switches and opens nothing; off leaves the panel open; the welcome button opens the board. The follow-ups from the approval on feat: bring back the Crew Mode switch above the chat input #21526 (review): "is busy, still focusable, with a visible hint while this composer runs a reply the slot list has not seen" (the local slotRunning term), "is not offered on a remote-instance chat" (instance_id), "is held back while the chat is still loading" (slotLoading). Each turns red when its term is removed.
  • CrewModeChip.test.tsx: one accessible name with aria-pressed; the described-by line is the accessible description; busy is aria-disabled and ignores clicks; the welcome page has no sample board and its button opens the board.
  • test/test_crew_mode.py, lib/crewMode.test.ts, ChatPage.pageOwners.test.ts: the prompt section, the constant and the owner order.

Determinism: test_crew_mode_board.py and test_crew_mode.py 20/20 at -n0 and 10/10 at -n 4 --dist loadgroup beside test_session_dashboard.py; the four frontend files 20/20 and green shuffled (--sequence.shuffle --sequence.seed=20817, 45 tests).

Manual verification

On a pod built from this branch: a new chat, then the Crew Mode chip. The side panel Overview opened, the page read back goal-board v1, and after one turn asking the Conductor to record three items it drew those three items. All four Conductor turns carried this block, and the worker and plain chats carried none:

[DASHBOARD]
Your Dashboard tab shows template goal-board v1.
Fields you write: asks. Call dashboard_fields for their shapes and current values before dashboard_write.
Upkeep: dashboard_fields also says what each field means, when to write it, and how -- read it before you write a field.

The Conductor's replies carried no inline task board. Its dispatched worker chat answered the dashboard read with 404 not_root_session and drew no Overview. A dispatched chat on the default agent, where the chip shows, could not be produced on the pod (the Conductor dispatches only on kirocrew-worker, where the chip is not offered by design); that path is covered by "turns on in a dispatched chat without opening a board it does not have".

Local gates: every static gate in the prepare-pr profile passed, the frontend related suite (875 files) passed, semgrep and the flake-pattern ratchet passed. The backend related suite (2,425 files) had 71 failures; each is red on a clean origin/main checkout on this host too, or passes when rerun alone, except test_the_dashboard_boot_keeps_its_chain_hooks_and_order, which differs only because this worktree holds a built website/dist. CI is the authority on the full suites.

Screenshots / video

The whole flow: a new chat, Crew Mode on (the side panel opens on the goal board), the first send (the memory chip leaves and the Crew Mode chip moves to the centre), the busy state, then the reply with the note under the chip.

crew-mode-flow.webm

While a reply runs: the chip keeps its on look, takes keyboard focus, and the visible line says "Available after the reply."

Busy, chip focused, desktop light

After the reply: the note says what turning it off does.

Crew Mode on after the reply, desktop light

Crew Mode on: the side panel Overview draws the Conductor's goal board from its work ledger, and the reply carries no board.

Crew Mode on, goal board in the side panel, desktop light

The welcome page with no sample board, and its side panel button (phone, dark):

Welcome page, phone dark

A new chat with the chip off:

Chip off, desktop light

A dispatched worker chat: no Overview, and no chip on a non-default agent.

Dispatched chat, desktop light

Turned off mid-conversation: the chat is back on the default agent (the agent picker under the composer reads kirocrew), the chip leaves with the mode as on main, and the side panel page is left as it was. The agent picker is the way back to the Conductor in a chat that already has messages; the chip is offered on a new chat.

Crew Mode on, mid-chat, desktop light

Crew Mode turned off mid-chat, desktop light

Crew Mode turned off mid-chat, phone dark

Every scene, desktop and 390x844, light and dark













Findings from #21526

Finding Outcome
UX: the sample board reads as real, #21526 (comment) fixed: the sample board and its keys are gone; the real board is in the side panel, a2021b1
First Principles: the welcome page is oversized, #21526 (comment) fixed in part: the sample board, sampleCrew() and the board_*, sample_*, state_* keys are removed, a2021b1. Rebutted for the ghost art: it is the welcome design this PR asks a maintainer to sign off
UX: the agent label shows the code name deferred: #21531
UX: the opened chats cannot be found or stopped rebutted: #21526 (comment); the side panel board now lists them too
Opus: off pointed at the wrong default while the catalog loads, #21526 (comment) fixed earlier, kept: #21526 (comment)
Design: confirm a maintainer approved bringing Crew Mode back, #21526 (comment) open: this PR is held for that sign-off
Approval follow-up 1, test gaps, #21526 (review) fixed: three named tests, each red when its term is removed, a2021b1
Approval follow-up 2, chip name and hints fixed: stable name, aria-pressed, a visible described-by hint, aria-disabled while busy, a2021b1
Approval follow-up 3, First Principles dispositions answered on this PR, one per item, on the current head
UX on this PR: the open Overview does not re-read after the session writes its ledger deferred: #21915 (the side panel dashboard's refresh path)

Related Issues

Part of #21503

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

crew-mode-flow.webm

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 18, 2026 12:27
@bolichen97
bolichen97 requested a review from CrysisDeu October 18, 2026 12:27
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 18, 2026
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a2021b1d9c321bc1c5fca1065227d559923b7412 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that a chat created directly on kirocrew-conductor, without the agent-switch route, should keep the inline board, since only switch_slot_agent adopts goal-board.

[DESIGN-REVIEWED] a2021b1

Description read

[DESCRIPTION-READ] 719690cf027a687e7ad39902307c4d497075ef27503657141269f45e7037fb28

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — 🟡 CONCERNS

Premise-level review of a2021b1d9c321bc1c5fca1065227d559923b7412 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

Every root kirocrew-conductor chat now gets goal-board adopted automatically, from the agent picker too. No recorded decision covers this for root sessions.

Not justified as shipped

  • Item 3 — inherited: the hook is await adopt_crew_mode_board_on_switch(slot, agent_name, state) in the generic switch_slot_agent route. So any root Persistent switch to the conductor changes its page from project-report to goal-board, and together with item 4 the replies drop the inline board. The cited rfc-conductor-chat-board-on-tab.md (in-progress) is scoped to a crewmate's Dashboard tab. It lists "Changing the templates, the [DASHBOARD] block, or any code path" as a non-goal. Decision 2026-10-10 says "Dashboard tab" and never mentions a root session's page. Whether either covers this is a judgement call, not something on record.
    Clears when: a non-draft RFC on base covers adopting goal-board on a root conductor session (then push or rebase), or a maintainer posts /ai-review override first-principles a2021b1d9c321bc1c5fca1065227d559923b7412: <decision>.

What this change ships

Inventory (7 items) — 6 justified

Intent: let a user turn a chat into a Conductor with one switch and watch its task board in the side panel, not in its replies. ADDITION.

  1. A "Crew Mode" chip appears next to "Choose memory mode" in eligible chats — justified
  2. Turning it on in a root chat opens the side panel Dashboard view — justified
  3. Switching a root Persistent chat to the conductor, by chip or agent picker, adopts goal-board — inherited: root-session coverage not recorded
  4. Root conductor chats with an adopted page get a [DASHBOARD] block each turn — justified
  5. The Crew Mode welcome page shows an "Open task board" button and no sample board — justified
  6. Switching a conductor chat to Incognito or Temporary recreates it on the default template — justified
  7. isRootSession moves into command-center/model.ts — justified

[FIRST-PRINCIPLES-REVIEWED] a2021b1

Description read

[DESCRIPTION-READ] 2e8fb6574e8191f3d3b396f1ae1769569a1c913b0229c79e088897cd69216742

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of a2021b1d9c321bc1c5fca1065227d559923b7412 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

In shot-02 the side panel board says "No item on this board yet" right after the reply says an item was recorded, so users can't tell whether Crew Mode worked.

Watch

  • The board contradicts the reply. The PR says the side panel board "stays current from the work ledger on its own". In shot-02 the reply reads Recorded it_7e3c815f "Check the nightly run" as open, but the Goal board still reads "No item on this board yet" and "entries 0". The blind reader's words: "contradiction. I can't tell whether it worked." This is the PR's main value, and the user hits it on the first turn of every new Crew Mode chat. Either refresh the Overview after each ledger write, or replace these screenshots with one that shows the board updated after the turn.
  • One board, three names. The button says "Open task board", it opens a panel tab named "Dashboard", and the box inside is titled "Goal board". The blind reader: "I think these are all the same thing, but nothing tells me so." A user who clicks the button lands on a surface that never says "task board". Use one name: either the button names the panel ("Open Dashboard") or the panel's heading uses the button's words.
  • The main switch was only guessed. For "Crew Mode: split into tasks" the reader said it "turns Crew Mode on… a guess". For the on state, "Turning off Crew Mode makes this a normal chat. Chats it opened keep running.", they said they would dare to click only "maybe… I don't know which chats it 'opened'". The note warns that chats keep running but gives no way to see or stop them. Add a link from the note to those chats (for example "See 2 running chats"), or name how many there are.
  • The board fills its first view with jargon. This PR auto-adopts goal-board and opens it for every new Crew Mode chat. In shots 01–03 that view shows "round 0, goal version 0, depth 0", "entries 4" beside 3 cards, and a full purple bar for "0 of 3 accepted". The reader: "no idea what these words mean" and "the bar looks 100% full even though nothing is done". Because the PR now puts this board in front of every new Crew Mode chat, a human should decide whether it is ready to be the first thing users see.

Suggestions

  • On a phone the off chip says only "Crew Mode" (chip_off), so it never says what turning it on does. Keep a short outcome word on narrow widths too, for example "Crew Mode: split tasks".
  • After Crew Mode is turned off (shots 08 and 22), the Goal board stays open with no sign that it no longer updates. Show a line on the Overview when the chat has left Crew Mode.

[UX-REVIEWED] a2021b1

Description read

[DESCRIPTION-READ] 1f2a109c436ff7d9e250d9d4784228cd34212c335a374b7b02796bb6ee3830f9

That sha256 names everything this verdict read: the PR description, plus the 26 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a2021b1d9c321bc1c5fca1065227d559923b7412 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a2021b1

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a2021b1d9c321bc1c5fca1065227d559923b7412: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a2021b1d9c321bc1c5fca1065227d559923b7412 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a2021b1

Verdict parsed from the review's SHA-scoped output markers for commit a2021b1d9c321bc1c5fca1065227d559923b7412.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a2021b1d9c321bc1c5fca1065227d559923b7412: <one-sentence reason>

@bolichen97
bolichen97 enabled auto-merge (squash) October 18, 2026 12:35
@bolichen97
bolichen97 disabled auto-merge October 18, 2026 12:39
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 18, 2026
@bolichen97
bolichen97 force-pushed the feat/crew-mode-side-panel branch from 99d339c to 9b48e1f Compare October 18, 2026 13:20
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Off does not undo on span=66aeb113d7a6

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • A plain chat keeps being told to write asks span=a81edca694fe

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The block widens to every root chat with an adopted page span=dfbde97c11a2

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Clears when the block is gated on the conductor template span=7f36f61c817d

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Item 4: the block reaches non-Conductor root chats span=8c723511e482

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Item 1: why the backout no longer applies span=cdfb35a8b69f

rebutted: #16257 backed the switch out because #16088 merged before it was meant to land, not because of a defect; its description says the switch returns in a fresh PR.
This PR is that fresh PR, and it is held: the title says [PENDING] and the body's first line says it waits for a design sign-off from a maintainer, which is the clear condition this item names. No code change answers it.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The visible note never says what turning off does span=bab9debca7a2

fixed in 9b48e1f: the visible line beside the on chip (chip_off_keeps_chats, named by the chip's aria-describedby) now states the outcome: "Turning off Crew Mode makes this a normal chat. Chats it opened keep running." in every catalog and en-XA.
The PR body adds a recording of the whole flow (on, side panel, first send, the chip moving to the centre, the busy state) and screenshots of the busy chip with keyboard focus and of the note after the reply.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The reader would not click the on chip span=0897a578b692

fixed in 9b48e1f: the visible line beside the on chip (chip_off_keeps_chats, named by the chip's aria-describedby) now states the outcome: "Turning off Crew Mode makes this a normal chat. Chats it opened keep running." in every catalog and en-XA.
The PR body adds a recording of the whole flow (on, side panel, first send, the chip moving to the centre, the busy state) and screenshots of the busy chip with keyboard focus and of the note after the reply.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The only way out of the mode span=061d648453de

fixed in 9b48e1f: the visible line beside the on chip (chip_off_keeps_chats, named by the chip's aria-describedby) now states the outcome: "Turning off Crew Mode makes this a normal chat. Chats it opened keep running." in every catalog and en-XA.
The PR body adds a recording of the whole flow (on, side panel, first send, the chip moving to the centre, the busy state) and screenshots of the busy chip with keyboard focus and of the note after the reply.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Make the visible note state the outcome span=d44b542f12b8

fixed in 9b48e1f: the visible line beside the on chip (chip_off_keeps_chats, named by the chip's aria-describedby) now states the outcome: "Turning off Crew Mode makes this a normal chat. Chats it opened keep running." in every catalog and en-XA.
The PR body adds a recording of the whole flow (on, side panel, first send, the chip moving to the centre, the busy state) and screenshots of the busy chip with keyboard focus and of the note after the reply.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • One board, four names span=7a00f874d27e

rebutted: the welcome line "Your task board shows in the side panel" is the wording this PR's requester asked for, and the button beside it opens that board in one click, so the link between the names is shown rather than described.
"Dashboard" and "Goal board" are the side panel's existing tab and the shipped page's own title; renaming either is outside this PR's goal (no template or panel change).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • No Crew Mode chip in task chats span=4236769b504e

rebutted: a task chat runs on kirocrew-worker, and the chip is offered only on the default template or the conductor (crewModeSwitch.ts crewModeEligible), as on #21526: turning a worker into a conductor would detach it from the item it reports to.
Low severity and blocks nothing, as the finding says.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • A root tab that picked a crewmate still gets the session block span=e59eecd02bf3

fixed in 9b48e1f: root_session_dashboard_block returns no block unless the slot runs the kirocrew-conductor TEMPLATE (agent name, and agent_kind not member), so turning Crew Mode off, or a root chat whose page was adopted some other way, gets no [DASHBOARD] block; the page itself is left as it is.
Tests: test_crew_mode_board.py covers a root chat on the default template with an adopted goal-board (no block) and a crewmate named like the conductor (no block); each goes red when the gate is removed.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 18, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 18, 2026
A Crew Mode chip right of "Choose memory mode" switches a plain chat to
the existing kirocrew-conductor through the ordinary agent switch, and
back again. Turning it on in a root session opens the side panel
Dashboard view, whose Overview is that session's own Dynamic Dashboard.
Turning it off leaves the side panel and the page alone. A dispatched or
adopted session switches without opening it.

On the server, the switch to the conductor template on a root session
adopts the shipped goal-board on that session's page with the ordinary
instance.adopt, only while nothing is adopted there yet, and tells an
open Overview to re-read. Each dashboard turn of a root session with an
adopted page carries its own [DASHBOARD] block (the crewmate block keyed
by the session's store key), so the conductor's existing rule skips its
inline task board.

The empty-chat welcome page keeps its title, tagline, four capability
lines and ghost art, and drops the sample board: one line and an "Open
task board" button point at the side panel instead.

The chip keeps one accessible name ("Crew Mode") with aria-pressed
carrying on and off, stays focusable while a reply runs, and its busy
and on hints show as a visible line it names with aria-describedby.

The client root test (isRootSession) is the side panel's existing one,
moved into command-center/model.ts so the panel and the switch share it.
There is no new setting, route, agent, template or session field.

Re-lands the switch backed out in #16257 on the current page owners.

Co-authored-by: zejiangg <zejiangg@amazon.com>
Co-authored-by: Joe Guo <12429733+iamwhatever@users.noreply.github.com>
@bolichen97
bolichen97 force-pushed the feat/crew-mode-side-panel branch from 79571ab to a2021b1 Compare October 18, 2026 20:57
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved (b26871d -> 8fd2af9); new head a2021b1. Related tests and local gates pass; CI re-running.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 18, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Item 3: picker switches also adopt the board span=0b01b80b5bea

needs-a-decision, for a maintainer: whether https://github.com/kirodotdev/KiroCrew/blob/main/docs/decisions/2026-10-10-conductor-board-tab-replaces-the-in-chat-board.md covers a root session's side panel page, so a picker switch to the conductor also gets goal-board. The chip and the picker send the same switch; confining it needs a new field or route this PR's goal excludes. The author posts no override.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • A chat created directly on the conductor keeps its page

needs-a-decision, for a maintainer: adoption runs only in switch_slot_agent, the switch the chip and the picker send, so a chat created on kirocrew-conductor another way keeps its page as on main. Widening it is the same open picker and CLI adoption question as the first-principles item on this head; the author leaves it to the sign-off.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The board contradicts the reply span=850e4f5de1cd

accepted-and-deferred: #21915, the open Overview not re-reading on a ledger write (the side panel dashboard's refresh path from #18105); reopening shows the item.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • One board, three names span=4d7ba7f0810a

rebutted, as on the earlier heads: the welcome wording is the requester's, its button opens the board in one click, and the tab and page titles are existing names this PR's goal does not rename.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The main switch was only guessed span=eda538e8d091

rebutted: the chip's label names the outcome, the visible note under it says what turning it off does and that opened chats keep running, and its aria-pressed and description carry the state; this is the a11y follow-up wording a reviewer asked for on the earlier head.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The board fills its first view with jargon span=6db8175b00af

rebutted: those tiles are the shipped goal-board template's own; this PR's goal excludes template edits and only chooses that page.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • On a phone the off chip does not say what it does span=8d646ceda6e8

rebutted: on and off differ in label, colour and aria-pressed at every width; the phone keeps the short off label for space, and the chip's description still states the outcome.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • After Crew Mode is off the board gives no sign span=8354a4065189

rebutted: owner ruled option A for this held PR; the agent picker is the way back after turning Crew Mode off mid-chat, as on #21526. The page stays as it is by design.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 18, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Held at the author's request: this PR is marked [PENDING] and brings back Crew Mode, a change to an experience users already have. It needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. This review is dismissed once the design is agreed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 18, 2026
Crew Mode is now chosen once, on a new chat's welcome state. Pressing the
composer chip hides both the memory-mode chip and the Crew Mode chip for
that chat and neither comes back: there is no off control and no off note.
A refused switch brings both chips back. The agent picker is unchanged.

The welcome page is pictures, not prose: the Crew Mode hero, the slogan, a
five-step flow (Goal, Split, Own chats, Board, Needs you) and one "Task
board" button, shown as its icon alone where room is tight with its name
kept on aria-label and title and a 44px touch target. Everything plays once
within 3.5s, once per chat, and settles on its final frame as soon as the
person starts typing; reduced motion draws only the final frame. The page
stays on screen from the chip press to the first message.

Specs and docs that described the off switch, the four capability labels
and the old button text are updated to match.
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Closing: Crew Mode is being redesigned. A new pull request will replace this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants