Skip to content

docs(rfc): answer the hybrid RFC's two packaging questions - #22120

Merged
Zedmor merged 1 commit into
mainfrom
zedmor/rfc-hybrid-packaging-answers
Oct 19, 2026
Merged

Zedmor merged 1 commit into
mainfrom
zedmor/rfc-hybrid-packaging-answers

Conversation

@Zedmor

@Zedmor Zedmor commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Answer the two packaging questions that block Phase 3 of the Python+Rust hybrid RFC, so the maintainer can settle packaging before any Rust PR moves.

rfc-python-rust-hybrid-backend.md §7 lists two packaging unknowns that block Phase 3's kirocrew-native wheel. First, does the Windows signing hook sign an .exe inside a wheel ("Unverified"; Windows stays on the Python stub until it is answered)? Second, does packaging/resign-macos-libs.sh cover suffix-less Mach-O binaries (it blocks local macOS installs)? The maintainer asked that packaging be settled before the Rust PRs (#19627, #19628) move.

Why it matters

Without these answers Phase 3 would be planned around a Windows exclusion it doesn't need, and it would miss the one change macOS source installs do need.

Not a goal

  • Changing any phase, decision or status. The two §7 rows are answered and nothing else changes.
  • The resign-macos-libs.sh change itself. It belongs with Phase 3, when there is a binary to re-sign.
  • Building or shipping kirocrew-native.

What changed (motivation → approach → change)

  • Approach. I read the code that runs at release, then the installer tool's own source at the pinned version.
  • Windows. The bundled interpreter's Lib/site-packages sits in backend-dist, which website/electron/package.json ships as extraResources. In electron-builder 26.15.3, PlatformPackager copies extra resources through WinPackager.createTransformerForExtraFiles, and shouldSignFile accepts every .exe by default. website/electron/scripts/sign-windows.js then Authenticode-signs each one, except the pinned ffmpeg-win-x86_64-v7.1.exe. So a stub .exe inside the wheel gets signed with no workflow change. perf(mcp-gateway): Rust MCP stub, used by default when built #19627's embedded source digest survives, because Authenticode appends rather than rewrites; a pinned whole-file hash would not, which is why ffmpeg is exempt.
  • macOS, released app. packaging/signing/generate-manifest.py finds every Mach-O under Contents/Resources by magic and signs it with Developer ID, hardened runtime and a timestamp. It already does this for imageio-ffmpeg's suffix-less executable, so the released app is covered.
  • macOS, source install. resign-macos-libs.sh re-signs only *.so and *.dylib, and only make build runs it. A stub binary would keep its linker-signed signature, so Phase 3 has to extend the script's find.
  • rfc-python-rust-hybrid-backend.md §7: both rows now record the answer, its evidence and what still blocks. This branch is stacked on docs(rfc): record measured executor CPU, GIL holders and anon memory #22065, which edits the same table, and should merge after it.

Backwards compatibility

Compatible: documentation only.

Removes nothing: the two questions stay in the table with their answers.

Tests

N/A — documentation only. scripts/docs-lint.sh and scripts/check_brand_name.py pass.

Manual verification

  • Read WinPackager.signApp, createTransformerForExtraFiles and shouldSignFile in the app-builder-lib 26.15.3 package from the public npm registry. Also read PlatformPackager, where extra resources are copied through that transformer.
  • Checked that website/electron/package.json sets no signExts, so the default .exe rule applies.
  • No signed Windows build was run for this. The Windows row says so and asks for confirmation on the first signed build.

Related Issues

Stacked on #22065. Context: #19627, #19628.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@Zedmor
Zedmor requested review from a team and KiroCrewCaptain as code owners October 19, 2026 08:05
@Zedmor
Zedmor requested review from dodgeblaster and removed request for a team October 19, 2026 08:05
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 82b76753a4c0db81df646fe39d7cfde370b34a85 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 82b76753a4c0db81df646fe39d7cfde370b34a85 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 82b76753a4c0db81df646fe39d7cfde370b34a85 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that #22065 merges first; both PRs edit the same §7 table, so merging this one out of order will conflict.

[DESIGN-REVIEWED] 82b7675

Description read

[DESCRIPTION-READ] 856e8d2faa27c2891786a516ae0179b760b3958caba8c8187bb47cfb25d18e14

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 82b76753a4c0db81df646fe39d7cfde370b34a85 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 82b7675

Verdict parsed from the review's SHA-scoped output markers for commit 82b76753a4c0db81df646fe39d7cfde370b34a85.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 82b76753a4c0db81df646fe39d7cfde370b34a85: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 82b76753a4c0db81df646fe39d7cfde370b34a85 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 82b7675

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 82b76753a4c0db81df646fe39d7cfde370b34a85: <one-sentence reason>

@Zedmor
Zedmor force-pushed the zedmor/rfc-python-rust-hybrid-measurements branch from 551fab9 to ffd0d5b Compare October 19, 2026 08:09
@Zedmor
Zedmor force-pushed the zedmor/rfc-hybrid-packaging-answers branch from d5b6c03 to fc6dcb4 Compare October 19, 2026 08:09
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@Zedmor
Zedmor requested a review from iamwhatever October 19, 2026 08:59
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD (base) at fc6dcb4.

This PR targets zedmor/rfc-python-rust-hybrid-measurements, the branch of the still-open #22065, not main. It cannot be approved until #22065 merges and this PR is retargeted to main (and re-reviewed at that head).

The content itself looks sound: the two §7 rows match the cited code (sign-windows.js exempts only the pinned ffmpeg exe, resign-macos-libs.sh walks only *.so/*.dylib, backend-dist ships as extraResources with no signExts). All AI lanes pass with no findings, and CI is green. The Windows answer is from reading source; the row itself says to confirm it on the first signed build, which is the Design punchline's ask.

— crew-pr-reviewer (r112)

@Zedmor
Zedmor changed the base branch from zedmor/rfc-python-rust-hybrid-measurements to main October 19, 2026 14:18
@Zedmor
Zedmor force-pushed the zedmor/rfc-hybrid-packaging-answers branch from fc6dcb4 to 918e2c5 Compare October 19, 2026 14:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026
@Zedmor

Zedmor commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. I've retargeted this to main as a standalone change: one commit, 918e2c5e86, which edits only the two §7 packaging rows. It no longer depends on #22065. The two PRs touch adjacent §7 rows, so whichever merges second gets a one-line rebase from me. The base HOLD should no longer apply at this head.

@github-actions

Copy link
Copy Markdown
Contributor

Security Scope Review -- 🔴 could not complete (fails closed)

No scope verdict for 918e2c5e86a40a076ed42535e4cb1c455586a2e3 (the candidate stage failed). This lane fails CLOSED: an unmeasured tightening must not read as "nothing newly refused". See the job logs, then re-run -- or record /ai-review override scope 918e2c5e86a40a076ed42535e4cb1c455586a2e3: <reason> if a human has judged the scope by hand.

@Zedmor

Zedmor commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

On the Design note at 918e2c5 (make "confirm once in the first signed build" an actual Phase 3 gate): this PR's frozen scope excludes changing any phase, so I've deferred it rather than widening the PR. For now the gate is the §7 row's Blocks column. @iamwhatever, if you want it in the plan itself, this is the amendment I'd propose for §5's Phase 3 row. Add to the success signal: "in the first signed release, the stub inside the Windows installer passes signtool verify /pa and the one inside the macOS app passes codesign --verify --strict; resign-macos-libs.sh re-signs it on a make build install". Add to the kill criteria: "a signed release ships the stub unsigned on either platform". I can open that as its own PR if you'd like.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@Zedmor
Zedmor force-pushed the zedmor/rfc-hybrid-packaging-answers branch from 918e2c5 to 57582fd Compare October 19, 2026 15:18
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 19, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 19, 2026
Phase 3 of the Python+Rust hybrid RFC was blocked on two questions in
section 7: does the Windows signing hook sign an .exe inside a wheel,
and does the macOS re-sign script cover a suffix-less Mach-O binary.

The code answers both. The desktop installer copies the bundled
interpreter's site-packages as an extra resource, and electron-builder
hands every .exe there to the sign hook, which exempts only the pinned
ffmpeg binary. The released macOS app signs every nested Mach-O by
magic. Only the source-install re-sign script misses a suffix-less
binary, which Phase 3 now has to extend.
@Zedmor
Zedmor force-pushed the zedmor/rfc-hybrid-packaging-answers branch from 57582fd to 82b7675 Compare October 19, 2026 17:46
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 19, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason as other proposal

@Zedmor
Zedmor merged commit 36aa41d into main Oct 19, 2026
105 checks passed
@Zedmor
Zedmor deleted the zedmor/rfc-hybrid-packaging-answers branch October 19, 2026 21:37
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants