Repository navigation
feat(schedule): show a crewmate's schedules as Crewmate in the list, with a by-crewmate filter - #22136
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 7745f8d Description read[DESCRIPTION-READ] 25fd8e6dd105881c9b29549dffe6a9d3eee77efba6829c240277e689c806df6c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The list now shows "Crewmate" next to "agent", but nothing on screen tells a first-time user how the two differ. Explaining that difference is the reason this PR exists. Watch
Suggestions
[UX-REVIEWED] 7745f8d Description read[DESCRIPTION-READ] 0ac2b6aed11edf78b87a3cb91009c996eafcab9be9ebe6b23df816cfcbf2cc6d That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that #18772 asks for a separate dropdown: this PR also makes search match crewmate names, so typing "Radar" already narrows the list. What this change shipsInventory (8 items) — 8 justifiedIntent: let a user tell a crewmate's own schedule (it runs in that crewmate's chat with its private memory) apart from a custom-agent job, and read one crewmate's jobs together. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 7745f8d Description read[DESCRIPTION-READ] fe9390b31cc28c6129aae52215154e9c38ac0fa984cdd8e6c89a829bace296a8 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
d86f6ef to
ac470ee
Compare
|
|
|
|
|
|
|
ac470ee to
bbcf5d4
Compare
|
|
|
|
|
|
|
8d28090 to
0a4d180
Compare
|
Rebased again onto main 6257f69 because GitHub reported a second merge conflict. New head 0a4d180. The conflict was in The previous head's red Harness Parity Gate ( |
…with a by-crewmate filter
|
Rebased onto main ed975d7 because GitHub reported a merge conflict. New head 7745f8d. The conflict was again only in |
0a4d180 to
7745f8d
Compare
|
Review-ready at head 7745f8d (single commit on main ed975d7, which includes #22178). This is the last slice of #18772 ( Open for the maintainer, no code change pending:
Not merged, approved, or set to auto-merge. |
|
|
|
|
|
|
|
Problem / Motivation
Goal: On the Schedule page, a crewmate's own schedule reads as "Crewmate" with that crewmate's face and name, and the list can be narrowed to one crewmate's schedules.
Today the Schedule list shows every LLM job as "Agent · ". A crewmate's own schedule (a job with
member_id, which runs in that crewmate's chat with its own memory) and a job that opens a new session on a custom agent look the same. A crewmate schedule whose crewmate has run once even shows only its durable id, because the row'smember_idchanges from the name to that id after the first run.Why it matters
The two kinds of job deliver to different places: a crewmate schedule lands in that crewmate's chat with its private memory, a custom-agent job opens a new session on shared memory. #18772 asks the list to tell them apart so the user knows where a job's output goes, and to let a crewmate's jobs be read as one block.
Not a goal
member_idis stored.agent.default_agentknob (fix(session): a plain session is the default template, never the default crewmate #18328).What changed (motivation → approach → change)
The list now tells a crewmate's own schedule apart from a custom-agent job.
member_idset)/members?member=<name>The Type cell's hover tooltip names the crewmate for a crewmate schedule (the raw id when no roster row resolves), where it used to name the agent.
The page reads the crewmate from the members roster it already loads (
membersRosterQuery,GET /api/members). Creation stores the crewmate's durable id in a row'smember_id(bind_cron_memory), which is the roster row'sslug, socrewmateForJobmatches on the slug alone, aswakesCrewdoes; a slug two roster rows share names nobody, as the roster itself treats it. No backend change.A by crewmate dropdown beside the search box narrows the list to one crewmate's schedules. It shows only when some listed job belongs to a crewmate, applies only while its crewmate still owns a listed job, and while it is set, folder collapse is bypassed the same way the search does. The search box also matches the crewmate's name and display name. If the roster read fails while a crewmate schedule is listed, an inline notice with Retry says so, rather than the links and filter quietly disappearing. The change is in
pages/SchedulePage.tsx. Three new strings are translated in all 12 locales (i18n/locales/*.json, notes ini18n/en.context.json),en-XAis regenerated, andlearn-cron-dashboard.mddescribes the row field, the Type cell and the filter.Backwards compatibility
Compatible: no API changes; the page reads
GET /api/cronsandGET /api/membersas they are on main.Removes nothing: the Type cell keeps every existing case and adds one for rows with
member_id.Tests
website/src/test/SchedulePage.crewmateType.test.tsx: a crewmate job's Type cell reads Crewmate and links to/members?member=radar; a template job is unchanged and unlinked; a slug two roster rows share names nobody (raw id, unlinked); a crewmate filter whose crewmate no longer owns a listed job is dropped; a failed roster read shows the notice, keeps the raw ids, and recovers on Retry; search finds a crewmate job by its display name; a gone crewmate shows the raw id, unlinked; the filter narrows to one crewmate; no filter shows when no job belongs to a crewmate.The frontend file is red on main's
SchedulePage.tsxand green on this head, including withKIROCREW_ACT_STRICT=1.Manual verification
Looked at the real Schedule page on a loopback dev server with a stubbed API (two crewmate schedules, one stored by durable id and one by name, a custom-agent job and a script job, with the members roster stubbed), dark and light, with the filter closed, open and set. The frames below are those captures.
Screenshots / video
Before: crewmate schedules read as Agent, with the raw id.
After: crewmate schedules read as Crewmate with face and name; the filter sits beside the search.
After: filtered to Radar.
After: the members roster fails to load. The notice says so with Retry, and crewmate rows show the raw id, unlinked.
More: filter open, light theme
Related Issues
Closes #18772
Slice 3 of #18772 (the list), the last one: slice 2 (the form's "Runs as" switch, #22055) is on main.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)