Skip to content

docs(rfc): crew usage metrics, wave 2 - #22180

Closed
chenmingwei23 wants to merge 2 commits into
mainfrom
docs/21270-crew-usage-metrics-rfc
Closed

chenmingwei23 wants to merge 2 commits into
mainfrom
docs/21270-crew-usage-metrics-rfc

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Give maintainers a design to review for the next set of crew usage metrics, before any implementation PR lands.

We cannot answer basic questions about how the crew is used: how many workers a conductor runs, how wide and deep session trees get, how agents drive each other through session control, whether monitor loops do real work or tick quietly, how work ledger items end, which event sources wake sessions, and whether the crew log drops data or folds slowly. The first export round (#21342, #21308) counts sessions and turns only.

Why it matters

Without these numbers, decisions about the conductor, monitors and the work ledger rest on guesses. Regressions that people do not report (failed sub-agents, quiet monitor ticks, slow folds) stay invisible.

Not a goal

  • Where the numbers are sent or which ones leave the machine. That is a separate RFC.
  • Counting machines or installs. No metric carries a machine or install id.
  • "Stale" work items. Deferred.
  • Exact per-event latencies (spans).
  • Building any of it. Each area lands in its own implementation PR.

What changed (motivation -> approach -> change)

Adds docs/request-for-change/rfc-crew-usage-metrics.md and its index row in docs/request-for-change/README.md.

Approach: counters and gauges only; every attribute is a closed enum listed in the document; a duration or size is a counter with a small bucket attribute so the distribution survives backends that do not keep explicit histogram buckets; "how many right now" is a gauge read from live state, never an up/down counter. Sources prefer small counting folds on the crew log (the model of #21288), otherwise the single commit point of the feature. The first crew log health batch adds no work to the append thread.

It also records two changes to the open first-round PRs: crew.turn.started gains agent_kind, and a new crew.session.tree.child counter gives tree width. crew.session.tree.depth is unchanged: it is already a counter with a closed depth label.

Backwards compatibility

Compatible: documentation only; no code, config or behaviour changes.

Removes nothing: the diff adds one document and one index row.

Tests

N/A -- documentation only. python3 scripts/docs_lint.py passes locally.

Manual verification

Every "today" claim in section 2 and the README row was checked against 76e470d39e with git grep.

Related Issues

Refs #21270. Builds on #21288.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d57b8eb74578b5fcc08f8e621d2b5542b3a76172 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d57b8eb74578b5fcc08f8e621d2b5542b3a76172 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d57b8eb74578b5fcc08f8e621d2b5542b3a76172 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this PR only adds a design document and its index row. It changes no code, config or rendered surface, and takes nothing away.

[DESIGN-REVIEWED] d57b8eb

Description read

[DESCRIPTION-READ] c79fd774f77815919be505912d8173898896b6e38735e3224e1af47c67a04286

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d57b8eb74578b5fcc08f8e621d2b5542b3a76172 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d57b8eb

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d57b8eb74578b5fcc08f8e621d2b5542b3a76172 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d57b8eb74578b5fcc08f8e621d2b5542b3a76172 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d57b8eb

Verdict parsed from the review's SHA-scoped output markers for commit d57b8eb74578b5fcc08f8e621d2b5542b3a76172.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d57b8eb74578b5fcc08f8e621d2b5542b3a76172 false-positive: <reason, 20 to 500 characters>

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on dd9e49c.

  1. Labels that are not listed. Section 9 says each enum is listed in this document, but three are not: autonudge.loops.stopped reason (L143, the fixed stop reasons), monitor.decisions kind (L144, the closed monitor kinds) and crew_log.fold.apply fold (L186, FOLD_NAMES). On main, autonudge stop reasons are store-sourced strings clipped to 200 characters (autonudge_stop_log.py safe_text) and monitor stop reasons can be up to 500 characters (monitoring/models.py:51), so the raw-text to closed-value mapping needs to be written down here.
  2. Cardinality math. agent_kind has 16 values in #21342 (13 agent-file stems plus default, crewmate, other), not 6. turn.started is at most 8 x 16 = 128 series (160 after the actor change), not 48 (L102), and session_control.calls is 18 x 16 x 2 = 576, not 216 (L132). Please restate the bounds and add one for fold.apply and loops.stopped.
  3. Failure isolation at commit points. Wave 2 records from request handlers and service code (session control, WebhookRunStore.record, the ledger handler, autonudge firing), not only through the bus, which already isolates subscriber errors. Please add a rule that a failure while recording is caught and never changes the outcome of the call it measures.
  4. Relation to the base RFC. L25 and L71 hand egress to rfc-telemetry-export-kiro-endpoint.md on a branch with no pull request. That document adds a default destination, depends on telemetry.enabled turning on by default and sends the sign-in credential, and L73 counts people at the endpoint. #21288 sections 8 and 9 and its question 3 say the opposite. Please link a pull request or remove the dependency, and say which RFC governs. Also note that wave 2 spends #21288 question 1 (category vs named list) and pulls in its S4 work ledger phase.

Follow-ups, not blocking: section 2 says depth is a histogram although #21288 and #21308 already moved it to a counter; L162 justifies commit-point counting by the existing work fold, while a new counting fold would not have the 32-item limit.

For maintainers: this RFC and the export-endpoint RFC need a ruling before the wave-2 code PRs can rely on it. Checks are green (84 pass, 16 skipped) and readiness passed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 19, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Addressed the review in 8caf72a.

  1. Value lists: new section 6.6 lists agent_kind (16), actor, the stop reason table (raw stored text to closed value, 28 values plus other; free text clipped to 200 or 500 characters and composed reasons map to other), the registered monitor kinds plus other, and the 16 FOLD_NAMES. Values are copied from feat(metrics): count monitor loop starts, ticks, stops and decisions #22217, feat(metrics): count crew log losses and folds without touching the append path #22226 and feat(otel): export session/turn usage counts from the crew log (#21272) #21342.
  2. Cardinality: turn.started is 8 x 16 = 128 (160 after the actor change), session_control.calls is 18 x 16 x 2 = 576. New section 6.7 adds bounds for tree.child, loops.stopped (348), monitor.decisions (56) and fold.apply (204, at most 64 in practice).
  3. Failure isolation: section 4 rule 8. A failure while recording at a commit point is caught and never changes the result, status, error or written state of the measured call; tests make the recorder raise.
  4. Base RFC: the export-endpoint dependency is removed. docs(request-for-change): add crew log telemetry export RFC #21288 sections 8 and 9 govern egress and this RFC adds no outbound path. docs(rfc): send product metrics to the Kiro telemetry endpoint #22181 is named only as a separate draft proposal under review. The endpoint people-count line is gone. Section 7 notes that wave 2 relies on docs(request-for-change): add crew log telemetry export RFC #21288 question 1 and pulls in its S4 phase.

Follow-ups: section 2, section 5 and section 8 now say depth is already a counter. Section 6.3 now says a new counting fold would not hit the 32-item limit; the commit point is used because the depth, fails and duration labels need per-item facts a numbers-only fold cannot hold.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 19, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Opus 5.5 finding (rfc-crew-usage-metrics.md:321, stop reason mapping): fixed in 9b05c72.

Section 6.6 now says a reason with no table entry falls back to the row's terminal MonitorOutcome value when the monitor row records one (so a pull_request_merged stop reports success), and only a reason with neither reports other. The success / blocked / budget / target_unavailable row says the same. This matches the stop emitter in src/kiro_crew/metrics/monitor_loops.py.

@chenmingwei23

chenmingwei23 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto main (b700d47) again; the branch was conflicting. The only conflict was docs/request-for-change/README.md: kept main's text and re-applied this PR's one history sentence and its index row. docs/request-for-change/rfc-crew-usage-metrics.md is unchanged from 9b05c72, so both review-finding fixes carry over to head b8d7dd6. Still 2 commits. (An intermediate push, c37f903, left conflict markers in the README; b8d7dd6 removes them.)

@chenmingwei23

chenmingwei23 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebased onto main (2dd19ba); the branch was conflicting. The only conflict was docs/request-for-change/README.md: kept main's text and re-applied this PR's one history sentence and its index row. docs/request-for-change/rfc-crew-usage-metrics.md is unchanged from b8d7dd6. New head b7dc496, still 2 commits. The Real Adapter Contract Tests job is expected to stay red until the main fix for issue #22958 lands.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto main (3d6cda4) to pick up the fix for the Real Adapter Contract Tests job (#22951). No conflicts this time. docs/request-for-change/README.md and docs/request-for-change/rfc-crew-usage-metrics.md are unchanged from b7dc496. New head 8a1528f, still 2 commits.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD -- reviewed 8a1528f.

The factual problem behind our r114 change request is fixed: the RFC is status: partial, names each merged implementation PR with its sha, and marks append.bytes, append.batch and fold.lag as open append-path work (rfc-crew-usage-metrics.md#L1-L26). There is no active third-party change request, and checks are green.

What still blocks:

What clears it: a maintainer ruling on both questions, plus a reply to each Design note.

— crew-pr-reviewer (r119)

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto current main; the branch was conflicting. The only conflict was docs/request-for-change/README.md: kept main's text and re-applied this PR's one history sentence and its index row. docs/request-for-change/rfc-crew-usage-metrics.md is byte-identical to 8a1528f. New head a1520ed, still 2 commits.

Replies to the two Design Review notes on 8a1528f:

  1. Goal / description. Agreed, and the Goal text is left as written. With status: partial, accepting this RFC now means ratifying the metrics that already ship on main, as the status line lists them:

    It also records the open work as not yet decided: the 6.4 actor change (webhook and heartbeat), and the append-path instruments crew_log.append.bytes, crew_log.append.batch and crew_log.fold.lag (Metrics: crew_log.fold.lag (deferred from #22226) #22630). Accepting the RFC does not approve building those; each comes back for review when it is built.

  2. kirocrew.crew_log.write.lost type. It ships in feat(metrics): count crew log losses and folds without touching the append path #22226 (2d2a08a) as an observable gauge whose reading is a process-lifetime total, kept in memory and reset on restart. That follows the project rule that no instrument exports a CUMULATIVE series (pinned by test_no_instrument_exports_cumulative): the value is a total owned by other modules, so the instrument has to be asynchronous, and an observable counter would export CUMULATIVE. Section 6.5 records this as a deviation from the counter in its table. Which type stands is a maintainer ruling, and it should be made before the 6.5 second batch builds on it. This PR does not claim that ruling.

Also open for a maintainer: #21288 question 1 (rfc-crew-usage-metrics.md L363), whether approval is for a data category or for a named list of metrics. Wave 2 reads it as a category; if the answer is a named list, each phase returns for review with section 6.6 as its list.

No design text changed in this push.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (8edd26d); new head 5c99523, still 2 commits.

Conflict was only in docs/request-for-change/README.md: main had added new index rows and edited the history paragraph. Main's text is kept as is; this PR re-adds only its one history sentence and its index row (now after the rfc-adaptive-warm-pool row at the end of the table).

docs/request-for-change/rfc-crew-usage-metrics.md is byte-identical to the previous head a1520ed. docs_lint passes.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 5c99523.

The rebase left the RFC byte-identical to a1520ed, and the r114 factual problem stays fixed: the RFC is status: partial and names each merged implementation PR. Checks are green and there is no active third-party change request.

What still blocks:

  • Two maintainer rulings the RFC defers are still open: the type of kirocrew.crew_log.write.lost (L244-L252) and docs(request-for-change): add crew log telemetry export RFC #21288 question 1 (L363). The Design lane repeats the write.lost point on this head.

  • The Opus note on this head has no reply. SESSION_CONTROL_OPS on main now has 19 verbs including handoff (session_control_calls.py#L94-L116), but section 6.1 lists 18 verbs and bounds the instrument at 608 series (L166-L171, and L344). The lane also reports FOLD_NAMES and agent_kind counts below the code. Smallest fix: re-audit the enum counts and bounds against current main, or reply saying why the audit point stays at ba5a6fc614.

  • The branch now conflicts with main again and needs a rebase; the rebased head needs a fresh review.

What clears it: a maintainer ruling on both questions, the count fix or a reply, and a rebase.

— crew-pr-reviewer (r126)

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto main (c7189a8). New head: cf5bb22, still 2 commits.

Conflicts were only in docs/request-for-change/README.md: the history sentence on line 28 and the index table, where main had added the rfc-idle-compaction-before-cache-expiry and rfc-fold-delta-push rows at the same spot. Main's text is kept as is; this PR's one history sentence and its rfc-crew-usage-metrics row are re-applied after main's new rows.

docs/request-for-change/rfc-crew-usage-metrics.md is byte-identical to the previous head 5c99523.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Re-audited the RFC value lists and series bounds against main at c7189a8. New head: 9333b45, still 2 commits. This answers the Opus 5.5 finding (#22180 (comment)) and the count point in r126 (#22180 (comment)).

What changed on main after the old audit point ba5a6fc:

New bounds in 6.1, 5 and 6.7:

  • crew.turn.started: 8 x 18 = 144; 10 x 18 = 180 after the actor change (was 128 / 160)
  • crew.session.tree.child: 18 x 5 = 90 (was 80)
  • crew.session_control.calls: 20 x 18 x 2 = 720, 360 without outcome (was 608 / 304)
  • crew_log.fold.apply: 3 x 23 x 4 = 276; at most 22 x 4 = 88 on a correct install (was 228 / 72)

The other value lists (actor, monitor stop reasons, monitor kinds, MonitorDecision) are unchanged at c7189a8. audited-at and the README index row now point at c7189a8.

The two maintainer questions stay open as before: the type of kirocrew.crew_log.write.lost, and question 1 of #21288.

@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 9333b45.

The r126 count point is answered: the RFC is re-audited at c7189a8, and SESSION_CONTROL_OPS there has 19 verbs including handoff, matching the new op bound (20 values with other). The branch is rebased and mergeable, all checks are green, every AI lane on this head has no findings, and buluoray's change requests are dismissed. The r114 factual problem stays fixed.

What still blocks: this RFC asks for maintainer acceptance and defers two rulings to that maintainer:

Minor: the description's Manual verification still says claims were checked against afed43d2c0, while the RFC now says c7189a883e.

What clears it: a maintainer ruling on both questions, recorded in the RFC or on this PR.

— crew-pr-reviewer (r129)

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto main f2ce16f (still 2 commits). The README conflict was resolved by keeping main's version and re-adding only this PR's index row and history line.

One RFC change, from a re-audit at f2ce16f: main added a custom fold, so FOLD_NAMES is now 23 names. The fold list in the value-list section now includes custom, and the crew_log.fold.apply bound in 6.7 is 3 x 24 x 4 = 288 (at most 23 x 4 = 92 on a correct install). SESSION_CONTROL_OPS (19) and the agent_kind set (18) are unchanged. The audit sha in the front matter, the status line and the README row moved to f2ce16f.

@iamwhatever

Copy link
Copy Markdown
Contributor

Hold at 6c9f19c.

The RFC content stays sound: the f2ce16f re-audit adds the custom fold and moves the fold.apply bound to 288, the r114 factual problem stays fixed, and all checks are green.

What blocks:

Non-blocking: the Opus notes on the 6.2 source wording and the missing other kind values, and the description's audit sha, are small accuracy fixes worth doing in the rebase.

What clears it: a rebase onto main, plus a maintainer ruling on both questions recorded in the RFC or on this PR.

— crew-pr-reviewer (r133)

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto main (76e470d); new head 445d860, still 2 commits. The only conflict was docs/request-for-change/README.md: kept main's text and re-added only this RFC's history sentence and index row.

RFC changes, folded into the second commit:

  • 6.2: loops.started and loops.stopped now name their real source, the one commit point in autonudge_service/store.py that compares active loops before and after each write. A resume counts as a start.
  • 6.5: savepoint.write and bus.subscriber_error kind lists now include other, as crew_log_health.py ships.
  • Re-audited at 76e470d: SESSION_CONTROL_OPS (19), FOLD_NAMES (23) and agent_kind (18) are unchanged, so no count or bound moved. Audit sha updated in the RFC, the README row and the PR description.

The two maintainer questions (the write.lost type and #21288 question 1) stay open.

@iamwhatever

Copy link
Copy Markdown
Contributor

Rebased onto current main; new head b59a567, still 2 commits. The only conflict was docs/request-for-change/README.md: kept main's text and re-added only this RFC's history sentence and index row. docs/request-for-change/rfc-crew-usage-metrics.md is byte-identical to 445d860. docs_lint passes. This RFC still waits on maintainer acceptance and the two deferred rulings (write.lost type, #21288 question 1).

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (664feb4); new head b2206f8, still 2 commits. The only conflict was docs/request-for-change/README.md: kept main's text and re-added only this RFC's history sentence and index row. docs/request-for-change/rfc-crew-usage-metrics.md is byte-identical to 9d5746e.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Opus 5.5 review finding (value lists and series bounds, rfc-crew-usage-metrics.md): fixed in c0164ff, checked against current main.

  • 6.6 actor list: added agent (ACTOR_VALUES in crew_log/entry_types_lifecycle.py has 9 values including agent), so 9 today and 11 after 6.4.
  • 6.6 legacy stop reasons: added claim_unsaved (CLAIM_UNSAVED_REASON is in _PASSED_THROUGH_REASONS in metrics/monitor_loops.py), so 29 reported values plus other, 30 in all.
  • 6.2 work.reports status: added reply (WORK_WORKER_STATUSES in work_vocab.py includes reply; REPORT_STATUSES adds failed).
  • Recomputed bounds: section 5 and 6.7 crew.turn.started 9 x 18 = 162 (11 x 18 = 198 after 6.4); 6.7 autonudge.loops.stopped 3 x 30 x 4 = 360.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

@iamwhatever rebased onto current main (f4369b0); new head 1fb3e92, still 2 commits, docs only. The only conflict was the long row-notes paragraph in docs/request-for-change/README.md; I kept main's text and our sentence.

Re your 2026-10-20 change request, re-verified against current main:

  • Status: the RFC header and the index row say partial, not "nothing built". Shipped on main: kirocrew.crew.session_control.calls (6.1), kirocrew.work.created and the other work ledger metrics (6.3), kirocrew.crew_log.savepoint.write plus the rest of the 6.5 batches, and the 6.2 autonudge and monitor metrics. Both audit stamps now read f4369b02a3.
  • Append instruments: append.bytes and append.batch (and fold.lag) are dropped, not deferred, with the reason from crew_log_health.py (the only source sits on the crew log write path, which goal 3 keeps untouched). Section 6.5 marks them "Not built".
  • Still open: the 6.4 actor enum has no webhook or heartbeat on main (ACTOR_VALUES in entry_types_lifecycle.py).

The Design punchline (#21288 question 1) is left as written; it needs a maintainer ruling together with #21288. Could you re-review when you have a moment?

@KiroCrewCaptain

KiroCrewCaptain commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 7% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 439 lines, more than the 400 it may approve on its own.

This PR only changes docs. It adds an RFC with status partial, plus its index row and an audit sentence in the README. I checked the RFC's code claims against repo/ at head and they hold. FOLD_NAMES has 24 names (6 + 4 + 12 + 1 + 1, including custom and objects), so the stated bound of 3 x 25 x 4 is right. SESSION_CONTROL_OPS has the 19 listed verbs. ACTOR_VALUES has the 9 listed values, with no webhook or heartbeat, which matches the stated open item. METRIC_OUTCOMES exists in webhooks.py. MAX_MONITOR_STOP_REASON_CHARS is 500. outbound_consented in metrics/consent_pins.py works as the RFC describes: export needs an explicit opt-in, and anything unreadable counts as no consent. The RFC adds no outbound path and moves no trust boundary. The front matter matches the format of the sibling RFCs. The README row and audit sentence agree with the document's front matter. No code, config or behaviour changes, so there is nothing to regress and no tests are needed.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit d57b8eb745 · 439 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

@iamwhatever rebased onto current main; new head 11929c0, still 2 commits, docs only. The only conflict was the row-notes paragraph in docs/request-for-change/README.md (kept main text and our sentence). No content change since the last reply.

Propose counters and gauges for conductor use, session-tree depth and
width, session control, monitor loops, the work ledger, event sources and
crew log health. Counters and gauges only, closed-enum attributes, no ids.
Refs #21270.
…lation, egress

- List the agent_kind, actor, stop reason (raw text to closed value),
  monitor kind and fold enums, copied from the wave-2 code.
- Restate cardinality with the 16-value agent_kind and add a bounds table.
- Add rule 8: a failure while recording at a commit point never changes
  the outcome of the measured call.
- Drop the export-endpoint dependency; #21288 sections 8 and 9 govern
  egress and this RFC adds no outbound path. Note wave 2 relies on #21288
  question 1 and pulls in its S4 phase.
- Depth is already a counter; restate why ledger counters use the commit
  point rather than a new counting fold.
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

GPT 6.1 finding (rfc-crew-usage-metrics.md:35 and :408, telemetry.enabled "off by default"): fixed in d57b8eb.

Checked against main (TelemetryConfig in config/sections_telemetry.py, outbound_consented in metrics/consent_pins.py): local recording is on by default (a local JSONL sink, no network egress), and nothing leaves the machine unless a collector is configured (otlp_endpoint or otlp_endpoints) and the user has opted in to recording themselves (telemetry.enabled: true written in a config file, or KIROCREW_TELEMETRY truthy). Both sites now say that, and so does the same claim in the Non-goals egress bullet (it said "opt-in through telemetry.enabled"). No other off-by-default or opt-in claim about recording is left in the RFC. Docs only; head is d57b8eb, still 2 commits.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Closing: this design is outdated and no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants