Skip to content

docs(prepare-pr): say the --reviewers pin no longer hides a whole-design CONCERNS - #22198

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:docs/prepare-pr-pin-concerns-docs
Oct 20, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
unstablebrainiac:docs/prepare-pr-pin-concerns-docs

Conversation

@unstablebrainiac

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The prepare-pr skill tells an agent that an unanswered whole-design CONCERNS stops the loop through pr_status.py's exit code under the --reviewers pin, now that #21808 made it do so.

Two passages still describe the bug #21808 fixed. SKILL.md says that under the --reviewers pin, a CONCERNS in the Whole-design punchlines block is the stop. The rationale section "Why a pinned reviewer fleet hides a whole-design CONCERNS" says the pin keeps those lanes' CONCERNS out of the exit code. Since #21808, pr_status.py exits 20 on an unanswered Design, First Principles or UX CONCERNS whatever the pin says.

Why it matters

An agent reading the skill is told to watch printed text for a stop the exit code now gives. The rationale tells a reader the opposite of what the code does, so the next person to touch the check starts from a false premise.

Not a goal

What changed (motivation → approach → change)

  • SKILL.md: the whole-design bullet now says the --reviewers pin does not hide the exit-20 stop, instead of naming the punchline block as the stop.
  • references/rationale.md: the section is renamed "Why a whole-design CONCERNS still stops a pinned reviewer fleet". It says why the pin leaves the marker verdicts without those lanes, and that the CONCERNS check reads them from their own comments with design_lane_verdicts(), which ignores the pin. The punchline block still changes no exit code.

Backwards compatibility

Compatible: documentation only; no code, key or exit code changes.

Removes nothing: the removed sentences described behaviour #21808 already removed from pr_status.py.

Tests

N/A, documentation only. The behaviour the text now describes is pinned by #21808's test in test/test_prepare_pr_status_concerns.py. The tests that read the prepare-pr skill files pass.

Manual verification

Read pr_status.py on main after #21808: the unanswered-CONCERNS check merges design_lane_verdicts(bot_comments, head_sha, marker_bindings) into the pinned verdicts before unanswered_concern_lanes(). A grep of main finds no other passage that describes the old behaviour.

Related Issues

Part of #19652

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@unstablebrainiac
unstablebrainiac force-pushed the docs/prepare-pr-pin-concerns-docs branch from fdee9a8 to c54cccc Compare October 19, 2026 17:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision c54cccccf6002a7ca45ef01ea87423a7ab44d3ff touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of c54cccccf6002a7ca45ef01ea87423a7ab44d3ff via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that the rationale's "Until #21808…" history sentence is wanted. Everything else matches what pr_status.py:2400-2407 does on base.

What this change ships

Inventory (2 items) — 2 justified

Intent: correct two prepare-pr skill passages so an agent learns the exit code, not printed text, stops on an unanswered whole-design CONCERNS under the --reviewers pin. FIX.

  1. SKILL.md no longer calls the Whole-design punchlines block the stop under the pin. It now says the pin does not hide the exit-20 stop — justified
  2. The rationale.md section is renamed and rewritten: design_lane_verdicts() ignores the pin, and the punchline block changes no exit code — justified

[FIRST-PRINCIPLES-REVIEWED] c54cccc

Description read

[DESCRIPTION-READ] 65eaefecd2d31a9f920d0fff1747e2c095bb4515f8c7f823a73696e74e53c900

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of c54cccccf6002a7ca45ef01ea87423a7ab44d3ff via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] c54cccc

Description read

[DESCRIPTION-READ] b6dad86a1e66bb6486bb6e8585e0eee8087a6311ae38a031ebf162cbaf97b428

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed c54cccccf6002a7ca45ef01ea87423a7ab44d3ff via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c54cccc

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed c54cccccf6002a7ca45ef01ea87423a7ab44d3ff via the fork AI-review pipeline; updated in place on each push.

Review details

The doc matches the code.

No findings.

[OPUS-REVIEWED] c54cccc

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 19, 2026

@mbriones98 mbriones98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks green and readiness passed at c54cccc; no behavior change.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at c54cccc.

The two corrected passages now match the code: pr_status.py L2397-L2409 merges design_lane_verdicts() into the pinned verdicts before unanswered_concern_lanes(), so an unanswered whole-design CONCERNS exits 20 under --reviewers gpt,opus, while marker verdicts are still pin-filtered at L1415. On the First Principles punchline about the "Until #21808" sentence: it explains why the second read exists, and rationale.md already records history the same way at L314 (#15200), so I see no reason to drop it.

All AI lanes pass or were skipped, there is no change request, CI is green (83 pass, 17 skipped) and the branch merges cleanly into current main.

— crew-pr-reviewer (r113)

@iamwhatever
iamwhatever merged commit 717bb98 into kirodotdev:main Oct 20, 2026
101 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants