Skip to content

refactor(service): split linux.py into four owner modules - #22273

Merged
chenmingwei23 merged 1 commit into
mainfrom
refactor/linecap-s76-linux
Oct 20, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
refactor/linecap-s76-linux

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring src/kiro_crew/service/linux.py (2,232 lines) under the 2,000-line cap without changing how the Linux service installs, reports, restarts or uninstalls, so new work on the unit, systemd access, install and uninstall lands in modules sized for it.

service/linux.py is past the repository's 2,000-line cap for hand-written files and is listed in .github/file-line-cap-baseline.txt (row 2,232). One file holds what the unit says and whom it runs as, the privilege and systemctl plumbing with each scope's unit state, the install path with its SELinux refusal and AppArmor steps, the uninstall ownership decision with its teardown arms, and the verbs that read and restart a running unit.

Why it matters

A file over the cap makes every feature PR that touches it grow a baselined file, which the line-cap guard reports and the campaign must later undo. The service module is changed often (install, doctor, restart and SELinux work all land here), so it keeps collecting code.

Not a goal

  • No behaviour change beyond the one decode line listed under Behaviour changes: every other moved definition keeps its AST.
  • No change to which names kiro_crew.service.linux offers, or to how a test patches them.
  • No change to the service tests beyond re-pointing three source pins at the new files.
  • No change to macOS (service/macos.py), the controller or the AppArmor and SELinux modules.

What changed (motivation → approach → change)

linux.py keeps the verbs that read and drive an installed unit and becomes a kiro_crew._facade_mirror facade over four sibling owners. The suites patch names that every layer reads (_systemctl, _sudo_run, UNIT_PATH, _current_user, kirocrew_bin, ...), so a plain re-export would leave moved readers unpatched; the mirror sends a write through the facade to every owner binding the name, which keeps each moved body as it was.

File Lines Owns
service/linux.py 2,232 → 592 the module docstring; user_unit_installed, user_unit_active, user_unit_path, is_active, is_up, alias_holder, stop, restart with its settle window, status; the mirror glue
service/linux_unit.py 396 the unit and overrides-file paths, the service account (user, group, uid, home, linger), render_unit
service/linux_systemctl.py 408 privilege (_privilege_prefix, _sudo_run, ServiceInstallError), _systemctl in either scope, one scope's unit state (_UnitState, _unit_state, _stale_unit_line)
service/linux_install.py 506 install: the root-owned writes, the overrides seed, the SELinux refusal and start-failure hint, the AppArmor profile install and removal
service/linux_uninstall.py 592 uninstall: the ownership decision _owned_unit, the per-scope teardown arms, UninstallReport

Each owner imports only the owners above it in the table, never the facade. The owners log as kiro_crew.service.linux, and ServiceInstallError keeps kiro_crew.service.linux as its __module__. cli.md's Service Management section gains the owner map.

Behaviour changes

  • _systemctl's system-scope branch (plain systemctl show|status, no sudo) decodes with **UTF8_TEXT instead of text=True: the same mapping its user-scope branch already uses, since systemd writes UTF-8. It differs from the base only on a host whose locale is not UTF-8, and a malformed byte becomes U+FFFD instead of raising. This is the one non-move edit to a moved body (ruled for this split under the subprocess-encoding ratchet).
  • The pruned 3 src/kiro_crew/service/linux.py row of .github/subprocess-encoding-baseline.txt is replaced by the two inline locale markers on _sudo_run and _write_unit_via_sudo (whose children, sudo and coreutils, print in the locale, as the base decodes them) plus the **UTF8_TEXT fix in _systemctl.

Backwards compatibility

Compatible: every public name kiro_crew.service.linux bound before the split still resolves on it and is the same object (test/campaign_facade_inventories/kiro_crew.service.linux.json, 49 names, 39 re-bound by import), every module-level name it bound, private helpers included, still resolves (test_linux_facade.py::test_every_base_module_name_resolves_through_the_facade), and a patch through the facade reaches every owner that reads the name (test_linux_facade.py::test_a_patch_through_the_facade_reaches_every_family_reader, plus the repo-wide test_facade_mirror_guards.py).

The take-away check flags the 12 public defs that moved to owners; each is still bound on the facade:

Reader: src/kiro_crew/service/common.py:user_unit_file_path -- release -- restart_command_hint() reads linux.user_unit_file_path() through the facade, which serves linux_unit's function (test_service_controller.py)
Reader: src/kiro_crew/service/controller.py:linger_warning_for_service_account -- release -- install_service() calls linux.linger_warning_for_service_account(), the facade binding of linux_unit's function (test_service_controller.py)
Reader: src/kiro_crew/service/linux_install.py:render_unit -- release -- install() and _user_scope_remedy() import it from linux_unit; the facade serves the same object (test_service.py)
Reader: src/kiro_crew/service/linux_install.py:selinux_refusal -- release -- install() calls it in the same owner; the facade serves it (test_service_selinux.py)
Reader: src/kiro_crew/service/linux_install.py:selinux_start_failure_hint -- release -- install() calls it in the same owner; the facade serves it (test_service_selinux.py)
Reader: src/kiro_crew/service/controller.py:install -- release -- install_service() calls linux.install(), the facade binding of linux_install.install (test_service_controller.py)
Reader: src/kiro_crew/service/linux_install.py:install_apparmor_profile -- release -- install() calls it in the same owner; the facade serves it (test_service_apparmor.py)
Reader: src/kiro_crew/service/controller.py:remove_apparmor_profile -- release -- uninstall_service() calls linux.remove_apparmor_profile(), the facade binding of linux_install's function (test_service_apparmor.py)
Reader: src/kiro_crew/service/controller.py:install_launcher_profile -- release -- controller.install_launcher_profile() calls linux.install_launcher_profile(), the facade binding (test_service_controller.py)
Reader: src/kiro_crew/service/controller.py:remove_launcher_profile -- release -- controller.remove_launcher_profile() calls linux.remove_launcher_profile(), the facade binding (kiro_crew.service.linux.json rebound check)
Reader: src/kiro_crew/service/controller.py:unit_file_carries_managed_marker -- release -- installed_service_has_managed_marker() (read by kirocrew doctor) calls linux.unit_file_carries_managed_marker(), the facade binding (test_service.py)
Reader: src/kiro_crew/service/controller.py:uninstall -- release -- uninstall_service() calls linux.uninstall(), the facade binding of linux_uninstall.uninstall (test_service_controller.py)

Move audit

move_audit.py --base c3f2b27de7 --head 0291d31396 (the merge-base and this head):

src/kiro_crew/service/linux.py: 2232 -> 592 lines; moved 98.45% (python-ast)
   changed: _systemctl [FunctionDef] 30 lines
   changed: Assign [Assign] 1 lines

Every other moved unit's AST is identical to the base. Non-move edits:

Edit Where Why
text=True → **UTF8_TEXT in the system-scope subprocess.run _systemctl (linux_systemctl.py) see Behaviour changes; the moved call leaves the subprocess-encoding baseline's linux.py row, and systemd writes UTF-8
logging.getLogger(__name__) → logging.getLogger("kiro_crew.service.linux") log (linux_install.py) the moved logger keeps the facade's name (L25)
inline # subprocess-encoding: locale -- ... on the text=True, line _sudo_run (linux_systemctl.py), _write_unit_via_sudo (linux_install.py) sudo and coreutils print localized diagnostics in the locale, which is how the base decodes them; comment only, AST unchanged
added ServiceInstallError.__module__ = "kiro_crew.service.linux" linux_systemctl.py an exception's dotted name is what a traceback shows
black reformat of five spots _systemctl, _stale_unit_line, selinux_start_failure_hint, _teardown_scope (×2) the new files must be black-clean; AST unchanged

Glue, not moves: each owner's docstring and import header; the facade's header imports for the code it keeps, the owner-map comment, _OWNERS and its import loop, _facade_mirror.install(..., excluded=()), the class swap, the derived __all__ and the two TYPE_CHECKING manifests. The split is reproducible from any base by the name-keyed recipe in the campaign's scratch/S76/recipe/.

L36 parity (default diff vs --minimal, identical + lines): every changed file equal; linux.py 138/1778 both. Diff size: 216,804 bytes.

Path union

This head (0291d31396) is the reviewed commit (5768fdb753, plus one docstring fold in linux_systemctl.py) rebased onto c3f2b27de7 with no conflict; its -U0 patch and path set equal the folded commit's. git diff --name-only c3f2b27de7 0291d31396 names 16 paths; there are no staged, unstaged or untracked paths.

  • The split target: src/kiro_crew/service/linux.py.
  • Four new owners: src/kiro_crew/service/linux_{unit,systemctl,install,uninstall}.py.
  • One new test: test/test_linux_facade.py; the facade inventory test/campaign_facade_inventories/kiro_crew.service.linux.json.
  • This module's own rows in .github/file-line-cap-baseline.txt, .github/black-baseline.txt and .github/subprocess-encoding-baseline.txt.
  • Three source pins re-pointed at the facade plus its owners: test/test_spawn_audit.py (BENIGN_SPAWNS rows), test/test_service.py, test/test_service_linux_unit_ownership.py.
  • The owner map in docs/system-specs/modules/cli.md, and citation edits in src/kiro_crew/cli.py, test/test_sandbox_slice_encoding.py, test/test_service.py.

Tests

  • test/test_linux_facade.py (new, 22 tests): the facade serves a mirror over exactly the linux_* modules beside it (excluded == (), nothing divergent); every module-level name the base file bound resolves through it, to each holder's object; a patch through the facade reaches every family module reading 11 shared names (UNIT_PATH, ENV_FILE_PATH, _current_user, _home_for_user, _privilege_prefix, _require_privilege, _sudo_run, _systemctl, _unit_state, kirocrew_bin, time) and its undo restores each one, with a non-vacuity check that those names are read by more than one member; each owner imports only the owners before it, and nothing outside the family imports an owner (each with a planted self-test); the owners log as kiro_crew.service.linux; every served non-owner name is in a TYPE_CHECKING group (with a dropped-name self-test); ServiceInstallError.__module__ is the facade.
  • Re-pointed source pins (assertions unchanged): test_every_text_write_in_the_linux_service_names_its_encoding and test_every_teardown_arm_rests_on_the_one_ownership_decision read the facade joined with every module in _OWNERS; BENIGN_SPAWNS rows follow _current_group, _linger_enabled, _sudo_run, _systemctl and _write_unit_via_sudo to their owners.
  • Mutation proofs (each turns its test red with exit 1; the file is restored after): drop encoding= from _install_file_via_sudo's os.fdopen; annotate _finish_scope(owned: object); revert one BENIGN_SPAWNS row; plant an owner import in service/common.py; plant an upward import in linux_unit.py; log under __name__; drop the __module__ line; drop kirocrew_bin from the manifest; remove the facade's class swap.
  • Determinism: test_linux_facade.py 5 runs at -n0 and one at -n 3, 22 passed each time; no sleeps, clocks, ports or ordering assertions.
  • Local gate floor: local-gate --dry-run selects 1,226 backend files (1,031 of them from the stem cli, which the one-line comment edit in cli.py adds) and 481 frontend files (no website/ change), so it was not run whole. Instead: every test naming the family (27 files) plus every src tree-scan guard (299) and the ratchets, 323 files at -n 3: 19,062 passed, 81 skipped, 5 xfailed, 2 failed. Both failures are main's (test_name_grant_facade.py::test_the_patch_scan_reads_every_spelling_and_nothing_else[helper-binding] and test_backend_cards_advertised.py::test_no_new_runtime_site_gates_a_field_backed_line_on_a_set, both fixed on main by test: clear main's four reds left by #21753, #21598 and later backend edits #22178, which this head includes; on this head they pass, 6 of 6). That run's tree differs from this head only in two comment lines of gateway_lock.py (since restored to the base) and one docstring line of test_linux_facade.py; both files were re-run on this head (107 passed). The service suites alone: 809 passed.
  • mypy src/kiro_crew: no issues in 3,307 files. isort --check-only src/kiro_crew test conftest.py xdist_budget.py and flake8 on the changed files: clean. Comment-history, brand, black, subprocess-encoding, agent-sdk boundary, sync-io, feature-map and line-cap gates and docs_lint.py: clean. The harness-parity gate failed on the gated base for the same reason (ACP_BACKENDS_MEMBER_CAPABILITIES [claude], test: clear main's four reds left by #21753, #21598 and later backend edits #22178) and passes on this head. Semgrep 1.78 with the CI configs and --baseline-commit 2cf3d0d69f (the gated base) over the 11 changed Python files: 0 findings, no parse errors. Installed-mode smoke: a wheel built from a git archive export of this head ships all five service/linux*.py modules, and each imports from the unpacked wheel under the isolated env -i wrapper.
  • Per-file line coverage of the family (the service suites plus test_cli_doctor.py and test_cli_server_more_coverage.py): linux.py 99%, linux_unit 96%, linux_systemctl 99%, linux_install 88%, linux_uninstall 97% (floor 80%).

Manual verification

N/A — a move of definitions behind the same import path; the service suites that drive install, status, restart and uninstall through mocked systemctl and sudo run unchanged against the facade and pass (see Tests).

Citation edits (L29)

  • src/kiro_crew/cli.py:795 (comment) (service/linux.py) → (service/linux_unit.py): the unit's RestartPreventExitStatus= is rendered by render_unit.
  • test/test_spawn_audit.py:1717 (comment) service/linux.py::_current_group → service/linux_unit.py::_current_group, beside the re-keyed BENIGN_SPAWNS rows.
  • test/test_sandbox_slice_encoding.py:7 (docstring) as service/linux.py does → as service/linux_unit.py does: the UTF-8 errors="replace" spawns are _current_group and _linger_enabled.
  • test/test_service.py:850 (docstring) (linux.py:448) → (_env_file_is_untouched_seed): a line cite, already stale at the base, becomes the symbol.
  • docs/system-specs/modules/cli.md:1943 "the module docstring in service/linux.py sits next to the call sites, names the current set" → "names the current set for the whole family"; the owner map is added under ## Service Management.

Import-path spellings (kiro_crew.service.linux.<name>, linux.<name>, :func:kiro_crew.service.linux.install``) are unchanged: they still name where the code is reached. The moved docstrings that say "this module" or "the module docstring" read at family level, which each owner's docstring states.

References not edited (cost)

  • src/kiro_crew/gateway_lock.py:128 cites service/linux.py and :161 service/linux as the module that feeds LIVE_HOLDER_EXIT_CODE into RestartPreventExitStatus; that is now render_unit in service/linux_unit.py. The file sits in macos-on-demand.yml's darwin path filter, so a comment edit there would start the 4-shard macOS suite on every push of this PR; left for the batched docs PR.

CI path references

None: no workflow path filter or explicit file list names service/linux.py, and no sensitive_change_review.py glob matches service/linux*.

Portability

Cross-Platform Portability flags four moved lines; each is POSIX-only code moved byte-identically, and the systemd backend runs only on Linux:

  • src/kiro_crew/service/linux_unit.py: UNIT_PATH = Path(f"/etc/systemd/system/{SERVICE_NAME}.service") and ENV_DIR = Path("/etc/kirocrew") (base linux.py:103, :135).
  • src/kiro_crew/service/linux_install.py: os.getuid(), in install_apparmor_profile and in install_launcher_profile (base linux.py:1270, :1297).

Notes for reviewers

  • Facade mechanism: kiro_crew._facade_mirror (L28), not a plain re-export, because the suites patch names through the facade that every layer reads (31 distinct names; _systemctl alone is read by linux_systemctl, linux_install, linux_uninstall and the facade). The facade keeps the verbs on top of the layering, so no owner needs anything the facade defines.
  • Logger name (L25): the one moved log binds logging.getLogger("kiro_crew.service.linux"), the base logger object; no test or filter reads the name, the records simply keep it.
  • ServiceInstallError keeps kiro_crew.service.linux as its __module__ (an exception's dotted name shows in tracebacks). The moved dataclasses (_UnitState, UninstallReport, _ScopeTeardown, OwnedUnit) report their owner module: none is an exception or enum, nothing reads their __module__, nothing pickles them, and their reprs name the class only.
  • Four sibling modules rather than a linux_parts/ package, the same shape as acp/liveness_*.py; the compound stems keep the related-test selection narrow.
  • __all__ is derived (the mirror's shape): it equals the base's star-import set plus TYPE_CHECKING; nothing star-imports this module.

Related Issues

Part of #20192
Follow-up: #21320 (the gateway_lock.py comment cites listed under References not edited)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

service/linux.py (2,232 lines) was over the 2,000-line cap. It keeps
the verbs that read and drive an installed unit (status, stop, restart
and its settle window, is_active, is_up, alias_holder and the
user-scope queries) and becomes a kiro_crew._facade_mirror facade over
four sibling owners:

- linux_unit: the unit and overrides paths, the service account and
  render_unit
- linux_systemctl: privilege, systemctl in either scope and one
  scope's unit state
- linux_install: install, the SELinux refusal and the AppArmor
  profile steps
- linux_uninstall: the ownership decision and the per-scope teardown

The suites patch names every layer reads, so the mirror sends a write
through the facade to every owner binding the name, and moved bodies
keep their AST. The one exception is _systemctl's system-scope branch,
which decodes with **UTF8_TEXT like its user-scope branch; _sudo_run
and _write_unit_via_sudo carry the locale marker instead. The owners
log as kiro_crew.service.linux and ServiceInstallError keeps that
module. test_linux_facade.py pins the contract, three source pins read
the facade with its owners, and cli.md gains the owner map.

Part of #20192
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 19, 2026 19:38
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 19, 2026
@bolichen97 bolichen97 added the posix-only-approved Cross-Platform Portability findings reviewed and accepted as intentionally POSIX-only label Oct 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0291d31396407295b8a53a80e68e5dbaef4c868a touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0291d31396407295b8a53a80e68e5dbaef4c868a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check one thing before merge: the system-scope _systemctl decode change (text=True → **UTF8_TEXT) is the only behaviour edit, so confirm it on a host whose locale is not UTF-8.

[DESIGN-REVIEWED] 0291d31

Description read

[DESCRIPTION-READ] ca105201deac84927e7358eb87a3542d23059d19d9d6a95e37b510b56b24e39e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 0291d31396407295b8a53a80e68e5dbaef4c868a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check the one behaviour edit: system-scope _systemctl now decodes as UTF-8 with replacement, not the locale. It differs only on non-UTF-8 hosts.

What this change ships

Inventory (7 items) — 7 justified

Intent: get service/linux.py under the 2,000-line cap without changing how the Linux service is installed, reported, restarted or uninstalled. This is a FIX that clears a cap violation the repo already enforces (AGENTS.md "No hand-written file over 2,000 lines"). It is not an ADDITION.

  1. linux.py (2,232 lines) is split into four owner modules (linux_unit, linux_systemctl, linux_install, linux_uninstall) and drops off the line-cap baseline. — justified
  2. kiro_crew.service.linux keeps every name it bound before, served through the existing kiro_crew._facade_mirror mechanism, which 200 src/ files already use. It does not add a new mechanism. — justified
  3. On a non-UTF-8 locale, system-scope systemctl show|status output decodes as UTF-8 with replacement instead of raising. The subprocess-encoding gate required each moved call to be either pinned or marked, so one of the two was needed. — justified
  4. The linux.py rows in the subprocess-encoding and black baselines are replaced by two inline locale markers. — justified
  5. cli.md Service Management gets the owner map. AGENTS.md requires the spec to be updated in the same commit. — justified
  6. Three source-reading tests, the spawn-audit allow-list and two comments now point at the new files. — justified
  7. A new facade inventory JSON and test_linux_facade.py pin that every name resolves and patches still reach every owner. — justified

[FIRST-PRINCIPLES-REVIEWED] 0291d31

Description read

[DESCRIPTION-READ] f214603254f224a402f75e6e0d365284764b53a06f11d2db51f590d578e4d2b1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0291d31396407295b8a53a80e68e5dbaef4c868a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0291d31

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0291d31396407295b8a53a80e68e5dbaef4c868a: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0291d31396407295b8a53a80e68e5dbaef4c868a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0291d31

Verdict parsed from the review's SHA-scoped output markers for commit 0291d31396407295b8a53a80e68e5dbaef4c868a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0291d31396407295b8a53a80e68e5dbaef4c868a: <one-sentence reason>

@bolichen97

bolichen97 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Punchline: confirm the system-scope _systemctl decode (text=True → UTF8_TEXT) on a host whose locale is not UTF-8

Confirmed. A stub systemctl printing UTF-8 (Description=Kiro Crew — gateway), read once with the base call (text=True) and once with this head's _systemctl("show", sudo=False), under three locales:
C.UTF-8: both decode Kiro Crew — gateway; identical.
en_US.iso88591: base yields mojibake Kiro Crew \xe2\x80\x94 gateway; this head decodes Kiro Crew — gateway.
C with UTF-8 mode and locale coercion off (ASCII): base raises UnicodeDecodeError; this head decodes it.
So the edit changes nothing on a UTF-8 host and reads systemd's output correctly on the others, since systemd writes UTF-8 whatever the locale.

@bolichen97

bolichen97 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor Author
  • Punchline: confirm the system-scope _systemctl decode (text=True → UTF8_TEXT) on a host whose locale is not UTF-8

Confirmed. A stub systemctl printing UTF-8 (Description=Kiro Crew — gateway), read once with the base call (text=True) and once with this head's _systemctl("show", sudo=False), under three locales:
C.UTF-8: both decode Kiro Crew — gateway; identical.
en_US.iso88591: base yields mojibake Kiro Crew \xe2\x80\x94 gateway; this head decodes Kiro Crew — gateway.
C with UTF-8 mode and locale coercion off (ASCII): base raises UnicodeDecodeError; this head decodes it.
So the edit changes nothing on a UTF-8 host and reads systemd's output correctly on the others, since systemd writes UTF-8 whatever the locale.

@bolichen97
bolichen97 enabled auto-merge (squash) October 19, 2026 20:05
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@chenmingwei23
chenmingwei23 merged commit 15f11ce into main Oct 20, 2026
105 of 114 checks passed
@chenmingwei23
chenmingwei23 deleted the refactor/linecap-s76-linux branch October 20, 2026 00:19
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

posix-only-approved Cross-Platform Portability findings reviewed and accepted as intentionally POSIX-only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants