Repository navigation
fix(members): say which crewmates the roster hides - #22296
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that What this change shipsInventory (7 items) — 7 justifiedIntent: a user whose crew has a crewmate they never chatted with can tell it exists and how to reach it, instead of reading "2 crewmates" as the whole crew (#21852). This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 1a887a3 Description read[DESCRIPTION-READ] 69d95bdb4c070d748f7e891fbd9d7019c0322bc7a48d6f70feef947c83f81742 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The hidden-crewmates line says hidden crewmates "aren't counted above", but searching makes the count jump to "3 crewmates" while one row shows, so the reader can't trust either. Watch
Suggestions
[UX-REVIEWED] 1a887a3 Description read[DESCRIPTION-READ] 2226c9762a43fe9f22862450c096afb7114e47ffa76b95c5ac9f5b59d7e9269d That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 1a887a3 Description read[DESCRIPTION-READ] 33516f709534e55d8fd13c040dd8ea9a87207ff8c815933a8d529550a03f96a4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
e528775 to
d03567b
Compare
|
Screenshots for head d03567b (fixture render, roster column at rest): one hidden crewmate named, and four hidden crewmates counted. The same frames are in the description. |
d03567b to
b3cfd4e
Compare
|
Review findings on b3cfd4e, by finding. The fixes are on cb2c828. Design Review, wrong rows named: fixed in cb2c828. Hidden crewmates the user made (origin Mine, or created on the dashboard) are named before package and app rows, then roster order. A new case covers a user-made crewmate that sorts last behind four package rows; it fails on b3cfd4e. The First Principles, UX Review:
|
affaafd to
cb2c828
Compare
|
Review notes on cb2c828, by finding. First Principles, stale Design Review, UX Review:
|
|
HOLD (AI review concern not fully answered) at cb2c828. The code looks correct. What blocks approval is the UX Review CONCERNS on this head:
What clears it: adopt the copy changes, or reply to each one with why the current wording is better. — crew-pr-reviewer (r113) |
cb2c828 to
426e1be
Compare
The Crewmates roster lists only crewmates whose thread holds a message, starred ones and Mate, and its count covers the listed rows only. A crew of three read as "2 crewmates" and the third turned up only when a search matched it. The list now ends with one muted line naming the hidden crewmates by their row label (the first three, then a count of the rest) and saying the search finds them. The rule and the count are unchanged.
426e1be to
1a887a3
Compare
|
Reply to the HOLD at cb2c828 and the UX rounds since, on 1a887a3. 1. The count and the line disagree: adopted. The count stays: listed rows plus any row a search reaches, as before. Both forms of the line now say the hidden crewmates aren't counted above, in all 12 locales and en-XA:
2. "and N more": the copy option "search by name to find the rest" went in on 426e1be. The UX round on that head found it sends the reader to a search they cannot run for the crewmates the line does not name. So the counted form now asks for no action and only states that the rest exist and aren't counted. The named form keeps "Search to find it/them", because every name it gives can be searched. A control that lists the hidden rows would turn off the listing rule, which is a roster mode of its own and outside #21852. UX round on 1a887a3:
Tests: the three counted-form cases in |
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at 1a887a3.
The r113 HOLD is cleared. Your reply on this head answers each UX Review item: the line now says the hidden crewmates are not counted above in both forms, the counted form drops the search step for crewmates it cannot name, and the remaining suggestions are declined with reasons that hold. The line is drawn only with no search typed and no filter narrowing, so the count during a search is main's existing behavior, not something this line contradicts.
The First Principles check also holds: hiddenCount and hiddenNames are derived from the same rows, because orderedMembers is a reordering of members (useMembersPageRoster.ts L250-L278). The tests assert whole lines, CI is green, and no sensitive files are touched.
— crew-pr-reviewer (r115)




Problem / Motivation
Goal: The Crewmates roster says how many crewmates it hides and how to reach them, so its count is not read as the whole crew.
The roster lists a crewmate unasked only when its thread holds a message, it is starred, or it is Mate, and its count covers those rows only. In the nightly GUI user test a crew of three read as "2 crewmates". The third, created but never chatted with, turned up only after a search for its name matched it (#21852). #22142 reported the same friction in another scenario and was marked its duplicate.
Why it matters
A user who creates a crewmate and has not chatted with it yet cannot see it on the page, and nothing says it exists. The count reads as "your crew is these two", so the natural conclusion is that the crewmate was lost.
Not a goal
CrewmateSwitcher), which opens with its own search field.What changed (motivation → approach → change)
rosterPopulation(listed rows plus search hits) on purpose, and the only hidden-row notice (all_hidden_hint) is drawn when every row is hidden. With at least one listed row, nothing said that more existed.useMembersPageRosterSignalsderiveshiddenCount, the roster rows minus the shown population. It is non-zero only while no search is typed, no filter narrows the list, and at least one row is listed (the every-row-hidden case keeps its own line). It also deriveshiddenNames, the row labels (rowLabel, now exported fromrosterFilter) of up to three hidden crewmates (HIDDEN_NAMES_MAX): the ones the user made (origin Mine, or created on the dashboard) first, then roster order, so a crewmate just created is named rather than counted behind package and app rows.MembersPageRosterends the list with one muted item (member-hidden-hint). With up to three hidden crewmates it names them all, joined withfmtList: "Recipe Box is hidden because you haven't used it yet, and isn't counted above. Search to find it." Past three it names three and counts the rest: "Recipe Box, pkg-budget, pkg-notes and 1 more crewmate you haven't used yet are hidden and aren't counted above." The hidden set often includes dozens of package and app crewmates, so naming every one stops helping past a few, while the named ones still give the reader something to type. Both forms say the count above leaves the hidden crewmates out, so the count keeps its meaning (shown crewmates) and is not read as the whole crew. The counted form names no action: the crewmates it does not name give the reader nothing to search for, so it only states that they exist and are not counted.pages.membersPage.hidden_named_hintandpages.membersPage.hidden_more_hint, registered inpluralKeys.json, in all 12 locales with each language's own plural forms, plus the regenerateden-XA.crew-members.mddoc say the line exists.website/scripts/capture-members-hidden-hint.mjsrenders the frames below from fixtures (second commit);ROSTER=manyadds three hidden package rows for the count form.Backwards compatibility
Compatible: the change adds one list item and two catalog keys, and exports one existing helper; no API, stored shape or existing string changes.
Removes nothing: the listing rule, the count, the filters and every existing notice are unchanged; the diff only adds a line.
Tests
MembersPage.filters.test.tsx, in the "hides unlisted crewmates" block, seven new cases:member-hidden-hintelement). The other two pass on both and stand as guards.npx vitest run src/pages/members src/i18n(94 files, 1,860 tests, including catalog parity, plural forms and key references) pass; eslint on the touched files;npm run build(includestsc);npm run i18n:checkwithI18N_BASE_REF=origin/main;scripts/docs-lint.sh;test/test_crew_members_doc.pyandtest/test_crewmate_guidance_copies.py.Manual verification
Built the SPA from origin/main 3ad0780 and from this branch, and ran the harness against each with a stubbed API. Fixture roster: two crewmates with messages and one created but never chatted with (
ROSTER=manyadds three hidden package rows). What the DOM reads:ROSTER=manyScreenshots / video
Roster column, 1500×940 viewport at 2x, light theme; each frame is 528×1780 px.
Before (main), at rest:
After (this PR), at rest, one hidden crewmate named, and the line says the count above leaves it out:
After, at rest, four hidden crewmates: Recipe Box (made by the user) and two package rows named, one counted, none of them in the count above:
After, search "recipe" (byte-identical to main's frame):
Related Issues
Fixes #21852
Pattern harvest
Not generalizable: the gap is this roster's own copy for its own hide rule; there is no shared list component that a rule could target.
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license, per CONTRIBUTING.md.