Skip to content

test: split four oversized test files by behaviour under test - #22389

Merged
bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t57-test-slack-handler-composition-contract
Oct 21, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
refactor/linecap-t57-test-slack-handler-composition-contract

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Bring four test files of 2,629 to 2,808 lines each down to at most 1,300 lines, so none of them exceeds the 2,000-line cap, without changing a single test.

test/test_slack_handler_composition_contract.py (2,686 lines), test/test_spawn_audit.py (2,808), test/test_llm_pool.py (2,659) and test/test_slack_handler_coverage.py (2,629) are each over the 2,000-line cap the line-cap campaign enforces, and each is listed in .github/file-line-cap-baseline.txt. A file that large is hard to navigate and review, and every PR that adds a test (or, for the spawn audit, an allowlist row) pushes it further past the cap.

Why it matters

The maintainers' rule is that no hand-written file may exceed 2,000 lines. These four files break it today, and they keep growing: in the 30 days before this PR's base test_llm_pool.py gained 1,163 lines, test_slack_handler_coverage.py 406 and the spawn audit 334 (most of them BENIGN_SPAWNS rows), and the composition contract was created at 2,635 lines. Splitting by the behaviour under test now gives each file room to grow and makes each topic findable by file name.

Not a goal

  • Changing, renaming, fixing, de-flaking or re-parametrizing any test. Every test body moves with an identical AST.
  • Changing what the spawn audit allows: BENIGN_SPAWNS is the same set, row for row.
  • Changing production code. This PR touches only tests, test helpers and data modules, two baseline row files, one spec sentence and one test docstring cite.
  • Fixing the pre-existing flaky shapes and the semgrep finding that move with their tests (they are marked, not rewritten).
  • Splitting any file outside these four.

What changed (motivation → approach → change)

Each file splits along its own section banners and tests, grouped by the behaviour under test. Each original keeps its module docstring (each edited to name the new layout), its import block (pruned of what only the moved code used, plus one import of the new module) and its own code in BASE order, so its diff is deletions plus a few glue lines. Helpers and fixtures that two or more files of a family use move to a non-test *_helpers.py module (the composition contract's recording doubles also move to one, with a single reader, see below), and every file imports what it uses by name. A recipe tool did the move, reading each file at BASE, so it can be re-run after a rebase instead of hand-merged.

Origin (lines) Stays in the original New files (lines)
test_slack_handler_composition_contract.py (2686 → 1118) the surface and its composition: base names and owners, the globals sweep, owner import edges, the patch-reach corpus sweep, the placement guards _golden (1112): every golden scenario, its recorded digest and the golden tests; slack_handler_composition_contract_helpers.py (517): the recording doubles and the world fixture they run on
test_spawn_audit.py (2823 → 1161) the whole audit: census, routing, resource-limit and cgroup checks, first-party flags, asset imports, gateway spawn discipline; BENIGN_SPAWNS is now BENIGN_PACKAGE_SPAWNS | BENIGN_APP_SPAWNS spawn_audit_helpers.py (1116): the 189 rows keyed outside apps/builtins/; spawn_audit_app_spawns.py (580): the 133 apps/builtins/** rows
test_llm_pool.py (2659 → 1248) the pool's own mechanics and the AcpWorker (send, start, shutdown, backend selection, zero-tool confirmation) _effort (493): reasoning effort; _ccworker (484): the CCWorker subprocess worker; _lifecycle (449): fetch_url_content, idle-TTL reaping, conversation recycling; llm_pool_helpers.py (98)
test_slack_handler_coverage.py (2629 → 1273) slash and keyword commands with their helpers, agent-name resolution, thread-override hydration, !compact _inbound (275): privacy modifiers and linked-thread routing; _approvals (639): approval prompts from request to click; _delivery (248): status reactions, review drafts, safe updates; _pure_helpers (231); slack_handler_coverage_helpers.py (98)

BENIGN_SPAWNS was one 1,670-line literal, so no file holding it whole could meet this PR's 1,300-line goal; its rows split by the path they key on into two tables (a new row goes in the table for its path; the comment above the union says which). Every row moves byte-identical with its comment block, in BASE order, except one note placed with the row above it (listed under Non-move edits). The two llm_pool and coverage helpers modules are under 150 lines because they hold only what two or more files of their family share. The composition contract's helpers module has one reader on purpose: the doubles and scenarios together would be about 1,590 lines.

Rows and citations: the four line-cap rows are deleted; two test/wait_discipline_baseline.txt rows move to the files that now hold their sites (counts unchanged); docs/system-specs/modules/slack-gateway.md names test_slack_handler_composition_contract_golden.py as the file that replays the golden transcripts; test/test_s29_spawn_env_regression.py:229 cites test/test_llm_pool_ccworker.py (L29).

Backwards compatibility

Compatible: test-only change. Every collected test keeps its class, name, parameters, fixtures and markers (identical before and after). test_spawn_audit.BENIGN_SPAWNS is the same frozenset. No production module, import path, patch target or CLI changes.

Removes nothing: every test, fixture, helper and allowlist row still exists; tests and helpers keep an identical AST, the four fixtures world, owner, slack and sessions keep their names through @pytest.fixture(name=...) with unchanged bodies, and the rows keep identical text. The only deleted lines are the four .github/file-line-cap-baseline.txt rows of files now under the cap.

Tests

No test was added or rewritten. These proofs show the move lost nothing:

Check Result
pytest --collect-only at BASE (4 originals) vs HEAD (12 test files) 605 = 605; the (class, name, params) multiset is identical
pytest --fixtures-per-test at BASE vs HEAD identical fixture set for every test
item markers at BASE vs HEAD identical
the 12 split files at -n0 605 passed, 1 warning (BASE: 605 passed, the same warning)
BENIGN_SPAWNS BASE vs HEAD the same set and element multiset (322 = 189 + 133, the BASE duplicate kept); the 1,666 row lines inside the literal's 4-line frame are the two tables' row lines, partitioned in order
mutations, in git-archive exports dropping one row from either table: test_every_spawn_is_routed_or_allowlisted red (rc 1); an owner binding note_turn locally: test_no_owner_binds_a_name_the_tests_patch_on_the_facade red at HEAD, green at BASE
the 12 split files at -n 3, then at -n0 in three seeded shuffled orders 605 passed each time
the backend related set from local-gate.py --dry-run (32 files) plus every corpus gate scripts/leaf_test_scope.py derives (652) and every source_corpus / repo_files( scanner (154), plus the flake-pattern, wait-discipline, line-cap and source-pin-budget ratchets: 712 files, -n 3 (the same split over base aa71296bd9) 38913 passed, 127 skipped, 5 xfailed
semgrep 1.78, CI configs, --baseline-commit BASE, the 18 changed .py files 0 findings; --disable-nosem on the new files: exactly the 1 marked site
static floor: isort and flake8 (CI commands), black, black baseline, subprocess encoding, comment history, brand, docs-lint, line cap, testpaths, feature map, harness parity, cwd reads, agent-sdk boundary, memory-store seam, focus cue, sync-io-in-async all exit 0

The composition contract's patch-corpus sweep skips only its own file, so it now also reads the golden file and the doubles: its derived set of facade names the suite patches grows from 97 to 106 (_persist_channel_config, append_and_surface, build_cancelled_turn_preamble, build_session_replay, cron_command_reply, note_turn, replies_since_last_turn, run_in_tool_gate_pool, spawn_command_reply; none removed). No owner binds any of them, so the guard stays green and gets stronger.

scripts/local-gate.py --base <BASE> --dry-run: backend related set 32 test files (13 in the diff, 19 referencing a changed file); frontend 383 cross-surface files (this PR changes no frontend file).

Move audit

test/test_slack_handler_composition_contract.py: 2686 -> 1118 lines; moved 96.1% (python-ast)
   changed: world [FunctionDef] 81 lines
   changed: Expr [Expr] 7 lines
test/test_spawn_audit.py: 2823 -> 1161 lines; moved 33.54% (python-ast)
   changed: AnnAssign [AnnAssign] 1670 lines
   changed: Expr [Expr] 70 lines
test/test_llm_pool.py: 2659 -> 1248 lines; moved 99.96% (python-ast)
   changed: Expr [Expr] 1 lines
test/test_slack_handler_coverage.py: 2629 -> 1273 lines; moved 98.69% (python-ast)
   changed: sessions [FunctionDef] 13 lines
   changed: Expr [Expr] 12 lines
   changed: owner [FunctionDef] 4 lines
   changed: slack [FunctionDef] 2 lines

Every test function and class moved with an identical AST. The changed units: the four module docstrings (each names the new layout; the coverage and contract docstrings also stop naming topics that moved, and the spawn audit's two mentions of BENIGN_SPAWNS "below" name the two tables), four fixtures re-declared @pytest.fixture(name="x") def x_fixture (bodies unchanged: world, owner, slack, sessions), and BENIGN_SPAWNS (the union line). verify_test_split.py: rename-ok for the four fixtures; its only leftover is the BENIGN_SPAWNS AnnAssign, whose rows are proven above. git diff BASE...HEAD is 645,615 bytes.

Non-move edits, each listed: every new module's docstring and import header (the origin's imports pruned to what the module uses, plus the helpers import); the three remainders' import blocks (pruned the same way, plus the helpers import); the union line plus its 4-line comment, the two table imports and the two docstring sentences that name the tables in test_spawn_audit.py; the two tables' frames and docstrings; one placement choice (the "(_bootstrap.py::_self_heal removed ...)" note about the package's dep_sync keys travels with the package row above it); two comment-only cite corrections in moved code (_GOLDEN_DIGESTS: "recorded by running these scenarios", and TestWorkerConversationRecycle: "like the AcpWorker tests in test_llm_pool.py").

Moved findings, each with an own-line marker (moved bodies unchanged): # nosemgrep: kirocrew.test-autouse-shared-monkeypatch on _config_dir_tracks_patched_home in llm_pool_helpers.py. semgrep only partially parses test_llm_pool.py (a syntax error inside TestAcpWorkerZeroToolConfirmation, :1200 at BASE, :1122 at HEAD), so this finding was invisible there; that class stays in test_llm_pool.py, which semgrep reads exactly as at BASE. Eleven pre-emptive # flake-ok: markers: the two asyncio.sleep(0.01) approval polls in _golden, two asyncio.Event().wait() parks in _ccworker, two more parks and the two clock reads of _within_lost_run's elapsed-time check in _approvals, and three time.monotonic() draft stamps in _delivery. Kept in their originals on purpose: TestLLMPoolConcurrency's sleeps, TestThreadOverrideHydration's waits and TestSpawnHelpers's clock read. AKIAIOSFODNN7EXAMPLE, AWS's documented example id, moves bare or as a URL query value in 7 lines of the golden scenarios.

Known, kept byte-identical: a few row comments in the two tables name a row by position ("above"/"below") that now sits in the other table, for example gateway_service.py::default_detached_spawn citing cli_server_restart.py::_spawn_detached_gateway above; each names the key, so it stays findable.

Diff alignment (L36): for every changed file, git diff BASE -- <file> and git diff --minimal BASE -- <file> give the same counts: contract 10/1578, spawn audit 11/1673, llm_pool 17/1428, coverage 16/1372, line-cap baseline 0/4, wait-discipline baseline 2/2, slack-gateway.md 4/3, test_s29 1/1, and each new file only added lines.

Logger names (L25): no new module defines a logger.

CI path references

None: no workflow filter, explicit file list, AUTOSDE.yaml glob or sensitive-change glob names these four files.

Manual verification

N/A: unit coverage is sufficient. This is a test-only move, and the collected-test multiset plus a full run of every moved test prove it.

Related Issues

Part of #20192

Follow-up: #20383 (pre-existing shapes moved verbatim; de-flake there)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 20, 2026 03:40
@bolichen97
bolichen97 requested a review from mbriones98 October 20, 2026 03:40
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 4b0fef835900604e23e9eae7ce9944425825eb94 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 4b0fef835900604e23e9eae7ce9944425825eb94 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4b0fef835900604e23e9eae7ce9944425825eb94 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the dozens of docs and source comments saying "add a test_spawn_audit.py::BENIGN_SPAWNS entry" still lead contributors to the right table.

[DESIGN-REVIEWED] 4b0fef8

Description read

[DESCRIPTION-READ] 8d35cfeed0469fb0ed853624ee39d558f464d1ba59e03ad55159dd6dd7b67fbd

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4b0fef835900604e23e9eae7ce9944425825eb94 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4b0fef8

Verdict parsed from the review's SHA-scoped output markers for commit 4b0fef835900604e23e9eae7ce9944425825eb94.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4b0fef835900604e23e9eae7ce9944425825eb94: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4b0fef835900604e23e9eae7ce9944425825eb94 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4b0fef8

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4b0fef835900604e23e9eae7ce9944425825eb94: <one-sentence reason>

@bolichen97
bolichen97 enabled auto-merge (squash) October 20, 2026 04:05
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Patch-corpus sweep 97 -> 106 facade names: intended tightening (rebutted as a side effect)

_test_sources() skips only its own file. Before the split the golden scenarios and the world fixture lived in that file, so the facade names they patch were never read; they now live in test_slack_handler_composition_contract_golden.py and slack_handler_composition_contract_helpers.py, so the sweep reads them: +9 names (_persist_channel_config, append_and_surface, build_cancelled_turn_preamble, build_session_replay, cron_command_reply, note_turn, replies_since_last_turn, run_in_tool_gate_pool, spawn_command_reply), none removed.
Kept on purpose: test_no_owner_binds_a_name_the_tests_patch_on_the_facade now also guards the seams the goldens patch, which is the guard's stated job. No owner binds any of the nine, so it stays green.
Evidence: both sets dumped from git-archive exports of the base and this head (97 -> 106); planting a function-local from kiro_crew.slack.handler import note_turn in an owner turns that guard red at this head and leaves it green at the base.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at 0615a56.

The split is faithful. An AST comparison against the merge base finds every test function and class unchanged across all four groups. The only differences are module docstrings and the renamed fixtures, which keep their requested names through @pytest.fixture(name=...). BENIGN_SPAWNS is now BENIGN_PACKAGE_SPAWNS | BENIGN_APP_SPAWNS (

). Those two tables hold 188 + 132 entries with no overlap, and their union equals main's 320-entry set exactly. The baselines and docs follow the moved files. Your Design disposition explains the 97 -> 106 sweep growth as a stricter guard.

The one blocker is a merge conflict with main in test/test_spawn_audit.py. GitHub reports the branch as CONFLICTING, so auto-merge cannot land it. Please rebase. After the rebase, check whether main added BENIGN_SPAWNS rows in the meantime, and put each one in the right one of the two tables. The new head will need another review.

I compared the code and read CI. I did not run tests.

— crew-pr-reviewer (r114)

mbriones98
mbriones98 previously approved these changes Oct 20, 2026

@mbriones98 mbriones98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks green and readiness passed at 0615a56; no behavior change.

@bolichen97
bolichen97 force-pushed the refactor/linecap-t57-test-slack-handler-composition-contract branch from 0615a56 to 7c07f5e Compare October 20, 2026 06:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Patch-corpus sweep 97 -> 106 facade names: intended tightening (rebutted as a side effect)

_test_sources() skips only its own file. Before the split the golden scenarios and the world fixture lived in that file, so the facade names they patch were never read; they now live in test_slack_handler_composition_contract_golden.py and slack_handler_composition_contract_helpers.py, so the sweep reads them: +9 names (_persist_channel_config, append_and_surface, build_cancelled_turn_preamble, build_session_replay, cron_command_reply, note_turn, replies_since_last_turn, run_in_tool_gate_pool, spawn_command_reply), none removed.
Kept on purpose: test_no_owner_binds_a_name_the_tests_patch_on_the_facade now also guards the seams the goldens patch, which is the guard's stated job. No owner binds any of the nine, so it stays green.
Evidence: both sets dumped from git-archive exports of the base and this head (97 -> 106); planting a function-local from kiro_crew.slack.handler import note_turn in an owner turns that guard red at this head and leaves it green at the base.

@bolichen97
bolichen97 force-pushed the refactor/linecap-t57-test-slack-handler-composition-contract branch from 7c07f5e to 38f4514 Compare October 20, 2026 08:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Patch-corpus sweep 97 -> 106 facade names: intended tightening (rebutted as a side effect)

_test_sources() skips only its own file. Before the split the golden scenarios and the world fixture lived in that file, so the facade names they patch were never read; they now live in test_slack_handler_composition_contract_golden.py and slack_handler_composition_contract_helpers.py, so the sweep reads them: +9 names (_persist_channel_config, append_and_surface, build_cancelled_turn_preamble, build_session_replay, cron_command_reply, note_turn, replies_since_last_turn, run_in_tool_gate_pool, spawn_command_reply), none removed.
Kept on purpose: test_no_owner_binds_a_name_the_tests_patch_on_the_facade now also guards the seams the goldens patch, which is the guard's stated job. No owner binds any of the nine, so it stays green.
Evidence: both sets dumped from git-archive exports of the base and this head (97 -> 106); planting a function-local from kiro_crew.slack.handler import note_turn in an owner turns that guard red at this head and leaves it green at the base.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 958316e to clear the merge conflict in .github/file-line-cap-baseline.txt (main had dropped the test_slack_options_lifecycle.py row; this PR drops its own four rows; both deletions kept). Head 38f4514 -> dae7283, still one commit, no other file changed. Split files 836 passed, related backend set 2045 passed, isort/flake8/black/semgrep clean; local Opus and GPT review: no findings. The approval on the old head needs a fresh one on this head.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 20, 2026
@bolichen97
bolichen97 force-pushed the refactor/linecap-t57-test-slack-handler-composition-contract branch from dae7283 to 95930c3 Compare October 20, 2026 16:44
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in docs/system-specs/modules/ (crew-mode.md, same dir as slack-gateway.md) since this head went green (958316e -> db57e2c); CI re-running. Head dae7283 -> 95930c3, one commit, clean rebase; split files 836 passed again.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Name-keyed Windows exemptions (conftest._windows_restrict_to_owner_stub): no exempted test left its module (rebutted)

The exemption lists module names; of the four origins only test_spawn_audit is listed, and every test of that family stays in test/test_spawn_audit.py.
What moved out of it is data only: the BENIGN_SPAWNS rows now live in test/spawn_audit_helpers.py and test/spawn_audit_app_spawns.py, which hold no test functions and are not collected.
The llm_pool, slack_handler_coverage and composition-contract families were never exempted, so their new files keep the same stubbed behaviour on Windows.
Windows CI on this head: Backend Tests (Windows) shards 1-8, Windows Fail-Closed Sandbox Contract and Pod Boot Canary (Windows) all passed.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 20, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every review lane on the new head is clean (Design PASS, UX and First Principles skipped as test-only; only runner notices); held by the triage cron on the 21-file cap alone. Approved on the watch holder's request.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 20, 2026
test_slack_handler_composition_contract.py, test_spawn_audit.py,
test_llm_pool.py and test_slack_handler_coverage.py were each over the
2,000-line cap. Each splits along its section banners into topic files;
the helpers and fixtures a family's files share, and the composition
contract's recording doubles, move to *_helpers.py modules the files
import by name. Every test moves with an identical AST, and the
collected tests, their fixtures and markers are unchanged.

BENIGN_SPAWNS was one literal larger than the 1,600-line target, so its
rows split by the path they key on into spawn_audit_helpers.py (the
package) and spawn_audit_app_spawns.py (apps/builtins); the audit reads
their union, the same set, each row byte-identical.

Part of #20192
@bolichen97
bolichen97 force-pushed the refactor/linecap-t57-test-slack-handler-composition-contract branch from 95930c3 to 4b0fef8 Compare October 20, 2026 22:17
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased onto main 20bc3fcdfc to clear the merge conflict in .github/file-line-cap-baseline.txt. Main had dropped the test/test_mcp_gatewayd_coverage.py row (in #22190); this PR drops its own four rows. Both deletions kept.

Head 95930c345c -> 4b0fef8359. Still one commit. git range-diff shows the patch unchanged apart from context lines; no other file this PR touches changed on main. Local: the PR's test files plus test/test_slack_renderer.py 695 passed, line-cap check, isort, flake8, semgrep, flake ratchet green; local GPT and Opus reviews: no findings. CI re-running.

@KiroCrewCaptain the push dismissed your approval at 95930c3. Please re-approve 4b0fef8 once CI is green.

[operator: bolichen97]

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 20, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • test_spawn_audit.py::BENIGN_SPAWNS pointers still lead to the right table (rebutted)

The name the docs and comments cite is unchanged: BENIGN_SPAWNS is still defined at test/test_spawn_audit.py:265, now as BENIGN_PACKAGE_SPAWNS | BENIGN_APP_SPAWNS.
The comment right above it (test/test_spawn_audit.py:262-264) says which table a new row goes in: under apps/builtins/ to spawn_audit_app_spawns.BENIGN_APP_SPAWNS, anything else to spawn_audit_helpers.BENIGN_PACKAGE_SPAWNS. Each helper's module docstring names the union too.
So a contributor following docs/system-specs/modules/computer-use.md:566/1579, src/kiro_crew/computer_use/capture_windows.py:11 or src/kiro_crew/cli_chat.py:422 lands on the union and is pointed to the table one hop away. Rewriting those pointers is wording churn outside this split's goal.
This head is a mechanical rebase of 95930c3 (patch unchanged per git range-diff).

[operator: bolichen97]

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every review lane on the head is clean (Design PASS, UX and First Principles skipped as docs/test-only; no annotations); held by the triage cron on a README path or the 21-file cap alone. Approved on the watch holder's request.

@bolichen97
bolichen97 merged commit 5821f39 into main Oct 21, 2026
107 of 108 checks passed
@bolichen97
bolichen97 deleted the refactor/linecap-t57-test-slack-handler-composition-contract branch October 21, 2026 04:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants