Repository navigation
docs(rfc): quarantine keeps only unsaved work, not the whole clone - #22428
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
1f76723 to
e18ba31
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Maintainers should first accept that default hosts gain nothing until open question 9 is answered. Until then the sibling PR is the only shrink for them. [DESIGN-REVIEWED] c39e7f3 Description read[DESCRIPTION-READ] 7a49b7f4d79772f539c7f5947deb2f2372e6616fd8f967d99d631205616ffacb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
e18ba31 to
cb57e88
Compare
|
|
|
|
cb57e88 to
aa4512c
Compare
|
|
|
b5716b2 to
f1eec53
Compare
|
|
|
|
f1eec53 to
8a6c58a
Compare
|
|
|
|
2007949 to
24b7a0c
Compare
|
|
24b7a0c to
20c035c
Compare
|
|
|
|
|
20c035c to
cd20046
Compare
|
|
|
|
Backend Tests (Windows) (3) is red on this head from main, not from this docs-only diff:
|
Propose replacing the whole-tree scratch quarantine with a small rescue: commits a trusted object store does not have, as a git bundle, plus changed and untracked files verbatim. Git runs inside the agent sandbox with no network; any failure or doubt keeps today's whole-tree move. Adds the index row in docs/request-for-change/README.md.
cd20046 to
c39e7f3
Compare
|
Rebased onto main carrying #22433; CI re-running. |
|
mbriones98
left a comment
There was a problem hiding this comment.
Checks green and readiness passed at c39e7f3; no behavior change.
Problem / Motivation
Goal: Record a design, for maintainers to judge, that lets the scratch quarantine keep only a dead clone's unsaved work instead of the whole clone.
Since #19897, every dead, idle scratch tree holding a git repository is moved whole into
.quarantineand kept 14 days. On one host that reached 28 GB over 24 trees in about a day, and the 80 GB disk hit 99%. A Kiro Crew clone is about 4.2 GB; the unsaved work in it is usually KB to a few MB.Why it matters
The quarantine fills the disk long before anything expires. The fix cannot just ask the clone whether its work is pushed: #19897 showed the clone's refs and config are agent-controlled. So the design needs to be agreed before any code.
Not a goal
draftRFC and its index row only.node_modules,.venv); a sibling change on branchfix/scratch-delete-clean-treesdoes that.What changed (motivation → approach → change)
A dead clone costs gigabytes in
.quarantineto protect kilobytes of work.The RFC asks a trusted source, never the clone, which commits are saved: a gateway-owned mirror, or the hosting provider by SHA. Everything else becomes a small rescue: a git bundle of unsaved commits plus changed and untracked files copied verbatim. Git runs inside the agent sandbox with no network and program-naming settings forced off. Any failure or doubt keeps today's whole-tree move; nothing falls back to deleting.
docs/request-for-change/rfc-quarantine-unsaved-work-only.mddocs/request-for-change/README.mddraftindex rowBackwards compatibility
Compatible: docs only; no behaviour changes.
Removes nothing: the diff adds one document and one index row.
Tests
N/A — docs only.
python3 scripts/docs_lint.pyexits 0.Manual verification
N/A — docs only. The cited symbols (
sweep_dead_scratch,holds_git_repository,_quarantine,_expire_quarantine,QUARANTINE_TTL_SECONDS,wrap_argv) were checked on main at6432cad9e.Related Issues
Part of #22423
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)