Repository navigation
test: re-key the slot-creator registry after the Slack split - #22434
iamwhatever wants to merge 1 commit into
Conversation
#22079 moved _import_thread_to_slot from slack/interactions.py into slack/interactions_options.py. The registry added by #22110 still keyed it under the old file, so test_no_stale_entry and test_every_creator_is_classified failed on main (Backend Tests (Windows) (3)). Re-key the entry; the classification text stays true for the moved function.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 0a48e59 Description read[DESCRIPTION-READ] 268b9b8fbeeca3fe03d7dec452388250431a639ccc296163087a6a1a79f67a28 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Thanks for tracking down the stale registry key. The fix itself is correct: on main, This PR is an exact duplicate of #22433, opened by you 34 seconds earlier with a byte-identical diff to Verified on head |
Problem / Motivation
Goal: Turn main's red
Backend Tests (Windows) (3)shard green again by pointing the slot-creator registry at the file where_import_thread_to_slotnow lives.Main fails on every PR in
Backend Tests (Windows) (3)(seen on PR 22419, job 118480798042). Two tests intest/test_chat_follow_default_slot_kinds.pyfail:TestSlotCreatorRegistry::test_no_stale_entry:Lists differ: [('slack/interactions.py', '_import_thread_to_slot')] != []TestSlotCreatorRegistry::test_every_creator_is_classified:Lists differ: [('slack/interactions_options.py', '_import_thread_to_slot')] != []Why it matters
Every open PR inherits the red shard, so no PR can show a clean Backend Tests rollup until main is fixed.
Not a goal
What changed (motivation → approach → change)
#22079 moved
_import_thread_to_slotintosrc/kiro_crew/slack/interactions_options.py;interactions.pyonly re-imports it. #22110 added the registry with the old location. The test finds creators by AST, keyed by (file, innermost function), so the old key is stale and the new location is unclassified.The fix re-keys the one entry to
("slack/interactions_options.py", "_import_thread_to_slot"). The classification text is unchanged and still true: the function callsds.get_or_create_slot()with nomodel=, and it runs for an allowed user's!link-to-dashboardcommand or Link button. This is the minimal fix: one line in one test file.Backwards compatibility
Compatible: test-only change to one dictionary key; no product code, API or stored data changes.
Removes nothing: the entry is re-keyed, not dropped, and its classification text is kept.
Tests
test/test_chat_follow_default_slot_kinds.py: the file's two failing tests pass again. On Linux, before the change: 2 failed, 3 passed. After: 5 passed. Also run:test/test_chat_follow_default.pyandtest/test_slack_interactions_coverage.py(277 passed with the file above). isort and flake8 are clean on the file. No new test: the registry tests are the check.Manual verification
N/A — unit coverage sufficient; the registry tests exercise the changed key directly.
Related Issues
None. Root cause: #22079 (moved the function) and #22110 (added the registry).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)