Skip to content

test: re-key the slot-creator registry after the Slack split - #22434

Closed
iamwhatever wants to merge 1 commit into
mainfrom
test/slot-creator-registry-slack-split
Closed

iamwhatever wants to merge 1 commit into
mainfrom
test/slot-creator-registry-slack-split

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Turn main's red Backend Tests (Windows) (3) shard green again by pointing the slot-creator registry at the file where _import_thread_to_slot now lives.

Main fails on every PR in Backend Tests (Windows) (3) (seen on PR 22419, job 118480798042). Two tests in test/test_chat_follow_default_slot_kinds.py fail:

  • TestSlotCreatorRegistry::test_no_stale_entry: Lists differ: [('slack/interactions.py', '_import_thread_to_slot')] != []
  • TestSlotCreatorRegistry::test_every_creator_is_classified: Lists differ: [('slack/interactions_options.py', '_import_thread_to_slot')] != []

Why it matters

Every open PR inherits the red shard, so no PR can show a clean Backend Tests rollup until main is fixed.

Not a goal

  • Changing what the registry classifies or how creators are discovered.
  • Touching any other registry entry. Only this one is proved stale.

What changed (motivation → approach → change)

#22079 moved _import_thread_to_slot into src/kiro_crew/slack/interactions_options.py; interactions.py only re-imports it. #22110 added the registry with the old location. The test finds creators by AST, keyed by (file, innermost function), so the old key is stale and the new location is unclassified.

The fix re-keys the one entry to ("slack/interactions_options.py", "_import_thread_to_slot"). The classification text is unchanged and still true: the function calls ds.get_or_create_slot() with no model=, and it runs for an allowed user's !link-to-dashboard command or Link button. This is the minimal fix: one line in one test file.

Backwards compatibility

Compatible: test-only change to one dictionary key; no product code, API or stored data changes.

Removes nothing: the entry is re-keyed, not dropped, and its classification text is kept.

Tests

test/test_chat_follow_default_slot_kinds.py: the file's two failing tests pass again. On Linux, before the change: 2 failed, 3 passed. After: 5 passed. Also run: test/test_chat_follow_default.py and test/test_slack_interactions_coverage.py (277 passed with the file above). isort and flake8 are clean on the file. No new test: the registry tests are the check.

Manual verification

N/A — unit coverage sufficient; the registry tests exercise the changed key directly.

Related Issues

None. Root cause: #22079 (moved the function) and #22110 (added the registry).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

#22079 moved _import_thread_to_slot from slack/interactions.py into
slack/interactions_options.py. The registry added by #22110 still keyed it
under the old file, so test_no_stale_entry and test_every_creator_is_classified
failed on main (Backend Tests (Windows) (3)). Re-key the entry; the
classification text stays true for the moved function.
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 20, 2026 06:33
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0a48e59b000297de933bcfbf8faeab584ad8b2fe touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 0a48e59b000297de933bcfbf8faeab584ad8b2fe ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0a48e59b000297de933bcfbf8faeab584ad8b2fe — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 0a48e59

Description read

[DESCRIPTION-READ] 268b9b8fbeeca3fe03d7dec452388250431a639ccc296163087a6a1a79f67a28

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0a48e59b000297de933bcfbf8faeab584ad8b2fe — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0a48e59

Verdict parsed from the review's SHA-scoped output markers for commit 0a48e59b000297de933bcfbf8faeab584ad8b2fe.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0a48e59b000297de933bcfbf8faeab584ad8b2fe: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0a48e59b000297de933bcfbf8faeab584ad8b2fe and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0a48e59

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0a48e59b000297de933bcfbf8faeab584ad8b2fe: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor

Thanks for tracking down the stale registry key. The fix itself is correct: on main, _import_thread_to_slot is defined in slack/interactions_options.py and interactions.py only re-imports it, so re-keying the entry is the right one-line change.

This PR is an exact duplicate of #22433, opened by you 34 seconds earlier with a byte-identical diff to test/test_chat_follow_default_slot_kinds.py (same blob f34ab464d6e). Keeping both open would split CI time and review between two copies of the same change, so I am closing this one and keeping #22433, the earlier of the two. Nothing is lost: the description and test notes here apply to #22433 unchanged.

Verified on head 0a48e59b000297de933bcfbf8faeab584ad8b2fe: the diff, the function's location and its ds.get_or_create_slot() call with no model= on main, and the identical diff on #22433.

@bolichen97 bolichen97 closed this Oct 20, 2026
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 20, 2026
@bolichen97
bolichen97 deleted the test/slot-creator-registry-slack-split branch November 6, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants