Repository navigation
fix(stt): name a keep-draft control that works on every push-to-talk binding - #22439
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the hold bar's release path decides "keep draft" from the same zone state that now arms the cue at hold start. Otherwise the label and the behaviour could disagree again. [DESIGN-REVIEWED] ef8b088 Description read[DESCRIPTION-READ] 5e8f74ce74eb86e478584b82c5a609d9b953de754404d661f64adc6e4bab2491 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has checked the reworded keep-draft hint or the hold bar's draft cue; both screenshots show them, so only this lane's cap applies. Watch
[UX-REVIEWED] ef8b088 Description read[DESCRIPTION-READ] 9e01133ee44159440db192a58285995b2642d2e09e888085d270788737a053c7 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (3 items) — 3 justifiedIntent: make the "Send when I stop recording" hints name a way to keep a draft that actually works on every push-to-talk binding, and make the phone hold bar show the draft label when a release will keep a draft. FIX (#22438).
[FIRST-PRINCIPLES-REVIEWED] ef8b088 Description read[DESCRIPTION-READ] 45fdea9729b1329a8d7b45113a7d894619363a22d7f0eead3d6d38626c006df7 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
note (non-blocking): the hold-bar label change appeared in no screenshot, and no blind reader has read the hint
|
|
note (non-blocking): check that Shift-clicking the mic keeps a draft on the Windows and Linux default binding
|
|
note (non-blocking): can a keyboard-only push-to-talk user still see a way to keep a draft?
|
bda8884 to
f87befc
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Looks good to ship. Approval waits for PR Readiness on this head.
Head reviewed: f87befc. No must-fix or should-fix findings.
What I checked:
- Hint copy: "Shift-click the mic" keeps a draft on every binding. The mic click handler reads Shift from its own click event, and
useComposerVoiceSubmitOnRelease.test.tsxpins that case. The new copy also matches the existing mic tooltip strings. - Config help,
configuration.md, the settings registry pair andconfig-baseline.jsoncarry the same text. All 13 locale catalogs anden.context.jsonchange onlysubmit_on_release_desc. useTouchPushToTalk.ts: the release decision still reads the release position, so behaviour does not change. Only the cue timing changes.lastZoneRefresets on each press, and acancelornullzone arms nothing. When the draft zone is off,holdZonenever returnsdraft.- The new test goes red if the
setArmedDraftline in the hold timer is removed. It also checks that the cue stays off while the press is still arming. - Category
fixmatches the diff. The linked issue is T1. No file is on a security-sensitive path. No other open PR touches these files.
Remaining before merge: CI and the AI review lanes are still running on this head. The UX lane verdict on the previous head was BLOCK for missing hold-bar evidence. The description now has that frame, and the lane must re-read it on this head. I will approve when PR Readiness reports passed.
|
thought (non-blocking): the Settings hint offers keyboard push-to-talk users only a mouse action
|
|
Backend Tests (3.12, 3) is red on main, not on this diff. |
f87befc to
a11412c
Compare
|
note (non-blocking): does the timer-armed draft cue match the release if
|
|
thought (non-blocking): the keep-draft hint gives push-to-talk key users no keyboard way out
|
…binding The submit-on-release Settings hint said "Hold Shift" to keep a draft. Shift is ignored for a binding that already uses it, which includes the Windows and Linux default, so that instruction did nothing there. The hint now names Shift-click on the mic, which works everywhere, in all 12 catalogs and the config help. On the phone's hold bar, a finger that slid into the keep-as-draft zone while the press was still arming, then held still, kept reading "Release to send". The hold timer now arms the cue from the last zone seen, so the label matches what the release will do.
a11412c to
ef8b088
Compare
|
Same-tree retrigger as ef8b088, no code change. The reds on a11412c were the known flakes: Frontend Tests shard 3 on CrewDynamicDashboard.remint (#22458) and Backend shard 2 on the facade_mirror_guards 120 s timeout (#22004). Frontend Coverage Merge and Coverage Gate failed only because the frontend shard did. |
|
Hold at The code looks sound. The hold timer now arms the draft cue from the zone of the latest move (useTouchPushToTalk.ts#L426-L444), the release still recomputes the zone from its own position (#L465), and the new test covers the arming-then-hold case. The copy changes are consistent across config help, docs, the registry pair and all locale catalogs. Checks on this head are green. Blocker: the UX Review on this head raises a new CONCERNS item with no reply: the keep-draft instruction is only reachable by hovering the info icon, so someone can turn on auto-send without ever seeing how to keep a draft. The earlier UX dispositions answer different items (the hold-bar screenshot and the keyboard-only path). To clear: post a — crew-pr-reviewer (r115) |
|
note (non-blocking): the way to keep a draft is still only in a tooltip
|
|
note (non-blocking): does the release decide "keep draft" from the same zone state that arms the cue at hold start?
|
bolichen97
left a comment
There was a problem hiding this comment.
Approving head ef8b088.
This head is a pure rebase of the head I reviewed earlier. The range-diff is identical, and I found no must-fix or should-fix items.
Gates checked on this head:
- Label
readiness: passedis set. - PR Readiness is green, and no required check is red or pending.
- The AI review lanes show no BLOCK verdict on this head.
- The linked issue is tier T1.
- No other change request is open.
- No file is on the security path denylist.
Auto-merge is set to squash.
Problem / Motivation
Goal: Make the "Send when I stop recording" hints tell people a way to keep a draft that actually works, on every keyboard binding and on the phone's hold bar.
The Settings hint for
stt.submit_on_releasesays "Hold Shift" to keep a draft. Shift is ignored for a binding that already uses it, which includes the Windows and Linux default ⌥⇧Space, so following the hint there sends the message. On the hold bar, a finger that slides into the keep-as-draft zone while the press is still arming and then holds still keeps seeing "Release to send", although letting go keeps a draft.Why it matters
The setting sends messages on its own, so a hint that names a way out that does nothing on the default binding sends a message the person meant to keep. A label that says "send" when the release keeps a draft is the opposite error, and both undermine trust in the feature.
Not a goal
What changed (motivation → approach → change)
The hint named a control that is ignored on the default Windows and Linux binding, so it now names Shift-click on the mic, which keeps a draft on every binding: "Stopping sends the message. Shift-click the mic, or slide sideways on the phone, to keep a draft." It is updated in every catalog under
i18n/locales/, with translator context inen.context.json, and the config help inconfig/sections_stt.pyandconfiguration.mdadds that Shift at release works for a binding without Shift. The settings registry (components/commandPalette/settingsRegistry.gen.tsand its JSON twin) andconfig-baseline.jsonare regenerated.The hold bar armed its keep-as-draft cue only on a pointer move, and the move that entered the zone happened before the hold began.
hooks/useTouchPushToTalk.tsnow remembers the zone of the latest move and arms the cue when the hold timer fires.Backwards compatibility
Compatible: copy and a label's timing change; no key, setting or behaviour changes.
Removes nothing: no key, route, function or setting is removed or renamed.
Tests
website/src/hooks/useTouchPushToTalk.draftZone.test.ts: a finger that enters the draft zone while arming and then holds still reads armed-draft once the hold begins, and the release keeps a draft.Manual verification
Checked in a disposable pod (never the live gateway): Settings > Voice > Fine-tuning shows the new hint, and the existing pod gesture run with Chromium's fake microphone passed 16 of 16. No physical phone was reachable; the touch path is covered by synthetic
PointerEvents.Screenshots / video
The reworded hint in Settings > Voice > Fine-tuning:
The phone hold bar after sliding into the keep-as-draft zone while the press is still arming, then holding still past the hold threshold. The bar and the strip above it both read "Release to keep as draft", and the release kept the transcript unsent. Captured in the pod at a 390 px touch viewport with synthetic
PointerEvents; before the hold began the bar read "Hold to talk".Related Issues
Fixes #22438
Pattern harvest
Not generalizable: a single hint named a modifier that one binding family reserves; the copy now names a control that works on every binding.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)